Page MenuHomePhabricator

kiranktp (Kiran Kumar T P)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 31 2020, 2:10 AM (33 w, 1 d)

Recent Activity

Tue, Sep 15

kiranktp accepted D87549: [OpenMP][MLIR] Add assembly format for master op.

LGTM

Tue, Sep 15, 8:27 PM · Restricted Project

Tue, Sep 8

kiranktp accepted D86051: [flang]Add Semantic Checks for OpenMP Allocate Clause.

LGTM

Tue, Sep 8, 9:08 AM · Restricted Project, Restricted Project, Restricted Project

Mon, Sep 7

kiranktp added reviewers for D87247: [MLIR,OpenMP] Added support for lowering MasterOp to LLVMIR: anchu-rajendran, clementval.
Mon, Sep 7, 6:27 PM · Restricted Project
kiranktp committed rG4536c6acb380: [flang][OpenMP] Enhance parser support for atomic construct to OpenMP 5.0 (authored by kiranktp).
[flang][OpenMP] Enhance parser support for atomic construct to OpenMP 5.0
Mon, Sep 7, 6:22 PM
kiranktp closed D82931: [flang][OpenMP] Enhance parser support for atomic construct to OpenMP 5.0.
Mon, Sep 7, 6:22 PM · Restricted Project, Restricted Project
kiranktp added inline comments to D87247: [MLIR,OpenMP] Added support for lowering MasterOp to LLVMIR.
Mon, Sep 7, 6:03 PM · Restricted Project

Tue, Sep 1

kiranktp updated the diff for D82931: [flang][OpenMP] Enhance parser support for atomic construct to OpenMP 5.0.

Incorporated review comments.

Tue, Sep 1, 12:30 AM · Restricted Project, Restricted Project
kiranktp added inline comments to D82931: [flang][OpenMP] Enhance parser support for atomic construct to OpenMP 5.0.
Tue, Sep 1, 12:21 AM · Restricted Project, Restricted Project

Aug 5 2020

kiranktp added a comment to D85212: [flang] Add parser support for OpenMP allocate clause.

LGTM

Aug 5 2020, 9:01 AM · Restricted Project, Restricted Project

Jul 29 2020

kiranktp added a reviewer for D82931: [flang][OpenMP] Enhance parser support for atomic construct to OpenMP 5.0: clementval.
Jul 29 2020, 5:35 AM · Restricted Project, Restricted Project
kiranktp updated the diff for D82931: [flang][OpenMP] Enhance parser support for atomic construct to OpenMP 5.0.

Used Common openmp Directives and added a negative test case.

Jul 29 2020, 5:31 AM · Restricted Project, Restricted Project

Jul 28 2020

kiranktp added inline comments to D84798: [OpenMP,MLIR] Translation of parallel operation: num_threads, if clauses 3/n.
Jul 28 2020, 11:18 PM · Restricted Project
kiranktp added a comment to D84798: [OpenMP,MLIR] Translation of parallel operation: num_threads, if clauses 3/n.

LGTM

Jul 28 2020, 9:24 PM · Restricted Project

Jul 15 2020

kiranktp committed rGd4b1a14f0a6f: [flang][OpenMP] Enhance parser support for taskwait construct to OpenMP 5.0 (authored by kiranktp).
[flang][OpenMP] Enhance parser support for taskwait construct to OpenMP 5.0
Jul 15 2020, 9:42 PM
kiranktp closed D82255: [flang][OpenMP] Enhance parser support for taskwait construct to OpenMP 5.0.
Jul 15 2020, 9:41 PM · Restricted Project, Restricted Project
kiranktp updated the diff for D82255: [flang][OpenMP] Enhance parser support for taskwait construct to OpenMP 5.0.

taskwait has depend clause from OpenMP 5.0 and later.

Jul 15 2020, 9:37 AM · Restricted Project, Restricted Project
kiranktp added a comment to D82255: [flang][OpenMP] Enhance parser support for taskwait construct to OpenMP 5.0.

Minor comment but LGTM.

Jul 15 2020, 7:04 AM · Restricted Project, Restricted Project
kiranktp added a reviewer for D82255: [flang][OpenMP] Enhance parser support for taskwait construct to OpenMP 5.0: clementval.
Jul 15 2020, 2:20 AM · Restricted Project, Restricted Project
kiranktp updated the diff for D82255: [flang][OpenMP] Enhance parser support for taskwait construct to OpenMP 5.0.

Rebasing after @clementval's patch and adding appropriate changes needed.

Jul 15 2020, 12:57 AM · Restricted Project, Restricted Project

Jul 14 2020

kiranktp added a comment to D82255: [flang][OpenMP] Enhance parser support for taskwait construct to OpenMP 5.0.

This looks OK but needs a rebase after @clementval's changes.

Jul 14 2020, 3:04 AM · Restricted Project, Restricted Project

Jul 8 2020

kiranktp added a comment to D82931: [flang][OpenMP] Enhance parser support for atomic construct to OpenMP 5.0.

Any syntax error will lead to chain of errors. It will be tough to add a case for invalid syntax.

Please consider adding error recovery to prevent the cascade of errors. See the docs and the parser for examples.

Jul 8 2020, 5:10 AM · Restricted Project, Restricted Project

Jul 7 2020

kiranktp committed rGcd503166fb74: [flang][OpenMP] Enhance parser support for flush construct to OpenMP 5.0 (authored by kiranktp).
[flang][OpenMP] Enhance parser support for flush construct to OpenMP 5.0
Jul 7 2020, 1:57 AM

Jul 6 2020

kiranktp added a comment to D82931: [flang][OpenMP] Enhance parser support for atomic construct to OpenMP 5.0.

Looks good to me! As a nit, perhaps you could add some tests that shouldn't parse correctly as well?

Jul 6 2020, 9:15 PM · Restricted Project, Restricted Project

Jun 30 2020

kiranktp created D82931: [flang][OpenMP] Enhance parser support for atomic construct to OpenMP 5.0.
Jun 30 2020, 10:43 PM · Restricted Project, Restricted Project
kiranktp added a reviewer for D82931: [flang][OpenMP] Enhance parser support for atomic construct to OpenMP 5.0: shivarama_rao.
Jun 30 2020, 10:43 PM · Restricted Project, Restricted Project
kiranktp added a comment to D82177: [flang][OpenMP] Enhance parser support for flush construct to OpenMP 5.0.

@echristo was seeing a failure when running the test "Semantics/omp-clause-validity01.f90" as per his revert commit message.

Tests pass for me. I built and tested on an ubuntu Aarch64 machine. Flang was built as a release with debug build using gcc-9.2 with ninja.

I'm happy to try again if you think that the current diff should work :)

-eric

Jun 30 2020, 9:39 PM · Restricted Project, Restricted Project
kiranktp added a comment to D82177: [flang][OpenMP] Enhance parser support for flush construct to OpenMP 5.0.

@echristo was seeing a failure when running the test "Semantics/omp-clause-validity01.f90" as per his revert commit message.

Tests pass for me. I built and tested on an ubuntu Aarch64 machine. Flang was built as a release with debug build using gcc-9.2 with ninja.

Jun 30 2020, 9:39 PM · Restricted Project, Restricted Project

Jun 26 2020

kiranktp added a comment to D82177: [flang][OpenMP] Enhance parser support for flush construct to OpenMP 5.0.

What is happening with this change? It looks like it was applied and then reverted.
@echristo, was there a problem?

Jun 26 2020, 5:56 AM · Restricted Project, Restricted Project

Jun 24 2020

kiranktp added a comment to D82255: [flang][OpenMP] Enhance parser support for taskwait construct to OpenMP 5.0.

Lint: Pre-merge checks

Jun 24 2020, 9:42 PM · Restricted Project, Restricted Project

Jun 23 2020

kiranktp updated the diff for D82255: [flang][OpenMP] Enhance parser support for taskwait construct to OpenMP 5.0.

Corrected the section number to 2.17.5 [from OpenMP 5.0] for taskwait construct

Jun 23 2020, 5:17 AM · Restricted Project, Restricted Project
kiranktp updated the diff for D82176: [flang][OpenMP] Added parser support for Iterators (OpenMP 5.0) and updated depend clause.

Corrected the section number to 2.17.11 [From OpenMP 5.0] for Depend clause.
Removed the dependence type (inoutset) which is from OpenMP 5.1.

Jun 23 2020, 4:45 AM · Restricted Project, Restricted Project
kiranktp updated the diff for D82177: [flang][OpenMP] Enhance parser support for flush construct to OpenMP 5.0.

Corrected the section number to 2.17.8 [from OpenMP 5.0] for flush construct

Jun 23 2020, 2:36 AM · Restricted Project, Restricted Project

Jun 20 2020

kiranktp added a comment to D82177: [flang][OpenMP] Enhance parser support for flush construct to OpenMP 5.0.

Two comments.

memory-order-clause is defined for both atomic and flush instructions. We already have MemoryOrder
defined in the parse-tree for atomic in 4.5. In 4.5 memory-order can only be seq_cst. In 5.0 memory-order
for atomic can be seq_cst, acq_rel, release, acquire, relaxed. For flush it is only a subset and the allowed
values are only acq_rel, release, acquire.

Would it make sense to have a common definition for memory-order-clause and handle the fact that it
can only be a subset in semantics?

Flush is 2.17.8 (not 2.18.8) as part of the OpenMP 5.0 specification here. Is there a newer document?
https://www.openmp.org/wp-content/uploads/OpenMP-API-Specification-5.0.pdf

Jun 20 2020, 5:16 AM · Restricted Project, Restricted Project
kiranktp added a comment to D82177: [flang][OpenMP] Enhance parser support for flush construct to OpenMP 5.0.

Hi All,

The commit for this ended up failing so I temporarily reverted it in 64b04e4754bfe7bf718e5140fe1fd0ca50373c28. Feel free to recommit on fix :)

Thanks!

-eric

Jun 20 2020, 5:16 AM · Restricted Project, Restricted Project
kiranktp created D82255: [flang][OpenMP] Enhance parser support for taskwait construct to OpenMP 5.0.
Jun 20 2020, 2:05 AM · Restricted Project, Restricted Project
kiranktp committed rGb32401464f4c: [flang][OpenMP] Enhance parser support for flush construct to OpenMP 5.0 (authored by kiranktp).
[flang][OpenMP] Enhance parser support for flush construct to OpenMP 5.0
Jun 20 2020, 1:33 AM
kiranktp closed D82177: [flang][OpenMP] Enhance parser support for flush construct to OpenMP 5.0.
Jun 20 2020, 1:33 AM · Restricted Project, Restricted Project

Jun 19 2020

kiranktp updated the diff for D82176: [flang][OpenMP] Added parser support for Iterators (OpenMP 5.0) and updated depend clause.

Corrected the test case

Jun 19 2020, 5:53 AM · Restricted Project, Restricted Project
kiranktp created D82177: [flang][OpenMP] Enhance parser support for flush construct to OpenMP 5.0.
Jun 19 2020, 5:21 AM · Restricted Project, Restricted Project
kiranktp created D82176: [flang][OpenMP] Added parser support for Iterators (OpenMP 5.0) and updated depend clause.
Jun 19 2020, 4:49 AM · Restricted Project, Restricted Project

Jun 16 2020

kiranktp abandoned D81848: [flang][OpenMP] Upgrade support for Flush, Depend, Taskwait construct to OpenMP 5.0.
Jun 16 2020, 11:57 PM · Restricted Project, Restricted Project
kiranktp added a comment to D81848: [flang][OpenMP] Upgrade support for Flush, Depend, Taskwait construct to OpenMP 5.0.

@kiranktp Can we have separate patches for Flush, depend & iterator, taskwait? It will be easier to review.

Jun 16 2020, 10:23 PM · Restricted Project, Restricted Project

Jun 15 2020

kiranktp added a comment to D81848: [flang][OpenMP] Upgrade support for Flush, Depend, Taskwait construct to OpenMP 5.0.

@kiranktp Hi Kiran, Will any of the proposed OpenMP 5.1 features affect these features?

Thanks!

Jun 15 2020, 11:04 PM · Restricted Project, Restricted Project
kiranktp created D81848: [flang][OpenMP] Upgrade support for Flush, Depend, Taskwait construct to OpenMP 5.0.
Jun 15 2020, 9:17 AM · Restricted Project, Restricted Project

May 19 2020

kiranktp committed rGfa8fc9ffcc9b: [MLIR, OpenMP] Support for flush operation, and translating the same to LLVM IR (authored by kiranktp).
[MLIR, OpenMP] Support for flush operation, and translating the same to LLVM IR
May 19 2020, 4:50 AM
kiranktp closed D79937: [MLIR] Support for flush operation, and translating the same to LLVM IR.
May 19 2020, 4:50 AM · Restricted Project, Restricted Project
kiranktp updated the diff for D79937: [MLIR] Support for flush operation, and translating the same to LLVM IR.

Fixed formatting issue.

May 19 2020, 4:17 AM · Restricted Project, Restricted Project

May 17 2020

kiranktp updated the diff for D79937: [MLIR] Support for flush operation, and translating the same to LLVM IR.

Hi @ftynse, @kiranchandramohan,
I have incorporated the review comments.

May 17 2020, 11:24 PM · Restricted Project, Restricted Project
kiranktp added inline comments to D79937: [MLIR] Support for flush operation, and translating the same to LLVM IR.
May 17 2020, 11:24 PM · Restricted Project, Restricted Project

May 14 2020

kiranktp added a reviewer for D79937: [MLIR] Support for flush operation, and translating the same to LLVM IR: ronlieb.
May 14 2020, 9:13 PM · Restricted Project, Restricted Project
kiranktp added inline comments to D79937: [MLIR] Support for flush operation, and translating the same to LLVM IR.
May 14 2020, 10:50 AM · Restricted Project, Restricted Project
kiranktp created D79937: [MLIR] Support for flush operation, and translating the same to LLVM IR.
May 14 2020, 5:20 AM · Restricted Project, Restricted Project

Apr 9 2020

kiranktp added a comment to D77634: [MLIR] Support for taskwait and taskyield operations, and translating the same to LLVM IR.

Hi Mehdi, Thanks for the review. I do not have commit access. Could you please merge this code on my behalf.?

Apr 9 2020, 11:21 PM · Restricted Project
kiranktp committed rG17332e283e25: [flang] Fix for flang-compiler/f18#694 - Unexpected error when compiling… (authored by kiranktp).
[flang] Fix for flang-compiler/f18#694 - Unexpected error when compiling…
Apr 9 2020, 12:21 PM
kiranktp committed rGe572117f8b7c: [flang] Fix for flang-compiler/f18#694 - Unexpected error when compiling… (authored by kiranktp).
[flang] Fix for flang-compiler/f18#694 - Unexpected error when compiling…
Apr 9 2020, 12:20 PM
kiranktp committed rGdeffc7a55cd2: [flang] Fix for flang-compiler/f18#694 - Unexpected error when compiling… (authored by kiranktp).
[flang] Fix for flang-compiler/f18#694 - Unexpected error when compiling…
Apr 9 2020, 12:20 PM
kiranktp committed rGc1ca1b2b7f8c: [flang] Fix for flang-compiler/f18#694 - Unexpected error when compiling… (authored by kiranktp).
[flang] Fix for flang-compiler/f18#694 - Unexpected error when compiling…
Apr 9 2020, 12:20 PM
kiranktp updated the diff for D77634: [MLIR] Support for taskwait and taskyield operations, and translating the same to LLVM IR.

Incorporated all review comments.

Apr 9 2020, 5:23 AM · Restricted Project

Apr 8 2020

kiranktp updated the diff for D77634: [MLIR] Support for taskwait and taskyield operations, and translating the same to LLVM IR.
Apr 8 2020, 4:49 AM · Restricted Project
kiranktp updated the diff for D77634: [MLIR] Support for taskwait and taskyield operations, and translating the same to LLVM IR.
Apr 8 2020, 3:12 AM · Restricted Project
kiranktp added inline comments to D77634: [MLIR] Support for taskwait and taskyield operations, and translating the same to LLVM IR.
Apr 8 2020, 3:12 AM · Restricted Project

Apr 7 2020

kiranktp created D77634: [MLIR] Support for taskwait and taskyield operations, and translating the same to LLVM IR.
Apr 7 2020, 2:08 AM · Restricted Project