Page MenuHomePhabricator

kiranchandramohan (Kiran Chandramohan)
User

Projects

User does not belong to any projects.

User Details

User Since
May 5 2017, 1:55 PM (193 w, 2 d)

Recent Activity

Fri, Jan 15

kiranchandramohan requested changes to D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.

A few comments.

Fri, Jan 15, 12:46 PM · Restricted Project, Restricted Project, Restricted Project

Thu, Jan 14

kiranchandramohan requested changes to D91920: [Flang] [OpenMP] Add semantic checks for OpenMP firstprivate , lastprivate and copyprivate clauses.

I believe the checks have to be made more precise. Please have a look at the comments.

Thu, Jan 14, 4:31 PM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan requested changes to D92732: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs.
Thu, Jan 14, 6:31 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added a reviewer for D94618: [flang] Fix dangling pointer in LabelEnforce: awarzynski.
Thu, Jan 14, 6:15 AM · Restricted Project, Restricted Project

Wed, Jan 13

kiranchandramohan accepted D93205: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs for single directive.

LGTM. Thanks for the patience.

Wed, Jan 13, 7:03 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan requested changes to D93205: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs for single directive.
Wed, Jan 13, 5:41 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added inline comments to D93205: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs for single directive.
Wed, Jan 13, 1:18 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan requested changes to D93091: [Flang] [OpenMP] Add semantic checks for OpenMP Workshare Construct.

Add a few tests to show that most restrictions do not apply inside a parallel construct nested inside a workshare construct.

Wed, Jan 13, 1:11 AM · Restricted Project

Tue, Jan 12

kiranchandramohan added inline comments to D93205: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs for single directive.
Tue, Jan 12, 7:59 PM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added inline comments to D93205: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs for single directive.
Tue, Jan 12, 6:30 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added inline comments to D93205: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs for single directive.
Tue, Jan 12, 12:49 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan accepted D93710: [mlir][openacc] Use TableGen information for default enum.

LGTM.

Tue, Jan 12, 12:27 AM · Restricted Project, Restricted Project

Mon, Jan 11

kiranchandramohan added inline comments to D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0..
Mon, Jan 11, 4:02 PM · Restricted Project, Restricted Project
kiranchandramohan added inline comments to D93373: [Flang][Openmp] Upgrade TASKGROUP construct to 5.0..
Mon, Jan 11, 3:52 PM · Restricted Project, Restricted Project
kiranchandramohan requested changes to D94087: [flang][openmp]At most one threads, simd and depend clause can appear on OpenMP ORDERED construct..

Requesting changes as per review comments/questions before. Thanks @clementval.

Mon, Jan 11, 2:52 PM · Restricted Project, Restricted Project
kiranchandramohan accepted D93447: [Flang][openmp][openacc] Extend CheckNoBranching to handle branching provided by LabelEnforce..

LGTM.

Mon, Jan 11, 2:50 PM · Restricted Project, Restricted Project
kiranchandramohan added a comment to D93710: [mlir][openacc] Use TableGen information for default enum.

Thanks for the patience.

Mon, Jan 11, 2:33 PM · Restricted Project, Restricted Project
kiranchandramohan added a comment to D93205: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs for single directive.

Looks mostly OK. Just one issue (FindEnclosingDirContext) to take a decision.

Mon, Jan 11, 2:13 PM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added inline comments to D93205: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs for single directive.
Mon, Jan 11, 6:12 AM · Restricted Project, Restricted Project, Restricted Project

Fri, Jan 8

kiranchandramohan requested changes to D92735: [Flang] [OpenMP] Add semantic checks for invalid branch into/from OpenMP constructs.

Need an answer here to proceed with review.

Fri, Jan 8, 7:26 PM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added a reviewer for D94247: [MLIR][TOSA] First lowerings from Tosa to Linalg: sjarus.
Fri, Jan 8, 6:50 PM · Restricted Project
kiranchandramohan committed rG268ff38a7161: [MLIR][OpenMP] Attribute to include WsLoop upperbound (authored by kiranchandramohan).
[MLIR][OpenMP] Attribute to include WsLoop upperbound
Fri, Jan 8, 6:43 AM
kiranchandramohan closed D94235: [MLIR][OpenMP] Attribute to include WsLoop upperbound.
Fri, Jan 8, 6:42 AM · Restricted Project

Thu, Jan 7

kiranchandramohan added a reviewer for D94235: [MLIR][OpenMP] Attribute to include WsLoop upperbound: SouraVX.
Thu, Jan 7, 8:40 AM · Restricted Project
kiranchandramohan requested review of D94235: [MLIR][OpenMP] Attribute to include WsLoop upperbound.
Thu, Jan 7, 7:53 AM · Restricted Project

Wed, Jan 6

kiranchandramohan accepted D94086: [mlir] Refactor translation of OpenMP dialect ops to LLVM IR.

Thanks for this patch Alex. LGTM.

Wed, Jan 6, 3:21 PM · Restricted Project

Tue, Jan 5

kiranchandramohan added a comment to D94087: [flang][openmp]At most one threads, simd and depend clause can appear on OpenMP ORDERED construct..

Two quick questions.

Tue, Jan 5, 7:39 AM · Restricted Project, Restricted Project

Wed, Dec 23

kiranchandramohan added inline comments to D93205: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs for single directive.
Wed, Dec 23, 3:21 PM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan accepted D93213: [Flang] [OpenMP] Add semantic check for OpenMP private ,firstprivate and lastprivate clauses.

"Variables that appear in namelist statements, in variable format expressions, or in expressions for statement function definitions, may not appear in a firstprivate clause."

@kiranchandramohan I was not able to find the implementation for the "variable format expressions" . Do we have support for this part ?

Wed, Dec 23, 3:19 PM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan requested changes to D93091: [Flang] [OpenMP] Add semantic checks for OpenMP Workshare Construct.
Wed, Dec 23, 3:16 PM · Restricted Project
kiranchandramohan requested changes to D91920: [Flang] [OpenMP] Add semantic checks for OpenMP firstprivate , lastprivate and copyprivate clauses.
Wed, Dec 23, 3:15 PM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added a comment to D91920: [Flang] [OpenMP] Add semantic checks for OpenMP firstprivate , lastprivate and copyprivate clauses.

A few comments.

Wed, Dec 23, 3:03 PM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added inline comments to D88655: [Flang][OpenMP][OpenACC] Fix exit out of a region in OpenMP parallel construct..
Wed, Dec 23, 2:19 PM · Restricted Project, Restricted Project
kiranchandramohan accepted D92055: [mlir] Add translation of omp.wsloop to LLVM IR.

I think the following three points can be dealt in other patches.
-> Attribute for inclusive upperbound/stop. If at some point in the future we decide to do some transformation/normalization then would this require initially creating a wsloop operation with inclusive attributes and bounds and then transforming this to a new wsloop operation without the attribute and normalized bounds and step? And is such a transformation OK with the MLIR flow?
-> Additional work in the OpenMPIRBuilder for handling negative step.
-> Changes to SCF for negative step (if required).

Wed, Dec 23, 1:08 AM · Restricted Project

Tue, Dec 22

kiranchandramohan added inline comments to D93576: [openacc] Use TableGen enum for default clause value.
Tue, Dec 22, 7:10 AM · Restricted Project, Restricted Project

Mon, Dec 21

kiranchandramohan added inline comments to D93091: [Flang] [OpenMP] Add semantic checks for OpenMP Workshare Construct.
Mon, Dec 21, 3:36 PM · Restricted Project
kiranchandramohan added inline comments to D93205: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs for single directive.
Mon, Dec 21, 11:49 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added a comment to D93205: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs for single directive.

Why are you changing the tests while removing XFAIL? eg. omp-do05.f90 was supposed to check chunk_size.

Mon, Dec 21, 11:17 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added a comment to D92735: [Flang] [OpenMP] Add semantic checks for invalid branch into/from OpenMP constructs.

@kiranchandramohan We can make use of labelEnforce class to identify the control flow escaping the construct . But it would not be useful to identify the control flow entering the OpenMP constructs and also it does not identify the transfer of control from one OpenMP construct to another such as this.
!$omp parallel
goto 10
a = a + b
!$omp single
10 call sb()
!$omp end single
!$omp end parallel

Mon, Dec 21, 9:46 AM · Restricted Project, Restricted Project, Restricted Project

Sun, Dec 20

kiranchandramohan added a comment to D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.

The following are not implemented. They also don't seem to be in the list of items to do. Do you know why they were not added?
-> The type and the rank of a list item that appears in a reduction clause must be valid for the combiner and initializer.
-> Additionally, the list item or the pointer component of the list item must not be deallocated, allocated, or pointer assigned within the region.
-> Additionally, the list item or the allocatable component of the list item must be neither deallocated nor allocated within the region.

Sun, Dec 20, 5:16 PM · Restricted Project, Restricted Project, Restricted Project

Dec 18 2020

kiranchandramohan updated the diff for D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.

Rebasing on main.

Dec 18 2020, 7:47 AM · Restricted Project, Restricted Project
kiranchandramohan commandeered D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.
Dec 18 2020, 7:46 AM · Restricted Project, Restricted Project
kiranchandramohan accepted D92854: [flang][driver] Add support for `-fsyntax-only`.
Dec 18 2020, 1:13 AM · Restricted Project, Restricted Project

Dec 17 2020

kiranchandramohan added inline comments to D92055: [mlir] Add translation of omp.wsloop to LLVM IR.
Dec 17 2020, 12:54 PM · Restricted Project
kiranchandramohan added a reviewer for D93105: [Flang][openmp][5.0] Add task_reduction clause.: yhegde.

@yhegde Will the changes in this patch affect your reduction patch (https://reviews.llvm.org/D90697)?

Dec 17 2020, 12:00 PM · Restricted Project, Restricted Project

Dec 16 2020

kiranchandramohan accepted D92638: [Flang][openmp]Fix crash in OpenMP semantic check( bug 48308).

LGTM.

Dec 16 2020, 5:29 AM · Restricted Project

Dec 11 2020

kiranchandramohan added a comment to D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.

First few comments.

Dec 11 2020, 9:41 AM · Restricted Project, Restricted Project
kiranchandramohan added inline comments to D92055: [mlir] Add translation of omp.wsloop to LLVM IR.
Dec 11 2020, 7:31 AM · Restricted Project
kiranchandramohan added inline comments to D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.
Dec 11 2020, 5:49 AM · Restricted Project, Restricted Project
kiranchandramohan accepted D89879: [Flang][OpenMP-5.0] Semantic checks for flush construct..

LGTM.

Dec 11 2020, 1:13 AM · Restricted Project, Restricted Project

Dec 10 2020

kiranchandramohan added inline comments to D92638: [Flang][openmp]Fix crash in OpenMP semantic check( bug 48308).
Dec 10 2020, 3:53 PM · Restricted Project
kiranchandramohan updated subscribers of D92055: [mlir] Add translation of omp.wsloop to LLVM IR.
Dec 10 2020, 3:49 PM · Restricted Project
kiranchandramohan accepted D89562: [flang]Add Parser Support for OpenMP Allocate Directive.

For semantics should have a check where the following case is caught.
!$omp allocate[(list)] clause
!$omp allocate(list)
!$omp allocate(list)

allocate statement
Dec 10 2020, 7:58 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added inline comments to D92055: [mlir] Add translation of omp.wsloop to LLVM IR.
Dec 10 2020, 2:15 AM · Restricted Project

Dec 9 2020

kiranchandramohan added inline comments to D92055: [mlir] Add translation of omp.wsloop to LLVM IR.
Dec 9 2020, 2:08 PM · Restricted Project
kiranchandramohan accepted D92845: [mlir] Explicitly track branch instructions in translation to LLVM IR.

Thanks for fixing this. LGTM.

Dec 9 2020, 11:17 AM · Restricted Project
kiranchandramohan added a comment to D92854: [flang][driver] Add support for `-fsyntax-only`.

A few comments.

Dec 9 2020, 1:12 AM · Restricted Project, Restricted Project

Dec 6 2020

kiranchandramohan requested changes to D92732: [Flang][OpenMP 4.5] Add semantic check for OpenMP Do Loop Constructs.
Dec 6 2020, 3:18 PM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan requested changes to D92735: [Flang] [OpenMP] Add semantic checks for invalid branch into/from OpenMP constructs.

There is a labelEnforce class (https://github.com/llvm/llvm-project/blob/a2f922140f5380571fb74179f2bf622b3b925697/flang/lib/Semantics/tools.cpp#L1338) which is used for checks in do-concurrent and co-arrays. It is used to find control flow escaping from a construct. Can that be reused?
Function CheckBranchesIntoDoBody (https://github.com/llvm/llvm-project/blob/a2f922140f5380571fb74179f2bf622b3b925697/flang/lib/Semantics/resolve-labels.cpp#L845) in resolve-labels.cpp checks for branches into the body of a loop. Can this code be reused?

Dec 6 2020, 2:35 PM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan accepted D92476: [OpenMPIRBuilder] introduce createStaticWorkshareLoop.

LGTM. Please wait for approval from @Meinersbur.

Dec 6 2020, 10:12 AM · Restricted Project, Restricted Project

Dec 2 2020

kiranchandramohan added a comment to D92476: [OpenMPIRBuilder] introduce createStaticWorkshareLoop.

Thanks @ftynse for this patch. This is great and will speed us up by a month.

Dec 2 2020, 11:09 AM · Restricted Project, Restricted Project

Dec 1 2020

kiranchandramohan added a comment to D91879: [Flang][OpenMP 4.5] Add semantic check for OpenMP Schedule Clause - chunk size.

OK. please close.

Dec 1 2020, 7:19 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added a comment to D91879: [Flang][OpenMP 4.5] Add semantic check for OpenMP Schedule Clause - chunk size.

Yes was referring to the 2), second one actually. So probably what check introduced in this patch is applicable as a semantic check. And I suppose the one which you were suggesting can be done at runtime. Also kindly suggest how I can go ahead with this patch.

Dec 1 2020, 6:38 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added a comment to D91879: [Flang][OpenMP 4.5] Add semantic check for OpenMP Schedule Clause - chunk size.

I only saw the following one which puts some conditions for using the same assignment of logical iteration numbers to threads for two loops. If these conditions are not met it is just that the implementation can use a different assignment. Are you referring to something else?

Dec 1 2020, 1:03 AM · Restricted Project, Restricted Project, Restricted Project

Nov 30 2020

kiranchandramohan added inline comments to D91879: [Flang][OpenMP 4.5] Add semantic check for OpenMP Schedule Clause - chunk size.
Nov 30 2020, 8:29 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan requested review of D92327: [MLIR][OpenMP][WIP] Pretty printer and parser for omp.wsloop.
Nov 30 2020, 8:12 AM · Restricted Project
kiranchandramohan accepted D90210: [flang] [OpenMP 4.5] Add semantic checks for OpenMP Private clause.

LGTM. Thanks @praveen.

Nov 30 2020, 6:08 AM · Restricted Project, Restricted Project, Restricted Project

Nov 25 2020

kiranchandramohan added inline comments to D90210: [flang] [OpenMP 4.5] Add semantic checks for OpenMP Private clause.
Nov 25 2020, 2:12 PM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added inline comments to D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.
Nov 25 2020, 5:35 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan accepted D90184: [flang][openacc] Semantic check for cache directive.

LGTM.

Nov 25 2020, 1:01 AM · Restricted Project, Restricted Project

Nov 24 2020

kiranchandramohan added inline comments to D90184: [flang][openacc] Semantic check for cache directive.
Nov 24 2020, 11:13 AM · Restricted Project, Restricted Project
kiranchandramohan updated subscribers of D91982: [mlir] Add conversion from SCF parallel loops to OpenMP.

LGTM.

Do you need the lowering to LLVM IR also sometime soon?

Previously, did you mention something about a parallelisation strategy and SCF ops carrying an attribute to determine whether they should be lowered to OpenMP parallel loops.

@SouraVX we can discuss the lowering separately for Flang. Since we decided to represent the work-sharing loop as a loop like operation (omp.wsloop), lowering directly to the work-sharing loop from the parse tree will be the straight forward method. If there are difficulties with that we can think of lowering to fir.do_loop and then converting to omp.wsloop but I think this might need modification of fir.do_loop or addition of a directive like operation in FIR.

Thanks for the quick review!

I am in the process of writing a translation to LLVM IR, happy to use anything that is already available.

Nov 24 2020, 9:52 AM · Restricted Project
kiranchandramohan accepted D91982: [mlir] Add conversion from SCF parallel loops to OpenMP.

Do you need the lowering to LLVM IR also sometime soon?

Nov 24 2020, 9:15 AM · Restricted Project
kiranchandramohan updated subscribers of D91982: [mlir] Add conversion from SCF parallel loops to OpenMP.

Thanks for this patch.

Nov 24 2020, 6:39 AM · Restricted Project
kiranchandramohan updated subscribers of D90210: [flang] [OpenMP 4.5] Add semantic checks for OpenMP Private clause.
Nov 24 2020, 1:22 AM · Restricted Project, Restricted Project, Restricted Project

Nov 23 2020

kiranchandramohan added a comment to D90210: [flang] [OpenMP 4.5] Add semantic checks for OpenMP Private clause.

@praveen can you reply inline in each comment whether you have made the changes suggested, reply to the question asked, or give your opinion? That way it will be easier for me to review.

Nov 23 2020, 2:35 PM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan accepted D91989: [mlir] Support WsLoopOp in OpenMP to LLVM dialect conversion.

Thanks. LGTM.

Nov 23 2020, 2:02 PM · Restricted Project
kiranchandramohan requested changes to D90210: [flang] [OpenMP 4.5] Add semantic checks for OpenMP Private clause.
Nov 23 2020, 6:24 AM · Restricted Project, Restricted Project, Restricted Project

Nov 22 2020

kiranchandramohan added a comment to D91920: [Flang] [OpenMP] Add semantic checks for OpenMP firstprivate , lastprivate and copyprivate clauses.

@kiranchandramohan In the test file omp-clause-validity01.f90 , the following no symbol found errors are not being thrown.

!ERROR: Internal: no symbol found for 'i'
!$omp taskwait depend(sink:i-1)

!ERROR: Internal: no symbol found for 'first'
!$omp critical (first)

Since the errors related to copyprivate clause in omp-clause-validity01.f90 (line numbers 324 and 340 above) being thrown as part of the checks for copyprivate in resolve-directives.cpp are marked as fatal errors , the flag errorOnUnresolvedName_ is being set to false and the no symbol found error is not being thrown.

 RewriteMutator(SemanticsContext &context)
 : errorOnUnresolvedName_{!context.AnyFatalError()},
    messages_{context.messages()} {}

void RewriteMutator::Post(parser::Name &name) {
   if (!name.symbol && errorOnUnresolvedName_) {
     messages_.Say(name.source, "Internal: no symbol found for '%s'"_err_en_US,
       name.source);
    }
 }

Is it not necessary to throw the "no symbol found" error if there is any error marked as fatal while resolving the directives ?

Should all the checks related to copyprivate be moved to check-omp-structure.cpp?

Can you please suggest the approach to follow for these changes?

Thanks!

Nov 22 2020, 3:38 PM · Restricted Project, Restricted Project, Restricted Project

Nov 21 2020

kiranchandramohan added a comment to D91920: [Flang] [OpenMP] Add semantic checks for OpenMP firstprivate , lastprivate and copyprivate clauses.

Flang.Semantics::omp-clause-validity01.f90

Script:

: 'RUN: at line 1'; /mnt/disks/ssd0/agent/llvm-project/flang/test/Semantics/test_errors.sh /mnt/disks/ssd0/agent/llvm-project/flang/test/Semantics/omp-clause-validity01.f90 /mnt/disks/ssd0/agent/llvm- project/build/tools/flang/test/Semantics/Output/omp-clause-validity01.f90.tmp /mnt/disks/ssd0/agent/llvm-project/build/bin/f18 -intrinsic-module-directory /mnt/disks/ssd0/agent/llvm-project/build/tools/flang/include/flang -fopenmp

Nov 21 2020, 3:04 PM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added inline comments to D89860: [Flang][OpenMP 4.5] Add semantic check for OpenMP ordered and collapse clause.
Nov 21 2020, 3:03 PM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added a comment to D89395: [Flang][OpenMP 4.5] Add semantic check for OpenMP shared and private clause.

No issues, please go ahead.

Nov 21 2020, 2:57 PM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan accepted D90834: [Flang][OpenMP][NFC][2/2] Reorder OmpStructureChecker and simplify it..

LGTM.

Nov 21 2020, 8:25 AM · Restricted Project, Restricted Project
kiranchandramohan added a comment to D90834: [Flang][OpenMP][NFC][2/2] Reorder OmpStructureChecker and simplify it..

Looks OK to me. Couple of minor comments.

Nov 21 2020, 6:29 AM · Restricted Project, Restricted Project
kiranchandramohan accepted D91839: [flang][openmp] Separate memory-order-clause parser creating OmpClause node.

@kiranchandramohan does this seem ok from query which was raised in https://reviews.llvm.org/D89583#inline-836220 comment ?

Nov 21 2020, 5:29 AM · Restricted Project, Restricted Project

Nov 20 2020

kiranchandramohan accepted D91889: [flang][openacc] Add clause validity tests for the host_data directive.

LGTM.

Nov 20 2020, 2:10 PM · Restricted Project
kiranchandramohan updated subscribers of D91879: [Flang][OpenMP 4.5] Add semantic check for OpenMP Schedule Clause - chunk size.

I will provide my understanding below. Can also check with @huntergr @Meinersbur.

Nov 20 2020, 2:04 PM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan added a comment to D87247: [MLIR,OpenMP] Added support for lowering MasterOp to LLVMIR.

I guess the only remaining point to address is to handle return the pass/fail status to MLIR module translation.

Nov 20 2020, 8:36 AM · Restricted Project
kiranchandramohan retitled D88706: [OpenMP][MLIR] WIP : Fix for AllocaIP from [OpenMP][MLIR] WIP : Fix for nested parallel region to [OpenMP][MLIR] WIP : Fix for AllocaIP.
Nov 20 2020, 7:28 AM · Restricted Project, Restricted Project

Nov 19 2020

kiranchandramohan added inline comments to D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.
Nov 19 2020, 3:37 PM · Restricted Project, Restricted Project, Restricted Project

Nov 18 2020

kiranchandramohan added a comment to D86071: [MLIR][OpenMP] Add omp.wsloop operation.

Thanks @Meinersbur for your comments. I will have a look soon. I suspect these are only used now for generating string enum classes in mlir openmp.

Nov 18 2020, 2:55 PM · Restricted Project, Restricted Project

Nov 17 2020

kiranchandramohan added a reviewer for D91556: [OpenMPIRBuilder} Add capturing of parameters to pass to omp::parallel: jdoerfert.

Thanks @llitchev for this patch.

Nov 17 2020, 4:29 PM · Restricted Project, Restricted Project, Restricted Project

Nov 16 2020

kiranchandramohan added a comment to D91159: [flang][openmp] Add General Semantic Checks for Allocate Directive.

I) Are you handling only a subset of the restrictions here? I see the following in,

  1. General restrictions.

-> allocate directives that appear in a target region must specify an allocator clause unless a requires directive with the dynamic_allocators clause is present in the same compilation unit.

Nov 16 2020, 10:57 AM · Restricted Project, Restricted Project
kiranchandramohan requested changes to D89562: [flang]Add Parser Support for OpenMP Allocate Directive.
Nov 16 2020, 10:43 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan committed rG843525075b87: [MLIR][OpenMP] Add omp.wsloop operation (authored by DavidTruby).
[MLIR][OpenMP] Add omp.wsloop operation
Nov 16 2020, 7:25 AM
kiranchandramohan closed D86071: [MLIR][OpenMP] Add omp.wsloop operation.
Nov 16 2020, 7:25 AM · Restricted Project, Restricted Project

Nov 15 2020

kiranchandramohan added a comment to D91002: [OpenMP] Fix asm for arm64-darwin.

I tested with make check-openmp and make check-clang on an AArch64 linux machine and both versions (D91002,D88252) pass.
If you were asking for a different kind of testing then please let me know.

Nov 15 2020, 1:47 PM · Restricted Project

Nov 13 2020

kiranchandramohan added a comment to D90697: [Flang][OpenMP 4.5] Add semantic check for OpenMP Reduction Clause.

@clementval had some changes for the OpenACC reduction operator in the following commit. I am not sure whether it is related to this issue.
https://reviews.llvm.org/D86296

Nov 13 2020, 7:45 AM · Restricted Project, Restricted Project, Restricted Project
kiranchandramohan accepted D89934: [flang] [OpenMP 4.5] Add semantic checks for OpenMP Depend clause.

LGTM.

Nov 13 2020, 7:33 AM · Restricted Project, Restricted Project, Restricted Project

Nov 12 2020

kiranchandramohan added a comment to D90210: [flang] [OpenMP 4.5] Add semantic checks for OpenMP Private clause.

ping.

Nov 12 2020, 5:54 AM · Restricted Project, Restricted Project, Restricted Project