Page MenuHomePhabricator

Meinersbur (Michael Kruse)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 17 2015, 7:07 AM (344 w, 1 d)

Recent Activity

Today

Meinersbur committed rG1d4ca42b4380: [OpenMPIRBuilder] Detect ambiguous InsertPoints for apply*WorkshareLoop. NFC. (authored by Meinersbur).
[OpenMPIRBuilder] Detect ambiguous InsertPoints for apply*WorkshareLoop. NFC.
Thu, Jan 20, 2:11 PM
Meinersbur requested review of D117835: [OpenMPIRBuilder] Detect and fix ambiguous InsertPoints for createSections..
Thu, Jan 20, 1:59 PM · Restricted Project, Restricted Project
Meinersbur committed rG616f77172f0a: [OpenMPIRBuilder] Detect and fix ambiguous InsertPoints for createParallel. (authored by Meinersbur).
[OpenMPIRBuilder] Detect and fix ambiguous InsertPoints for createParallel.
Thu, Jan 20, 8:14 AM
Meinersbur closed D117226: [OpenMPIRBuilder] Detect and fix ambiguous InsertPoints for createParallel..
Thu, Jan 20, 8:14 AM · Restricted Project, Restricted Project

Yesterday

Meinersbur accepted D114379: [OMPIRBuilder] Add support for simd (loop) directive..
Wed, Jan 19, 6:51 AM · Restricted Project, Restricted Project
Meinersbur added a comment to D117450: [LoopInterchange] Support loop interchange with floating point reductions.

There is the function findInnerReductionPhi that calls RecurrenceDescriptor::isReductionPHI to determine whether an operation is a reduction and also already checks fast-math flags. Isn't that check already sufficient?

Wed, Jan 19, 6:48 AM · Restricted Project, Unknown Object (Project)

Tue, Jan 18

Meinersbur updated the diff for D114413: [OpenMPIRBuilder] Implement static-chunked workshare-loop schedules..

libomp implemented a special case that I was not considering: When not in a parallel environment, it would ignore the chunksize and execute the entire iteration space as a single chunk. That is, we cannot assume that the chunk loop iteration count is chunksize must compute it from the lower and upper bound returned from the runtime call.

Tue, Jan 18, 3:54 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
Meinersbur accepted D117541: [polly][cmake] Use `GNUInstallDirs` to support custom installation dirs.

AFAICS, the commit did not break any Polly buildbots (https://lab.llvm.org/buildbot/#/changes/44169). That is, the Polly part looks good to me.

Tue, Jan 18, 11:51 AM · Restricted Project
Meinersbur added inline comments to D114379: [OMPIRBuilder] Add support for simd (loop) directive..
Tue, Jan 18, 8:31 AM · Restricted Project, Restricted Project

Mon, Jan 17

Meinersbur updated the diff for D114413: [OpenMPIRBuilder] Implement static-chunked workshare-loop schedules..

Still to do: fix bug report

Mon, Jan 17, 3:19 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
Meinersbur committed rZORGfd5d6f0cb350: [Zorg] Honor clean_obj in WebUI. (authored by Meinersbur).
[Zorg] Honor clean_obj in WebUI.
Mon, Jan 17, 1:57 PM
Meinersbur closed D107193: [Zorg] Honor clean_obj in WebUI..
Mon, Jan 17, 1:57 PM
Meinersbur accepted D114379: [OMPIRBuilder] Add support for simd (loop) directive..

LGTM. Thanks for the patch.

Mon, Jan 17, 1:48 PM · Restricted Project, Restricted Project
Meinersbur added a comment to D117226: [OpenMPIRBuilder] Detect and fix ambiguous InsertPoints for createParallel..

Nit: It seems the same code is codded to quite a few tests. Would it make sense to factor out the common portion?

Mon, Jan 17, 1:37 PM · Restricted Project, Restricted Project
Meinersbur updated the diff for D117226: [OpenMPIRBuilder] Detect and fix ambiguous InsertPoints for createParallel..
  • me -> be
Mon, Jan 17, 1:33 PM · Restricted Project, Restricted Project
Meinersbur updated the diff for D117226: [OpenMPIRBuilder] Detect and fix ambiguous InsertPoints for createParallel..
  • fix check-mlir
Mon, Jan 17, 1:30 PM · Restricted Project, Restricted Project
Meinersbur added inline comments to D117450: [LoopInterchange] Support loop interchange with floating point reductions.
Mon, Jan 17, 6:49 AM · Restricted Project, Unknown Object (Project)
Meinersbur added inline comments to D107193: [Zorg] Honor clean_obj in WebUI..
Mon, Jan 17, 6:35 AM
Meinersbur updated the diff for D107193: [Zorg] Honor clean_obj in WebUI..
  • Some forgotten cleanBuildRequestedByProperty
Mon, Jan 17, 6:35 AM

Thu, Jan 13

Meinersbur added inline comments to D114379: [OMPIRBuilder] Add support for simd (loop) directive..
Thu, Jan 13, 12:34 PM · Restricted Project, Restricted Project
Meinersbur added a comment to D114379: [OMPIRBuilder] Add support for simd (loop) directive..

[testing] Could you add a test for applySimd into OpenMPIRBuilderTests.cpp, so we have a test that is independent of Clang?

Thu, Jan 13, 12:32 PM · Restricted Project, Restricted Project
Meinersbur added a comment to D107193: [Zorg] Honor clean_obj in WebUI..

To clarify, in addition to renaming, I am proposing to change the semantics to match what you described in https://reviews.llvm.org/D107193#3194088. The new name "cleanObjRequested" is meant to reflect that. Renaming without this change of semantics IMHO does not make sense because the current cleanBuildRequestedByProperty does something else than described in https://reviews.llvm.org/D107193#3194088.

Thu, Jan 13, 7:54 AM
Meinersbur updated the diff for D107193: [Zorg] Honor clean_obj in WebUI..
  • Rebase
Thu, Jan 13, 7:45 AM
Meinersbur requested review of D117226: [OpenMPIRBuilder] Detect and fix ambiguous InsertPoints for createParallel..
Thu, Jan 13, 7:22 AM · Restricted Project, Restricted Project
Meinersbur accepted D115590: [LoopNest] Add new utilites.

LGTM

Thu, Jan 13, 7:01 AM · Restricted Project, Unknown Object (Project)

Wed, Jan 5

Meinersbur retitled D107193: [Zorg] Honor clean_obj in WebUI. from [Zorg] Don't delete test-suite source directory every time. to [Zorg] Honor clean_obj in WebUI..
Wed, Jan 5, 6:11 AM
Meinersbur added a comment to D107193: [Zorg] Honor clean_obj in WebUI..

In addition to be "not set", the clean property can also be "false". Should this count as "set"?

Sorry for not being clear. With a flag “not set" I meant "anything that evaluates to false", and with "set" I meant "anything that evaluates to true". But you have figured that out.

Wed, Jan 5, 6:09 AM

Thu, Dec 23

Meinersbur committed rG937b00ab2cf0: [Polly][SchedOpt] Account for prevectorization of multiple statements. (authored by Meinersbur).
[Polly][SchedOpt] Account for prevectorization of multiple statements.
Thu, Dec 23, 12:07 PM

Wed, Dec 22

Meinersbur added a comment to D107193: [Zorg] Honor clean_obj in WebUI..
  1. If clean build property is set, the source code, the build, and the install directories are removed before corresponding steps.
  2. If clean build property is NOT set, and if clean arg is set, or if clean_obj is set, then the build, and the install directories are removed before corresponding steps.

I do not see this in this patch. What am I missing?

Wed, Dec 22, 6:34 AM

Dec 20 2021

Meinersbur added a comment to D67258: Out-of-tree machine IR passes.

RegisterMIRPasses uses the "old" mechanism using a static initializer to register passes. For some time now the llvm-project it trying to get rid of static initializers because of their problems (static initialization order fiasco, more difficult to use as a library, etc.) AFAIU, especially MLIR was designed to avoid static initializers from the ground up, e.g. to register a dialect one has to call e.g. registerAffinePasses explicitly instead of relying on static initializers. I feel the patch re-introduces what we were trying to avoid.

Dec 20 2021, 8:58 AM · Restricted Project
Meinersbur added inline comments to D115590: [LoopNest] Add new utilites.
Dec 20 2021, 5:52 AM · Restricted Project, Unknown Object (Project)

Dec 12 2021

Meinersbur committed rG77e019c23389: [OpenMP] Add "not" to test dependencies. (authored by Meinersbur).
[OpenMP] Add "not" to test dependencies.
Dec 12 2021, 8:55 AM
Meinersbur closed D115454: [OpenMP] Add "not" to test dependencies..
Dec 12 2021, 8:54 AM · Restricted Project
Meinersbur added inline comments to D115454: [OpenMP] Add "not" to test dependencies..
Dec 12 2021, 8:32 AM · Restricted Project

Dec 10 2021

Meinersbur added a comment to D115529: [flang][nfc] Clarify the frontend/backend distinction.

IMHO, MLIR is part of the mid-end/optimizer. From a conceptual point, drawing the line between LLVM-IR and MLIR is arbitrary, and optimizations are done on the MLIR/FIR-level as well. Eg. Open64 has six different intermediate representations. "all the stages implemented in the Flang sub-project" is also blurry since MLIR other than the FIR dialect is not part of the flang project. Consistency with Clang can also not claimed since Clang has no MLIR or language-specific IR stage.

Dec 10 2021, 10:15 AM · Restricted Project, Restricted Project

Dec 9 2021

Meinersbur requested review of D115454: [OpenMP] Add "not" to test dependencies..
Dec 9 2021, 9:59 AM · Restricted Project
Meinersbur added a comment to D114639: Raise the minimum Visual Studio version to VS2019.

@erichkeane Since you are pushing for upgrade the gcc/clang requirement as well, would you take care of that?

Dec 9 2021, 9:53 AM · Restricted Project, Restricted Project
Meinersbur accepted D115042: [test-suite] Use CMAKE_C_COMPILER as TEST_SUITE_HOST_CC when compiling test-suite tools. .

LGTM

Dec 9 2021, 8:54 AM

Dec 8 2021

Meinersbur accepted D115378: OpenMP: Avoid using SmallVector::set_size().

LGTM

Dec 8 2021, 3:02 PM · Restricted Project, Restricted Project
Meinersbur added a comment to D114501: [OpenMP][test] Regression tests for OpenMPIRBuilder..

The two additional tests cause clang with -fopenmp-enable-irbuilder to crash, their introduction is not motivated by a specific execution behaviour (although that is useful too). D115216 is the basis to fix those. I will add descriptions to the tests.

Dec 8 2021, 9:51 AM · Restricted Project
Meinersbur added a comment to D115042: [test-suite] Use CMAKE_C_COMPILER as TEST_SUITE_HOST_CC when compiling test-suite tools. .

Use CMAKE_C_COMPILER_ID for detection.
The additional set(TEST_SUITE_HOST_CC ${CMAKE_C_COMPILER}) would ignore a user-configured host compiler. Instead, provide a default option like this (untested):

set(_host_cc_default "cc")
if (CMAKE_C_COMPILER_ID STREQUALS "Clang")
  # If using Clang we can use executable for the host even if CMake is configured to cross-compile.
  set(_host_cc_default "${CMAKE_C_COMPILER}")
endif ()
set(TEST_SUITE_HOST_CC "${_host_cc_default}" CACHE STRING "C compiler targeting the host")
Dec 8 2021, 9:44 AM

Dec 7 2021

Meinersbur updated the diff for D114501: [OpenMP][test] Regression tests for OpenMPIRBuilder..
  • Fix/adapt tests
Dec 7 2021, 11:47 AM · Restricted Project
Meinersbur requested changes to D114379: [OMPIRBuilder] Add support for simd (loop) directive..
Dec 7 2021, 11:13 AM · Restricted Project, Restricted Project
Meinersbur added a comment to D107193: [Zorg] Honor clean_obj in WebUI..

@gkistanova ping

Dec 7 2021, 8:07 AM
Meinersbur updated the diff for D114501: [OpenMP][test] Regression tests for OpenMPIRBuilder..

Rebase to head-of-tree

Dec 7 2021, 8:07 AM · Restricted Project
Meinersbur requested changes to D115042: [test-suite] Use CMAKE_C_COMPILER as TEST_SUITE_HOST_CC when compiling test-suite tools. .

CMAKE_C_COMPILER does not work here in all cases. In particular, when cross-compiling using gcc. For instance, I would like to cross-compile to an embedded ARM board on my x86_64 desktop. I'd configure CMake to aarch64-linux-gnu-gcc as CMAKE_C_COMPILER. Hence that llvm_add_host_executable would compile to aarch64, not my x86_64 host.

Dec 7 2021, 7:47 AM
Meinersbur added inline comments to D114940: [OMPIRBuilder] Support ordered clause specified without parameter.
Dec 7 2021, 7:35 AM · Restricted Project, Restricted Project

Dec 6 2021

Meinersbur requested review of D115218: [CodeExtractor] Refactor extractCodeRegion. NFCI..
Dec 6 2021, 10:09 PM · Restricted Project
Meinersbur requested review of D115216: [CodeExtractor] Optionally keep code in original function..
Dec 6 2021, 9:12 PM · Restricted Project
Meinersbur committed rGfed966f2a456: [OpenMPIRBuilder] Implicitly defined control blocks. NFC. (authored by Meinersbur).
[OpenMPIRBuilder] Implicitly defined control blocks. NFC.
Dec 6 2021, 12:09 PM
Meinersbur closed D114368: [OpenMPIRBuilder] Implicitly defined control blocks. NFC..
Dec 6 2021, 12:09 PM · Restricted Project, Restricted Project

Dec 2 2021

Meinersbur added inline comments to D114940: [OMPIRBuilder] Support ordered clause specified without parameter.
Dec 2 2021, 8:39 AM · Restricted Project, Restricted Project
Meinersbur added a comment to D114413: [OpenMPIRBuilder] Implement static-chunked workshare-loop schedules..

getPreheader() was in OMPIRBuilder.cpp before you rebase in your last update here. That's why I let you rebase since I failed to git apply your last patch in main branch. It's not important now. Please forget about that.

Dec 2 2021, 7:37 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Dec 1 2021

Meinersbur added inline comments to D114379: [OMPIRBuilder] Add support for simd (loop) directive..
Dec 1 2021, 9:44 AM · Restricted Project, Restricted Project
Meinersbur added a project to D109527: [Delinearization] Delinearization of Array-of-Struct. Proof-of-Concept.: Unknown Object (Project).
Dec 1 2021, 8:08 AM · Unknown Object (Project), Restricted Project

Nov 29 2021

Meinersbur added a comment to D114183: [ThreadPool] Support returning futures with results..

I try to make it disappear from my Phabricator dashboard. Seems the only way is to resign as a reviewer :-(

Nov 29 2021, 2:21 PM · Restricted Project, Restricted Project
Meinersbur accepted D114183: [ThreadPool] Support returning futures with results..
Nov 29 2021, 2:11 PM · Restricted Project, Restricted Project
Meinersbur updated the diff for D114368: [OpenMPIRBuilder] Implicitly defined control blocks. NFC..

Rebase

Nov 29 2021, 11:58 AM · Restricted Project, Restricted Project
Meinersbur added a comment to D114413: [OpenMPIRBuilder] Implement static-chunked workshare-loop schedules..

@Meinersbur Please rebase on main. The function "getPreheader()" was moved into OMPIRBuilder.h.

Nov 29 2021, 11:56 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
Meinersbur updated the diff for D114413: [OpenMPIRBuilder] Implement static-chunked workshare-loop schedules..
  • Rebase
  • clang-format
Nov 29 2021, 11:55 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
Meinersbur accepted D114143: [OpenMP][IRBuilder] Fix createSections.

AllocaIP could be handled better, but as a fix LGTM.

Nov 29 2021, 10:42 AM · Restricted Project, Restricted Project
Meinersbur added a comment to D114183: [ThreadPool] Support returning futures with results..

Could you close the review again if done?

Nov 29 2021, 10:39 AM · Restricted Project, Restricted Project
Meinersbur added inline comments to D114639: Raise the minimum Visual Studio version to VS2019.
Nov 29 2021, 10:07 AM · Restricted Project, Restricted Project

Nov 25 2021

Meinersbur updated the diff for D114413: [OpenMPIRBuilder] Implement static-chunked workshare-loop schedules..
  • Remove unused code
  • Fix mlir test
Nov 25 2021, 7:08 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Nov 24 2021

Meinersbur added a comment to D114331: [OMPIRBuilder] Fix static schedule in worksharing-loop directive.

@Meinersbur Thanks for the clarification. Can you also handle the fix in mlir part in D114413 (initilize chunk to nullptr and add some test cases in oepnmp-llvm.mlir)? I will close this PR since it is not complete fix.

Nov 24 2021, 9:03 PM · Restricted Project, Restricted Project
Meinersbur updated the diff for D114413: [OpenMPIRBuilder] Implement static-chunked workshare-loop schedules..
  • Simicolon after LLVM_FALLTHROUGH
  • Changes requested by @peixin
Nov 24 2021, 9:02 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
Meinersbur added a comment to D114336: [Polly] Generalize the pattern matching to the case of tensor contractions..

Thanks for upstreaming your tensor optimization!

Nov 24 2021, 6:36 PM · Restricted Project

Nov 23 2021

Meinersbur requested review of D114501: [OpenMP][test] Regression tests for OpenMPIRBuilder..
Nov 23 2021, 9:40 PM · Restricted Project
Meinersbur committed rT6a0d9f4af038: [sollve_vv] Don't run unsupported tests. (authored by Meinersbur).
[sollve_vv] Don't run unsupported tests.
Nov 23 2021, 7:53 PM
Meinersbur accepted D113857: [llvm-reduce] Add parallel chunk processing..

LGTM

Nov 23 2021, 12:59 AM · Restricted Project

Nov 22 2021

Meinersbur accepted D114363: [ThreadPool] Do not return shared futures..

LGTM as well. Indeed, users that need shared_future can call .share() themselves. Nothing else than the caller to async can retrieve the future anyway.

Nov 22 2021, 9:24 PM · Restricted Project, Restricted Project
Meinersbur requested changes to D114379: [OMPIRBuilder] Add support for simd (loop) directive..

Thanks for helping to complete the OpenMPIRBuilder implementation!

Nov 22 2021, 9:21 PM · Restricted Project, Restricted Project
Meinersbur requested review of D114413: [OpenMPIRBuilder] Implement static-chunked workshare-loop schedules..
Nov 22 2021, 8:50 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
Meinersbur requested changes to D114331: [OMPIRBuilder] Fix static schedule in worksharing-loop directive.

@peixin is correct. However, a "dispatch" loop is needed in addition to a "chunk" loop, please see TODO in the description of applyStaticWorkshareLoop. This patch would only iterate over chunk_size*omp_get_num_threads() iterations and leave any additional loop iterations unprocessed.

Nov 22 2021, 8:21 PM · Restricted Project, Restricted Project
Meinersbur requested review of D114368: [OpenMPIRBuilder] Implicitly defined control blocks. NFC..
Nov 22 2021, 7:12 AM · Restricted Project, Restricted Project

Nov 19 2021

Meinersbur added a comment to D114183: [ThreadPool] Support returning futures with results..

Variants of

llvm/include/llvm/Support/ThreadPool.h:184:12: error: no viable conversion from returned value of type 'shared_future<void>' to function return type 'shared_future<llvm::SmallString<0>>'
    return Future.share();
           ^~~~~~~~~~~~~~
Nov 19 2021, 8:06 PM · Restricted Project, Restricted Project
Meinersbur added a comment to D114183: [ThreadPool] Support returning futures with results..

I tried using void with both TaskTy and PackagedTaskTy, but both resulted in build errors when sharing the Future.

Nov 19 2021, 9:04 AM · Restricted Project, Restricted Project

Nov 18 2021

Meinersbur added inline comments to D113857: [llvm-reduce] Add parallel chunk processing..
Nov 18 2021, 3:45 PM · Restricted Project
Meinersbur added a comment to D114183: [ThreadPool] Support returning futures with results..

The pre-merge check has found additional locations where template arguments need to be added. Did you consider using using void as default template argument, or make ThreadPool a typedef of "ThreadPoolWithResult<void>"?

Nov 18 2021, 3:12 PM · Restricted Project, Restricted Project

Nov 17 2021

Meinersbur added a comment to D113857: [llvm-reduce] Add parallel chunk processing..

I am writing lots of suggestion for something you may have intended to be a simple addition that could be improved later just as well. If this applies, please tell me.

Nov 17 2021, 4:23 PM · Restricted Project
Meinersbur added inline comments to D113857: [llvm-reduce] Add parallel chunk processing..
Nov 17 2021, 10:55 AM · Restricted Project

Nov 16 2021

Meinersbur committed rGd2124bfccf59: [flang] Remove default argument from function template specialization. NFC. (authored by Meinersbur).
[flang] Remove default argument from function template specialization. NFC.
Nov 16 2021, 10:06 PM
Meinersbur closed D114032: [flang] Remove default argument from function template specialization. NFC..
Nov 16 2021, 10:06 PM · Restricted Project, Restricted Project
Meinersbur updated the summary of D114032: [flang] Remove default argument from function template specialization. NFC..
Nov 16 2021, 2:35 PM · Restricted Project, Restricted Project
Meinersbur requested review of D114032: [flang] Remove default argument from function template specialization. NFC..
Nov 16 2021, 1:59 PM · Restricted Project, Restricted Project

Nov 15 2021

Meinersbur added a comment to D107193: [Zorg] Honor clean_obj in WebUI..

@gkistanova ping

Nov 15 2021, 11:24 AM
Meinersbur accepted D113816: [llvm-reduce] Assert that the number of chunks does not change with reductions.
Nov 15 2021, 11:23 AM · Restricted Project
Meinersbur added a comment to D113812: [Cloning] Clone metadata on function declarations.

Huh... when did metadata get added to function declarations?

Nov 15 2021, 11:21 AM · Restricted Project
Meinersbur accepted D113808: [llvm-reduce] Don't reuse SmallVector across calls to getAllMetadata().

LGTM, thanks.

Nov 15 2021, 11:14 AM · Restricted Project
Meinersbur added a comment to D113816: [llvm-reduce] Assert that the number of chunks does not change with reductions.

Approach looks good to me.

Nov 15 2021, 11:09 AM · Restricted Project
Meinersbur added a comment to D113857: [llvm-reduce] Add parallel chunk processing..

Fixes spelling in title and summary.

Nov 15 2021, 10:56 AM · Restricted Project
Meinersbur retitled D113857: [llvm-reduce] Add parallel chunk processing. from [[llvm-reduce] Add parallel chunk processing. to [llvm-reduce] Add parallel chunk processing..
Nov 15 2021, 10:05 AM · Restricted Project

Nov 11 2021

Meinersbur committed rGc15f930e9656: [llvm-reduce] Introduce operands-skip pass. (authored by Meinersbur).
[llvm-reduce] Introduce operands-skip pass.
Nov 11 2021, 6:21 PM
Meinersbur added a reverting change for rGfa4210a9a072: [llvm-reduce] Introduce operands-skip pass.: rGed7b37155b48: Revert "[llvm-reduce] Introduce operands-skip pass.".
Nov 11 2021, 5:31 PM
Meinersbur committed rGed7b37155b48: Revert "[llvm-reduce] Introduce operands-skip pass." (authored by Meinersbur).
Revert "[llvm-reduce] Introduce operands-skip pass."
Nov 11 2021, 5:31 PM
Meinersbur added a reverting change for D111818: [llvm-reduce] Introduce operands-skip pass.: rGed7b37155b48: Revert "[llvm-reduce] Introduce operands-skip pass.".
Nov 11 2021, 5:31 PM · Restricted Project
Meinersbur accepted D113537: [llvm-reduce] Count chunks by running a preliminary reduction.

I can add such a test/assert in a followup patch, I'm afraid some existing pass already doesn't pass this test.

Nov 11 2021, 5:06 PM · Restricted Project
Meinersbur committed rGfa4210a9a072: [llvm-reduce] Introduce operands-skip pass. (authored by Meinersbur).
[llvm-reduce] Introduce operands-skip pass.
Nov 11 2021, 4:54 PM
Meinersbur closed D111818: [llvm-reduce] Introduce operands-skip pass..
Nov 11 2021, 4:54 PM · Restricted Project
Meinersbur updated the diff for D111818: [llvm-reduce] Introduce operands-skip pass..

Address last comment before landing

Nov 11 2021, 4:50 PM · Restricted Project