- User Since
- Jun 17 2015, 7:07 AM (291 w, 5 d)
Wed, Jan 6
I expected more changes to be necessary, to make it work with litsupport modules, perf/timeit, statistics, compile time (Interestingly, CMAKE_Fortran_COMPILE_OBJECT is already defined), LNT, ... . But if we find they don't work yet, we can fix that later.
Tue, Jan 5
Consider clang-format before pushing to main.
Mon, Jan 4
LGTM, thank you.
Tue, Dec 22
Alternatively, we could rely on SimplifyCFG to remote such empty BBs?
I don't understand the motivation. Sharing RuntimeCheckingPtrGroup between multiple objects will increase coupling between them.
Dec 18 2020
I would have done an unequal: if (NOT TARGET_OS STREQUAL "Darwin"). libIntl is part of the GNU user space environment, not the kernel, e.g. also apply to GNU/kFreeBSD.
- Address reviews
Dec 17 2020
Dec 15 2020
You are right, FindGettext seems to look for some commands, not the library.
Dec 14 2020
Can I help fixing the Windows build problem?
Thanks. Still LGTM.
Usually system introspection happens in the top-level CMakeLists.txt, but test-suite allows to selectively include subdirs, so it is a good location to do here.
Dec 11 2020
Dec 10 2020
- Avoid pre-merge check warning about using auto for an iterator.
- Extract changes not directly related to tileLoop into D93088
- Address pre-merge checks
Obsoleted by D91210
Dec 9 2020
Dec 8 2020
OMPBuilder part looks good to me, but probably an MLIR person should accept this patch.
Dec 7 2020
Dec 2 2020
Sorry for the wait. Phabricator did not send me notifications for the all the updates. Anyone has an idea why?
Nov 27 2020
Looking at CodeGenFunction::GenerateOpenMPCapturedVars, the condition if (!CurField->getType()->isAnyPointerType()) seems to match what is done here, but I wonder whether it is always necessary. Is the additional indirection necessary for pointer-sized data types (e.g. intptr_t, or smaller)?
So why not creating a OpenMPIRBuilder::createWorksharingLoop that can be used by clang as well?
Nov 25 2020
The intent was to create a OpenMPIRBuilder::createWorksharingLoop that takes a CanonicalLoop as an argument to be workshared. The heavy lifting would be done by createWorksharingLoop such that its logic does not need to be duplicated by clang and the OpenMP dialect.
Nov 18 2020
Nov 17 2020
Thank you for you the fix!
There might be other cmake configuration parameters used for introspection, such as ZLIB_INCLUDE_DIR (if using zlib), <PackageName>_ROOT etc.
From the array element type, the compiler should know which type to brace-initialize. There seems to be one set of braces too much, makes me wonder how it ever worked.
Nov 16 2020
Nov 14 2020
Nov 13 2020
Is this obsolete after D91470 has been committed?
Like IRBuilder and OpenMPIRBuilder, I think the OpenACC stuff is meant to be used by frontends outside of LLVM (in the sense of /llvm/*) and thus should be exposed as a component and llvm-config, but tested independently of those outside users. OpenACC is standardized for C/C++ as well.
This looks like an overdue fix. Thanks.
Nov 12 2020
Nov 11 2020
Could you try configuring LLVM with -DLLVM_BYE_LINK_INTO_TOOLS=ON? I assume the test will break because it unconditionally adds a FunctionPass.
Nov 10 2020
This looks like a major simplification of the build system. Code looks good, I confirmed it is working for my Windows build, Polly (i.e. statically linked pass plugins) is listed with --libs.
Thanks, looks good to me.
Nov 9 2020
My point is that it is possible for a pass plugin (such as llvm/examples/Bye) that can add themselves to the -O0 pipeline. If those plugins are linked statically, it will break tests that assume that no passes are added at those extension points.
Last update pushed only the change
Missed reference of CreateXXXX in comments
Thanks for your effort. I love it. Seems to remove complexities of the buildsystem and the ugly split of having to define library dependencies in two files.
Did you consider just removing the -NEXT suffix? Polly might not be the only case, other statically linked pass-plugins may also insert themselves at extension points.