Page MenuHomePhabricator

jhuber6 (Joseph Huber)
User

Projects

User does not belong to any projects.

User Details

User Since
May 4 2020, 11:17 AM (49 w, 8 h)

Recent Activity

Thu, Apr 1

jhuber6 committed rG69ca50bd7dfd: [OpenMP] Pass mapping names to add components in a user defined mapper (authored by jhuber6).
[OpenMP] Pass mapping names to add components in a user defined mapper
Thu, Apr 1, 12:52 PM
jhuber6 closed D99681: [OpenMP] Pass mapping names to add components in a user defined mapper.
Thu, Apr 1, 12:52 PM · Restricted Project
jhuber6 updated the diff for D99681: [OpenMP] Pass mapping names to add components in a user defined mapper.

Adding test

Thu, Apr 1, 10:58 AM · Restricted Project
jhuber6 committed rG0af4e74aef2e: [OpenMP][NFC] Fix typo in libomptarget error message (authored by jhuber6).
[OpenMP][NFC] Fix typo in libomptarget error message
Thu, Apr 1, 9:49 AM

Wed, Mar 31

jhuber6 requested review of D99681: [OpenMP] Pass mapping names to add components in a user defined mapper.
Wed, Mar 31, 1:08 PM · Restricted Project

Mon, Mar 29

jhuber6 committed rG29338459fb7e: [OpenMP] Trim error messages in CUDA plugin (authored by jhuber6).
[OpenMP] Trim error messages in CUDA plugin
Mon, Mar 29, 9:20 AM
jhuber6 closed D99510: [OpenMP] Trim error messages in CUDA plugin.
Mon, Mar 29, 9:20 AM · Restricted Project
jhuber6 added a comment to D99510: [OpenMP] Trim error messages in CUDA plugin.

How do error messages/info output look before & after?

Mon, Mar 29, 8:39 AM · Restricted Project
jhuber6 requested review of D99510: [OpenMP] Trim error messages in CUDA plugin.
Mon, Mar 29, 8:16 AM · Restricted Project

Fri, Mar 26

jhuber6 committed rG16064e71e934: [OpenMP] Reset async stream properly upon failure (authored by jhuber6).
[OpenMP] Reset async stream properly upon failure
Fri, Mar 26, 4:05 PM
jhuber6 closed D99443: [OpenMP] Reset async stream properly upon failure.
Fri, Mar 26, 4:05 PM · Restricted Project
jhuber6 requested review of D99443: [OpenMP] Reset async stream properly upon failure.
Fri, Mar 26, 2:18 PM · Restricted Project

Wed, Mar 24

jhuber6 committed rG8140d0ec4a3e: [OpenMP] Change OMPIRBuilder to append function attributes (authored by jhuber6).
[OpenMP] Change OMPIRBuilder to append function attributes
Wed, Mar 24, 6:09 AM
jhuber6 closed D98740: [OpenMP] Change OMPIRBuilder to append function attributes.
Wed, Mar 24, 6:08 AM · Restricted Project

Tue, Mar 23

jhuber6 updated the diff for D98740: [OpenMP] Change OMPIRBuilder to append function attributes.

Making changes.

Tue, Mar 23, 6:28 PM · Restricted Project
jhuber6 updated the diff for D97818: [OpenMP] Replace GPU globalization calls with shared memory in the middle-end.

Adding enum for address space constant.

Tue, Mar 23, 6:27 PM · Restricted Project, Restricted Project
jhuber6 updated the diff for D97818: [OpenMP] Replace GPU globalization calls with shared memory in the middle-end.

Making changes.

Tue, Mar 23, 5:48 PM · Restricted Project, Restricted Project
jhuber6 updated the diff for D99202: [OpenMP] Add OpenMPOpt as a Module pass.

Changed the pass registration to happen before the Attributor pass to avoid function specialization. Added a PhaseOrdering test that won't pass without the module pass.

Tue, Mar 23, 1:57 PM · Restricted Project
jhuber6 updated the diff for D99202: [OpenMP] Add OpenMPOpt as a Module pass.

Forgot to format.

Tue, Mar 23, 11:32 AM · Restricted Project
jhuber6 requested review of D99202: [OpenMP] Add OpenMPOpt as a Module pass.
Tue, Mar 23, 11:20 AM · Restricted Project

Fri, Mar 19

jhuber6 updated the diff for D97680: [OpenMP] Simplify GPU memory globalization.

Remove command line argument and more unused runtime functions from clang.

Fri, Mar 19, 11:44 AM · Restricted Project, Restricted Project, Restricted Project

Thu, Mar 18

jhuber6 updated the diff for D97818: [OpenMP] Replace GPU globalization calls with shared memory in the middle-end.
Thu, Mar 18, 1:30 PM · Restricted Project, Restricted Project
jhuber6 updated the diff for D97680: [OpenMP] Simplify GPU memory globalization.

Fixing test and formatting

Thu, Mar 18, 7:58 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Mar 17

jhuber6 updated the diff for D97818: [OpenMP] Replace GPU globalization calls with shared memory in the middle-end.

Changing the test to simply check if we are in a non-SPMD kernel function. A more advanced approach can be used in the future.

Wed, Mar 17, 2:21 PM · Restricted Project, Restricted Project
jhuber6 updated the diff for D97680: [OpenMP] Simplify GPU memory globalization.

Fixing tests and changing function interface back.

Wed, Mar 17, 2:19 PM · Restricted Project, Restricted Project, Restricted Project

Tue, Mar 16

jhuber6 updated the diff for D98740: [OpenMP] Change OMPIRBuilder to append function attributes.

Adding context, forgot to specify the range.

Tue, Mar 16, 4:26 PM · Restricted Project
jhuber6 requested review of D98740: [OpenMP] Change OMPIRBuilder to append function attributes.
Tue, Mar 16, 1:25 PM · Restricted Project

Mar 12 2021

jhuber6 updated the diff for D97818: [OpenMP] Replace GPU globalization calls with shared memory in the middle-end.

Changing this optimization to replace the globalization calls with shared memory. Removing them will be done by the attributor using HeapToStack once we add the allocation calls and improve the attributor.

Mar 12 2021, 1:24 PM · Restricted Project, Restricted Project
jhuber6 updated the diff for D97680: [OpenMP] Simplify GPU memory globalization.

Changed the RTL to have an argument that indicates if there is only one active caller for a team. This makes it easier to optimize.

Mar 12 2021, 1:21 PM · Restricted Project, Restricted Project, Restricted Project

Mar 11 2021

jhuber6 committed rG807466ef2812: [OpenMP] Restore backwards compatibility for libomptarget (authored by jhuber6).
[OpenMP] Restore backwards compatibility for libomptarget
Mar 11 2021, 6:52 AM
jhuber6 closed D98358: [OpenMP] Restore backwards compatibility for libomptarget.
Mar 11 2021, 6:52 AM · Restricted Project, Restricted Project, Restricted Project

Mar 10 2021

jhuber6 updated the diff for D98358: [OpenMP] Restore backwards compatibility for libomptarget.

Updating tests and adding the new function to the exports.

Mar 10 2021, 10:28 AM · Restricted Project, Restricted Project, Restricted Project
jhuber6 added a comment to D98358: [OpenMP] Restore backwards compatibility for libomptarget.

I think some existing Clang OpenMP codegen tests will break if they are testing against __kmpc_push_target_tripcount.

Mar 10 2021, 9:18 AM · Restricted Project, Restricted Project, Restricted Project
jhuber6 requested review of D98358: [OpenMP] Restore backwards compatibility for libomptarget.
Mar 10 2021, 8:30 AM · Restricted Project, Restricted Project, Restricted Project

Mar 3 2021

jhuber6 added a comment to D96462: [LV] Add remarks that explicitly mention error handling in candidate loops.

Ping.

Mar 3 2021, 7:38 AM · Restricted Project

Mar 2 2021

jhuber6 updated the summary of D97680: [OpenMP] Simplify GPU memory globalization.
Mar 2 2021, 4:41 PM · Restricted Project, Restricted Project, Restricted Project
jhuber6 requested review of D97818: [OpenMP] Replace GPU globalization calls with shared memory in the middle-end.
Mar 2 2021, 4:34 PM · Restricted Project, Restricted Project

Mar 1 2021

jhuber6 updated the summary of D97680: [OpenMP] Simplify GPU memory globalization.
Mar 1 2021, 5:55 AM · Restricted Project, Restricted Project, Restricted Project
jhuber6 added a comment to D97680: [OpenMP] Simplify GPU memory globalization.

Fixing tests is WIP

Mar 1 2021, 5:55 AM · Restricted Project, Restricted Project, Restricted Project
jhuber6 requested review of D97680: [OpenMP] Simplify GPU memory globalization.
Mar 1 2021, 5:54 AM · Restricted Project, Restricted Project, Restricted Project

Feb 19 2021

jhuber6 updated the diff for D96462: [LV] Add remarks that explicitly mention error handling in candidate loops.

Removing check for assert to keep the pass agnostic to the front-end and cleaning up the test file.

Feb 19 2021, 10:45 AM · Restricted Project

Feb 17 2021

jhuber6 committed rGc3a3d2009323: [LV] Add analysis remark for mixed precision conversions (authored by jhuber6).
[LV] Add analysis remark for mixed precision conversions
Feb 17 2021, 6:38 PM
jhuber6 closed D95539: [LV] Add analysis remark for mixed precision conversions.
Feb 17 2021, 6:38 PM · Restricted Project
jhuber6 updated the diff for D95539: [LV] Add analysis remark for mixed precision conversions.

Adding an extra check for multiple codes. I'll land it later today.

Feb 17 2021, 2:19 PM · Restricted Project
jhuber6 updated the diff for D95539: [LV] Add analysis remark for mixed precision conversions.

Adding test additional test case that checks for operands defined outside the
loop, and makes sure multiple remarks are not emitted for the same floating
point extension instruction.

Feb 17 2021, 11:37 AM · Restricted Project

Feb 16 2021

jhuber6 updated the diff for D95539: [LV] Add analysis remark for mixed precision conversions.

Pruning test file metadata.

Feb 16 2021, 2:12 PM · Restricted Project

Feb 11 2021

jhuber6 added a comment to D96462: [LV] Add remarks that explicitly mention error handling in candidate loops.

Thanks for working on improving the remarks! Unfortunately we have to be careful to keep them generic with respect to the frontend. I don't think we should be using a function name string to detect using assert and include other implementation specific parts (like NDEBUG) in the message. For example, the user could define their own __assert_fail function or the IR could be coming from a Rust or Swift frontend.

Feb 11 2021, 5:53 AM · Restricted Project

Feb 10 2021

jhuber6 requested review of D96462: [LV] Add remarks that explicitly mention error handling in candidate loops.
Feb 10 2021, 4:04 PM · Restricted Project

Feb 3 2021

jhuber6 added a comment to D95539: [LV] Add analysis remark for mixed precision conversions.

ping

Feb 3 2021, 7:56 AM · Restricted Project

Feb 2 2021

jhuber6 committed rGed8943c08769: [OpenMP][NFC] Adding FAQ Entry for errors with static libraries (authored by jhuber6).
[OpenMP][NFC] Adding FAQ Entry for errors with static libraries
Feb 2 2021, 7:50 AM

Feb 1 2021

jhuber6 added inline comments to D95786: [OpenMP] Fix seg fault in libomptarget when using Info with multiple threads.
Feb 1 2021, 8:49 AM · Restricted Project
jhuber6 committed rGfda48539988d: [OpenMP] Fix seg fault in libomptarget when using Info with multiple threads (authored by jhuber6).
[OpenMP] Fix seg fault in libomptarget when using Info with multiple threads
Feb 1 2021, 8:22 AM
jhuber6 closed D95786: [OpenMP] Fix seg fault in libomptarget when using Info with multiple threads.
Feb 1 2021, 8:22 AM · Restricted Project
jhuber6 requested review of D95786: [OpenMP] Fix seg fault in libomptarget when using Info with multiple threads.
Feb 1 2021, 7:38 AM · Restricted Project

Jan 27 2021

jhuber6 updated the diff for D95539: [LV] Add analysis remark for mixed precision conversions.

Adding test. Changing store type check.

Jan 27 2021, 2:21 PM · Restricted Project
jhuber6 updated the diff for D95539: [LV] Add analysis remark for mixed precision conversions.

Making suggested changes. I'll add a test case later.

Jan 27 2021, 10:54 AM · Restricted Project
jhuber6 added a comment to D95539: [LV] Add analysis remark for mixed precision conversions.

If anyone knows a better place to put this let me know. I couldn't find any existing infrastructure to run checks on the loop after its been vectorized.

Jan 27 2021, 9:22 AM · Restricted Project
jhuber6 requested review of D95539: [LV] Add analysis remark for mixed precision conversions.
Jan 27 2021, 9:21 AM · Restricted Project

Jan 26 2021

jhuber6 added a comment to D93727: [OpenMP] Add using bit flags to select Libomptarget Information.

Can mark the function itself as ((used)), for slightly less typing. Seems a reasonable workaround to me, with a comment like 'workaround bug in gcc 5.ish'

Jan 26 2021, 1:19 PM · Restricted Project
jhuber6 added inline comments to D93727: [OpenMP] Add using bit flags to select Libomptarget Information.
Jan 26 2021, 12:34 PM · Restricted Project
jhuber6 added inline comments to D93727: [OpenMP] Add using bit flags to select Libomptarget Information.
Jan 26 2021, 12:26 PM · Restricted Project

Jan 25 2021

jhuber6 committed rG93eef7d8e978: [OpenMP][NFC] Fix SourceInfo.h variable names (authored by jhuber6).
[OpenMP][NFC] Fix SourceInfo.h variable names
Jan 25 2021, 9:47 AM

Jan 22 2021

jhuber6 added inline comments to D95282: [OpenMP] Add source location information to the libomptarget profile.
Jan 22 2021, 6:19 PM · Restricted Project
jhuber6 added inline comments to D95282: [OpenMP] Add source location information to the libomptarget profile.
Jan 22 2021, 6:11 PM · Restricted Project

Jan 21 2021

jhuber6 committed rG119a9ea13f9f: [OpenMP] Fix failing test due to change in offloading flags (authored by jhuber6).
[OpenMP] Fix failing test due to change in offloading flags
Jan 21 2021, 11:10 AM
jhuber6 closed D95133: [OpenMP] Fix failing test due to change in offloading flags.
Jan 21 2021, 11:09 AM · Restricted Project
jhuber6 updated the diff for D95133: [OpenMP] Fix failing test due to change in offloading flags.

Added a flag selector to the INFO macro.

Jan 21 2021, 7:26 AM · Restricted Project
jhuber6 requested review of D95133: [OpenMP] Fix failing test due to change in offloading flags.
Jan 21 2021, 7:05 AM · Restricted Project
jhuber6 committed rGe4eaf9d82064: [OpenMP] Add support for mapping names in mapper API (authored by jhuber6).
[OpenMP] Add support for mapping names in mapper API
Jan 21 2021, 6:27 AM
jhuber6 closed D94806: [OpenMP] Add support for mapping names in mapper API.
Jan 21 2021, 6:27 AM · Restricted Project, Restricted Project, Restricted Project

Jan 20 2021

jhuber6 updated the diff for D94806: [OpenMP] Add support for mapping names in mapper API.

Adding a test case for the mapper names.

Jan 20 2021, 4:29 PM · Restricted Project, Restricted Project, Restricted Project
jhuber6 updated the diff for D94806: [OpenMP] Add support for mapping names in mapper API.

Changing the handling of OMP_TGT_MAPTYPE_PTR_AND_OBJ so it will not pass the same name for the base object. This doesn't pass in the correct name, simply makes it show up as unknown if queried.

Jan 20 2021, 1:40 PM · Restricted Project, Restricted Project, Restricted Project

Jan 15 2021

jhuber6 updated the diff for D94806: [OpenMP] Add support for mapping names in mapper API.

Fixed test

Jan 15 2021, 11:45 AM · Restricted Project, Restricted Project, Restricted Project
jhuber6 requested review of D94806: [OpenMP] Add support for mapping names in mapper API.
Jan 15 2021, 10:16 AM · Restricted Project, Restricted Project, Restricted Project

Jan 13 2021

jhuber6 committed rGa957634942a4: [OpenMP] Add documentation for error messages and release notes (authored by jhuber6).
[OpenMP] Add documentation for error messages and release notes
Jan 13 2021, 8:02 AM
jhuber6 closed D94562: [OpenMP] Add documentation for error messages and release notes.
Jan 13 2021, 8:02 AM · Restricted Project

Jan 12 2021

jhuber6 requested review of D94562: [OpenMP] Add documentation for error messages and release notes.
Jan 12 2021, 4:20 PM · Restricted Project
jhuber6 accepted D94541: [OpenMP] Fixed the link error that cannot find static data member.

LGTM.

Jan 12 2021, 12:07 PM · Restricted Project
jhuber6 accepted D94534: [OpenMP] Fixed include directories for OpenMP when building OpenMP with LLVM_ENABLE_RUNTIMES.

I tested it with a clean build using GCC 8.3 and CUDA 10.1, the resulting compiler successfuly built an offloading application that ran on the CUDA device. LGTM.

Jan 12 2021, 11:31 AM · Restricted Project

Jan 7 2021

jhuber6 committed rG2ce16810f283: [OpenMP] Always print error messages in libomptarget CUDA plugin (authored by jhuber6).
[OpenMP] Always print error messages in libomptarget CUDA plugin
Jan 7 2021, 2:48 PM
jhuber6 closed D94263: [OpenMP] Always print error messages in libomptarget CUDA plugin.
Jan 7 2021, 2:47 PM · Restricted Project
jhuber6 requested review of D94263: [OpenMP] Always print error messages in libomptarget CUDA plugin.
Jan 7 2021, 1:51 PM · Restricted Project
jhuber6 committed rGabb174bbc100: [OpenMP] Add example in Libomptarget Information docs (authored by jhuber6).
[OpenMP] Add example in Libomptarget Information docs
Jan 7 2021, 12:01 PM
jhuber6 closed D94246: [OpenMP] Add example in Libomptarget Information docs.
Jan 7 2021, 12:01 PM · Restricted Project
jhuber6 requested review of D94246: [OpenMP] Add example in Libomptarget Information docs.
Jan 7 2021, 10:43 AM · Restricted Project

Jan 6 2021

jhuber6 committed rG1ca5e68aa07e: [NVPTX] Fix debugging information being added to NVPTX target if remarks are… (authored by jhuber6).
[NVPTX] Fix debugging information being added to NVPTX target if remarks are…
Jan 6 2021, 10:45 AM
jhuber6 closed D94123: [NVPTX] Fix debugging information being added to NVPTX target if remarks are enabled.
Jan 6 2021, 10:45 AM · Restricted Project, Restricted Project
jhuber6 updated the diff for D94123: [NVPTX] Fix debugging information being added to NVPTX target if remarks are enabled.

Changing the solution. The problem seems to be that after adjusting the debug info, the driver would change the debug kind if remarks were enabled. Now it adjusts the debug information after performing that change. This means that some diagnostics won't work with optimizations but it's necessary to compile correctly.

Jan 6 2021, 8:05 AM · Restricted Project, Restricted Project

Jan 5 2021

jhuber6 added a comment to D94123: [NVPTX] Fix debugging information being added to NVPTX target if remarks are enabled.
In D94123#2480633, @tra wrote:

There's --cuda-noopt-device-debug option specifically to allow compiling GPU code with full debug info. Clang will generate optimized PTX, but ptxas optimizations will be disabled.

Without that flag clang automatically downgrades debug info generation to lineinfo only. I think -fsave-optimization-record should do the same.
Adding a pass to strip debug info may not be the best place to deal with the issue. I think not enabling full debug info would be a better choice.

Jan 5 2021, 3:56 PM · Restricted Project, Restricted Project
jhuber6 requested review of D94123: [NVPTX] Fix debugging information being added to NVPTX target if remarks are enabled.
Jan 5 2021, 2:33 PM · Restricted Project, Restricted Project
jhuber6 accepted D93785: [OpenMP][FIX] Ensure the isa trait is evaluated last.

LGTM

Jan 5 2021, 9:23 AM · Restricted Project, Restricted Project

Jan 4 2021

jhuber6 accepted D93735: [OpenMP][Docs] Add remarks intro section.

LGTM

Jan 4 2021, 9:54 AM · Restricted Project
jhuber6 committed rGfe5d51a4897c: [OpenMP] Add using bit flags to select Libomptarget Information (authored by jhuber6).
[OpenMP] Add using bit flags to select Libomptarget Information
Jan 4 2021, 9:05 AM
jhuber6 closed D93727: [OpenMP] Add using bit flags to select Libomptarget Information.
Jan 4 2021, 9:05 AM · Restricted Project

Dec 28 2020

jhuber6 updated the diff for D93727: [OpenMP] Add using bit flags to select Libomptarget Information.

Fixing a bug with passing a nullptr and making the kernel arguments print a different message for which type of region was executed.

Dec 28 2020, 12:34 PM · Restricted Project
jhuber6 added inline comments to D93727: [OpenMP] Add using bit flags to select Libomptarget Information.
Dec 28 2020, 11:51 AM · Restricted Project
jhuber6 updated the diff for D93727: [OpenMP] Add using bit flags to select Libomptarget Information.

Changing environment variables to initialize using std::call_once. Added a message when exiting an OpenMP data kernel.

Dec 28 2020, 9:14 AM · Restricted Project

Dec 24 2020

jhuber6 added inline comments to D93727: [OpenMP] Add using bit flags to select Libomptarget Information.
Dec 24 2020, 11:46 AM · Restricted Project

Dec 23 2020

jhuber6 added inline comments to D93723: [OpenMP] Add OpenMP Documentation for Libomptarget environment variables.
Dec 23 2020, 8:48 AM · Restricted Project
jhuber6 committed rG631501b1f90e: [OpenMP] Fixing typo on memory size in Documenation (authored by jhuber6).
[OpenMP] Fixing typo on memory size in Documenation
Dec 23 2020, 8:47 AM