Page MenuHomePhabricator

martong (Gabor Marton)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 10 2017, 8:01 AM (170 w, 4 d)

Recent Activity

Dec 15 2020

martong accepted D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes..

Thanks for your work, I am glad that finally the Window bug is fixed with a simple solution.

Dec 15 2020, 2:28 PM · Restricted Project
martong added inline comments to D93224: [RFC][analyzer] Use the MacroExpansionContext for macro expansions in plists.
Dec 15 2020, 4:09 AM · Restricted Project
martong added inline comments to D93224: [RFC][analyzer] Use the MacroExpansionContext for macro expansions in plists.
Dec 15 2020, 4:05 AM · Restricted Project
martong added inline comments to D93222: [RFC][analyzer] Introduce MacroExpansionContext to libAnalysis.
Dec 15 2020, 4:04 AM · Restricted Project
martong added a comment to D93223: [RFC][analyzer] Create MacroExpansionContext member in AnalysisConsumer and pass down to the diagnostics consumers.

Looks quite straight-forward other than that new prototype.

Dec 15 2020, 3:57 AM · Restricted Project
martong added a comment to D93222: [RFC][analyzer] Introduce MacroExpansionContext to libAnalysis.

Nice and precise work! And special thanks for the unit tests. I've found some minor nits.

Dec 15 2020, 3:51 AM · Restricted Project
martong requested changes to D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes..
Dec 15 2020, 3:14 AM · Restricted Project
martong added a comment to D92797: APINotes: add initial stub of APINotesWriter.

Ping

Dec 15 2020, 2:45 AM · Restricted Project
martong added a comment to D92634: [Analyzer] Diagnose signed integer overflow.

I think it could be better to implement this check with a checker on PreStmt<BinaryOperator> and so on. And IMO, checkers have enough functionalities to report these problems.

Besides, the return value should be the exact value computed from the two integers, even unknown, rather than undefined. As the developers may overflow an integer on purpose.

Dec 15 2020, 2:31 AM · Restricted Project
martong added a comment to D92634: [Analyzer] Diagnose signed integer overflow.

No reviews => I will not contribute.

Dec 15 2020, 2:24 AM · Restricted Project

Dec 14 2020

martong added a comment to D92962: [ASTImporter] Fix import of a typedef that has an attribute.

Shafik, thanks for the review!

Dec 14 2020, 9:28 AM · Restricted Project
martong committed rG68f53960e17d: [ASTImporter] Fix import of a typedef that has an attribute (authored by martong).
[ASTImporter] Fix import of a typedef that has an attribute
Dec 14 2020, 9:27 AM
martong closed D92962: [ASTImporter] Fix import of a typedef that has an attribute.
Dec 14 2020, 9:27 AM · Restricted Project
martong accepted D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes..

Thanks for the update. I checked it, still looks good to me.

Dec 14 2020, 8:11 AM · Restricted Project

Dec 10 2020

martong added inline comments to D92962: [ASTImporter] Fix import of a typedef that has an attribute.
Dec 10 2020, 6:00 AM · Restricted Project
martong updated the diff for D92962: [ASTImporter] Fix import of a typedef that has an attribute.
  • Check the attribute in the test as well
Dec 10 2020, 5:59 AM · Restricted Project
martong added a comment to D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes..

I wouldn't worry much about the ASTMerge tests, those are mostly legacy and not actively used nowadays. (At one point we were thinking even to remove them because we could got rid of the ASTMergeAction which is exclusively used for testing.)
The main test infrastructure for the ASTImporter is in the unittests. Those tests are exercised even with -fdelayed-template-parsing and with -fms-compatibility. So I am fine with marking the ASTMerge tests with XFAIL on windows.

Dec 10 2020, 5:47 AM · Restricted Project
martong accepted D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes..

LGTM!

Dec 10 2020, 2:54 AM · Restricted Project

Dec 9 2020

martong requested review of D92962: [ASTImporter] Fix import of a typedef that has an attribute.
Dec 9 2020, 12:49 PM · Restricted Project
martong committed rGa5e6590b15b1: [ASTImporter] Support CXXDeductionGuideDecl with local typedef (authored by martong).
[ASTImporter] Support CXXDeductionGuideDecl with local typedef
Dec 9 2020, 12:25 PM
martong closed D92209: [ASTImporter] Support CXXDeductionGuideDecl with local typedef.
Dec 9 2020, 12:25 PM · Restricted Project
martong updated the diff for D92209: [ASTImporter] Support CXXDeductionGuideDecl with local typedef.
  • Remove not relevant param from test
Dec 9 2020, 11:41 AM · Restricted Project
martong added a comment to D92848: [lldb] Create a ASTImporterSharedState and pass it to all ASTImporterDelegates.

However, every single TU in LLDB starts being pretty much empty (we do have some dummy declarations in them, but none of them have any name conflicts with declarations in any other AST we import from). So technically the 'empty' LookupTable is accurate.

Dec 9 2020, 9:08 AM
martong added a comment to D92848: [lldb] Create a ASTImporterSharedState and pass it to all ASTImporterDelegates.

So the only downside I can see is that the ASTImporter is no longer considering non-imported declarations in the To context (which are not known to the SharedState) for merging?

This is the case if you create the SharedState without a lookup table. If you pass a TUDecl then a lookup table will be created and in the constructor of that we traverse the AST to initialize the lookup. And from that point we will find every existing Decl even if they were not imported. As it is now we'd still be using the old noload_lookup.

@martong I assume I can make a follow-up for removing all the ASTImporter code for situations without a shared state?

Yes, that'd would be super.
Other than that, if you could make sure that the ASTImporterLookupTable is initialized then noload_lookup would not be needed and we could simplify so much in clang::ASTImporter.

Dec 9 2020, 6:30 AM
martong added a comment to D92848: [lldb] Create a ASTImporterSharedState and pass it to all ASTImporterDelegates.

So the only downside I can see is that the ASTImporter is no longer considering non-imported declarations in the To context (which are not known to the SharedState) for merging?

This is the case if you create the SharedState without a lookup table. If you pass a TUDecl then a lookup table will be created and in the constructor of that we traverse the AST to initialize the lookup. And from that point we will find every existing Decl even if they were not imported. As it is now we'd still be using the old noload_lookup.

Dec 9 2020, 6:27 AM
martong added a comment to D92209: [ASTImporter] Support CXXDeductionGuideDecl with local typedef.

Thanks for the review guys!

Dec 9 2020, 6:11 AM · Restricted Project
martong updated the diff for D92209: [ASTImporter] Support CXXDeductionGuideDecl with local typedef.
  • Remove if (!DC || !LexicalDC)
Dec 9 2020, 6:08 AM · Restricted Project
martong added inline comments to D92432: [analyzer] Add a thin abstraction layer between libCrossTU and libAnalysis..
Dec 9 2020, 3:33 AM · Restricted Project

Dec 8 2020

martong committed rGfebe75032f6f: [analyzer][StdLibraryFunctionsChecker] Add more return value contraints (authored by martong).
[analyzer][StdLibraryFunctionsChecker] Add more return value contraints
Dec 8 2020, 8:06 AM
martong closed D92771: [analyzer][StdLibraryFunctionsChecker] Add more return value contraints.
Dec 8 2020, 8:06 AM · Restricted Project
martong added a comment to D92771: [analyzer][StdLibraryFunctionsChecker] Add more return value contraints.

Thanks for the review!

Dec 8 2020, 8:03 AM · Restricted Project
martong committed rGd14c63167315: [analyzer][StdLibraryFunctionsChecker] Make close and mmap to accept -1 as fd (authored by martong).
[analyzer][StdLibraryFunctionsChecker] Make close and mmap to accept -1 as fd
Dec 8 2020, 8:01 AM
martong closed D92764: [analyzer][StdLibraryFunctionsChecker] Make close and mmap to accept -1 as fd.
Dec 8 2020, 8:01 AM · Restricted Project
martong updated the summary of D92771: [analyzer][StdLibraryFunctionsChecker] Add more return value contraints.
Dec 8 2020, 7:32 AM · Restricted Project
martong updated subscribers of D92771: [analyzer][StdLibraryFunctionsChecker] Add more return value contraints.
Dec 8 2020, 12:26 AM · Restricted Project

Dec 7 2020

martong added a comment to D92209: [ASTImporter] Support CXXDeductionGuideDecl with local typedef.

Ping.
@teemperor please take a look if you have some time. This is a really important patch which may influence some future directions regarding the ASTImporter.

Dec 7 2020, 9:45 AM · Restricted Project
martong requested review of D92771: [analyzer][StdLibraryFunctionsChecker] Add more return value contraints.
Dec 7 2020, 9:37 AM · Restricted Project
martong added inline comments to D92764: [analyzer][StdLibraryFunctionsChecker] Make close and mmap to accept -1 as fd.
Dec 7 2020, 8:41 AM · Restricted Project
martong updated the diff for D92764: [analyzer][StdLibraryFunctionsChecker] Make close and mmap to accept -1 as fd.
  • Use -1 for mmap too
Dec 7 2020, 8:41 AM · Restricted Project
martong requested review of D92764: [analyzer][StdLibraryFunctionsChecker] Make close and mmap to accept -1 as fd.
Dec 7 2020, 7:17 AM · Restricted Project

Dec 4 2020

martong added a comment to D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes..

It might be worth to extend StmtComparer as well with this Expr. I mean, probably two selections exprs should be considered equal if their assoc exprs are equal too...

Dec 4 2020, 1:06 AM · Restricted Project
martong added a comment to D92600: [ASTImporter] Add support for importing GenericSelectionExpr AST nodes..

It might be worth to extend StmtComparer as well with this Expr. I mean, probably two selections exprs should be considered equal if their assoc exprs are equal too...

Dec 4 2020, 1:04 AM · Restricted Project

Dec 3 2020

martong added a comment to D92209: [ASTImporter] Support CXXDeductionGuideDecl with local typedef.

I was thinking about to create a separate ASTImporter implementation specifically for CTU and LLDB could have it's own implementation. For that we just need to create an interface class with virtual functions.

Dec 3 2020, 10:27 AM · Restricted Project
martong added inline comments to D92209: [ASTImporter] Support CXXDeductionGuideDecl with local typedef.
Dec 3 2020, 9:31 AM · Restricted Project
martong committed rG1e14588d0f68: [Clang][Sema] Attempt to fix CTAD faulty copy of non-local typedefs (authored by martong).
[Clang][Sema] Attempt to fix CTAD faulty copy of non-local typedefs
Dec 3 2020, 2:36 AM
martong closed D92101: [Clang][Sema] Attempt to fix CTAD faulty copy of non-local typedefs.
Dec 3 2020, 2:36 AM · Restricted Project

Dec 2 2020

martong committed rGb40b3196b321: [analyzer][StdLibraryFunctionsChecker] Add return value constraint to functions… (authored by martong).
[analyzer][StdLibraryFunctionsChecker] Add return value constraint to functions…
Dec 2 2020, 8:55 AM
martong closed D92474: [analyzer][StdLibraryFunctionsChecker] Add return value constraint to functions with BufferSize.
Dec 2 2020, 8:55 AM · Restricted Project
martong updated the diff for D92474: [analyzer][StdLibraryFunctionsChecker] Add return value constraint to functions with BufferSize.
  • Remove comments
  • Hoist Range(-1,0) to ReturnsZeroOrMinusOne
Dec 2 2020, 6:48 AM · Restricted Project
martong added inline comments to D92474: [analyzer][StdLibraryFunctionsChecker] Add return value constraint to functions with BufferSize.
Dec 2 2020, 6:48 AM · Restricted Project
martong added inline comments to D92474: [analyzer][StdLibraryFunctionsChecker] Add return value constraint to functions with BufferSize.
Dec 2 2020, 6:36 AM · Restricted Project
martong accepted D92432: [analyzer] Add a thin abstraction layer between libCrossTU and libAnalysis..

Looks good, thanks!

Dec 2 2020, 4:05 AM · Restricted Project
martong accepted D91997: APINotes: add bitcode format schema definitions.

Looks good, thanks!

Dec 2 2020, 3:54 AM · Restricted Project
martong requested review of D92474: [analyzer][StdLibraryFunctionsChecker] Add return value constraint to functions with BufferSize.
Dec 2 2020, 3:40 AM · Restricted Project
martong updated subscribers of D92103: [ASTImporter] Import the default argument of TemplateTypeParmDecl.

Hey Raphael, thanks for looking into the CTU crash!

Dec 2 2020, 2:53 AM · Restricted Project, Restricted Project
martong added a comment to D92101: [Clang][Sema] Attempt to fix CTAD faulty copy of non-local typedefs.

Should we add a test for the regular function template case as well?

Dec 2 2020, 2:39 AM · Restricted Project
martong added a comment to D92101: [Clang][Sema] Attempt to fix CTAD faulty copy of non-local typedefs.

@rsmith I have moved the check into TransformTypedefType. We do not add the typedef to the MaterializedTypedefs list if it's context is dependent because later we set the deduction guide as the DC for all typedefs in the list:

for (auto *TD : MaterializedTypedefs)
  TD->setDeclContext(Guide);
Dec 2 2020, 2:36 AM · Restricted Project
martong updated the diff for D92101: [Clang][Sema] Attempt to fix CTAD faulty copy of non-local typedefs.
  • Add to MaterializedTypedefs only when copying the Decl
Dec 2 2020, 2:30 AM · Restricted Project
martong updated the diff for D92101: [Clang][Sema] Attempt to fix CTAD faulty copy of non-local typedefs.
  • Move dependent context check into TransformTypedefType
  • Add new test case for param with pointer type
Dec 2 2020, 2:23 AM · Restricted Project
martong added a comment to D92101: [Clang][Sema] Attempt to fix CTAD faulty copy of non-local typedefs.

Should we add a test for the regular function template case as well?

Dec 2 2020, 2:22 AM · Restricted Project

Dec 1 2020

martong added inline comments to D92109: [ASTImporter] Support import of CXXDeductionGuideDecl.
Dec 1 2020, 2:12 AM · Restricted Project

Nov 30 2020

martong committed rG70eb2ce395be: [ASTImporter] Support import of CXXDeductionGuideDecl (authored by martong).
[ASTImporter] Support import of CXXDeductionGuideDecl
Nov 30 2020, 8:56 AM
martong closed D92109: [ASTImporter] Support import of CXXDeductionGuideDecl.
Nov 30 2020, 8:56 AM · Restricted Project
martong added inline comments to D92101: [Clang][Sema] Attempt to fix CTAD faulty copy of non-local typedefs.
Nov 30 2020, 5:30 AM · Restricted Project
martong updated the diff for D92101: [Clang][Sema] Attempt to fix CTAD faulty copy of non-local typedefs.
  • Check for dependent DeclContext
  • Remove "dump()" calls from tests
Nov 30 2020, 5:30 AM · Restricted Project
martong accepted D92307: [analyzer][StdLibraryFunctionsChecker] Fix typos in summaries of mmap and mmap64.

Looks good, thanks!

Nov 30 2020, 5:05 AM · Restricted Project
martong added a comment to D92307: [analyzer][StdLibraryFunctionsChecker] Fix typos in summaries of mmap and mmap64.

That's a good fix!
How did this happen though that max value of off_t was even used for fd. Seems pretty odd!

Nov 30 2020, 5:03 AM · Restricted Project

Nov 27 2020

martong added inline comments to D92109: [ASTImporter] Support import of CXXDeductionGuideDecl.
Nov 27 2020, 1:37 AM · Restricted Project
martong updated the diff for D92109: [ASTImporter] Support import of CXXDeductionGuideDecl.
  • Update test to match the copy deduction guide
Nov 27 2020, 1:37 AM · Restricted Project
martong requested review of D92209: [ASTImporter] Support CXXDeductionGuideDecl with local typedef.
Nov 27 2020, 12:13 AM · Restricted Project

Nov 26 2020

martong added a comment to D92109: [ASTImporter] Support import of CXXDeductionGuideDecl.

Thanks for the review! Your comment made me think about whether we handle the deduced template class properly (getDeducedTemplate). Then I realized we do import that when we import the DeclarationName. Anyway I added a check for that in the test.

Nov 26 2020, 5:46 AM · Restricted Project
martong updated the diff for D92109: [ASTImporter] Support import of CXXDeductionGuideDecl.
  • Add test for user-defined ctad
  • Handle IsCopyDeductionCandidate
  • Fix typo
Nov 26 2020, 5:44 AM · Restricted Project
martong accepted D92119: [ASTImporter] Import the default argument of TemplateTemplateParmDecl.

Looks good, thanks!

Nov 26 2020, 2:58 AM · Restricted Project

Nov 25 2020

martong accepted D92106: [ASTImporter] Import the default argument of NonTypeTemplateParmDecl.

This looks good as well, thanks!

Nov 25 2020, 9:44 AM · Restricted Project
martong accepted D92103: [ASTImporter] Import the default argument of TemplateTypeParmDecl.

LG! Thanks!

Nov 25 2020, 9:40 AM · Restricted Project, Restricted Project
martong requested review of D92109: [ASTImporter] Support import of CXXDeductionGuideDecl.
Nov 25 2020, 9:33 AM · Restricted Project
martong added inline comments to D92101: [Clang][Sema] Attempt to fix CTAD faulty copy of non-local typedefs.
Nov 25 2020, 7:45 AM · Restricted Project
martong requested review of D92101: [Clang][Sema] Attempt to fix CTAD faulty copy of non-local typedefs.
Nov 25 2020, 7:31 AM · Restricted Project

Nov 24 2020

martong accepted D92016: [ASTImporter] Make the Import() return value consistent with the map of imported decls when merging ClassTemplateSpecializationDecls.

LGTM! And thanks for the pro unittest!

Nov 24 2020, 8:44 AM · Restricted Project

Nov 20 2020

martong accepted D91104: APINotes: add property models for YAML attributes.

Thanks, looks good to me!

Nov 20 2020, 2:35 AM · Restricted Project

Nov 19 2020

martong added inline comments to D91104: APINotes: add property models for YAML attributes.
Nov 19 2020, 6:34 AM · Restricted Project

Nov 17 2020

martong updated subscribers of D91543: [clang-tidy] Improving bugprone-sizeof-expr check..
Nov 17 2020, 1:53 AM · Restricted Project, Restricted Project

Nov 5 2020

martong requested changes to D90827: [clang] [StaticAnalyzer] DivZeroChecker: possibly zero non-tainted state should not transition to non-zero state directly..

We are trying to write checkers to catch possibly zero state.

IMO, that should be handled with taint analysis, i.e. when the value's provenance is untrusted we should warn. I don't see any other cases when we'd like to warn about a possible 0 denominator because that would cause false positives.

Nov 5 2020, 8:20 AM

Nov 3 2020

martong accepted D88859: APINotes: add APINotesYAMLCompiler.

Looks good to me now! Thanks for addressing my concerns.

Nov 3 2020, 2:35 AM · Restricted Project

Oct 30 2020

martong added inline comments to D88859: APINotes: add APINotesYAMLCompiler.
Oct 30 2020, 9:28 AM · Restricted Project

Oct 28 2020

martong added inline comments to D88859: APINotes: add APINotesYAMLCompiler.
Oct 28 2020, 10:41 AM · Restricted Project
martong added a comment to D88859: APINotes: add APINotesYAMLCompiler.

I'd like to have maximum flexibility from the submitter by willing to change the details of the implementation

I don't think that is a fair expectation - there are plenty of times where this is technical disagreement on functionality, and it doesn't get immediately resolved. A high quality implementation doesn't require that everything be changed immediately, nor does it mean that everything must be completely flexible. There are trade-offs, and the goal is to strike a balance between simplicity and the needs of the project.

Oct 28 2020, 10:38 AM · Restricted Project
martong added a comment to D63279: [Analyzer] Unroll for-loops where the upper boundary is a variable with know value.

FYI, I am working on repeating and reevaluating Peter's measurements with the current master. And if possible then I'd like to extend the measures for new C and C++ projects. I am planning to share the statistics and run-time results.

Oct 28 2020, 10:06 AM · Restricted Project
martong added a comment to D88859: APINotes: add APINotesYAMLCompiler.

I am having a hard time to accept "this is how it is implemented in our fork" as a technical argument. Besides, I am not sure how could the Clang community benefit about being backward compatible with a specialized fork and thus making superfluous complications.

Being compatible with Apple's SDKs is quite important for some part of the community.

This is similar to Clang implementing GCC and MSVC attributes, for example. Some might call them specialized attributes -- they are non-standard and are certainly not used by every C++ user -- but there exists a sizeable population of downstream consumers that rely on them. Apple's SDKs are in the same class.

Fair enough. But I don't think that Clang developers just copied the implementation from GCC or from MSVC.
I accept to keep the interface of the feature (i.e. the YAML format) as it is in the fork, okay. But, I'd like to have maximum flexibility from the submitter by willing to change the details of the implementation. I don't think that the implementation in the fork is necessarily the best realization, we can do better, after all that's the purpose of this review, isn't it?

Oct 28 2020, 4:47 AM · Restricted Project

Oct 27 2020

martong added a comment to D90157: [analyzer] Rework SValBuilder::evalCast function into maintainable and clear way.

Now I'm going to make unittests for SValBuilder::evalCast. Let me ask you to offer me some examples of casts to check. As many cases we can collect as robust the test would be. E.g.

Oct 27 2020, 5:41 AM · Restricted Project

Oct 20 2020

martong added a comment to D89638: [Analyzer][WebKit] Add attributes to suppress specific checkers.

I was thinking about an alternative approach (5th approach (?), yeah, I think we need an RFC).

What if we had just one attribute with a StringArgument ?
Actually, we already have that with the annotate attribute.
How do you like this?

struct [[clang::annotate("CSA:supress:RefCntblBaseVirtualDtor")]] Derived2
    : RefCntblBase{};

Disadvantages: we must process strings whenever a node has the annotate attr attached, we have to come up with a "DSL".
Advantages: total flexibility.
WDYT?

Honestly, I think that "CSA:supress:RefCntblBaseVirtualDtor" is way too verbose. It is incredibly easy to make mistakes, it seems hard to use and it is hell a lot to put in the actual code. It also doesn't resolve the issue with what unique identifier we should use. Imagine we decide that we should use Bug type as that unique identifier. It means that "CSA:supress:RefCntblBaseVirtualDtor" should get changed, but it is already in the user's code! It is quite important to settle on a solution that will still be available when we land a more general solution.

Oct 20 2020, 8:50 AM
martong added a comment to D89638: [Analyzer][WebKit] Add attributes to suppress specific checkers.

I was thinking about an alternative approach (5th approach (?), yeah, I think we need an RFC).

Oct 20 2020, 8:06 AM
martong accepted D89528: [clang][test] Fix prefix operator++ signature in iterators.

Ok, thanks for the context. LG!

Oct 20 2020, 5:14 AM · Restricted Project
martong abandoned D89318: [ASTImporter] Fix crash caused by unset AttributeSpellingListIndex.
Oct 20 2020, 4:41 AM · Restricted Project
martong reopened D89318: [ASTImporter] Fix crash caused by unset AttributeSpellingListIndex.
Oct 20 2020, 4:41 AM · Restricted Project
martong added a comment to D89318: [ASTImporter] Fix crash caused by unset AttributeSpellingListIndex.

Unfortunately, I could not reproduce the mentioned crash on our macOS machine. The mentioned test just passed with the output below. I gave up.

myuser@msmarple ~/llvm3/build/release_assert $ /usr/local/Frameworks/Python.framework/Versions/3.8/bin/python3.8 /Users/myuser/llvm3/git/llvm-project/lldb/test/API/dotest.py -S nm -u CXXFLAGS -u CFLAGS --codesign-identity - --env LLVM_LIBS_DIR=/Users/myuser/llvm3/build/release_assert/./lib --arch x86_64 --build-dir /Users/myuser/llvm3/build/release_assert/lldb-test-build.noindex -s /Users/myuser/llvm3/build/release_assert/lldb-test-traces --lldb-module-cache-dir /Users/myuser/llvm3/build/release_assert/lldb-test-build.noindex/module-cache-lldb/lldb-api --clang-module-cache-dir /Users/myuser/llvm3/build/release_assert/lldb-test-build.noindex/module-cache-clang/lldb-api --executable /Users/myuser/llvm3/build/release_assert/./bin/lldb --compiler /Users/myuser/llvm3/build/release_assert/./bin/clang --dsymutil /Users/myuser/llvm3/build/release_assert/./bin/dsymutil --filecheck /Users/myuser/llvm3/build/release_assert/./bin/FileCheck --yaml2obj /Users/myuser/llvm3/build/release_assert/./bin/yaml2obj --server /Users/myuser/llvm3/build/release_assert/./bin/debugserver --lldb-libs-dir /Users/myuser/llvm3/build/release_assert/./lib /Users/myuser/llvm3/git/llvm-project/lldb/test/API/commands/expression/import_builtin_fileid/ -p TestImportBuiltinFileID.py -t
lldb version 12.0.99 (https://github.com/llvm/llvm-project.git revision d454328ea88562a6ec6260529a040035ab9c4a06)
  clang revision d454328ea88562a6ec6260529a040035ab9c4a06
  llvm revision d454328ea88562a6ec6260529a040035ab9c4a06
libstdcxx tests will not be run because: Don't know how to build with libstdcxx on macosx
Skipping following debug info categories: ['dwo']
Oct 20 2020, 4:39 AM · Restricted Project

Oct 19 2020

martong added a reviewer for D88859: APINotes: add APINotesYAMLCompiler: NoQ.

Adding @NoQ as a reviewer, he might have some valuable comments, as he is very keen on this feature.

Oct 19 2020, 9:53 AM · Restricted Project
martong added a comment to D88859: APINotes: add APINotesYAMLCompiler.

as it is something which is actually in production already
...
At the very least we need it for compatibility - this is already a shipping feature.

Oct 19 2020, 9:49 AM · Restricted Project

Oct 16 2020

martong added a comment to D89528: [clang][test] Fix prefix operator++ signature in iterators.

What is the context here? Did it cause any crash/bug or were you just reading through the code for a good night sleep? :D

Oct 16 2020, 7:08 AM · Restricted Project
martong added a comment to D88859: APINotes: add APINotesYAMLCompiler.

Seems like this patch handles already existing attributes in Clang, so this might not be affected by the concerns brought up here by James:
http://lists.llvm.org/pipermail/cfe-dev/2020-October/066996.html

Oct 16 2020, 5:55 AM · Restricted Project