- User Since
- Jul 12 2018, 2:31 PM (132 w, 10 h)
LGTM, I will let Jonas approve since he has some issues that need addressing.
LGTM, thank you for expanding the test!
Fri, Jan 15
Wed, Jan 6
Tue, Jan 5
We can have unscoped enums in namespace and class scope and the enumerators won't leak out from those scopes. Thus we can have shadowing going on e.g.:
Dec 18 2020
- Fixed formatters::ObjCBOOLSummaryProvider to use int8_t and fixed the Printf
- Updated tests
Dec 17 2020
Updating diff to reflect comments.
After chatting with Raphael offline, we realize that BOOL will indeed always be signed. I was under the impression for some reason that it was actually unsigned. So the fix is simpler is that we just need to make the formatter use GetValueAsSigned(...)
Dec 16 2020
I am not sure if I need to worry about ValueObject::IsLogicalTrue(...) as well.
Dec 10 2020
Dec 9 2020
Dec 8 2020
Should the test also include types that don't come from modules, just to make sure there are no odd interactions with this change.
LGTM but I have one questions and I am also curious about Adrian's question about returning by reference.
Dec 4 2020
The problem with this approach is given:
Dec 3 2020
ASTImporter changes looks good to me.
Dec 2 2020
+1 to what @teemperor said
Dec 1 2020
There is also alias templates:
Nov 30 2020
Should we add a test for the regular function template case as well?
Nov 19 2020
LGTM, there are no tests currently?
Nov 18 2020
I think your CMakeLists.txt broke the green dragon build: http://lab.llvm.org:8080/green/view/LLDB/job/lldb-cmake/24893/consoleFull#349140555e9a0fee5-ebcc-4238-a641-c5aa112c323e
Interesting so we always had the error Top-level code needs to be inserted into a runnable target but we just were not triggering it before?
Nov 12 2020
Nov 10 2020
LGTM besides the minor comments.
Add a check to make sure the bit offset is zero for fields in a union.
So this work for primitive types like int* etc?
Nov 9 2020
Nov 2 2020
Oct 26 2020
Oct 22 2020
Oct 21 2020
LGTM, this feels cleaner.
Oct 16 2020
Oct 13 2020
makes sense, LGTM.
Oct 8 2020
This looks reasonable, I am guessing we can't test this b/c it would only come up in a cling use case?
Oct 7 2020
LGTM I notice that we are using m_byte_offset directly a little above the line you fixed instead of GetByteOffset().
Oct 6 2020
ASTImporter changes looks good.
I am happy this was not hiding any regressions.
Oct 2 2020
Oct 1 2020
So was the bug we were saying there were falsely equivalent or falsely not equivalent?
Sep 24 2020
Sep 21 2020
Sep 17 2020
Fix handling of multi-dimensional arrays.
Sep 16 2020
We are going to move forward with this approach (after dealing with the multi-dimensional array case) temporarily. We are seeing crash bugs from this from users and we want to fix it while we explore the solution space more.
Sep 13 2020
Sep 8 2020
Sep 3 2020
@martong I have been experimenting w/ how we pass around ImportDefinitionKind and pushing it through to more places does not help. I also tried defaulting most locations to IDK_Everything to experiment to see if maybe I was missing some crucial point and no luck. So while it seemed like a good direction it has not worked out, unless I missed something in your idea.
Aug 27 2020
Aug 26 2020
LGTM with minor comments. Thank you for these fixes, they are awesome!
Aug 24 2020
-Add REQUIRES x86
- Fix-up the comments in the test
Aug 21 2020
Thank you finding these additional fixed, it looks good but I don't know some of the details as well as Adrian so I would prefer he gives the LGTM.
Aug 20 2020
Aug 18 2020
This is nice catch! LGTM
Aug 13 2020
Minor comment but LGTM, nice fix!
LGTM, it is sad we lose the deterministic ordering though. Would it be efficient enough to use a vector but keep the set to prevent duplicates?
Update test name