- User Since
- Jul 12 2018, 2:31 PM (114 w, 1 d)
Thu, Sep 17
Fix handling of multi-dimensional arrays.
Wed, Sep 16
We are going to move forward with this approach (after dealing with the multi-dimensional array case) temporarily. We are seeing crash bugs from this from users and we want to fix it while we explore the solution space more.
Sun, Sep 13
Tue, Sep 8
Thu, Sep 3
@martong I have been experimenting w/ how we pass around ImportDefinitionKind and pushing it through to more places does not help. I also tried defaulting most locations to IDK_Everything to experiment to see if maybe I was missing some crucial point and no luck. So while it seemed like a good direction it has not worked out, unless I missed something in your idea.
Thu, Aug 27
Wed, Aug 26
LGTM with minor comments. Thank you for these fixes, they are awesome!
Mon, Aug 24
-Add REQUIRES x86
- Fix-up the comments in the test
Fri, Aug 21
Thank you finding these additional fixed, it looks good but I don't know some of the details as well as Adrian so I would prefer he gives the LGTM.
Thu, Aug 20
Aug 18 2020
This is nice catch! LGTM
Aug 13 2020
Minor comment but LGTM, nice fix!
LGTM, it is sad we lose the deterministic ordering though. Would it be efficient enough to use a vector but keep the set to prevent duplicates?
Update test name
Aug 12 2020
I am curious about constexpr static as well here.
Updated test using more compact code from Fred.
Replacing python test with Shell test
Aug 11 2020
We found a way to hand modify the assembly and it looks good, I just need to convert it to a test.
Aug 10 2020
Updated to use llvm.org clang, remove header files from the main.c and add the commit hash for the clang so that it is easier to replicate the main.s in the future.
Aug 6 2020
- Add more tests
- Refactored the Makefile and test based on offline comments from Adrian.
Removing use of -O1 from Makefile.
Aug 5 2020
Note: for the test I did not want to rely on clang choosing to pass the union by register, so I used assembly which ensures I will obtain the behavior I am looking to capture for the test.
Aug 3 2020
Do we understand how to fix the crash in the case where we get a pair back? I am not sure how frequent the use case is.
Jul 29 2020
Jul 24 2020
Jul 23 2020
Updating diff since the parent landed.
I updated to include the radar number.
Jul 22 2020
Removing text->GetValueAsUnsigned(0) == 0 check.
I was testing out how NSStringSummaryProvider deals w/ NULL using NSString *foo = nullptr and we filter out NULL values in ValueObjectPrinter::GetValueSummaryError(...) :
Jul 21 2020
Jul 20 2020
Thank you for this fix!
Jul 16 2020
LGTM but I want @martong to take a look as well and accept.
Jul 15 2020
@labath why do we need two copies of use_lldb_suite.py?
Jul 14 2020
Added clarifying comment.
It does indeed solve the immediate problem but if those namespaces aren't really meant to be shared across translation units they should have different names but that is for another PR.
Curious, why didn't we do it this way before?
Jul 9 2020
@aprantl I think this Objective-C Runtime Programming Guide: Bye Encodings entry and this sample program answer the rest of your questions:
We can never know the offsets statically b/c of how Objective-C deals with the fragile base class problem the runtime may have to shift fields over and we can not calculate this statically.
Jul 8 2020
Moved from shell test
Jul 7 2020
- Removing spurious local variables in test
- Simplifying the test
Jul 6 2020
Adding a second test that is not arm64 specific.
Jul 2 2020
So with the debug info before this fix what behavior does gdb and lldb have?