Page MenuHomePhabricator

hubert.reinterpretcast (Hubert Tong)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 27 2014, 8:34 PM (316 w, 5 d)

Recent Activity

Today

hubert.reinterpretcast committed rG6801950192ff: [InstCombine] For pow(x, +/-0.5), stop falling into pow(x, 1.5), etc. case (authored by hubert.reinterpretcast).
[InstCombine] For pow(x, +/-0.5), stop falling into pow(x, 1.5), etc. case
Tue, Sep 22, 11:24 AM
hubert.reinterpretcast committed rGb0f58aa116a1: [NFC] Replace tabs with spaces in PPCInstrPrefix.td (authored by hubert.reinterpretcast).
[NFC] Replace tabs with spaces in PPCInstrPrefix.td
Tue, Sep 22, 11:24 AM
hubert.reinterpretcast committed rGa6f8aeb51c73: [test][MC] Rehabilitate llvm/test/MC/COFF/bigobj.py (authored by hubert.reinterpretcast).
[test][MC] Rehabilitate llvm/test/MC/COFF/bigobj.py
Tue, Sep 22, 11:23 AM
hubert.reinterpretcast closed D88066: [InstCombine] For pow(x, +/-0.5), stop falling into pow(x, 1.5), etc. case.
Tue, Sep 22, 11:23 AM · Restricted Project
hubert.reinterpretcast closed D87122: [test][MC] Rehabilitate llvm/test/MC/COFF/bigobj.py.
Tue, Sep 22, 11:23 AM · Restricted Project
hubert.reinterpretcast added inline comments to D87877: [InstCombine] Fix errno bug in pow expansion to sqrt.
Tue, Sep 22, 9:17 AM · Restricted Project
hubert.reinterpretcast updated the diff for D87877: [InstCombine] Fix errno bug in pow expansion to sqrt.
  • Rebase on top of D88066; add isKnownNeverInfinity condition
  • Adjust comment for afn case
Tue, Sep 22, 8:56 AM · Restricted Project
hubert.reinterpretcast added inline comments to D88066: [InstCombine] For pow(x, +/-0.5), stop falling into pow(x, 1.5), etc. case.
Tue, Sep 22, 6:42 AM · Restricted Project

Yesterday

hubert.reinterpretcast requested review of D88066: [InstCombine] For pow(x, +/-0.5), stop falling into pow(x, 1.5), etc. case.
Mon, Sep 21, 9:06 PM · Restricted Project
hubert.reinterpretcast added inline comments to D87877: [InstCombine] Fix errno bug in pow expansion to sqrt.
Mon, Sep 21, 8:55 PM · Restricted Project
hubert.reinterpretcast accepted D87113: [AIX][compiler-rt] Use the AR/ranlib mode flag for 32-bit and 64-bit mode.

Compiler-rt supports generating multiple targets from a single configuration. By default the compiler-rt build process will figure out the supported arches and generate different targets for the powerpc and powerpc64 objects, so there is only one real run.

Mon, Sep 21, 4:54 PM · Restricted Project
hubert.reinterpretcast added a comment to D87114: [AIX][ExecutionEngine] Disable eh frame support when building with Clang on AIX.

General comment: CMake is not the only mechanism for making the conditions common; a header file is capable of the same.

Mon, Sep 21, 4:02 PM · Restricted Project
hubert.reinterpretcast accepted D87927: [AIX][clang][driver] Make sure crti[_64].o is linked in C++ mode.

LGTM; thanks.

Mon, Sep 21, 3:34 PM · Restricted Project
hubert.reinterpretcast retitled D87927: [AIX][clang][driver] Make sure crti[_64].o is linked in C++ mode from [AIX][clang][driver] Make sure ctri.o is linked in C++ mode to [AIX][clang][driver] Make sure crti[_64].o is linked in C++ mode.
Mon, Sep 21, 2:00 PM · Restricted Project
hubert.reinterpretcast added inline comments to D87927: [AIX][clang][driver] Make sure crti[_64].o is linked in C++ mode.
Mon, Sep 21, 1:59 PM · Restricted Project
hubert.reinterpretcast added inline comments to D87877: [InstCombine] Fix errno bug in pow expansion to sqrt.
Mon, Sep 21, 10:20 AM · Restricted Project
hubert.reinterpretcast added inline comments to D87877: [InstCombine] Fix errno bug in pow expansion to sqrt.
Mon, Sep 21, 8:35 AM · Restricted Project
hubert.reinterpretcast added inline comments to D87877: [InstCombine] Fix errno bug in pow expansion to sqrt.
Mon, Sep 21, 8:15 AM · Restricted Project

Fri, Sep 18

hubert.reinterpretcast updated the summary of D87877: [InstCombine] Fix errno bug in pow expansion to sqrt.
Fri, Sep 18, 11:01 AM · Restricted Project
hubert.reinterpretcast added inline comments to D87375: [compiler-rt] Support glibc's non-standard I printf flag character.
Fri, Sep 18, 9:42 AM · Restricted Project
hubert.reinterpretcast added inline comments to D87375: [compiler-rt] Support glibc's non-standard I printf flag character.
Fri, Sep 18, 6:23 AM · Restricted Project

Thu, Sep 17

hubert.reinterpretcast requested review of D87877: [InstCombine] Fix errno bug in pow expansion to sqrt.
Thu, Sep 17, 7:58 PM · Restricted Project

Wed, Sep 16

hubert.reinterpretcast accepted D87794: Disable a large test for EXPENSIVE_CHECKS and debug build.
Wed, Sep 16, 2:18 PM · Restricted Project
hubert.reinterpretcast added a comment to D87794: Disable a large test for EXPENSIVE_CHECKS and debug build.

LGTM (given similar handling for debug builds). Thanks @jasonliu for finding a way to disable this selectively.

Wed, Sep 16, 2:17 PM · Restricted Project
hubert.reinterpretcast added inline comments to D87794: Disable a large test for EXPENSIVE_CHECKS and debug build.
Wed, Sep 16, 2:15 PM · Restricted Project
hubert.reinterpretcast accepted D87611: [SystemZ][z/OS] Set aligned allocation unavailable by default for z/OS.

LGTM; thanks.

Wed, Sep 16, 10:09 AM · Restricted Project
hubert.reinterpretcast added inline comments to D87611: [SystemZ][z/OS] Set aligned allocation unavailable by default for z/OS.
Wed, Sep 16, 9:01 AM · Restricted Project
hubert.reinterpretcast accepted D87624: [SystemZ][z/OS] Set default wchar_t type for zOS.

LGTM.

Wed, Sep 16, 8:25 AM · Restricted Project

Tue, Sep 15

hubert.reinterpretcast added a comment to D86879: [XCOFF][AIX] Handle TOC entries that could not be reached by positive range in small code model.

It appears this patch added a test that is failing with expensive checks on GreenDragon: http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-expensive/17604/console. It would be great if you could take a look and revert if it takes longer to fix.

Tue, Sep 15, 6:49 AM · Restricted Project

Mon, Sep 14

hubert.reinterpretcast added a comment to D87650: [flang] Rework preprocessing of stringification.

Is this a documented assert idiom? Wouldn't macro expansion occur if STR(x) did not immediately apply the stringification (but instead expanded to an invocation of another macro)?

Mon, Sep 14, 8:07 PM · Restricted Project, Restricted Project
hubert.reinterpretcast added inline comments to D87611: [SystemZ][z/OS] Set aligned allocation unavailable by default for z/OS.
Mon, Sep 14, 9:53 AM · Restricted Project

Thu, Sep 10

hubert.reinterpretcast accepted D87383: [compiler-rt][AIX] Add CMake support for 32-bit Power builds.

LGTM; thanks.

Thu, Sep 10, 4:38 PM · Restricted Project
hubert.reinterpretcast accepted D86879: [XCOFF][AIX] Handle TOC entries that could not be reached by positive range in small code model.

LGTM with minor comments.

Thu, Sep 10, 4:30 PM · Restricted Project
hubert.reinterpretcast added a comment to D87113: [AIX][compiler-rt] Use the AR/ranlib mode flag for 32-bit and 64-bit mode.

since we will be building both 32-bit and 64-bit compiler-rt builtins
from a single configuration.

Thu, Sep 10, 2:39 PM · Restricted Project
hubert.reinterpretcast retitled D87113: [AIX][compiler-rt] Use the AR/ranlib mode flag for 32-bit and 64-bit mode from [AIX][compiler-rt] Use the AR mode flag for 32-bit and 64-bit mode to [AIX][compiler-rt] Use the AR/ranlib mode flag for 32-bit and 64-bit mode.
Thu, Sep 10, 2:28 PM · Restricted Project
hubert.reinterpretcast added inline comments to D86879: [XCOFF][AIX] Handle TOC entries that could not be reached by positive range in small code model.
Thu, Sep 10, 1:14 PM · Restricted Project
hubert.reinterpretcast added inline comments to D86879: [XCOFF][AIX] Handle TOC entries that could not be reached by positive range in small code model.
Thu, Sep 10, 12:53 PM · Restricted Project
hubert.reinterpretcast added inline comments to D86879: [XCOFF][AIX] Handle TOC entries that could not be reached by positive range in small code model.
Thu, Sep 10, 12:46 PM · Restricted Project

Wed, Sep 9

hubert.reinterpretcast added inline comments to D86879: [XCOFF][AIX] Handle TOC entries that could not be reached by positive range in small code model.
Wed, Sep 9, 10:25 AM · Restricted Project

Sun, Sep 6

hubert.reinterpretcast added inline comments to D82727: [PowerPC] Implement Vector Expand Mask builtins in LLVM/Clang.
Sun, Sep 6, 4:21 PM · Restricted Project, Restricted Project

Fri, Sep 4

hubert.reinterpretcast committed rGdde16ef031a0: [tests][libFuzzer] Fix `-Wmissing-field-initializers` after D86092 (authored by hubert.reinterpretcast).
[tests][libFuzzer] Fix `-Wmissing-field-initializers` after D86092
Fri, Sep 4, 10:11 AM

Thu, Sep 3

hubert.reinterpretcast added inline comments to D86879: [XCOFF][AIX] Handle TOC entries that could not be reached by positive range in small code model.
Thu, Sep 3, 9:19 PM · Restricted Project
hubert.reinterpretcast requested review of D87122: [test][MC] Rehabilitate llvm/test/MC/COFF/bigobj.py.
Thu, Sep 3, 8:38 PM · Restricted Project
hubert.reinterpretcast added inline comments to D86879: [XCOFF][AIX] Handle TOC entries that could not be reached by positive range in small code model.
Thu, Sep 3, 12:17 PM · Restricted Project
hubert.reinterpretcast added inline comments to D86879: [XCOFF][AIX] Handle TOC entries that could not be reached by positive range in small code model.
Thu, Sep 3, 9:16 AM · Restricted Project

Tue, Sep 1

hubert.reinterpretcast accepted D86707: [SystemZ][z/OS] Adding initial toolchain for z/OS.

Confirming LGTM. @abhina.sreeskantharajan, it seems that you have a good number of commits to the project (I see at least three). If you do not yet have commit access, it may be appropriate to request it now so that you can push this change directly when you believe you have the feedback that you're looking for.

Tue, Sep 1, 6:36 AM · Restricted Project

Mon, Aug 31

hubert.reinterpretcast committed rGd563d7a7313c: [analyzer][NFC] Add `override` keyword missing from D86027 (authored by hubert.reinterpretcast).
[analyzer][NFC] Add `override` keyword missing from D86027
Mon, Aug 31, 3:01 PM
hubert.reinterpretcast accepted D86707: [SystemZ][z/OS] Adding initial toolchain for z/OS.

LGTM with minor comments.

Mon, Aug 31, 2:48 PM · Restricted Project

Fri, Aug 28

hubert.reinterpretcast committed rG97febb139dc4: [LLD][PowerPC][test] Disable ELF/ppc64-pcrel-long-branch-error.s (authored by hubert.reinterpretcast).
[LLD][PowerPC][test] Disable ELF/ppc64-pcrel-long-branch-error.s
Fri, Aug 28, 9:10 PM

Thu, Aug 27

hubert.reinterpretcast added inline comments to D86707: [SystemZ][z/OS] Adding initial toolchain for z/OS.
Thu, Aug 27, 12:30 PM · Restricted Project

Tue, Aug 25

hubert.reinterpretcast added inline comments to D84265: [AIX][XCOFF] emit symbol visibility for xcoff object file..
Tue, Aug 25, 7:57 PM · Restricted Project
hubert.reinterpretcast committed rG97ccf93b3615: [SystemZ][z/OS] Add z/OS Target and define macros (authored by abhina.sreeskantharajan).
[SystemZ][z/OS] Add z/OS Target and define macros
Tue, Aug 25, 12:52 PM
hubert.reinterpretcast closed D85324: [SystemZ][z/OS] Add z/OS Target and define macros .
Tue, Aug 25, 12:52 PM · Restricted Project

Mon, Aug 24

hubert.reinterpretcast added a comment to D85324: [SystemZ][z/OS] Add z/OS Target and define macros .

Thanks Hubert, I fixed the comment.

Mon, Aug 24, 2:47 PM · Restricted Project
hubert.reinterpretcast added inline comments to D84265: [AIX][XCOFF] emit symbol visibility for xcoff object file..
Mon, Aug 24, 12:04 PM · Restricted Project

Aug 21 2020

hubert.reinterpretcast accepted D85324: [SystemZ][z/OS] Add z/OS Target and define macros .

LGTM from my end; although @MaskRay might want another look.

Aug 21 2020, 11:49 AM · Restricted Project

Aug 20 2020

hubert.reinterpretcast added inline comments to D85324: [SystemZ][z/OS] Add z/OS Target and define macros .
Aug 20 2020, 9:08 PM · Restricted Project
hubert.reinterpretcast accepted D85972: [AIX][compiler-rt][builtins] Don't add ppc builtin implementations that require __int128 on AIX.

LGTM with minor comment.

Aug 20 2020, 9:04 AM · Restricted Project
hubert.reinterpretcast added inline comments to D85324: [SystemZ][z/OS] Add z/OS Target and define macros .
Aug 20 2020, 7:55 AM · Restricted Project
hubert.reinterpretcast added inline comments to D85324: [SystemZ][z/OS] Add z/OS Target and define macros .
Aug 20 2020, 7:48 AM · Restricted Project

Aug 17 2020

hubert.reinterpretcast added inline comments to D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.
Aug 17 2020, 8:04 AM · Restricted Project
hubert.reinterpretcast added inline comments to D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.
Aug 17 2020, 7:51 AM · Restricted Project
hubert.reinterpretcast accepted D86075: [XCOFF] emit .rename for .lcomm when necessary.

LGTM.

Aug 17 2020, 7:42 AM · Restricted Project

Aug 14 2020

hubert.reinterpretcast accepted D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .

LGTM; thanks.

Aug 14 2020, 12:56 PM · Restricted Project
hubert.reinterpretcast accepted D83866: [SystemZ/ZOS] Additions to the build system..

LGTM; thanks.

Aug 14 2020, 9:22 AM · Restricted Project
hubert.reinterpretcast added inline comments to D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.
Aug 14 2020, 9:12 AM · Restricted Project
hubert.reinterpretcast accepted D85527: [AIX] Generate unique module id based on PID and timestamp.

Thanks; this LGTM with comments. Please double check to make sure the capitalization of clangPidTime is consistent (including in comments) if making that change.

Aug 14 2020, 9:03 AM · Restricted Project

Aug 13 2020

hubert.reinterpretcast committed rG800f0eda5b15: [NFC] Remove unused function. (authored by ckennelly).
[NFC] Remove unused function.
Aug 13 2020, 6:20 PM
hubert.reinterpretcast closed D85944: [NFC] Remove unused function..
Aug 13 2020, 6:20 PM · Restricted Project
hubert.reinterpretcast added inline comments to D85527: [AIX] Generate unique module id based on PID and timestamp.
Aug 13 2020, 5:48 PM · Restricted Project
hubert.reinterpretcast added inline comments to D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .
Aug 13 2020, 4:42 PM · Restricted Project
hubert.reinterpretcast added a comment to D85938: [OpenMP][OMPIRBuilder] Use the source (=directory + filename) for locations.

Thanks. Seems to fix the test for me FWIW, but

  1. why wasn't this caught by anyone and all of the bots?

For what it's worth, I have been affected by this and was drafting a note to D82822 today to ask about the status.

Aug 13 2020, 3:48 PM · Restricted Project, Restricted Project
hubert.reinterpretcast accepted D85944: [NFC] Remove unused function..

Thanks for the quick turnaround; LGTM.

Aug 13 2020, 3:28 PM · Restricted Project
hubert.reinterpretcast added inline comments to D85841: [tsan] Respect no_huge_pages_for_shadow..
Aug 13 2020, 3:10 PM · Restricted Project
hubert.reinterpretcast added inline comments to D85527: [AIX] Generate unique module id based on PID and timestamp.
Aug 13 2020, 2:59 PM · Restricted Project
hubert.reinterpretcast added inline comments to D85527: [AIX] Generate unique module id based on PID and timestamp.
Aug 13 2020, 1:07 PM · Restricted Project
hubert.reinterpretcast committed rGdedaf78fa714: [SystemZ][z/OS] enable trigraphs by default on z/OS (authored by abhina.sreeskantharajan).
[SystemZ][z/OS] enable trigraphs by default on z/OS
Aug 13 2020, 1:02 PM
hubert.reinterpretcast closed D85722: [SystemZ][z/OS] enable trigraphs by default on z/OS .
Aug 13 2020, 1:02 PM · Restricted Project
hubert.reinterpretcast added inline comments to D85527: [AIX] Generate unique module id based on PID and timestamp.
Aug 13 2020, 11:56 AM · Restricted Project
hubert.reinterpretcast accepted D85722: [SystemZ][z/OS] enable trigraphs by default on z/OS .

LGTM with suggested changes.

Aug 13 2020, 10:41 AM · Restricted Project
hubert.reinterpretcast added inline comments to D85324: [SystemZ][z/OS] Add z/OS Target and define macros .
Aug 13 2020, 9:07 AM · Restricted Project
hubert.reinterpretcast added inline comments to D85722: [SystemZ][z/OS] enable trigraphs by default on z/OS .
Aug 13 2020, 7:58 AM · Restricted Project

Aug 12 2020

hubert.reinterpretcast added inline comments to D83866: [SystemZ/ZOS] Additions to the build system..
Aug 12 2020, 6:09 AM · Restricted Project
hubert.reinterpretcast added inline comments to D83866: [SystemZ/ZOS] Additions to the build system..
Aug 12 2020, 6:05 AM · Restricted Project

Aug 11 2020

hubert.reinterpretcast added inline comments to D85722: [SystemZ][z/OS] enable trigraphs by default on z/OS .
Aug 11 2020, 3:44 PM · Restricted Project
hubert.reinterpretcast added inline comments to D83866: [SystemZ/ZOS] Additions to the build system..
Aug 11 2020, 1:53 PM · Restricted Project
hubert.reinterpretcast added inline comments to D81585: [AIX][XCOFF][Patch1] Provide decoding trace back table information API for xcoff object file for llvm-objdump -d .
Aug 11 2020, 8:01 AM · Restricted Project

Aug 10 2020

hubert.reinterpretcast added a comment to D85329: [AIX] Try to not use LLVM tools while building runtimes.

Is it possible to quickly address the issue or revert the change?

Aug 10 2020, 6:44 PM · Restricted Project
hubert.reinterpretcast added a reverting change for rG50dd75c8e0b8: [AIX] Try to not use LLVM tools while building runtimes: rG48cd6b8ca54e: Revert "[AIX] Try to not use LLVM tools while building runtimes".
Aug 10 2020, 6:38 PM
hubert.reinterpretcast committed rG48cd6b8ca54e: Revert "[AIX] Try to not use LLVM tools while building runtimes" (authored by hubert.reinterpretcast).
Revert "[AIX] Try to not use LLVM tools while building runtimes"
Aug 10 2020, 6:38 PM
hubert.reinterpretcast added a reverting change for D85329: [AIX] Try to not use LLVM tools while building runtimes: rG48cd6b8ca54e: Revert "[AIX] Try to not use LLVM tools while building runtimes".
Aug 10 2020, 6:38 PM · Restricted Project
hubert.reinterpretcast accepted D85329: [AIX] Try to not use LLVM tools while building runtimes.

LGTM.

Aug 10 2020, 8:41 AM · Restricted Project
hubert.reinterpretcast retitled D85329: [AIX] Try to not use LLVM tools while building runtimes from [AIX] Don't try to use llvm tools while building runtimes to [AIX] Try to not use LLVM tools while building runtimes.
Aug 10 2020, 8:41 AM · Restricted Project
hubert.reinterpretcast added inline comments to D85531: [SystemZ/ZOS] Add support for getHostNumPhysicalCores().
Aug 10 2020, 8:30 AM · Restricted Project
hubert.reinterpretcast added inline comments to D85531: [SystemZ/ZOS] Add support for getHostNumPhysicalCores().
Aug 10 2020, 8:22 AM · Restricted Project
hubert.reinterpretcast added inline comments to D85531: [SystemZ/ZOS] Add support for getHostNumPhysicalCores().
Aug 10 2020, 8:09 AM · Restricted Project
hubert.reinterpretcast added inline comments to D85531: [SystemZ/ZOS] Add support for getHostNumPhysicalCores().
Aug 10 2020, 7:38 AM · Restricted Project
hubert.reinterpretcast accepted D85531: [SystemZ/ZOS] Add support for getHostNumPhysicalCores().

LGTM with minor comment.

Aug 10 2020, 7:27 AM · Restricted Project

Aug 7 2020

hubert.reinterpretcast accepted D85315: [AIX][Clang][Driver] Generate reference to the C++ library on the link step.

LGTM with minor edits.

Aug 7 2020, 12:47 PM · Restricted Project, Restricted Project
hubert.reinterpretcast accepted D82081: [z/OS] Add binary format goff and operating system zos to the triple.

I confirm that I have reviewed the Clang part of this change, which is entirely consistent with the status quo for XCOFF. I'm not seeing any outstanding comments, and I do not believe that the changes are controversial. I think this patch meets the "likely community consensus" requirements for being committed.

Aug 7 2020, 9:28 AM · Restricted Project, Restricted Project