User Details
- User Since
- Aug 27 2014, 8:34 PM (333 w, 3 d)
Yesterday
Thu, Jan 14
Mon, Jan 11
Sat, Jan 9
- Address review: Mention plain char only when it appears
Fri, Jan 8
Ping, @aaron.ballman?
We're seeing:
CMake Error at cmake/modules/AddLLVM.cmake:861 (add_executable): The install of the verify-uselistorder target requires changing an RPATH from the build tree, but this is not supported with the Ninja generator unless on an ELF-based platform. The CMAKE_BUILD_WITH_INSTALL_RPATH variable may be set to avoid this relinking step. Call Stack (most recent call first): cmake/modules/AddLLVM.cmake:1209 (add_llvm_executable) tools/verify-uselistorder/CMakeLists.txt:10 (add_llvm_tool)
Wed, Jan 6
LGTM; thanks.
Sun, Jan 3
Sat, Jan 2
Wed, Dec 30
Tue, Dec 22
Sat, Dec 19
Fri, Dec 18
Dec 11 2020
LGTM with comments; thanks.
Dec 10 2020
Dec 9 2020
Dec 8 2020
Dec 4 2020
Thanks; the targeted fix for handling realpath (where we have experimentally verified that the operation does fail with paths longer than 1024) seems reasonable to me. Looks good from my end.
Dec 2 2020
Confirming LGTM.
Dec 1 2020
LGTM; thanks.
LGTM with comments.
Nov 30 2020
- AIX uses a new personality routine, named __xlcxx_personality_v1. It doesn't use the GCC personality rountine, because the intractability is not there yet on AIX.
That sounds okay.
The altivec feature was an optional part of the 2.03 (pwr4) and 2.04 (pwr5) ISAs, and it was not implemented by any IBM CPUs until Power6.
The Power Processing Element in various IBM CPUs (including the Cell Broadband Engine) incorporate VMX. With this change, which of the CPU options should a user targeting a PPE use?
Nov 29 2020
Nov 28 2020
Reverting this patch makes va_arg with the default 128-bit (double-double) long double work again:
#include <stdarg.h> void abort(void);
Nov 27 2020
LGTM.
Nov 24 2020
Nov 9 2020
This is a really old patch that I had in my usual build tree and needed to manually rebase recently.
It might be helpful for someone, but I think the original context where I developed it is not exactly the build configuration I wanted.
Rebase
LGTM; thanks!
Nov 8 2020
Nov 4 2020
Oct 27 2020
Oct 26 2020
LGTM; thanks.
LGTM; thanks!
Oct 23 2020
Oct 22 2020
LGTM; thanks!
LGTM; thanks!
Oct 21 2020
LGTM; thanks.
Oct 20 2020
I have two concerns over the choice of the option form/name.
Oct 19 2020
We've been building with LLVM_ENABLE_THREADS=0 to avoid dependencies on the TLS support in the build environment. We may require assistance to restore our builds if these patches introduce a TLS dependency. @daltenty, fyi.