Page MenuHomePhabricator

hubert.reinterpretcast (Hubert Tong)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 27 2014, 8:34 PM (333 w, 3 d)

Recent Activity

Yesterday

hubert.reinterpretcast added a comment to D94670: [DebugInfo][NFC] add a new DIE type to represent label + offset.

Seems that the error is expected, as gas/config/tc-ppc.c says:

Fri, Jan 15, 1:34 PM · Restricted Project
hubert.reinterpretcast added a comment to D94670: [DebugInfo][NFC] add a new DIE type to represent label + offset.

So how does your example work?

Fri, Jan 15, 12:10 PM · Restricted Project
hubert.reinterpretcast added a comment to D94670: [DebugInfo][NFC] add a new DIE type to represent label + offset.

2: On AIX, the assembler does not need the assembly file contains the dwarf sections length info in the dwarf section header(if the dwarf section has header.) Instead, the assembler will insert the calculated length into dwarf sections header of the final object according to DWARF type. Namely AIX assembler will insert 4 bytes in each section header for DWARF32 and 12 bytes for DWARF64.

Fri, Jan 15, 7:36 AM · Restricted Project

Thu, Jan 14

hubert.reinterpretcast retitled D94710: [Analysis] Support AIX vec_malloc routines from Support AIX vec_malloc routines to [Analysis] Support AIX vec_malloc routines.
Thu, Jan 14, 1:22 PM · Restricted Project

Mon, Jan 11

hubert.reinterpretcast committed rGc6ffe4d76fbf: [clang] Fix message text for `-Wpointer-sign` to account for plain char (authored by hubert.reinterpretcast).
[clang] Fix message text for `-Wpointer-sign` to account for plain char
Mon, Jan 11, 3:41 PM
hubert.reinterpretcast closed D93999: [clang] Fix message text for `-Wpointer-sign` to account for plain char.
Mon, Jan 11, 3:41 PM · Restricted Project
hubert.reinterpretcast committed rGf635bcd16105: NFC: Pre-commit test: -Wpointer-sign with plain char to [un]signed char (authored by hubert.reinterpretcast).
NFC: Pre-commit test: -Wpointer-sign with plain char to [un]signed char
Mon, Jan 11, 3:41 PM
hubert.reinterpretcast added inline comments to D93659: [AIX][XCOFF] emit vector info of traceback table..
Mon, Jan 11, 10:26 AM · Restricted Project

Sat, Jan 9

hubert.reinterpretcast updated the summary of D93999: [clang] Fix message text for `-Wpointer-sign` to account for plain char.
Sat, Jan 9, 8:56 PM · Restricted Project
hubert.reinterpretcast updated the diff for D93999: [clang] Fix message text for `-Wpointer-sign` to account for plain char.
  • Address review: Mention plain char only when it appears
Sat, Jan 9, 8:53 PM · Restricted Project

Fri, Jan 8

hubert.reinterpretcast added a comment to D93177: [CMake] Don't enable BUILD_WITH_INSTALL_RPATH when using custom build rpath.

I reverted (D94319) and now re-landed (D94322). Seems the check for empty CMAKE_BUILD_RPATH got incorrectly reverted when I addressed the review comment.

Fri, Jan 8, 1:29 PM · Restricted Project
hubert.reinterpretcast added inline comments to D93999: [clang] Fix message text for `-Wpointer-sign` to account for plain char.
Fri, Jan 8, 10:10 AM · Restricted Project
hubert.reinterpretcast added a comment to D93999: [clang] Fix message text for `-Wpointer-sign` to account for plain char.

Ping, @aaron.ballman?

Fri, Jan 8, 8:23 AM · Restricted Project
hubert.reinterpretcast added inline comments to D93095: Introduce -Wreserved-identifier.
Fri, Jan 8, 7:00 AM
hubert.reinterpretcast added a comment to D93177: [CMake] Don't enable BUILD_WITH_INSTALL_RPATH when using custom build rpath.

We're seeing:

CMake Error at cmake/modules/AddLLVM.cmake:861 (add_executable):
  The install of the verify-uselistorder target requires changing an RPATH
  from the build tree, but this is not supported with the Ninja generator
  unless on an ELF-based platform.  The CMAKE_BUILD_WITH_INSTALL_RPATH
  variable may be set to avoid this relinking step.
Call Stack (most recent call first):
  cmake/modules/AddLLVM.cmake:1209 (add_llvm_executable)
  tools/verify-uselistorder/CMakeLists.txt:10 (add_llvm_tool)
Fri, Jan 8, 6:15 AM · Restricted Project

Wed, Jan 6

hubert.reinterpretcast accepted D93901: [NFC] Renaming PackStack to AlignPackStack.

LGTM; thanks.

Wed, Jan 6, 1:14 PM · Restricted Project
hubert.reinterpretcast added inline comments to D92110: [SystemZ][ZOS] Provide PATH_MAX macro for libcxx.
Wed, Jan 6, 6:34 AM · Restricted Project
hubert.reinterpretcast added a comment to D93377: [Clang] Add __ibm128 type to represent ppc_fp128.

Are you committed to the name __ibm128?

Wed, Jan 6, 5:34 AM · Restricted Project

Sun, Jan 3

hubert.reinterpretcast added inline comments to D93901: [NFC] Renaming PackStack to AlignPackStack.
Sun, Jan 3, 3:10 PM · Restricted Project
hubert.reinterpretcast requested review of D93999: [clang] Fix message text for `-Wpointer-sign` to account for plain char.
Sun, Jan 3, 1:37 PM · Restricted Project

Sat, Jan 2

hubert.reinterpretcast updated the summary of D93901: [NFC] Renaming PackStack to AlignPackStack.
Sat, Jan 2, 7:31 AM · Restricted Project

Wed, Dec 30

hubert.reinterpretcast added inline comments to D93377: [Clang] Add __ibm128 type to represent ppc_fp128.
Wed, Dec 30, 1:46 PM · Restricted Project

Tue, Dec 22

hubert.reinterpretcast added inline comments to D93377: [Clang] Add __ibm128 type to represent ppc_fp128.
Tue, Dec 22, 6:13 AM · Restricted Project

Sat, Dec 19

hubert.reinterpretcast added inline comments to D93377: [Clang] Add __ibm128 type to represent ppc_fp128.
Sat, Dec 19, 9:41 PM · Restricted Project

Fri, Dec 18

hubert.reinterpretcast added inline comments to D93377: [Clang] Add __ibm128 type to represent ppc_fp128.
Fri, Dec 18, 11:04 AM · Restricted Project

Dec 11 2020

hubert.reinterpretcast accepted D92398: [AIX][XCOFF] emit traceback table for function in aix.

LGTM with comments; thanks.

Dec 11 2020, 12:49 PM · Restricted Project
hubert.reinterpretcast added inline comments to D92398: [AIX][XCOFF] emit traceback table for function in aix.
Dec 11 2020, 9:32 AM · Restricted Project
hubert.reinterpretcast added inline comments to D92398: [AIX][XCOFF] emit traceback table for function in aix.
Dec 11 2020, 9:26 AM · Restricted Project
hubert.reinterpretcast added inline comments to D92398: [AIX][XCOFF] emit traceback table for function in aix.
Dec 11 2020, 6:20 AM · Restricted Project

Dec 10 2020

hubert.reinterpretcast added inline comments to D92398: [AIX][XCOFF] emit traceback table for function in aix.
Dec 10 2020, 9:11 PM · Restricted Project
hubert.reinterpretcast added inline comments to D92398: [AIX][XCOFF] emit traceback table for function in aix.
Dec 10 2020, 8:32 PM · Restricted Project
hubert.reinterpretcast added inline comments to D92398: [AIX][XCOFF] emit traceback table for function in aix.
Dec 10 2020, 7:42 PM · Restricted Project
hubert.reinterpretcast added inline comments to D92398: [AIX][XCOFF] emit traceback table for function in aix.
Dec 10 2020, 12:01 PM · Restricted Project

Dec 9 2020

hubert.reinterpretcast added inline comments to D92398: [AIX][XCOFF] emit traceback table for function in aix.
Dec 9 2020, 8:46 PM · Restricted Project
hubert.reinterpretcast added inline comments to D92398: [AIX][XCOFF] emit traceback table for function in aix.
Dec 9 2020, 8:34 PM · Restricted Project
hubert.reinterpretcast added inline comments to D92398: [AIX][XCOFF] emit traceback table for function in aix.
Dec 9 2020, 10:18 AM · Restricted Project

Dec 8 2020

hubert.reinterpretcast added inline comments to D92398: [AIX][XCOFF] emit traceback table for function in aix.
Dec 8 2020, 8:44 PM · Restricted Project
hubert.reinterpretcast added inline comments to D92398: [AIX][XCOFF] emit traceback table for function in aix.
Dec 8 2020, 5:47 PM · Restricted Project
hubert.reinterpretcast added inline comments to D92398: [AIX][XCOFF] emit traceback table for function in aix.
Dec 8 2020, 5:07 PM · Restricted Project
hubert.reinterpretcast added inline comments to D92110: [SystemZ][ZOS] Provide PATH_MAX macro for libcxx.
Dec 8 2020, 9:28 AM · Restricted Project

Dec 4 2020

hubert.reinterpretcast added inline comments to D92110: [SystemZ][ZOS] Provide PATH_MAX macro for libcxx.
Dec 4 2020, 3:56 PM · Restricted Project
hubert.reinterpretcast accepted D92110: [SystemZ][ZOS] Provide PATH_MAX macro for libcxx.

Thanks; the targeted fix for handling realpath (where we have experimentally verified that the operation does fail with paths longer than 1024) seems reasonable to me. Looks good from my end.

Dec 4 2020, 12:20 PM · Restricted Project

Dec 2 2020

hubert.reinterpretcast added inline comments to D92278: [Clang] Don't adjust align for IBM extended double type.
Dec 2 2020, 7:06 PM · Restricted Project
hubert.reinterpretcast added inline comments to D92398: [AIX][XCOFF] emit traceback table for function in aix.
Dec 2 2020, 5:58 PM · Restricted Project
hubert.reinterpretcast added inline comments to D92398: [AIX][XCOFF] emit traceback table for function in aix.
Dec 2 2020, 5:09 PM · Restricted Project
hubert.reinterpretcast accepted D92058: [XCOFF][AIX] Alternative path in EHStreamer for platforms do not have uleb128 support.

Confirming LGTM.

Dec 2 2020, 8:21 AM · Restricted Project
hubert.reinterpretcast added inline comments to D92324: [PowerPC] Fix altivec feature on pwr cpus pre pwr6..
Dec 2 2020, 7:34 AM · Restricted Project, Restricted Project

Dec 1 2020

hubert.reinterpretcast added inline comments to D92110: [SystemZ][ZOS] Provide PATH_MAX macro for libcxx.
Dec 1 2020, 2:29 PM · Restricted Project
hubert.reinterpretcast accepted D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX.

LGTM; thanks.

Dec 1 2020, 1:52 PM · Restricted Project, Restricted Project
hubert.reinterpretcast accepted D92058: [XCOFF][AIX] Alternative path in EHStreamer for platforms do not have uleb128 support.
Dec 1 2020, 1:40 PM · Restricted Project
hubert.reinterpretcast added a comment to D92058: [XCOFF][AIX] Alternative path in EHStreamer for platforms do not have uleb128 support.

LGTM with comments.

Dec 1 2020, 1:40 PM · Restricted Project
hubert.reinterpretcast added inline comments to D92058: [XCOFF][AIX] Alternative path in EHStreamer for platforms do not have uleb128 support.
Dec 1 2020, 12:43 PM · Restricted Project
hubert.reinterpretcast added inline comments to D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX.
Dec 1 2020, 10:34 AM · Restricted Project, Restricted Project
hubert.reinterpretcast added inline comments to D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX.
Dec 1 2020, 10:24 AM · Restricted Project, Restricted Project

Nov 30 2020

hubert.reinterpretcast added a comment to D91455: [XCOFF][AIX] Generate LSDA data and compact unwind section on AIX.
  1. AIX uses a new personality routine, named __xlcxx_personality_v1. It doesn't use the GCC personality rountine, because the intractability is not there yet on AIX.
Nov 30 2020, 8:19 PM · Restricted Project, Restricted Project
hubert.reinterpretcast added inline comments to D92058: [XCOFF][AIX] Alternative path in EHStreamer for platforms do not have uleb128 support.
Nov 30 2020, 8:16 PM · Restricted Project
hubert.reinterpretcast added inline comments to D92058: [XCOFF][AIX] Alternative path in EHStreamer for platforms do not have uleb128 support.
Nov 30 2020, 8:07 PM · Restricted Project
hubert.reinterpretcast added inline comments to D92058: [XCOFF][AIX] Alternative path in EHStreamer for platforms do not have uleb128 support.
Nov 30 2020, 7:39 PM · Restricted Project
hubert.reinterpretcast added inline comments to D92058: [XCOFF][AIX] Alternative path in EHStreamer for platforms do not have uleb128 support.
Nov 30 2020, 5:23 PM · Restricted Project
hubert.reinterpretcast added inline comments to D92058: [XCOFF][AIX] Alternative path in EHStreamer for platforms do not have uleb128 support.
Nov 30 2020, 3:50 PM · Restricted Project
hubert.reinterpretcast added inline comments to D92324: [PowerPC] Fix altivec feature on pwr cpus pre pwr6..
Nov 30 2020, 2:05 PM · Restricted Project, Restricted Project
hubert.reinterpretcast added a comment to D92324: [PowerPC] Fix altivec feature on pwr cpus pre pwr6..

If the best CPU to target for a PPE is one of the ones modified in this patch, they can still do so, but will have to explicitly add -mattr=+altivec when invoking llc.

That sounds okay.

Nov 30 2020, 1:33 PM · Restricted Project, Restricted Project
hubert.reinterpretcast added inline comments to D92058: [XCOFF][AIX] Alternative path in EHStreamer for platforms do not have uleb128 support.
Nov 30 2020, 1:16 PM · Restricted Project
hubert.reinterpretcast added a comment to D92324: [PowerPC] Fix altivec feature on pwr cpus pre pwr6..

The altivec feature was an optional part of the 2.03 (pwr4) and 2.04 (pwr5) ISAs, and it was not implemented by any IBM CPUs until Power6.

The Power Processing Element in various IBM CPUs (including the Cell Broadband Engine) incorporate VMX. With this change, which of the CPU options should a user targeting a PPE use?

Nov 30 2020, 7:37 AM · Restricted Project, Restricted Project
hubert.reinterpretcast added inline comments to D92278: [Clang] Don't adjust align for IBM extended double type.
Nov 30 2020, 7:27 AM · Restricted Project

Nov 29 2020

hubert.reinterpretcast added inline comments to D92278: [Clang] Don't adjust align for IBM extended double type.
Nov 29 2020, 2:54 PM · Restricted Project

Nov 28 2020

hubert.reinterpretcast added a comment to D91596: [PowerPC] [Clang] Fix alignment of 128-bit floating types.

Reverting this patch makes va_arg with the default 128-bit (double-double) long double work again:

#include <stdarg.h>
void abort(void);
Nov 28 2020, 3:09 PM · Restricted Project

Nov 27 2020

hubert.reinterpretcast accepted D92225: [AIX][XCOFF][NFC] Change geNumberOfVRSaved function name to getNumberOfVRSaved..

LGTM.

Nov 27 2020, 7:44 AM · Restricted Project

Nov 24 2020

hubert.reinterpretcast committed rG44174b3d518e: [NFC][tests] Replace non-portable grep with FileCheck (authored by hubert.reinterpretcast).
[NFC][tests] Replace non-portable grep with FileCheck
Nov 24 2020, 9:15 AM

Nov 9 2020

hubert.reinterpretcast added a comment to D58951: [compiler-rt][tests] Improve handling with non-default toolchains.

This is a really old patch that I had in my usual build tree and needed to manually rebase recently.
It might be helpful for someone, but I think the original context where I developed it is not exactly the build configuration I wanted.

Nov 9 2020, 5:33 PM · Restricted Project, Restricted Project
hubert.reinterpretcast requested review of D91112: [compiler-rt][tests] Fix plugin support detection when no ld.gold.
Nov 9 2020, 5:16 PM · Restricted Project
hubert.reinterpretcast added inline comments to D58951: [compiler-rt][tests] Improve handling with non-default toolchains.
Nov 9 2020, 5:13 PM · Restricted Project, Restricted Project
hubert.reinterpretcast updated the diff for D58951: [compiler-rt][tests] Improve handling with non-default toolchains.

Rebase

Nov 9 2020, 4:54 PM · Restricted Project, Restricted Project
hubert.reinterpretcast accepted D87114: [CMake][ExecutionEngine] add HAVE_(DE)REGISTER_FRAME as a config.h macros.

LGTM; thanks!

Nov 9 2020, 2:54 PM · Restricted Project

Nov 8 2020

hubert.reinterpretcast committed rG09fc7796e574: [NFC][tests] Replace use of GNUisms in usage of diff (authored by hubert.reinterpretcast).
[NFC][tests] Replace use of GNUisms in usage of diff
Nov 8 2020, 9:08 AM

Nov 4 2020

hubert.reinterpretcast added inline comments to D87114: [CMake][ExecutionEngine] add HAVE_(DE)REGISTER_FRAME as a config.h macros.
Nov 4 2020, 9:41 AM · Restricted Project

Oct 27 2020

hubert.reinterpretcast added inline comments to D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility.
Oct 27 2020, 9:59 AM · Restricted Project

Oct 26 2020

hubert.reinterpretcast accepted D90187: [NFC] Remove max_align.c LIT testcase.

LGTM; thanks.

Oct 26 2020, 2:04 PM · Restricted Project
hubert.reinterpretcast updated the summary of D90187: [NFC] Remove max_align.c LIT testcase.
Oct 26 2020, 2:02 PM · Restricted Project
hubert.reinterpretcast accepted D90063: [AIX] Also error on -G for link-only step.

LGTM; thanks!

Oct 26 2020, 10:48 AM · Restricted Project

Oct 23 2020

hubert.reinterpretcast added inline comments to D90041: [AIX][cmake] Adjust management of `-G` for linking.
Oct 23 2020, 1:26 PM · Restricted Project
hubert.reinterpretcast added inline comments to D90063: [AIX] Also error on -G for link-only step.
Oct 23 2020, 12:42 PM · Restricted Project
hubert.reinterpretcast added inline comments to D90041: [AIX][cmake] Adjust management of `-G` for linking.
Oct 23 2020, 11:34 AM · Restricted Project
hubert.reinterpretcast committed rG1602c6fd9294: [AIX][cmake] Adjust management of `-G` for linking (authored by hubert.reinterpretcast).
[AIX][cmake] Adjust management of `-G` for linking
Oct 23 2020, 11:32 AM
hubert.reinterpretcast closed D90041: [AIX][cmake] Adjust management of `-G` for linking.
Oct 23 2020, 11:32 AM · Restricted Project
hubert.reinterpretcast requested review of D90041: [AIX][cmake] Adjust management of `-G` for linking.
Oct 23 2020, 6:45 AM · Restricted Project

Oct 22 2020

hubert.reinterpretcast added inline comments to D89986: [AIX] do not emit visibility attribute into IR when there is -mignore-xcoff-visibility.
Oct 22 2020, 3:57 PM · Restricted Project
hubert.reinterpretcast accepted D89910: [AIX] Let alloca return 16 bytes alignment.

LGTM; thanks!

Oct 22 2020, 3:14 PM · Restricted Project
hubert.reinterpretcast accepted D89897: [AIX] Emit error for -G option on AIX.

LGTM; thanks!

Oct 22 2020, 9:01 AM · Restricted Project, Restricted Project
hubert.reinterpretcast added inline comments to D89910: [AIX] Let alloca return 16 bytes alignment.
Oct 22 2020, 8:58 AM · Restricted Project

Oct 21 2020

hubert.reinterpretcast added inline comments to D89897: [AIX] Emit error for -G option on AIX.
Oct 21 2020, 2:28 PM · Restricted Project, Restricted Project
hubert.reinterpretcast added inline comments to D89897: [AIX] Emit error for -G option on AIX.
Oct 21 2020, 2:22 PM · Restricted Project, Restricted Project
hubert.reinterpretcast added inline comments to D89910: [AIX] Let alloca return 16 bytes alignment.
Oct 21 2020, 2:13 PM · Restricted Project
hubert.reinterpretcast accepted D88659: [NFC] Fix the definition of SuitableAlign.

LGTM; thanks.

Oct 21 2020, 7:16 AM · Restricted Project
hubert.reinterpretcast added a comment to D89758: Unconditionally #include <future>.

We've been building with LLVM_ENABLE_THREADS=0 to avoid dependencies on the TLS support in the build environment. We may require assistance to restore our builds if these patches introduce a TLS dependency. @daltenty, fyi.

Oct 21 2020, 5:48 AM · Restricted Project

Oct 20 2020

hubert.reinterpretcast added a comment to D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs. .

-mabi=aixvecextabi was suggested when I discussed this with someone who is familiar with GCC. The choice of extabi at the end is to match the spelling of the __EXTABI__ macro.

Oct 20 2020, 6:43 PM · Restricted Project, Restricted Project
hubert.reinterpretcast committed rG134ffa8138c3: NFC: Fix -Wsign-compare warnings on 32-bit builds (authored by hubert.reinterpretcast).
NFC: Fix -Wsign-compare warnings on 32-bit builds
Oct 20 2020, 5:52 PM
hubert.reinterpretcast closed D89612: NFC: Fix -Wsign-compare warnings on 32-bit builds.
Oct 20 2020, 5:52 PM · Restricted Project, Restricted Project
hubert.reinterpretcast added a comment to D89684: [AIX] Add mabi=vec-extabi options to enable the AIX extended and default vector ABIs. .

I have two concerns over the choice of the option form/name.

Oct 20 2020, 8:36 AM · Restricted Project, Restricted Project

Oct 19 2020

hubert.reinterpretcast updated subscribers of D89758: Unconditionally #include <future>.

We've been building with LLVM_ENABLE_THREADS=0 to avoid dependencies on the TLS support in the build environment. We may require assistance to restore our builds if these patches introduce a TLS dependency. @daltenty, fyi.

Oct 19 2020, 8:04 PM · Restricted Project