Page MenuHomePhabricator

mstorsjo (Martin Storsjö)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 25 2016, 12:54 PM (286 w, 3 d)

Recent Activity

Today

mstorsjo added a comment to D117820: Revert "[libc++] [test] UNSUPPORTED my new uniform_int_distribution test on MinGW.".

I had a look, and it seems to run correctly when built with a recent Clang 14 snapshot. But with Clang 13.0.0 as in the CI, it crashes.

Thu, Jan 20, 2:17 PM · Restricted Project

Yesterday

mstorsjo added a comment to D111081: [clang] [MinGW] Fix paths on Gentoo.

Well, I dunno how MinGW works, so can't judge that part. Furthermore, I'm thoroughly confused why this works on top of existing (non-Gentoo?) test tree. Could you explain it a bit more?

Wed, Jan 19, 3:37 AM
mstorsjo accepted D116088: [compiler-rt] Implement ARM atomic operations for architectures without SMP support.

I think this looks reasonable. I haven't tried it, but I guess we should proceed with it instead of holding it back, as there's nobody else reviewing it.

Wed, Jan 19, 3:25 AM · Restricted Project, Restricted Project

Tue, Jan 18

mstorsjo added a comment to D113130: [llvm-libtool-darwin] Print a warning if object file names are repeated.

For the test where we specify one file via -l and the other via its path, the output on Windows looks like

warning: file 'L-and-l.test.tmp-input1.o' was specified multiple times.
in: C:\Users\smeenai\llvm-project\build\Release\test\tools\llvm-libtool-darwin\Output\L-and-l.test.tmp/copy/L-and-l.test.tmp-input1.o
in: C:\Users\smeenai\llvm-project\build\Release\test\tools\llvm-libtool-darwin\Output\L-and-l.test.tmp/copy\L-and-l.test.tmp-input1.o

Note that the last slash is a forward slash in one path and a backslash in the other. The forward slash is coming from our path specification in the test, and the backslash is coming from sys::path::append in libtool (to concatenate -L directories and -l names).

One way to fix this would be to introduce a new %{sep} substitution in lit (similar to the existing %{pathsep}), so we could use the appropriate slashes for the platform in our test automatically. Another would be to use sys::path::Style::windows_slash in our sys::path::append call, but that could break with \\?\ paths, which can't use forward slashes.

@mstorsjo, I believe you have a bunch of experience dealing with slash differences on Windows. Any suggestions on the best way to proceed here?

Tue, Jan 18, 1:40 PM · Restricted Project
mstorsjo added a comment to D114357: [CodeGen][AArch64] Ensure isSExtCheaperThanZExt returns true for negative constants.

Hi @mstorsjo, thanks for the info. I'll revert the patch again for now. It's strange because ANY_EXTEND should really mean "any", i.e. you don't care if it's sign-extend or zero-extend! I suspect there is a bug in codegen somewhere that either relies upon ANY_EXTEND actually being ZERO_EXTEND, or relies upon ANY_EXTEND being consistently the same. I'm worried because the isSExtCheaperThanZExt interface definitely allows for the possibility of sometimes choosing one over the other depending upon the types.

Tue, Jan 18, 12:45 AM · Restricted Project
mstorsjo added a comment to D114357: [CodeGen][AArch64] Ensure isSExtCheaperThanZExt returns true for negative constants.

I've bisected a miscompilation to this file.

Tue, Jan 18, 12:32 AM · Restricted Project

Mon, Jan 17

mstorsjo added a comment to D116919: [AST] Add RParen loc for decltype AutoTypeloc..

Thanks, everyone!

I manage to figure out the cause, the crash was caused by an arbitrary RPareLoc -- we missed to set the RPareLoc in TreeTransform::TransformAutoType. I reland the patch in ab3f100bec03d72ecee947a323c51698d4b95207.

Mon, Jan 17, 5:19 AM · Restricted Project, Restricted Project

Fri, Jan 14

mstorsjo added a comment to D88827: [llvm-objcopy][NFC] Move core implementation of llvm-objcopy into separate library..
In D88827#3243298, @avl wrote:

This isn't generally true: even in debug builds and without --gc-sections, linkers tend not to link in unused objects into the final executable.

I remember there was a patch to make it possible - https://reviews.llvm.org/D54747 . Which finally was not applied and current behavior that it is not working(if I did not miss something new).

Fri, Jan 14, 4:54 AM · Restricted Project

Thu, Jan 13

mstorsjo accepted D117179: [lit] Make sure our test temp directory is actually used by tests.

Awesome, thanks! With this in place, /tmp stays uncluttered after running tests again.

Thu, Jan 13, 12:32 AM · Restricted Project

Wed, Jan 12

mstorsjo added inline comments to D116957: [libc++] [test] Add a test for proper _Uglification of template parameter names.
Wed, Jan 12, 11:38 PM · Restricted Project
mstorsjo added a comment to D116957: [libc++] [test] Add a test for proper _Uglification of template parameter names.

https://buildkite.com/llvm-project/libcxx-ci/builds/7765

c:\llvm-mingw\include\wchar.h:241:31: error: expected ')'
  int __cdecl iswalpha(wint_t _C);
                              ^

@mstorsjo perhaps: Do you think #ifndef _WIN32 is the right way to catch both MinGW and clang-cl, without catching anything else?

Wed, Jan 12, 11:34 PM · Restricted Project
mstorsjo updated the diff for D98769: [WIP] [private] [libcxx] Tests for future changes for windows CI configurations.
Wed, Jan 12, 2:24 PM
mstorsjo added a comment to rG3c7d8792f12d: [lit] Skip creation of tmp dir if we don't actually run any tests.

FYI I noted a regression caused by this commit; it doesn't seem to work as intended at all (the created temp directory doesn't get used by the tests), see https://github.com/llvm/llvm-project/issues/53167 for details.

Wed, Jan 12, 2:02 PM
mstorsjo added a comment to D116919: [AST] Add RParen loc for decltype AutoTypeloc..

Ok, now I managed to make a standalone reproducer: https://martin.st/temp/pch-preproc.hxx and https://martin.st/temp/main-preproc.cpp

$ bin/clang -target x86_64-w64-mingw32 -w -x c++-header -c pch-preproc.hxx -o pch-preproc.hxx.pch -std=c++17 -O3
$ bin/clang -target x86_64-w64-mingw32 -w -Xclang -include-pch -Xclang pch-preproc.hxx.pch -c main-preproc.cpp -std=c++17 -O3
Wed, Jan 12, 2:40 AM · Restricted Project, Restricted Project
mstorsjo added a comment to D116919: [AST] Add RParen loc for decltype AutoTypeloc..

The relanded version in rG41fbdfa4d5601cccbcdc0ded8ef35190d502f7f3 seems to be breaking some builds with PCH for me, failing asserts like this:

Wed, Jan 12, 1:55 AM · Restricted Project, Restricted Project

Tue, Jan 11

mstorsjo committed rG18b2385f2b09: [clang] [test] Fix clang-cl unused argument tests on paths that start with /U (authored by mstorsjo).
[clang] [test] Fix clang-cl unused argument tests on paths that start with /U
Tue, Jan 11, 2:28 AM
mstorsjo committed rGe26bbae30218: [clang] [test] Remove newly added tests that fail on Darwin (authored by mstorsjo).
[clang] [test] Remove newly added tests that fail on Darwin
Tue, Jan 11, 1:08 AM
mstorsjo accepted D116996: [lld-link] Change config and driver to unique_ptr.

Looks sensible to me based on the referenced patch.

Tue, Jan 11, 12:14 AM · Restricted Project

Mon, Jan 10

mstorsjo committed rG50ec1306d060: [clang] Add --start-no-unused-arguments/--end-no-unused-arguments to silence… (authored by mstorsjo).
[clang] Add --start-no-unused-arguments/--end-no-unused-arguments to silence…
Mon, Jan 10, 11:22 PM
mstorsjo closed D116503: [clang] Add --start-no-unused-arguments/--end-no-unused-arguments to silence some unused argument warnings.
Mon, Jan 10, 11:22 PM · Restricted Project
mstorsjo added a comment to D116503: [clang] Add --start-no-unused-arguments/--end-no-unused-arguments to silence some unused argument warnings.

But make sure to wait a bit to see what others think.

Mon, Jan 10, 4:54 AM · Restricted Project
mstorsjo committed rG392aa97acc05: [llvm-objcopy] Implement the PE-COFF specific --subsystem option (authored by mstorsjo).
[llvm-objcopy] Implement the PE-COFF specific --subsystem option
Mon, Jan 10, 4:44 AM
mstorsjo closed D116556: [llvm-objcopy] Implement the PE-COFF specific --subsystem option.
Mon, Jan 10, 4:44 AM · Restricted Project
mstorsjo updated the diff for D116556: [llvm-objcopy] Implement the PE-COFF specific --subsystem option.

Check the full exact filename in the error message. Changed to print the output filename instead of the input filename, for the error.

Mon, Jan 10, 2:22 AM · Restricted Project
mstorsjo added inline comments to D116556: [llvm-objcopy] Implement the PE-COFF specific --subsystem option.
Mon, Jan 10, 2:20 AM · Restricted Project
mstorsjo updated the diff for D116556: [llvm-objcopy] Implement the PE-COFF specific --subsystem option.

Applied the suggestions.

Mon, Jan 10, 1:27 AM · Restricted Project
mstorsjo added inline comments to D116556: [llvm-objcopy] Implement the PE-COFF specific --subsystem option.
Mon, Jan 10, 1:26 AM · Restricted Project

Thu, Jan 6

mstorsjo accepted D116709: [CMake][WinMsvc] Fix user passed compiler/linker flags.

Thanks for the explanations! LGTM.

Thu, Jan 6, 11:57 PM · Restricted Project
mstorsjo added a comment to D116709: [CMake][WinMsvc] Fix user passed compiler/linker flags.

User could pass flags by environment variables like CFLAGS/CXXFLAGS/LDFLAGS or by using CMAKE_<LANG>_FLAGS_INIT/CMAKE_<t>_LINKER_FLAGS_INIT. So this toolchain file should append to INIT flags instead. Otherwise, user flags would be discarded here by assigning to CMAKE_<LANG>_FLAGS directly.

Thu, Jan 6, 4:04 AM · Restricted Project
mstorsjo updated the diff for D116556: [llvm-objcopy] Implement the PE-COFF specific --subsystem option.

Fix a typo in a comment in the new test.

Thu, Jan 6, 2:54 AM · Restricted Project
mstorsjo updated the diff for D116556: [llvm-objcopy] Implement the PE-COFF specific --subsystem option.

Mention the new option in the docs. Lowercase an error message. Add a test for erroring out on object files. Spell out the type instead of using auto.

Thu, Jan 6, 2:52 AM · Restricted Project
mstorsjo added inline comments to D116556: [llvm-objcopy] Implement the PE-COFF specific --subsystem option.
Thu, Jan 6, 2:38 AM · Restricted Project
mstorsjo committed rG1919720fdd34: [lldb] [debugserver] Simplify handling of arch specific files (authored by mstorsjo).
[lldb] [debugserver] Simplify handling of arch specific files
Thu, Jan 6, 12:27 AM
mstorsjo closed D116625: [lldb] [debugserver] Simplify handling of arch specific files.
Thu, Jan 6, 12:27 AM · Restricted Project

Wed, Jan 5

mstorsjo updated the diff for D116503: [clang] Add --start-no-unused-arguments/--end-no-unused-arguments to silence some unused argument warnings.

Add testcases for using the new option with clang-cl, use --target= everywhere.

Wed, Jan 5, 2:55 PM · Restricted Project
mstorsjo updated the diff for D116556: [llvm-objcopy] Implement the PE-COFF specific --subsystem option.

Removed the "COFF only" annotation from the new option.

Wed, Jan 5, 4:30 AM · Restricted Project
mstorsjo added inline comments to D116556: [llvm-objcopy] Implement the PE-COFF specific --subsystem option.
Wed, Jan 5, 4:27 AM · Restricted Project
mstorsjo retitled D116503: [clang] Add --start-no-unused-arguments/--end-no-unused-arguments to silence some unused argument warnings from [clang] Add arguments for silencing unused argument warnings for some but not all arguments to [clang] Add --start-no-unused-arguments/--end-no-unused-arguments to silence some unused argument warnings.
Wed, Jan 5, 1:30 AM · Restricted Project
mstorsjo updated the diff for D116503: [clang] Add --start-no-unused-arguments/--end-no-unused-arguments to silence some unused argument warnings.

Regenerated ClangCommandLineReference.rst (with the relevant changes), removed NoXarchOption.

Wed, Jan 5, 1:29 AM · Restricted Project
mstorsjo added a comment to D116503: [clang] Add --start-no-unused-arguments/--end-no-unused-arguments to silence some unused argument warnings.

A more searchable subject (mentioning the new option in the subject is useful for archaeology) may be Add --start-no-unused-arguments/--end-no-unused-arguments to silence some unused argument warnings

Wed, Jan 5, 1:26 AM · Restricted Project
mstorsjo added a comment to D116426: [InferAttrs] Add writeonly to all the math functions.

I went ahead and reverted this, as it broke compilation of a couple projects for me. The breakage is reproducible with this snippet:

$ cat sqrt.c
float a;  
b() { sqrt(a); }
$ clang -target x86_64-linux-gnu -c -O2 sqrt.c 
Attributes 'readnone and writeonly' are incompatible!
  %sqrtf = tail call float @sqrtf(float %0) #1  
in function b
fatal error: error in backend: Broken function found, compilation aborted!
Wed, Jan 5, 1:15 AM · Restricted Project
mstorsjo added a reverting change for rGea75be3d9df4: [InferAttrs] Add writeonly to all the math functions: rG29b6e967f3e9: Revert "[InferAttrs] Add writeonly to all the math functions".
Wed, Jan 5, 1:13 AM
mstorsjo committed rG29b6e967f3e9: Revert "[InferAttrs] Add writeonly to all the math functions" (authored by mstorsjo).
Revert "[InferAttrs] Add writeonly to all the math functions"
Wed, Jan 5, 1:13 AM
mstorsjo added a reverting change for rG1eb5b6e85045: [InferAttrs] If readonly is already set, set readnone instead of writeonly: rG29b6e967f3e9: Revert "[InferAttrs] Add writeonly to all the math functions".
Wed, Jan 5, 1:13 AM
mstorsjo added a reverting change for D116426: [InferAttrs] Add writeonly to all the math functions: rG29b6e967f3e9: Revert "[InferAttrs] Add writeonly to all the math functions".
Wed, Jan 5, 1:13 AM · Restricted Project

Tue, Jan 4

mstorsjo added inline comments to D116556: [llvm-objcopy] Implement the PE-COFF specific --subsystem option.
Tue, Jan 4, 2:48 PM · Restricted Project
mstorsjo updated the diff for D116556: [llvm-objcopy] Implement the PE-COFF specific --subsystem option.

Improve test coverage; test for various error cases, test for specifying only a major version.

Tue, Jan 4, 2:45 PM · Restricted Project
mstorsjo added inline comments to D116556: [llvm-objcopy] Implement the PE-COFF specific --subsystem option.
Tue, Jan 4, 2:38 PM · Restricted Project
mstorsjo requested review of D116625: [lldb] [debugserver] Simplify handling of arch specific files.
Tue, Jan 4, 2:04 PM · Restricted Project
mstorsjo added a comment to D116537: [llvm][cmake] never link llvm-config against llvm dylib.

Ok, thanks. Don’t you have the same issue with the tblgen tools then too?

If I read llvm/cmake/modules/TableGen.cmake correctly, add_tablegen builds the tablegen tools with DISABLE_LLVM_LINK_LLVM_DYLIB.

Tue, Jan 4, 6:57 AM · Restricted Project
mstorsjo added a comment to D116537: [llvm][cmake] never link llvm-config against llvm dylib.

Ok, so the missing context is that you're manually forwarding this by setting e.g. -DLLVM_LINK_LLVM_DYLIB=ON -DCROSS_TOOLCHAIN_FLAGS_NATIVE="... -DLLVM_LINK_LLVM_DYLIB=ON ..."?

Yes.

Tue, Jan 4, 5:19 AM · Restricted Project
mstorsjo added a comment to D116537: [llvm][cmake] never link llvm-config against llvm dylib.

What do you think about not passing in LLVM_LINK_LLVM_DYLIB to the internal, chained cmake build for the native tools (or forcing it to false)? Either as complement to or replacement for this patch.

LLVM_LINK_LLVM_DYLIB isn't actually forwarded from the cross build to the native (re)configuration (only very few variables are), but it is actually desirable to pass this explicitly: If I want to cross compile something that depends on LLVM, I'd want native llvm-config to behave exactly as llvm-config would when executed on the target machine. llvm-config's behavior depends on the configuration variables via BuildVariables.inc which is generated independently for native and cross.

Tue, Jan 4, 1:45 AM · Restricted Project

Mon, Jan 3

mstorsjo accepted D116020: [clang][#52782] Bail on incomplete parameter type in stdcall name mangling.

LGTM, the change seems sensible to me. But I’d prefer if you could hold off pushing it for another couple days, as others who might want to comment might not be following during the holiday season.

Mon, Jan 3, 2:50 PM · Restricted Project
mstorsjo updated subscribers of D68480: Implementation of C++20's P1135R6 for libcxx.

I will argue that breaking this ABI on Windows is not a big deal since nobody's vending libc++ on Windows. Or at least if they do, they are completely invisible to us ("us" being the people who develop libc++).

Would you be willing to open a patch showing what changes are necessary for each of those? I think we can totally break the ABI on Windows since nobody's shipping it.

Mon, Jan 3, 2:23 PM · Restricted Project
mstorsjo requested review of D116556: [llvm-objcopy] Implement the PE-COFF specific --subsystem option.
Mon, Jan 3, 1:55 PM · Restricted Project
mstorsjo added a comment to D116537: [llvm][cmake] never link llvm-config against llvm dylib.

What do you think about not passing in LLVM_LINK_LLVM_DYLIB to the internal, chained cmake build for the native tools (or forcing it to false)? Either as complement to or replacement for this patch.

Mon, Jan 3, 10:16 AM · Restricted Project
mstorsjo added a comment to D116537: [llvm][cmake] never link llvm-config against llvm dylib.

What do you think about not passing in LLVM_LINK_LLVM_DYLIB to the internal, chained cmake build for the native tools (or forcing it to false)? Either as complement to or replacement for this patch.

Mon, Jan 3, 10:14 AM · Restricted Project

Sun, Jan 2

mstorsjo accepted D116510: [llvm][cmake] Normalize some indent.

LGTM

Sun, Jan 2, 9:23 PM · Restricted Project
mstorsjo requested review of D116503: [clang] Add --start-no-unused-arguments/--end-no-unused-arguments to silence some unused argument warnings.
Sun, Jan 2, 2:52 PM · Restricted Project
mstorsjo accepted D116477: [CMake] Use `LLVM_COMMON_CMAKE_UTILS` in runtimes just for clarity.

Seems to work fine for me now, but I guess it still requires approval from some of the libcxx approvers.

Sun, Jan 2, 2:41 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mstorsjo committed rGa8877c5ccc0e: [clang] [MinGW] Pass --no-demangle through to the mingw linker (authored by mstorsjo).
[clang] [MinGW] Pass --no-demangle through to the mingw linker
Sun, Jan 2, 2:23 PM
mstorsjo closed D114064: [clang] [MinGW] Pass --no-demangle through to the mingw linker.
Sun, Jan 2, 2:22 PM · Restricted Project
mstorsjo added a comment to D116484: [lld][MinGW] Ignore `--[no-]as-neeed` flags in MinGW driver.

Unless there are motivating examples that some options are incorrectly used in a prevailing way, it doesn't seem right to ignore options from another binary format which cannot be properly modeled.

As linking against DLL import libraries kinda works like --as-needed (only ending up with a runtime dependency if symbols actually are referenced), would you consider accepting --as-needed but omitting --no-as-needed?

Sun, Jan 2, 1:56 PM · Restricted Project
mstorsjo added a comment to D116358: Make lld to support win-xp.

There was similar differential recently: https://reviews.llvm.org/D112093

Quoting myself from that discussion:

I never had to dig into subsystem versions and what do the mean but looking at subsystem docs 4.0 stands for kernel mode drivers which looks wrong to me. They also specify 5.01 as 32-bit, 5.02 as 64-bit and 6.0 as being either 32-bit or 64-bit.

Sun, Jan 2, 1:55 PM · Restricted Project, lld
mstorsjo added a comment to D116484: [lld][MinGW] Ignore `--[no-]as-neeed` flags in MinGW driver.

Unless there are motivating examples that some options are incorrectly used in a prevailing way, it doesn't seem right to ignore options from another binary format which cannot be properly modeled.

Sun, Jan 2, 1:48 PM · Restricted Project
mstorsjo added a comment to D114064: [clang] [MinGW] Pass --no-demangle through to the mingw linker.

Not sure what the exact division of labor is between the GNU and MinGW backends, but assuming there is no way to share this between them the patch looks good.

Sun, Jan 2, 2:53 AM · Restricted Project
mstorsjo accepted D116485: [clang][MinGW] Explicitly ignore `-fPIC` & friends .

LGTM, thanks. The fact that GCC used to emit a non-fatal warning for this option, but no longer does, probably is the key deciding factor here.

Sun, Jan 2, 12:27 AM · Restricted Project

Sat, Jan 1

mstorsjo added inline comments to D116474: [lld] [coff] Fix the characteristics of some sections like ".voltbl"..
Sat, Jan 1, 3:19 PM · Restricted Project, lld
mstorsjo accepted D116484: [lld][MinGW] Ignore `--[no-]as-neeed` flags in MinGW driver.

LGTM. But I'd like to see an example of a project that sets these flags for mingw builds, as I haven't run into them so far.

Sat, Jan 1, 2:32 PM · Restricted Project
mstorsjo added inline comments to D116477: [CMake] Use `LLVM_COMMON_CMAKE_UTILS` in runtimes just for clarity.
Sat, Jan 1, 2:01 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mstorsjo added inline comments to D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs.
Sat, Jan 1, 1:20 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mstorsjo added a reviewer for D116467: Deprecate `LLVM_LIBRARY_DIRS`: beanz.

This looks reasonable to me, but I'm not sure if I know all the aspects that might be at play here, so I don't think I'm comfortable with accepting it on my own. Adding @beanz who should know lots about our cmake setup too.

Sat, Jan 1, 12:58 PM · Restricted Project, Restricted Project
mstorsjo added inline comments to D116477: [CMake] Use `LLVM_COMMON_CMAKE_UTILS` in runtimes just for clarity.
Sat, Jan 1, 12:47 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mstorsjo added a comment to D116477: [CMake] Use `LLVM_COMMON_CMAKE_UTILS` in runtimes just for clarity.

Looks sensible overall, modulo the typo.

Sat, Jan 1, 11:15 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
mstorsjo added a comment to D116474: [lld] [coff] Fix the characteristics of some sections like ".voltbl"..

This would need a test case for it to be commitable.

Sat, Jan 1, 5:15 AM · Restricted Project, lld
mstorsjo added a reviewer for D114064: [clang] [MinGW] Pass --no-demangle through to the mingw linker: MaskRay.

Adding more potential reviewers. For context, see https://github.com/llvm/llvm-project/blob/llvmorg-14-init/clang/lib/Driver/Driver.cpp#L335-L353 where the original option is filtered out.

Sat, Jan 1, 4:48 AM · Restricted Project
mstorsjo added a comment to D116358: Make lld to support win-xp.

Apologies for deceiving, but I think we aren't and we shouldn't be supporting Windows XP in LLVM. The OS is deprecated since 2009 and Microsoft ended all support in 2014. We don't even support Windows 7 officially. I think most of Windows-specific bindings in llvm/lib/Support/Windows/ assume Windows 8+ APIs. @mstorsjo @hans @rnk do have a different opinion?

Sat, Jan 1, 3:52 AM · Restricted Project, lld
mstorsjo retitled D116472: Set the path to the shared cmake modules based on the llvm directory from Allow overriding path to shared CMake utilities to Set the path to the shared cmake modules based on the llvm directory.
Sat, Jan 1, 1:52 AM · Restricted Project, Restricted Project
mstorsjo removed reviewers for D116472: Set the path to the shared cmake modules based on the llvm directory: Restricted Project, Restricted Project, Restricted Project.

Removing reviewers/subscribers that shouldn’t be affected by this patch any longer.

Sat, Jan 1, 1:48 AM · Restricted Project, Restricted Project
mstorsjo updated the diff for D116472: Set the path to the shared cmake modules based on the llvm directory.

Removed the changes to runtimes; the ways they are built is a separate story - afaik we mandate the monorepo layout there (and the symlinking setup isn't used there afaik).

Sat, Jan 1, 1:46 AM · Restricted Project, Restricted Project
mstorsjo commandeered D116472: Set the path to the shared cmake modules based on the llvm directory.
Sat, Jan 1, 1:40 AM · Restricted Project, Restricted Project
mstorsjo added a comment to D116472: Set the path to the shared cmake modules based on the llvm directory.

@mstorsjo I hope this fixes the issue you had in https://reviews.llvm.org/D115568#3215445. I just whipped this up coding blind. If you could test it to ensure it solves your issue, that would be much appreciated!

Sat, Jan 1, 1:13 AM · Restricted Project, Restricted Project

Fri, Dec 31

mstorsjo added inline comments to D115568: [lld][CMake] Use `GNUInstallDirs` to support custom installation dirs.
Fri, Dec 31, 4:08 PM · lld, Restricted Project
mstorsjo added inline comments to D115568: [lld][CMake] Use `GNUInstallDirs` to support custom installation dirs.
Fri, Dec 31, 4:03 PM · lld, Restricted Project

Wed, Dec 22

mstorsjo committed rG7176799a7e19: [libc++] Add from-scratch testing configs for Windows (authored by mstorsjo).
[libc++] Add from-scratch testing configs for Windows
Wed, Dec 22, 5:18 AM
mstorsjo committed rGfd64544fbe0a: [libcxx] [test] Remove a leftover unused function in config.py. NFC. (authored by mstorsjo).
[libcxx] [test] Remove a leftover unused function in config.py. NFC.
Wed, Dec 22, 5:18 AM
mstorsjo committed rG516882a8f23b: [libcxx] [test] Prepare the ctime.timespec test for mingw CI env upgrades (authored by mstorsjo).
[libcxx] [test] Prepare the ctime.timespec test for mingw CI env upgrades
Wed, Dec 22, 5:18 AM
mstorsjo closed D111202: [libc++] Add from-scratch testing configs for Windows.
Wed, Dec 22, 5:17 AM · Restricted Project, Restricted Project
mstorsjo closed D116131: [libcxx] [test] Remove a leftover unused function in config.py. NFC..
Wed, Dec 22, 5:17 AM · Restricted Project
mstorsjo closed D116132: [libcxx] [test] Prepare the ctime.timespec test for mingw CI env upgrades.
Wed, Dec 22, 5:17 AM · Restricted Project
mstorsjo updated the diff for D98769: [WIP] [private] [libcxx] Tests for future changes for windows CI configurations.

New run

Wed, Dec 22, 12:42 AM

Tue, Dec 21

mstorsjo updated the diff for D111202: [libc++] Add from-scratch testing configs for Windows.

Restored the naming to llvm-libc++-{static,shared}-clangcl.cfg.in for now (not worth breaking the consistency with the -gcc one for now), rerunning CI.

Tue, Dec 21, 4:12 PM · Restricted Project, Restricted Project
mstorsjo updated the diff for D98769: [WIP] [private] [libcxx] Tests for future changes for windows CI configurations.

New run

Tue, Dec 21, 4:08 PM
mstorsjo added a comment to D116132: [libcxx] [test] Prepare the ctime.timespec test for mingw CI env upgrades.

Out of curiosity, are you coordinating on the update to the testing environment?

Please make a note to come back and remove this :-)

Tue, Dec 21, 2:58 PM · Restricted Project
mstorsjo requested review of D116132: [libcxx] [test] Prepare the ctime.timespec test for mingw CI env upgrades.
Tue, Dec 21, 2:54 PM · Restricted Project
mstorsjo requested review of D116131: [libcxx] [test] Remove a leftover unused function in config.py. NFC..
Tue, Dec 21, 2:48 PM · Restricted Project

Dec 21 2021

mstorsjo updated the diff for D111202: [libc++] Add from-scratch testing configs for Windows.

Rebased on top of the split out changes. Now the remaining bits here should be pretty much straightforward.

Dec 21 2021, 2:46 PM · Restricted Project, Restricted Project
mstorsjo committed rGd67b25e7f6d9: [libcxx] [test] Extend test for bash for executor-has-no-bash (authored by mstorsjo).
[libcxx] [test] Extend test for bash for executor-has-no-bash
Dec 21 2021, 2:44 PM
mstorsjo committed rGf68e89044a2e: [libcxx] Add LIBCXX_EXTRA_SITE_DEFINES for adding extra defines in __config_site (authored by mstorsjo).
[libcxx] Add LIBCXX_EXTRA_SITE_DEFINES for adding extra defines in __config_site
Dec 21 2021, 2:44 PM
mstorsjo committed rGc1a14a5c3e6f: [libcxx] Use LIBCXX_EXECUTOR in new test configs (authored by mstorsjo).
[libcxx] Use LIBCXX_EXECUTOR in new test configs
Dec 21 2021, 2:44 PM