Page MenuHomePhabricator

mstorsjo (Martin Storsjö)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 25 2016, 12:54 PM (218 w, 2 d)

Recent Activity

Today

mstorsjo added inline comments to D88543: [AArch64] Match the windows canonical callee saved register order.
Wed, Sep 30, 2:10 PM · Restricted Project
mstorsjo added a comment to D88543: [AArch64] Match the windows canonical callee saved register order.

With all of them applied, a 228 KB xdata section shrinks by 74 KB thanks to being able to write packed unwind info, ending up with smaller xdata than the corresponding section for an x86_64 build of the same DLL.

Wed, Sep 30, 3:57 AM · Restricted Project
mstorsjo requested review of D88543: [AArch64] Match the windows canonical callee saved register order.
Wed, Sep 30, 2:02 AM · Restricted Project
mstorsjo requested review of D88541: [AArch64] Don't merge sp decrement into later stores when using WinCFI.
Wed, Sep 30, 1:41 AM · Restricted Project

Mon, Sep 28

mstorsjo accepted D88305: [COFF] Aliases resolve directly to defined external targets.

Awesome, thanks for finding all the relevant cases here. I've tested it with my own testsuite for GNU style weak symbols, and it seems to still be working.

Mon, Sep 28, 12:58 PM · Restricted Project

Sat, Sep 26

mstorsjo added a comment to D87732: [Support] Provide sys::path::guess_style.
In D87732#2296076, @rnk wrote:

Separately, I would like LLVM to move in the direction of standardizing on forward slashes in internal representations and data structures.

If we move that direction, we'll have to re-think VFS again. I'll also lobby hard to make sure that we show the native representation in compiler output, like diagnostic messages.

Sat, Sep 26, 12:08 PM · Restricted Project
mstorsjo added a comment to D88005: [clang] [MinGW] Add an implicit .exe suffix even when crosscompiling.

This change broke the configure step of Firefox mingw builds.

The build bot won't give me the full details, so I'll need to set up a local repro next week if needed, but my hunch is that we have some test like $CC $CFLAGS conftest.c -o conftest and then check for the existence of conftest.

Is that type of pattern an acceptable casualty of this change?

Sat, Sep 26, 11:49 AM · Restricted Project

Fri, Sep 25

mstorsjo added inline comments to D88305: [COFF] Aliases resolve directly to defined external targets.
Fri, Sep 25, 3:52 PM · Restricted Project
mstorsjo added a comment to D88305: [COFF] Aliases resolve directly to defined external targets.

I tested this with an input file like this here:

        .globl uniquename
uniquename:
        ret
Fri, Sep 25, 3:11 PM · Restricted Project
mstorsjo added a reviewer for D88305: [COFF] Aliases resolve directly to defined external targets: rnk.

This does seem to produce the right results for all the cases that I can come to think of right now, so I guess it's good, but I'd like to think about it for another day or two, if that's ok.

Fri, Sep 25, 3:02 PM · Restricted Project
mstorsjo added inline comments to D88213: [llvm-objcopy][NFC] refactor error handling. part 2..
Fri, Sep 25, 3:22 AM · Restricted Project
mstorsjo added a reviewer for D88124: [windows-itanium] [WIP] Windows Itanium Build Recipe: smeenai.

Hi mstorsjo, thanks for looking at this. Please add anyone else to this review that might be interested.

Fri, Sep 25, 12:59 AM
mstorsjo added a comment to D88213: [llvm-objcopy][NFC] refactor error handling. part 2..

LGTM overall, one change that seems superfluous though.

Fri, Sep 25, 12:05 AM · Restricted Project

Thu, Sep 24

mstorsjo added inline comments to D88124: [windows-itanium] [WIP] Windows Itanium Build Recipe.
Thu, Sep 24, 12:59 AM

Wed, Sep 23

mstorsjo added inline comments to D88176: Explicitly specify CMAKE_AR in WinMsvc.cmake.
Wed, Sep 23, 11:58 PM · Restricted Project

Tue, Sep 22

mstorsjo committed rGb90132399aa9: [CVP] Remove a redundant trailing semicolon, fixing GCC warnings. NFC. (authored by mstorsjo).
[CVP] Remove a redundant trailing semicolon, fixing GCC warnings. NFC.
Tue, Sep 22, 11:03 PM
mstorsjo committed rG2c4c659666b4: [InstCombine] Add parentheses in assert to silence GCC warning. NFC. (authored by mstorsjo).
[InstCombine] Add parentheses in assert to silence GCC warning. NFC.
Tue, Sep 22, 11:03 PM
mstorsjo committed rGf69e090d7dca: [MC] [Win64EH] Try to generate packed unwind info where possible (authored by mstorsjo).
[MC] [Win64EH] Try to generate packed unwind info where possible
Tue, Sep 22, 11:03 PM
mstorsjo closed D87371: [MC] [Win64EH] Try to generate packed unwind info where possible.
Tue, Sep 22, 11:03 PM · Restricted Project
mstorsjo updated the diff for D87371: [MC] [Win64EH] Try to generate packed unwind info where possible.

Expanded the comment regarding matching/mismatching prologues to include more about the backstory.

Tue, Sep 22, 2:04 AM · Restricted Project
mstorsjo added inline comments to D87371: [MC] [Win64EH] Try to generate packed unwind info where possible.
Tue, Sep 22, 1:51 AM · Restricted Project
mstorsjo committed rG3fec6ddc276a: Reapply: [clang-cl] Always interpret the LIB env var as separated with… (authored by mstorsjo).
Reapply: [clang-cl] Always interpret the LIB env var as separated with…
Tue, Sep 22, 12:51 AM

Mon, Sep 21

mstorsjo added a reverting change for rG4d85444b317a: [clang-cl] Always interpret the LIB env var as separated with semicolons: rG8c3ef08f8a4e: Revert "[clang-cl] Always interpret the LIB env var as separated with….
Mon, Sep 21, 2:15 PM
mstorsjo committed rG8c3ef08f8a4e: Revert "[clang-cl] Always interpret the LIB env var as separated with… (authored by mstorsjo).
Revert "[clang-cl] Always interpret the LIB env var as separated with…
Mon, Sep 21, 2:15 PM
mstorsjo added a reverting change for D88002: [clang-cl] Always interpret the LIB env var as separated with semicolons: rG8c3ef08f8a4e: Revert "[clang-cl] Always interpret the LIB env var as separated with….
Mon, Sep 21, 2:15 PM · Restricted Project, Restricted Project
mstorsjo committed rG36c64af9d7f9: [CodeGen] [WinException] Only produce handler data at the end of the function… (authored by mstorsjo).
[CodeGen] [WinException] Only produce handler data at the end of the function…
Mon, Sep 21, 1:43 PM
mstorsjo committed rG4d85444b317a: [clang-cl] Always interpret the LIB env var as separated with semicolons (authored by mstorsjo).
[clang-cl] Always interpret the LIB env var as separated with semicolons
Mon, Sep 21, 1:43 PM
mstorsjo committed rGead7c3cdc34c: [clang] [MinGW] Add an implicit .exe suffix even when crosscompiling (authored by mstorsjo).
[clang] [MinGW] Add an implicit .exe suffix even when crosscompiling
Mon, Sep 21, 1:43 PM
mstorsjo closed D87448: [CodeGen] [WinException] Only produce handler data at the end of the function if needed.
Mon, Sep 21, 1:43 PM · Restricted Project
mstorsjo closed D88002: [clang-cl] Always interpret the LIB env var as separated with semicolons.
Mon, Sep 21, 1:43 PM · Restricted Project, Restricted Project
mstorsjo closed D88005: [clang] [MinGW] Add an implicit .exe suffix even when crosscompiling.
Mon, Sep 21, 1:43 PM · Restricted Project
mstorsjo requested review of D88005: [clang] [MinGW] Add an implicit .exe suffix even when crosscompiling.
Mon, Sep 21, 1:42 AM · Restricted Project
mstorsjo requested review of D88002: [clang-cl] Always interpret the LIB env var as separated with semicolons.
Mon, Sep 21, 12:24 AM · Restricted Project, Restricted Project

Fri, Sep 18

mstorsjo added a comment to D87188: [InstCombine] Canonicalize SPF to abs intrinc.

Based on an initial look, the changes in comparison predicates here are probably a red herring. If I understand right, those predicates are switching from signed to unsigned comparison (e.g. gt to hi). I also see similar changes in IR. However, all the cases I looked at are actually correct (e.g. abs(x) > abs(y) can be compared signed or unsigned for poisoning abs). Assuming that this code is clean under ubsan, the problem is likely something else.

Fri, Sep 18, 12:44 PM · Restricted Project, Restricted Project

Thu, Sep 17

mstorsjo added a comment to D87188: [InstCombine] Canonicalize SPF to abs intrinc.

This broke a few tests for me (generating code that now gives the fail result at runtime).

Thu, Sep 17, 11:51 PM · Restricted Project, Restricted Project

Wed, Sep 16

mstorsjo added a comment to D87448: [CodeGen] [WinException] Only produce handler data at the end of the function if needed.

@rnk - Can you follow up on the discussion above?

Wed, Sep 16, 10:27 AM · Restricted Project

Tue, Sep 15

mstorsjo committed rGc913f6dce695: [llvm-rc] Lowercase the option definitions. NFC. (authored by mstorsjo).
[llvm-rc] Lowercase the option definitions. NFC.
Tue, Sep 15, 11:35 PM
mstorsjo committed rG74d7356fc63b: [llvm-rc] Update a comment. NFC. (authored by mstorsjo).
[llvm-rc] Update a comment. NFC.
Tue, Sep 15, 11:35 PM
mstorsjo committed rG794467b916e8: [llvm-rc] Allow omitting components from VERSIONINFO versions (authored by mstorsjo).
[llvm-rc] Allow omitting components from VERSIONINFO versions
Tue, Sep 15, 11:35 PM
mstorsjo closed D87570: [llvm-rc] Allow omitting components from VERSIONINFO version numbers.
Tue, Sep 15, 11:34 PM · Restricted Project
mstorsjo added a comment to D87379: [ARM] Selects SSAT/USAT from LLVM IR of min/max patterns.
In D87379#2274531, @srj wrote:

It seems we made a small mistake in one of the if conditions, will fix it now. Thanks for letting us know

What commit/review has the fixes? This is affecting Halide as well and we'd like to test the fix.

Tue, Sep 15, 9:16 AM · Restricted Project
mstorsjo added a comment to D87379: [ARM] Selects SSAT/USAT from LLVM IR of min/max patterns.

Headsup: This broke a number of tests for me. Looking closer into where it changed things erroneously...

It seems we made a small mistake in one of the if conditions, will fix it now. Thanks for letting us know

Tue, Sep 15, 6:24 AM · Restricted Project
mstorsjo accepted D83573: [libunwind] Support for leaf function unwinding..

LGTM

Tue, Sep 15, 3:49 AM · Restricted Project, Restricted Project
mstorsjo added a comment to D87379: [ARM] Selects SSAT/USAT from LLVM IR of min/max patterns.

The file that shows the error can be built from https://martin.st/temp/eval.c, built as clang -target armv7-w64-mingw32 -c -O2 eval.c.

Tue, Sep 15, 12:56 AM · Restricted Project
mstorsjo added a comment to D87379: [ARM] Selects SSAT/USAT from LLVM IR of min/max patterns.

The main difference in code, in the function that show the error in one of the testcases that broke, looks like this:

-       movs    r1, #9
-       cmp     r0, #9
-       it      lt
-       movlt   r1, r0
-       bic.w   r0, r1, r1, asr #31
+       usat    r0, #1, r0
Tue, Sep 15, 12:18 AM · Restricted Project

Mon, Sep 14

mstorsjo added a comment to D87379: [ARM] Selects SSAT/USAT from LLVM IR of min/max patterns.

Headsup: This broke a number of tests for me. Looking closer into where it changed things erroneously...

Mon, Sep 14, 11:50 PM · Restricted Project
mstorsjo added a comment to D87418: [LLD] Allow configuring default ld.lld backend.

Pushed this one now.

Mon, Sep 14, 11:32 PM · Restricted Project, lld
mstorsjo committed rGe71cda21d71c: [Windows][Polly] Disable LLVMPolly module for all compilers on Windows (authored by mati865).
[Windows][Polly] Disable LLVMPolly module for all compilers on Windows
Mon, Sep 14, 11:13 PM
mstorsjo committed rG61e0b2b4c5fb: [LLD] Allow configuring default ld.lld backend (authored by mati865).
[LLD] Allow configuring default ld.lld backend
Mon, Sep 14, 11:13 PM
mstorsjo committed rG7b416c5e3683: [llvm-readobj] [ARMWinEH] Print ARM64 packed unwind info (authored by mstorsjo).
[llvm-readobj] [ARMWinEH] Print ARM64 packed unwind info
Mon, Sep 14, 11:13 PM
mstorsjo closed D87524: [Windows][Polly] Disable LLVMPolly module for all compilers on Windows.
Mon, Sep 14, 11:13 PM · Restricted Project, Restricted Project
mstorsjo closed D87418: [LLD] Allow configuring default ld.lld backend.
Mon, Sep 14, 11:13 PM · Restricted Project, lld
mstorsjo closed D87370: [llvm-readobj] [ARMWinEH] Print ARM64 packed unwind info.
Mon, Sep 14, 11:13 PM · Restricted Project
mstorsjo added a comment to D87521: [MinGW][llvm-config] Use unversioned library name.

@hans - Does that sound right to you?

Yes, that matches my experience. But I don't know the backstory here. Maybe it would make sense to have version suffixes also on Windows?

Mon, Sep 14, 12:16 PM · Restricted Project
mstorsjo added a comment to D87418: [LLD] Allow configuring default ld.lld backend.

Ping @MaskRay

Mon, Sep 14, 12:13 PM · Restricted Project, lld

Sun, Sep 13

mstorsjo added a comment to D86256: [libunwind] Make .eh_frame scanning/caching optional.

The commit description talks about making the caching optional, but I don't really see that aspect in the patch - or maybe I'm just not studying it closely enough?

Sun, Sep 13, 1:41 PM · Restricted Project, Restricted Project
mstorsjo added a comment to D86256: [libunwind] Make .eh_frame scanning/caching optional.

If the unwinder uses dl_iterate_phdr, then entries that are automatically added to DwarfFDECache would become invalid if the module containing the entry were unloaded. (On Apple systems, DwarfFDECache registers dyldUnloadHook to remove unloaded entries.)

AFAICT, this is also a problem for Windows DWARF EH, which relies on scanning an .eh_frame section. e.g. A stale cachedFDE could point into the middle of an FDE/CIE with an arbitrary outcome. Maybe decodeFDE crashes, or maybe it decodes something that looks like a match. I'm not sure if it can be fixed without disabling the caching. If so, then I'd wonder if the caching is worth keeping. (Bare-metal could use .eh_frame_hdr, and I'm not sure whether Apple systems actually need the full __eh_frame scan.)

Sun, Sep 13, 1:36 PM · Restricted Project, Restricted Project
mstorsjo added a comment to D83573: [libunwind] Support for leaf function unwinding..

The change itself looks good to me, but the comment in lit.site.cfg.in does look confusing to me as well, so it'd be great to have it reworded.

Sun, Sep 13, 12:56 PM · Restricted Project, Restricted Project
mstorsjo added a comment to D87521: [MinGW][llvm-config] Use unversioned library name.

Cygwin seems to be the only Windows target that adds version to the library names.

Sun, Sep 13, 4:39 AM · Restricted Project

Sat, Sep 12

mstorsjo added a reviewer for D87521: [MinGW][llvm-config] Use unversioned library name: hans.

Ok, so if I read code correctly, the suffix gets added here: https://github.com/llvm/llvm-project/blob/9c651c231f3144f53e13cd0a1747589e1b2edccd/llvm/cmake/modules/AddLLVM.cmake#L599-L606

Sat, Sep 12, 2:47 PM · Restricted Project
mstorsjo requested review of D87570: [llvm-rc] Allow omitting components from VERSIONINFO version numbers.
Sat, Sep 12, 2:27 PM · Restricted Project
mstorsjo committed rG7da941939902: [MinGW][libclang] Allow simultaneous shared and static lib (authored by mati865).
[MinGW][libclang] Allow simultaneous shared and static lib
Sat, Sep 12, 12:06 PM
mstorsjo committed rGbb613044b680: [MinGW][clang-shlib] Build by default on MinGW (authored by mati865).
[MinGW][clang-shlib] Build by default on MinGW
Sat, Sep 12, 12:05 PM
mstorsjo committed rGcc76965b1908: [MinGW] Use lib prefix for libraries (authored by mati865).
[MinGW] Use lib prefix for libraries
Sat, Sep 12, 12:05 PM
mstorsjo closed D87539: [MinGW][libclang] Allow simultaneous shared and static lib.
Sat, Sep 12, 12:05 PM · Restricted Project
mstorsjo closed D87547: [MinGW][clang-shlib] Build by default on MinGW.
Sat, Sep 12, 12:05 PM · Restricted Project
mstorsjo closed D87517: [MinGW] Use lib prefix for libraries.
Sat, Sep 12, 12:05 PM · Restricted Project, Restricted Project, Restricted Project
mstorsjo accepted D87539: [MinGW][libclang] Allow simultaneous shared and static lib.

LGTM then! Can apply it a bit later.

Sat, Sep 12, 7:00 AM · Restricted Project
mstorsjo added a comment to D87521: [MinGW][llvm-config] Use unversioned library name.

what code appends a version number in dynamic libs when built for other platforms, but decides not to, when targeting windows in general, or mingw specifically?

I have very limited knowledge about what is going on but I think this version script controls it: https://github.com/llvm/llvm-project/blob/9c651c231f3144f53e13cd0a1747589e1b2edccd/llvm/tools/llvm-shlib/CMakeLists.txt#L51

Sat, Sep 12, 6:32 AM · Restricted Project
mstorsjo added a comment to D87539: [MinGW][libclang] Allow simultaneous shared and static lib.

bin/llvm-readobj --coff-directives lib/liblibclang.dll.a | grep -i export shows nothing.

Sat, Sep 12, 6:28 AM · Restricted Project
mstorsjo added a comment to D87521: [MinGW][llvm-config] Use unversioned library name.
Sat, Sep 12, 4:31 AM · Restricted Project
mstorsjo added a comment to D87539: [MinGW][libclang] Allow simultaneous shared and static lib.

We had this patch at MSYS2 for years and I'm not aware of any issues with the static library.
I think the library looks fine:

$ nm lib/liblibclang.a | grep __imp_
                 U __imp___acrt_iob_func
                 U __imp___acrt_iob_func
                 U __imp_GetModuleFileNameA
                 U __imp_VirtualQuery
                 U __imp___acrt_iob_func
                 U __imp___acrt_iob_func
                 U __imp___acrt_iob_func
Sat, Sep 12, 3:57 AM · Restricted Project

Fri, Sep 11

mstorsjo accepted D87547: [MinGW][clang-shlib] Build by default on MinGW.

This should be ok, I think.

Fri, Sep 11, 10:54 PM · Restricted Project
mstorsjo added a comment to D87539: [MinGW][libclang] Allow simultaneous shared and static lib.

Does the static lib built in this case include any dllexport attributes (that can cause issues if linking it statically into another DLL)?

Fri, Sep 11, 10:53 PM · Restricted Project
mstorsjo added a comment to D87521: [MinGW][llvm-config] Use unversioned library name.

If the corresponding DLLs built in MSVC mode actually have a version number suffix, should we change the build for MinGW mode to include a number as well? Or is any of the relevant DLLs ever built in MSVC mode at all?

Fri, Sep 11, 10:50 PM · Restricted Project
mstorsjo updated the diff for D87370: [llvm-readobj] [ARMWinEH] Print ARM64 packed unwind info.

Removed superfluous "sub sp, sp, #0".

Fri, Sep 11, 10:39 PM · Restricted Project
mstorsjo accepted D87517: [MinGW] Use lib prefix for libraries.

This looks good to me! I can push it later.

Fri, Sep 11, 1:29 PM · Restricted Project, Restricted Project, Restricted Project
mstorsjo added inline comments to D87521: [MinGW][llvm-config] Use unversioned library name.
Fri, Sep 11, 12:09 PM · Restricted Project
Herald added a reviewer for D87517: [MinGW] Use lib prefix for libraries: JDevlieghere.

What's the practical effect of this? I see that a number of libraries already have a lib prefix prepended, like libclang/liblldb - I presume this changes the name of the individual libs (for BUILD_SHARED_LIBS=TRUE configurations)?

Fri, Sep 11, 12:06 PM · Restricted Project, Restricted Project, Restricted Project
mstorsjo added a comment to D87448: [CodeGen] [WinException] Only produce handler data at the end of the function if needed.
In D87448#2266746, @rnk wrote:

Makes sense.

Unwind info for all remaining functions that hasn't gotten it emitted directly is emitted at the end.

Can we make .seh_endproc responsible for emitting the unwind info into .xdata if necessary?

Fri, Sep 11, 2:22 AM · Restricted Project
mstorsjo added a comment to D87371: [MC] [Win64EH] Try to generate packed unwind info where possible.

the length of the synthesized canonical prologue might differ a little from the actual one maybe

Getting the length wrong has caused miscompiles in the past.

Fri, Sep 11, 1:51 AM · Restricted Project
mstorsjo committed rGe6419d320d50: [MC] [Win64EH] Fix builds with expensive checks enabled (authored by mstorsjo).
[MC] [Win64EH] Fix builds with expensive checks enabled
Fri, Sep 11, 1:17 AM
mstorsjo committed rG700fbe591ac0: [MC] [Win64EH] Canonicalize ARM64 unwind opcodes (authored by mstorsjo).
[MC] [Win64EH] Canonicalize ARM64 unwind opcodes
Fri, Sep 11, 12:32 AM
mstorsjo committed rG1308bb99e067: [MC] [Win64EH] Write packed ARM64 epilogues if possible (authored by mstorsjo).
[MC] [Win64EH] Write packed ARM64 epilogues if possible
Fri, Sep 11, 12:32 AM
mstorsjo committed rG46416f08031f: [CodeGen] [WinException] Remove a redundant explicit section switch for aarch64 (authored by mstorsjo).
[CodeGen] [WinException] Remove a redundant explicit section switch for aarch64
Fri, Sep 11, 12:31 AM
mstorsjo closed D87369: [MC] [Win64EH] Write packed ARM64 epilogs if possible.
Fri, Sep 11, 12:31 AM · Restricted Project
mstorsjo closed D87367: [MC] [Win64EH] Canonicalize ARM64 unwind opcodes.
Fri, Sep 11, 12:31 AM · Restricted Project
mstorsjo closed D87447: [CodeGen] [WinException] Remove a redundant explicit section switch for aarch64.
Fri, Sep 11, 12:31 AM · Restricted Project
mstorsjo added inline comments to D87370: [llvm-readobj] [ARMWinEH] Print ARM64 packed unwind info.
Fri, Sep 11, 12:24 AM · Restricted Project

Thu, Sep 10

mstorsjo added a comment to D87418: [LLD] Allow configuring default ld.lld backend.
In D87418#2266652, @pcc wrote:

How widespread are these build systems that parse help output? (Given that it took until now to discover them, I'd venture "not very".) Maybe it would be better to fix them to explicitly pass -m and/or do something that doesn't rely on parsing help output (e.g. just try the flag and see whether it fails).

Thu, Sep 10, 1:45 PM · Restricted Project, lld
mstorsjo added inline comments to D87418: [LLD] Allow configuring default ld.lld backend.
Thu, Sep 10, 11:50 AM · Restricted Project, lld
mstorsjo added inline comments to D87371: [MC] [Win64EH] Try to generate packed unwind info where possible.
Thu, Sep 10, 5:07 AM · Restricted Project
mstorsjo requested review of D87448: [CodeGen] [WinException] Only produce handler data at the end of the function if needed.
Thu, Sep 10, 5:03 AM · Restricted Project
mstorsjo requested review of D87447: [CodeGen] [WinException] Remove a redundant explicit section switch for aarch64.
Thu, Sep 10, 4:52 AM · Restricted Project
mstorsjo added inline comments to D87418: [LLD] Allow configuring default ld.lld backend.
Thu, Sep 10, 3:38 AM · Restricted Project, lld
mstorsjo committed rG6313f5561945: [llvm-readobj] [ARMWinEH] Fix printing of exception handlers with packed… (authored by mstorsjo).
[llvm-readobj] [ARMWinEH] Fix printing of exception handlers with packed…
Thu, Sep 10, 1:42 AM
mstorsjo committed rG8060283ff8b7: [llvm-readobj] [ARMWinEH] Print set_fp/add_fp differently in epilogues (authored by mstorsjo).
[llvm-readobj] [ARMWinEH] Print set_fp/add_fp differently in epilogues
Thu, Sep 10, 1:42 AM
mstorsjo closed D87365: [llvm-readobj] [ARMWinEH] Fix printing of exception handlers with packed epilogues.
Thu, Sep 10, 1:41 AM · Restricted Project
mstorsjo closed D87363: [llvm-readobj] [ARMWinEH] Print set_fp/add_fp differently in epilogues.
Thu, Sep 10, 1:41 AM · Restricted Project
mstorsjo added inline comments to D87365: [llvm-readobj] [ARMWinEH] Fix printing of exception handlers with packed epilogues.
Thu, Sep 10, 1:13 AM · Restricted Project