Page MenuHomePhabricator

Recent Activity

Today

clemenswasser added a comment to D95184: [ASan] Stop blocking child thread progress from parent thread in `pthread_create` interceptor..

You should also change compiler-rt/lib/asan/asan_win.cpp like this:

diff --git a/compiler-rt/lib/asan/asan_win.cpp b/compiler-rt/lib/asan/asan_win.cpp
index 8044ae16ff9b..1577c83cf994 100644
--- a/compiler-rt/lib/asan/asan_win.cpp
+++ b/compiler-rt/lib/asan/asan_win.cpp
@@ -134,7 +134,7 @@ INTERCEPTOR(int, _except_handler4, void *a, void *b, void *c, void *d) {
 static thread_return_t THREAD_CALLING_CONV asan_thread_start(void *arg) {
   AsanThread *t = (AsanThread *)arg;
   SetCurrentThread(t);
-  return t->ThreadStart(GetTid(), /* signal_thread_is_registered */ nullptr);
+  return t->ThreadStart(GetTid());
 }
Sat, Jan 23, 6:43 AM · Restricted Project
aykevl added a comment to D63852: [Clang] Move assembler into a separate file.

Yeah I was wondering the same thing when I saw the failure. Unfortunately such design is a bit outside of my LLVM knowledge. I would just like to use cc1as_main.cpp functionality outside of LLVM without needing to update my copy of cc1as with every LLVM update.

Sat, Jan 23, 6:35 AM · Restricted Project
hubert.reinterpretcast added a comment to D63852: [Clang] Move assembler into a separate file.

or maybe I've put AssemblerInvocation in the wrong directory/library.

Sat, Jan 23, 6:25 AM · Restricted Project
HsiangKai updated the diff for D94465: [RISCV] Frame handling for RISC-V V extension. (2nd. version).
Sat, Jan 23, 6:14 AM · Restricted Project
hubert.reinterpretcast added a comment to D63852: [Clang] Move assembler into a separate file.

@aykevl, please check http://lab.llvm.org:8011/#/builders/57/builds/3704: it seems you are missing a change to clang/lib/Frontend/CMakeLists.txt to update the LLVM_LINK_COMPONENTS.

Sat, Jan 23, 6:11 AM · Restricted Project
LLVM GN Syncbot <llvmgnsyncbot@gmail.com> committed rGd5c4de40c679: [gn build] Port 0057cc5a215e (authored by LLVM GN Syncbot <llvmgnsyncbot@gmail.com>).
[gn build] Port 0057cc5a215e
Sat, Jan 23, 6:11 AM
aykevl added a comment to D63852: [Clang] Move assembler into a separate file.

@echristo do you have an idea what's going on or how to fix this? I suspect I'm not including a required dependency or maybe I've put AssemblerInvocation in the wrong directory/library.
I'm not very familiar with CMake or C++ so I'm not sure how to best fix this.

Sat, Jan 23, 6:09 AM · Restricted Project
aykevl added a reverting change for rG2325157c0568: [Clang] Move assembler into a separate file: rG0057cc5a215e: Revert "[Clang] Move assembler into a separate file".
Sat, Jan 23, 6:07 AM
aykevl committed rG0057cc5a215e: Revert "[Clang] Move assembler into a separate file" (authored by aykevl).
Revert "[Clang] Move assembler into a separate file"
Sat, Jan 23, 6:07 AM
aykevl added a reverting change for D63852: [Clang] Move assembler into a separate file: rG0057cc5a215e: Revert "[Clang] Move assembler into a separate file".
Sat, Jan 23, 6:07 AM · Restricted Project
aykevl added a comment to D63852: [Clang] Move assembler into a separate file.

Well that didn't quite work. I get errors like this:

Sat, Jan 23, 6:07 AM · Restricted Project
jeroen.dobbelaere added a comment to D95141: [InstCombine] Remove unused llvm.experimental.noalias.scope.decl.

I noticed that D93040 added a decent 2% penalty for trampd3d-v4. In https://llvm-compile-time-tracker.com/index.php?config=O3&stat=instructions&branch=dobbelaj-snps/perf/D95141_20210123_01 you can see that the cleanup wins back most of this regression.

It would be good to revert D93040 maybe.. Or be sure this fix goes in before llvm 12.

Sat, Jan 23, 5:59 AM · Restricted Project
xbolva00 added a comment to D95141: [InstCombine] Remove unused llvm.experimental.noalias.scope.decl.

I noticed that D93040 added a decent 2% penalty for trampd3d-v4. In https://llvm-compile-time-tracker.com/index.php?config=O3&stat=instructions&branch=dobbelaj-snps/perf/D95141_20210123_01 you can see that the cleanup wins back most of this regression.

Sat, Jan 23, 5:57 AM · Restricted Project
nikic added a reviewer for D95286: [LSR] Drop potentially invalid nowrap flags when switching to post-inc IV (PR46943): dmgreen.

Adding @dmgreen for the changes to the Thumb2 tests.

Sat, Jan 23, 5:55 AM · Restricted Project
jeroen.dobbelaere added a comment to D95141: [InstCombine] Remove unused llvm.experimental.noalias.scope.decl.

I noticed that D93040 added a decent 2% penalty for trampd3d-v4. In https://llvm-compile-time-tracker.com/index.php?config=O3&stat=instructions&branch=dobbelaj-snps/perf/D95141_20210123_01 you can see that the cleanup wins back most of this regression.

Sat, Jan 23, 5:54 AM · Restricted Project
nikic requested review of D95286: [LSR] Drop potentially invalid nowrap flags when switching to post-inc IV (PR46943).
Sat, Jan 23, 5:52 AM · Restricted Project
lebedev.ri committed rG022da61f6b30: [SimplifyCFG] Change 'LoopHeaders' to be ArrayRef<WeakVH>, not a naked set… (authored by lebedev.ri).
[SimplifyCFG] Change 'LoopHeaders' to be ArrayRef<WeakVH>, not a naked set…
Sat, Jan 23, 5:49 AM
LLVM GN Syncbot <llvmgnsyncbot@gmail.com> committed rGdbf87da739ba: [gn build] Port 2325157c0568 (authored by LLVM GN Syncbot <llvmgnsyncbot@gmail.com>).
[gn build] Port 2325157c0568
Sat, Jan 23, 5:42 AM
aykevl added a comment to D63852: [Clang] Move assembler into a separate file.

Thanks! I have updated this patch to match LLVM main and committed it.

Sat, Jan 23, 5:39 AM · Restricted Project
aykevl committed rG2325157c0568: [Clang] Move assembler into a separate file (authored by aykevl).
[Clang] Move assembler into a separate file
Sat, Jan 23, 5:38 AM
aykevl closed D63852: [Clang] Move assembler into a separate file.
Sat, Jan 23, 5:38 AM · Restricted Project
pengfei updated the diff for D95136: [X86] Fix tile config register spill issue..

A minor refactor.

Sat, Jan 23, 5:28 AM · Restricted Project
Mordante updated the diff for D91004: [libc++] Implements concept destructible.
  • Addresses review comments.
    • Add some fundamental types to the unit test
    • Ran clang-format on the patch
  • Rebased to test against a recent main before landing the patch
Sat, Jan 23, 5:18 AM · Restricted Project
Mordante added a comment to D91004: [libc++] Implements concept destructible.

Thanks for the review. I'll address your comments and run a CI build before landing this revision.

Sat, Jan 23, 5:15 AM · Restricted Project
pengfei updated the diff for D95136: [X86] Fix tile config register spill issue..

Remove an unnecessary ++MII;

Sat, Jan 23, 5:06 AM · Restricted Project
nikic added inline comments to D94106: [Local] Treat calls that may not return as being alive (WIP)..
Sat, Jan 23, 4:56 AM · Restricted Project
nikic committed rGa49a3a3ed568: [LSR] Add test for PR46943 (NFC) (authored by nikic).
[LSR] Add test for PR46943 (NFC)
Sat, Jan 23, 4:53 AM
fhahn committed rG08dbcc14e254: [LTO] Store target attributes as vector of strings (NFC). (authored by fhahn).
[LTO] Store target attributes as vector of strings (NFC).
Sat, Jan 23, 4:37 AM
fhahn closed D95224: [LTO] Store target attributes as vector of strings..
Sat, Jan 23, 4:37 AM · Restricted Project
pengfei added inline comments to D95136: [X86] Fix tile config register spill issue..
Sat, Jan 23, 4:17 AM · Restricted Project
Mordante updated the diff for D90999: [libc++] Implements ranges::enable_borrowed_range.

Rebase to trigger CI. The last build failed, but so did main.

Sat, Jan 23, 4:13 AM · Restricted Project
Mordante updated the diff for D92214: [libc++] Implement format_error..

Rebase to trigger CI. The last build failed, but so did main.

Sat, Jan 23, 4:12 AM · Restricted Project
pengfei updated the summary of D95136: [X86] Fix tile config register spill issue..
Sat, Jan 23, 4:11 AM · Restricted Project
pengfei updated the diff for D95136: [X86] Fix tile config register spill issue..
  1. Address review comments from Xiang and Yuanke.
  2. Optimize the algorithm to a single DFS.
  3. Fix bugs when counting the place for tilerelease.
Sat, Jan 23, 4:10 AM · Restricted Project
bondhugula added inline comments to D95047: [MLIR] Add support for extracting an integer sample point (if one exists) from an unbounded FlatAffineConstraints..
Sat, Jan 23, 3:52 AM · Restricted Project
ezhulenev abandoned D94255: [mlir] AsyncRuntime: use LLVM ThreadPool to run async tasks.
Sat, Jan 23, 3:45 AM · Restricted Project
jeroen.dobbelaere committed rG2b9a834c43cb: [InlineFunction] Use llvm.experimental.noalias.scope.decl for noalias arguments. (authored by jeroen.dobbelaere).
[InlineFunction] Use llvm.experimental.noalias.scope.decl for noalias arguments.
Sat, Jan 23, 3:12 AM
jeroen.dobbelaere closed D93040: [InlineFunction] Use llvm.experimental.noalias.scope.decl for noalias arguments..
Sat, Jan 23, 3:12 AM · Restricted Project, Restricted Project
RKSimon committed rG344afa853fcf: [Support] TrigramIndex::insert - pass std::String argument by const reference. (authored by RKSimon).
[Support] TrigramIndex::insert - pass std::String argument by const reference.
Sat, Jan 23, 3:05 AM
jeroen.dobbelaere added a comment to D93040: [InlineFunction] Use llvm.experimental.noalias.scope.decl for noalias arguments..

I am going to commit this patch today, so that we have a view on possible fallout.

Sat, Jan 23, 2:52 AM · Restricted Project, Restricted Project