Page MenuHomePhabricator

Recent Activity

Today

rengolin accepted D89995: Make the post-commit review expectations more explicit with respect to revert.

This is a great policy, thanks @silvas and @mehdi_amini.

Fri, Oct 23, 1:57 AM · Restricted Project
foad accepted D88060: [GISel]: Few InsertVecElt combines.

LGTM, thanks! Just a load of optional nits inline.

Fri, Oct 23, 1:54 AM · Restricted Project
jhenderson committed rG342040bf0074: [lld][ELF][test] Add additional test coverage for LTO (authored by jhenderson).
[lld][ELF][test] Add additional test coverage for LTO
Fri, Oct 23, 1:52 AM
jhenderson closed D89775: [lld][ELF][test] Add additional test coverage for LTO.
Fri, Oct 23, 1:52 AM · Restricted Project
uabelho added a comment to D89978: Fix SROA with a PHI mergig values from a same block.

I don't know what the best fix is, but I've verified that this patch solves the problem I saw and I haven't seen anything weird pop up with the patch in some limited testing I've done with it.
Thanks!

Fri, Oct 23, 1:52 AM · Restricted Project
labath accepted D89600: [lldb] Move copying of reproducer out of process.

Looks good.

Fri, Oct 23, 1:48 AM
steakhal added a comment to D89987: [analyzer] [NFC] Rename SymbolRef to SymExprRef.

@ASDenysPetrov
Please grep for the SymbolRef and rename the other symbols/comments as well, especially the compound names.

Fri, Oct 23, 1:42 AM · Restricted Project
zhanghb97 updated the diff for D89856: [mlir] Expose affine expression to C API.

Use the typeid/isa scheme, expose IsA and Get methods for each affine binary operation expression.

Fri, Oct 23, 1:38 AM · Restricted Project
t.p.northover updated the diff for D89959: UBSAN: emit distinctive traps in trapping mode.

Oh yes, added now.

Fri, Oct 23, 1:38 AM · Restricted Project
usaxena95 added a reviewer for D90014: [clangd] Add support for multiple DecisionForest model experiments.: adamcz.
Fri, Oct 23, 1:36 AM · Restricted Project
jhenderson accepted D89379: [llvm-readobj/libObject] - Allow dumping objects that has a broken SHT_SYMTAB_SHNDX section..

Looks good, (I'm ambivalent on the testing discussion, and will let you and @MaskRay come to a conclusion).

Fri, Oct 23, 1:36 AM · Restricted Project
usaxena95 requested review of D90014: [clangd] Add support for multiple DecisionForest model experiments..
Fri, Oct 23, 1:34 AM · Restricted Project
foad committed rG86a480e9ce78: [AMDGPU] Add simplification/combines for llvm.amdgcn.fmul.legacy (authored by foad).
[AMDGPU] Add simplification/combines for llvm.amdgcn.fmul.legacy
Fri, Oct 23, 1:31 AM
foad closed D88955: [AMDGPU] Add simplification/combines for llvm.amdgcn.fmul.legacy.
Fri, Oct 23, 1:31 AM · Restricted Project
pmatos added a comment to D89797: [WebAssembly] Implementation of (most) table instructions.

@sbc100 if it's ok for you, feel free to merge, thanks.

Fri, Oct 23, 1:31 AM · Restricted Project
jhenderson added inline comments to D89949: [yaml2obj][obj2yaml] - Teach tools to work with regular archives..
Fri, Oct 23, 1:30 AM · Restricted Project
pmatos updated the diff for D89797: [WebAssembly] Implementation of (most) table instructions.

Align with local indent style

Fri, Oct 23, 1:30 AM · Restricted Project
sammccall added inline comments to D89946: [clang] Suppress "follow-up" diagnostics on recovery call expressions..
Fri, Oct 23, 1:30 AM · Restricted Project
labath accepted D90011: [lldb] Redesign Target::GetUtilityFunctionForLanguage API.

Sounds like a good idea.

Fri, Oct 23, 1:25 AM
RKSimon added inline comments to D89105: [X86] Support Intel avxvnni.
Fri, Oct 23, 1:19 AM · Restricted Project
CarolineConcatto committed rG241563647555: [SVE]Clarify TypeSize comparisons in llvm/lib/Transforms (authored by CarolineConcatto).
[SVE]Clarify TypeSize comparisons in llvm/lib/Transforms
Fri, Oct 23, 1:16 AM
CarolineConcatto closed D89703: [SVE]Clarify TypeSize comparisons in llvm/lib/Transforms.
Fri, Oct 23, 1:15 AM · Restricted Project
labath added inline comments to D89812: [lldb][PDB] Add ObjectFile PDB plugin.
Fri, Oct 23, 1:13 AM · Restricted Project
LiuChen3 added inline comments to D90009: [X86] VEX/EVEX prefix doesn't work for inline assembly..
Fri, Oct 23, 1:13 AM · Restricted Project, Restricted Project
LiuChen3 updated the diff for D90009: [X86] VEX/EVEX prefix doesn't work for inline assembly..

Address comments

Fri, Oct 23, 1:12 AM · Restricted Project, Restricted Project
RKSimon added a comment to D89969: [SLP] Consider alternatives for cost of select instructions..

Why the reluctance to actually generate the min/max intrinsics?

Fri, Oct 23, 1:10 AM · Restricted Project
sdesmalen added a comment to D89576: [SVE][CodeGen] Lower scalable masked scatters.

I was thinking of vXi8 and vXi16 vectors that can't be used as indices on X86.

If vXi8 and vXi16 are not legal, the type-legaliser will re-add sign/zero extends when doing type-promotion in DAGTypeLegalizer::PromoteIntOp_MSCATTER, for which it uses the signedness of the MemIndexType. The same is also needed for SVE, which only supports nxvXi32 and nxvXi64 indices. But at least this ensures that e.g. a zero-extend of a legal nxv4i32 -> illegal nxv4i64 will get encoded as legal UNSIGNED_[UN]SCALED nxv4i32 for which the architecture will generate the instruction with zero-extending index. Do you think that will be sufficient?

vXi8/vXi16 are legal types on X86 but not supported as indices to gather.

Okay, I see what you mean. That suggests it would be useful to add a target interface to query if the type is legal as an index type for mgather/mscatter.

Fri, Oct 23, 1:09 AM · Restricted Project
hokein accepted D89785: [clangd] Add basic support for attributes (selection, hover).
Fri, Oct 23, 1:04 AM · Restricted Project
hokein added inline comments to D89946: [clang] Suppress "follow-up" diagnostics on recovery call expressions..
Fri, Oct 23, 1:00 AM · Restricted Project
hokein updated the diff for D89946: [clang] Suppress "follow-up" diagnostics on recovery call expressions..

address comments and add AST tests.

Fri, Oct 23, 1:00 AM · Restricted Project
sammccall added inline comments to D88553: [clangd] Start using SyntaxTrees for folding ranges feature.
Fri, Oct 23, 1:00 AM · Restricted Project
evgeny777 committed rGffc0f577dac7: [llvm-mca] Add test for cortex-a57 NEON instructions (authored by evgeny777).
[llvm-mca] Add test for cortex-a57 NEON instructions
Fri, Oct 23, 12:56 AM
grimar added inline comments to D89379: [llvm-readobj/libObject] - Allow dumping objects that has a broken SHT_SYMTAB_SHNDX section..
Fri, Oct 23, 12:56 AM · Restricted Project
grimar updated the diff for D89379: [llvm-readobj/libObject] - Allow dumping objects that has a broken SHT_SYMTAB_SHNDX section..
  • Addressed review comments.
Fri, Oct 23, 12:56 AM · Restricted Project
mkazantsev added a comment to D89381: [SCEV] Re-enable "Use nw flag and symbolic iteration count to sharpen ranges of AddRecs", attempt 3.

The common pattern where the CT drops that I ovserve is following: Start is a constant (in most cases zero), Step is also a constant and MaxBECount is a pretty big expression.

Fri, Oct 23, 12:55 AM · Restricted Project
nikic added a comment to D89587: [CGSCC] Detect devirtualization in more cases.

FYI, this showed up as a 5% compile-time regression in the NewPM-O3 configuration: https://llvm-compile-time-tracker.com/compare.php?from=3b8d8954bf2c192502d757019b9fe434864068e9&to=3024fe5b55ed72633915f613bd5e2826583c396f&stat=instructions

Fri, Oct 23, 12:54 AM · Restricted Project
alok added a comment to D89817: [DebugInfo] Expose Fortran array debug info attributes through DIBuilder..

Typed the attributes as DIExpression*, as suggested by @aprantl.

Fri, Oct 23, 12:52 AM · Restricted Project
jhenderson added inline comments to D90013: [llvm-objdump] - Rewrite malformed-archives.test to use YAML descriptions..
Fri, Oct 23, 12:45 AM · Restricted Project
evgeny777 committed rG7a78073be764: [ARM][SchedModels] Let ldm* instruction scheduling use MCSchedPredicate (authored by evgeny777).
[ARM][SchedModels] Let ldm* instruction scheduling use MCSchedPredicate
Fri, Oct 23, 12:34 AM
evgeny777 closed D89957: [ARM][SchedModels] Let ldm* instruction scheduling use MCSchedPredicate.
Fri, Oct 23, 12:34 AM · Restricted Project