Page MenuHomePhabricator

Recent Activity

Today

paulwalker-arm accepted D97471: [SVE] Fix LoopVectorizer test scalalable-call.ll.
Thu, Feb 25, 9:27 AM · Restricted Project
sgraenitz retitled D97338: [Orc] Use extensible RTTI for the orc::ObjectLayer class hierarchy from [Orc] Add LLVM-style RTTI for orc::ObjectLayer to [Orc] Use extensible RTTI for the orc::ObjectLayer class hierarchy.
Thu, Feb 25, 9:25 AM · Restricted Project
hans added a comment to D97484: Don't use $ as suffix for symbol names in ThinLTOBitcodeWriter and other places.

Why isn't the solution is to fix the uses to prevent variable substitution in them?
Because of course $1 is substituted with a value of variable 1 in shell, and elsewhere.

$ c++filt _Z3foov\$123
_Z3foov$123
Thu, Feb 25, 9:24 AM · Restricted Project
MaskRay added a comment to D97446: Change some addUsedGlobal to addUsedOrCompilerUsedGlobal.

GNU ld has a rule "start_/stop_ references from a live input section retain the associated C identifier name sections",

which LLD may change in the future (D96914).

The phrasing "may change" implies LLD could eliminate the rule; in fact D96914 will only add a way to opt-out of the rule. You can't eliminate the rule entirely without breaking a lot of useful cases.

Thu, Feb 25, 9:24 AM · Restricted Project
Meinersbur requested changes to D97425: [Polly] Refactoring IsInnermostParallel() in ISL to take the C++ wrapper object. NFC.

The pre-merge check failed. You can find the error in its log (Usually the pre-merge check directly adds the error into this review, don't know why this did not happen here):

[3036/3231] Building CXX object tools/polly/lib/CMakeFiles/obj.Polly.dir/CodeGen/IslNodeBuilder.cpp.o
FAILED: tools/polly/lib/CMakeFiles/obj.Polly.dir/CodeGen/IslNodeBuilder.cpp.o
CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache /usr/bin/clang++ -DBUILD_EXAMPLES -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Itools/polly/lib -I/mnt/disks/ssd0/agent/llvm-project/polly/lib -Itools/polly/include -I/mnt/disks/ssd0/agent/llvm-project/polly/lib/External -I/mnt/disks/ssd0/agent/llvm-project/polly/lib/External/pet/include -I/mnt/disks/ssd0/agent/llvm-project/polly/lib/External/isl/include -Itools/polly/lib/External/isl/include -I/mnt/disks/ssd0/agent/llvm-project/polly/include -Iinclude -I/mnt/disks/ssd0/agent/llvm-project/llvm/include -gmlt -fPIC -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -fdiagnostics-color -ffunction-sections -fdata-sections -fno-exceptions -fno-rtti -O3   -fno-exceptions -fno-rtti -UNDEBUG -std=c++14 -MD -MT tools/polly/lib/CMakeFiles/obj.Polly.dir/CodeGen/IslNodeBuilder.cpp.o -MF tools/polly/lib/CMakeFiles/obj.Polly.dir/CodeGen/IslNodeBuilder.cpp.o.d -o tools/polly/lib/CMakeFiles/obj.Polly.dir/CodeGen/IslNodeBuilder.cpp.o -c /mnt/disks/ssd0/agent/llvm-project/polly/lib/CodeGen/IslNodeBuilder.cpp
/mnt/disks/ssd0/agent/llvm-project/polly/lib/CodeGen/IslNodeBuilder.cpp:765:49: error: reference to type 'const isl::ast_node' could not bind to an lvalue of type 'isl_ast_node *'
  if (Vector && IslAstInfo::isInnermostParallel(For) &&
                                                ^~~
/mnt/disks/ssd0/agent/llvm-project/polly/include/polly/CodeGen/IslAst.h:151:56: note: passing argument to parameter 'Node' here
  static bool isInnermostParallel(const isl::ast_node &Node);
                                                       ^
1 error generated.
Thu, Feb 25, 9:23 AM · Restricted Project, Restricted Project
MaskRay updated the summary of D97446: Change some addUsedGlobal to addUsedOrCompilerUsedGlobal.
Thu, Feb 25, 9:22 AM · Restricted Project
jlpeyton updated the diff for D97413: [OpenMP] Fix clang-cl build error regarding TSX intrinsics.

Since CMake's documentation states that the CMAKE_REQURIED_FLAGS variable is a string rather than a list, use simple set() to assign it.

Thu, Feb 25, 9:22 AM · Restricted Project
lebedev.ri added a comment to D97484: Don't use $ as suffix for symbol names in ThinLTOBitcodeWriter and other places.

Why isn't the solution is to fix the uses to prevent variable substitution in them?
Because of course $1 is substituted with a value of variable 1 in shell, and elsewhere.

$ c++filt _Z3foov\$123
_Z3foov$123
Thu, Feb 25, 9:21 AM · Restricted Project
ahatanak added inline comments to D96832: [Clang][Attributes] Allow not_tail_called attribute to be applied to virtual function..
Thu, Feb 25, 9:21 AM · Restricted Project
madhur13490 accepted D96081: Option to ignore assume like intrinsic uses in hasAddressTaken().
Thu, Feb 25, 9:20 AM · Restricted Project
morehouse added inline comments to D97430: [SanitizerCoverage] Drop !associated on metadata sections.
Thu, Feb 25, 9:19 AM · Restricted Project
sgraenitz updated the diff for D97338: [Orc] Use extensible RTTI for the orc::ObjectLayer class hierarchy.

Switch to extensible RTTI

Thu, Feb 25, 9:19 AM · Restricted Project
ldrumm added reviewers for D97071: [lit] Add a TAP-formatted output mode to lit: jhenderson, thopre.
Thu, Feb 25, 9:18 AM · Restricted Project
sgraenitz added a comment to D97338: [Orc] Use extensible RTTI for the orc::ObjectLayer class hierarchy.

Thanks for having a look. Yes, extensibility is a good point. I switched it to the ExtensibleRTTI implementation and it works well. It's the first use-case in LLVM so far:
https://llvm.org/docs/HowToSetUpLLVMStyleRTTI.html#rtti-for-open-class-hierarchies

Thu, Feb 25, 9:18 AM · Restricted Project
vinograd47 updated the diff for D96145: [mlir] Model MemRef memory space as Attribute.

Re-implemented the feature on top of separate "renaming" change.

Thu, Feb 25, 9:16 AM · Restricted Project
Bigcheese accepted D97461: [clang][cli] Implement '-cuid=' marshalling.

LGTM

Thu, Feb 25, 9:16 AM · Restricted Project
hans requested review of D97484: Don't use $ as suffix for symbol names in ThinLTOBitcodeWriter and other places.
Thu, Feb 25, 9:15 AM · Restricted Project
luismarques added a comment to D97274: [RISCV] replace unuseful emergency spill slot test with a mir test.

From some quick testing, it seemed that you could trim this test down a bit.
You're also adding # REQUIRES: asserts but not actually checking for any debug output.
Also, it would be nice to add a comment documenting the logic of this test, unless new CHECKs of the debug output make it more obvious.

Thu, Feb 25, 9:12 AM · Restricted Project
stephan.yichao.zhao requested review of D97483: [dfsan] Propagate origins for callsites.
Thu, Feb 25, 9:12 AM · Restricted Project, Restricted Project
echristo added a comment to D96203: [clang][patch] Modify sanitizer options names: renaming blacklist to blocklist.

Exclusion list? or exclude?

Thu, Feb 25, 9:07 AM · Restricted Project
hoy added reviewers for D97482: [CSSPGO] Deduplicating dangling pseudo probes.: wmi, davidxl, wenlei.
Thu, Feb 25, 9:07 AM · Restricted Project
hoy requested review of D97482: [CSSPGO] Deduplicating dangling pseudo probes..
Thu, Feb 25, 9:06 AM · Restricted Project
njames93 updated the diff for D97415: [clang-tidy] Move Checkname out of Diagnostic Message.

Typo.

Thu, Feb 25, 9:06 AM · Restricted Project
hoy added reviewers for D97481: [CSSPGO] Unblocking optimizations by dangling pseudo probes.: wmi, davidxl, wenlei.
Thu, Feb 25, 9:06 AM · Restricted Project
craig.topper committed rGceaedfb5fc3a: [X86] Remove custom lowering of vXi1 ADD/SUB now that they are canonicalized to… (authored by craig.topper).
[X86] Remove custom lowering of vXi1 ADD/SUB now that they are canonicalized to…
Thu, Feb 25, 9:06 AM
craig.topper closed D97478: [X86] Remove custom lowering of vXi1 ADD/SUB now that they are canonicalized to XOR in getNode..
Thu, Feb 25, 9:05 AM · Restricted Project
hoy requested review of D97481: [CSSPGO] Unblocking optimizations by dangling pseudo probes..
Thu, Feb 25, 9:05 AM · Restricted Project
hoy updated the summary of D95962: [CSSPGO] Introducing dangling pseudo probes..
Thu, Feb 25, 9:05 AM · Restricted Project
ldionne accepted D97458: [libcxx] [test] Use string().c_str() to convert a std::filesystem::path to a const char*.
Thu, Feb 25, 9:05 AM · Restricted Project
hoy updated the diff for D95962: [CSSPGO] Introducing dangling pseudo probes..

Splitting patches.

Thu, Feb 25, 9:04 AM · Restricted Project
hoy added a comment to D95962: [CSSPGO] Introducing dangling pseudo probes..
In D95962#2586842, @wmi wrote:

Thanks for the detailed description. That really helps for better understanding the patch.

The patch includes multiple essential changes. Is it possible to split them? Like pseudo move, unblocking optimizations, and deduplicating are relatively standalone changes and it is better to make their impact isolated from each other.

Thu, Feb 25, 9:03 AM · Restricted Project
RKSimon added inline comments to D94395: [X86] AMD Znver3 Scheduler descriptions and llvm-mca tests.
Thu, Feb 25, 9:02 AM · Restricted Project
RedDocMD updated the diff for D96976: [analyzer] Fix reinterpret_cast handling for pointer-to-member.

Added some more comments to increase clarity

Thu, Feb 25, 9:02 AM · Restricted Project
clementval added inline comments to D91920: [Flang] [OpenMP] Add semantic checks for OpenMP firstprivate , lastprivate and copyprivate clauses.
Thu, Feb 25, 9:00 AM · Restricted Project, Restricted Project, Restricted Project
mibintc updated the diff for D96203: [clang][patch] Modify sanitizer options names: renaming blacklist to blocklist.

I rebased the patch and basically made no other changes. On the review there's a suggestion that 'blocklist' isn't the best word choice, do you have suggestions?

Thu, Feb 25, 8:57 AM · Restricted Project
RedDocMD updated the diff for D96976: [analyzer] Fix reinterpret_cast handling for pointer-to-member.

Added test for multiple inheritance

Thu, Feb 25, 8:56 AM · Restricted Project
a.elovikov added a comment to D96628: [VPlan] Add plain text (not DOT's digraph) dumps.

Ping

Thu, Feb 25, 8:55 AM · Restricted Project
HsiangKai added reviewers for D97480: [RISCV] Support inline asm for vector instructions.: craig.topper, frasercrmck, rogfer01, kito-cheng.
Thu, Feb 25, 8:54 AM · Restricted Project
HsiangKai requested review of D97480: [RISCV] Support inline asm for vector instructions..
Thu, Feb 25, 8:53 AM · Restricted Project
craig.topper added inline comments to D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics..
Thu, Feb 25, 8:51 AM · Restricted Project, Restricted Project