Page MenuHomePhabricator

Recent Activity

Today

craig.topper accepted D99362: Verify the LLVMContext for Attributes..

LGTM

Thu, Apr 15, 5:21 PM · Restricted Project
cmtice added a reverting change for rGb241f3cb292d: [LLDB] Use path relative to binary for finding .dwo files.: rG042668d092bb: Revert "[LLDB] Use path relative to binary for finding .dwo files.".
Thu, Apr 15, 5:19 PM
cmtice committed rG042668d092bb: Revert "[LLDB] Use path relative to binary for finding .dwo files." (authored by cmtice).
Revert "[LLDB] Use path relative to binary for finding .dwo files."
Thu, Apr 15, 5:19 PM
cmtice added a reverting change for D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files.: rG042668d092bb: Revert "[LLDB] Use path relative to binary for finding .dwo files.".
Thu, Apr 15, 5:19 PM · Restricted Project, Restricted Project, Restricted Project
jdoerfert added a comment to D95976: [OpenMP] Simplify offloading parallel call codegen.

I have only minor remarks but I'd like you to check if my hunch is correct and the proposed modifications will fix fix PR49777 *and* fix PR49779.
Also, the number of arguments need to be increased, let's go big and automatic here.

Thu, Apr 15, 5:14 PM · Restricted Project, Restricted Project, Restricted Project
rsmith committed rG834467590842: Implemented [[clang::musttail]] attribute for guaranteed tail calls. (authored by haberman).
Implemented [[clang::musttail]] attribute for guaranteed tail calls.
Thu, Apr 15, 5:13 PM
rsmith closed D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls..
Thu, Apr 15, 5:13 PM · Restricted Project
stella.stamenova added a comment to D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files..

This broke the windows LLDB bot. Please fix it soon or revert.

Thu, Apr 15, 5:12 PM · Restricted Project, Restricted Project, Restricted Project
stephan.yichao.zhao accepted D100608: [dfsan] Remove hard-coded constant in release_shadow_space.c.
Thu, Apr 15, 5:04 PM · Restricted Project, Restricted Project
yonghong-song updated the diff for D100567: BPF: emit debuginfo for Function of DeclRefExpr if requested.

Rename TargetInfo.allowDebugInfoForExternalVar to TargetInfo.allowDebugInfoForExternalRef.

Thu, Apr 15, 5:00 PM · Restricted Project, debug-info
cjdb committed rGf280505aa084: [libcxx] adds `std::indirectly_readable_traits` to <iterator> (authored by cjdb).
[libcxx] adds `std::indirectly_readable_traits` to <iterator>
Thu, Apr 15, 5:00 PM
cjdb closed D99461: [libcxx] adds `std::indirectly_readable_traits` to <iterator>.
Thu, Apr 15, 4:59 PM · Restricted Project
aeubanks committed rG9c776c2fa2bd: [NFC][NewPM] Remove some AnalysisManager invalidate methods (authored by aeubanks).
[NFC][NewPM] Remove some AnalysisManager invalidate methods
Thu, Apr 15, 4:57 PM
aeubanks closed D100519: [NFC][NewPM] Remove some AnalysisManager invalidate methods.
Thu, Apr 15, 4:57 PM · Restricted Project
cjdb added inline comments to D99855: [libcxx] makes `iterator_traits` C++20-aware.
Thu, Apr 15, 4:56 PM · Restricted Project
paquette added inline comments to D100398: [AArch64][GlobalISel] Regbankselect + select @llvm.aarch64.neon.uaddlv.
Thu, Apr 15, 4:54 PM · Restricted Project
jdoerfert added a comment to D100609: [Offload][OpenMP][CUDA] Allow fembed-bitcode for device offload.

I'm not really sure about the test, my local setup didn't have CUDA attached properly but this should work in principle ;)

Thu, Apr 15, 4:54 PM · Restricted Project
jdoerfert requested review of D100609: [Offload][OpenMP][CUDA] Allow fembed-bitcode for device offload.
Thu, Apr 15, 4:53 PM · Restricted Project
lxfind added a comment to D97673: [RFC] [[Coroutine] [Debug] Salvage dbg.value at O2.

Also, it seems that the newly added test "coro-debug-dbg.values-O2-nouse.ll" passes even without this patch

Thu, Apr 15, 4:53 PM · debug-info, Restricted Project
gbalats requested review of D100608: [dfsan] Remove hard-coded constant in release_shadow_space.c.
Thu, Apr 15, 4:53 PM · Restricted Project, Restricted Project
mehdi_amini accepted D100607: [mlir] Add a vscode language extension for MLIR.
Thu, Apr 15, 4:52 PM · Restricted Project
jdoerfert added a comment to D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.

I only have small nits, nothing major. @fghanim, is this OK with you, if so, please accept?

Thu, Apr 15, 4:52 PM · Restricted Project, Restricted Project
mehdi_amini added a comment to D100607: [mlir] Add a vscode language extension for MLIR.

If it works, that'll be good enough for me :)

Thu, Apr 15, 4:52 PM · Restricted Project
lxfind added a comment to D97673: [RFC] [[Coroutine] [Debug] Salvage dbg.value at O2.

Could you update the description of this patch as well?
It's still not fully clear to me what problem this patch is aiming at resolving.

Thu, Apr 15, 4:52 PM · debug-info, Restricted Project
rsmith accepted D99517: Implemented [[clang::musttail]] attribute for guaranteed tail calls..
Thu, Apr 15, 4:47 PM · Restricted Project
aralisza updated the diff for D100234: [compiler-rt][asan] use full vm range on apple silicon macs.

remove trailing whitespace

Thu, Apr 15, 4:47 PM · Restricted Project
aralisza updated the diff for D100239: [compiler-rt] assert max virtual address is <= mmap range size.

remove trailing whitesepace

Thu, Apr 15, 4:46 PM · Restricted Project
aralisza updated the summary of D100234: [compiler-rt][asan] use full vm range on apple silicon macs.
Thu, Apr 15, 4:45 PM · Restricted Project
aemerson added inline comments to D100398: [AArch64][GlobalISel] Regbankselect + select @llvm.aarch64.neon.uaddlv.
Thu, Apr 15, 4:43 PM · Restricted Project
aralisza added a reviewer for D100239: [compiler-rt] assert max virtual address is <= mmap range size: kubamracek.
Thu, Apr 15, 4:43 PM · Restricted Project
aralisza retitled D100239: [compiler-rt] assert max virtual address is <= mmap range size from [draft][compiler-rt]assert max virtual address is less than mmap range size to [compiler-rt] assert max virtual address is <= mmap range size.
Thu, Apr 15, 4:43 PM · Restricted Project
mehdi_amini committed rG102fd1cb8b40: Add support for numpy arrays to memref conversions. (authored by pashu123).
Add support for numpy arrays to memref conversions.
Thu, Apr 15, 4:41 PM
mehdi_amini closed D100077: Add support for numpy arrays to memref conversions..
Thu, Apr 15, 4:41 PM · Restricted Project
aralisza updated the diff for D100239: [compiler-rt] assert max virtual address is <= mmap range size.

rebase

Thu, Apr 15, 4:41 PM · Restricted Project
dexonsmith accepted D99362: Verify the LLVMContext for Attributes..

LGTM, assuming @craig.topper is also happy.

Thu, Apr 15, 4:38 PM · Restricted Project
aralisza updated the diff for D100234: [compiler-rt][asan] use full vm range on apple silicon macs.

use larger address space for iossim

Thu, Apr 15, 4:38 PM · Restricted Project
dexonsmith accepted D100536: [clang][deps] NFC: Remove unused FullDependencies member.

LGTM.

Thu, Apr 15, 4:36 PM · Restricted Project
rriddle requested review of D100607: [mlir] Add a vscode language extension for MLIR.
Thu, Apr 15, 4:35 PM · Restricted Project
echristo updated subscribers of D98508: Restore lit feature object-emission.

SGTM. :)

Thu, Apr 15, 4:35 PM · Restricted Project
dexonsmith added inline comments to D100534: [clang][deps] Generate the full command-line for modules.
Thu, Apr 15, 4:35 PM · Restricted Project