Page MenuHomePhabricator

Recent Activity

Yesterday

MaskRay accepted D106760: [AArch64] Fix Local Deallocation for Homogeneous Prolog/Epilog.
Sat, Jul 24, 11:46 PM · Restricted Project
chrisjackson updated the diff for D105207: [debuginfo][lsr] SCEV-based salvaging for LoopStrengthReduction.

Apply changes in response to @jmorse's review. Additionally:

  • Make LSR IV vector private and add accessor.
  • Collapse shortened PushCast() into PushSCEV().
  • Fix formatting.
  • Fix a mistake in pushSCEV()'s call to pushArithmeticImpl().
Sat, Jul 24, 11:31 PM · debug-info, Restricted Project
kyulee updated the diff for D106760: [AArch64] Fix Local Deallocation for Homogeneous Prolog/Epilog.

Update the change

Sat, Jul 24, 11:17 PM · Restricted Project
MaskRay added inline comments to D106760: [AArch64] Fix Local Deallocation for Homogeneous Prolog/Epilog.
Sat, Jul 24, 10:46 PM · Restricted Project
jdoerfert added a comment to D106720: [WIP][Attributor] AAFunctionReachability, Instruction reachability..

Add doxygen docu to the functions to describe what they do.

Sat, Jul 24, 10:32 PM · Restricted Project
jdoerfert added a comment to D106742: [SimplifyCFG] Improve store speculation check.

looks reasonable to me.

Sat, Jul 24, 10:26 PM · Restricted Project
jdoerfert accepted D106707: [OpenMP] Introduce RAII to protect certain RTL calls from DCE.

LG, two nits.

Sat, Jul 24, 10:26 PM · Restricted Project
Conanap added a comment to D106757: [PowerPC] Implement partial vector ld/st builtins for XL compatibility.

do we need an IR -> ASM test case as well?

Sat, Jul 24, 9:32 PM · Restricted Project
sbc100 accepted D106728: [lld][WebAssembly] Do not remove name section with --strip-debug.
Sat, Jul 24, 9:30 PM · Restricted Project
Conanap added inline comments to D106757: [PowerPC] Implement partial vector ld/st builtins for XL compatibility.
Sat, Jul 24, 9:24 PM · Restricted Project
kyulee updated the diff for D106760: [AArch64] Fix Local Deallocation for Homogeneous Prolog/Epilog.

Update the change per feedbacks.

Sat, Jul 24, 9:08 PM · Restricted Project
HassanElDesouky added a comment to D102590: [YAMLParser] Add multi-line literal folding support.

@dexonsmith Sorry for the ping, but this has been in review for so long. Can you review when you have the time?

Sat, Jul 24, 9:06 PM · Restricted Project
jdoerfert added a comment to D106687: [OpenMP] Only register HeapToShared in the OpenMPOpt module pass.

We should instead keep noinline on them till the CGSCC pass, at least for this one as it could trigger late even if it wasn't possible early.

But we run the Module pass and CGSCC passes at different optimization levels right now. It's possible that H2S could remove something after more optimizations, but I haven't seen any examples of something failing to be moved to the stack because of optimizations.

Sat, Jul 24, 9:01 PM · Restricted Project
MaskRay added a comment to D106760: [AArch64] Fix Local Deallocation for Homogeneous Prolog/Epilog.

LG

Sat, Jul 24, 9:01 PM · Restricted Project
jhuber6 added a comment to D106687: [OpenMP] Only register HeapToShared in the OpenMPOpt module pass.

We should instead keep noinline on them till the CGSCC pass, at least for this one as it could trigger late even if it wasn't possible early.

Sat, Jul 24, 8:48 PM · Restricted Project
MarcusJohnson91 updated the diff for D106753: ConvertUTF: Created wrapper convertUTF32ToUTF8String.

Added tests

Sat, Jul 24, 8:39 PM · Restricted Project, Restricted Project
evandro updated the diff for D98002: [RISCV] Add scheduling resources for V.

Add the scheduling resources for the V extension loads and stores.

Sat, Jul 24, 8:30 PM · Restricted Project
jdoerfert added a comment to D106687: [OpenMP] Only register HeapToShared in the OpenMPOpt module pass.

We should instead keep noinline on them till the CGSCC pass, at least for this one as it could trigger late even if it wasn't possible early.

Sat, Jul 24, 8:18 PM · Restricted Project
MarcusJohnson91 updated the diff for D106753: ConvertUTF: Created wrapper convertUTF32ToUTF8String.

Added tests

Sat, Jul 24, 8:13 PM · Restricted Project, Restricted Project
jdoerfert accepted D106710: [OpenMP][NVPTX] Disable OpenMPOpt when building deviceRTLs.

LGTM

Sat, Jul 24, 8:10 PM · Restricted Project
jdoerfert added a comment to D106674: Runtime for Interop directive.

There are a lot of minor things that should be easily addressable.

Sat, Jul 24, 7:39 PM · Restricted Project
t-tye added inline comments to D106736: Minor Sphinx documentation generation improvements.
Sat, Jul 24, 7:17 PM · Restricted Project, Restricted Project
t-tye updated the diff for D106736: Minor Sphinx documentation generation improvements.

Remove mention of easy_install as deprecated. MacOS still appears to only come with easy_install.

Sat, Jul 24, 7:13 PM · Restricted Project, Restricted Project
kyulee added reviewers for D106760: [AArch64] Fix Local Deallocation for Homogeneous Prolog/Epilog: MaskRay, plotfi, dmgreen, lanza, t.p.northover.
Sat, Jul 24, 6:55 PM · Restricted Project
kyulee updated the diff for D106760: [AArch64] Fix Local Deallocation for Homogeneous Prolog/Epilog.

Update the change per feedbacks.

Sat, Jul 24, 6:45 PM · Restricted Project
MaskRay requested changes to D89074: [SystemZ/z/OS] Add GOFF support for llvm-objdump.

Thanks for the patch.

Sat, Jul 24, 5:30 PM · Restricted Project
MaskRay added inline comments to D106760: [AArch64] Fix Local Deallocation for Homogeneous Prolog/Epilog.
Sat, Jul 24, 5:26 PM · Restricted Project
aqjune added a comment to D105344: [DAGCombiner] Fold SETCC(FREEZE(x),const) to FREEZE(SETCC(x,const)) if SETCC is used by BRCOND.

ping

Sat, Jul 24, 5:04 PM · Restricted Project
MaskRay updated subscribers of D106759: [yaml2obj][MachO] Rename PayloadString to Content.
Sat, Jul 24, 4:54 PM · Restricted Project, Restricted Project
aemerson committed rGacbc0c5f0ebd: [AArch64][GlobalISel] Widen non-pow-2 types for shifts before clamping. (authored by aemerson).
[AArch64][GlobalISel] Widen non-pow-2 types for shifts before clamping.
Sat, Jul 24, 3:51 PM
MaskRay added inline comments to D106701: [clang] Add -falign-loops=N where N is a power of 2.
Sat, Jul 24, 3:45 PM · Restricted Project, Restricted Project
kyulee retitled D106760: [AArch64] Fix Local Deallocation for Homogeneous Prolog/Epilog from Fix Local Deallocation for Homogeneous Prolog/Epilog to [AArch64] Fix Local Deallocation for Homogeneous Prolog/Epilog.
Sat, Jul 24, 3:41 PM · Restricted Project
kyulee requested review of D106760: [AArch64] Fix Local Deallocation for Homogeneous Prolog/Epilog.
Sat, Jul 24, 3:39 PM · Restricted Project
luismarques added inline comments to D106701: [clang] Add -falign-loops=N where N is a power of 2.
Sat, Jul 24, 3:38 PM · Restricted Project, Restricted Project
MaskRay added a comment to D106733: [clang/darwin] Pass libclang_rt.profile last on linker command.

LG

Sat, Jul 24, 3:32 PM
josemonsalve2 added inline comments to D106751: [OpenMP][Libomptarget] Adding `print_device_info` to RTL and `omptarget`.
Sat, Jul 24, 3:22 PM · Restricted Project
josemonsalve2 added a comment to D106751: [OpenMP][Libomptarget] Adding `print_device_info` to RTL and `omptarget`.

Not obvious to me that the functionality has much to do with the plugin. Could do a standalone tool instead?

I think there's a tool called nvidia-smi that does something similar. There's definitely one called rocminfo that does. The latter prints 'human readable' output, which gets in the way of scripting with it.

Sat, Jul 24, 3:21 PM · Restricted Project
MaskRay requested review of D106759: [yaml2obj][MachO] Rename PayloadString to Content.
Sat, Jul 24, 2:55 PM · Restricted Project, Restricted Project
MaskRay requested changes to D106334: Initialize common options in `getRegisteredOptions`.

(unittest request)

Sat, Jul 24, 2:40 PM · Restricted Project
MaskRay requested changes to D105527: libclang.so: Make SONAME independent from LLVM version.
Sat, Jul 24, 2:39 PM · Restricted Project