Page MenuHomePhabricator

Recent Activity

Today

mehdi_amini accepted D92165: Don't elide splat attributes during printing.
Thu, Nov 26, 8:00 PM · Restricted Project
Esme updated the diff for D90131: [PowerPC] Add folding patterns for rlwinm + andi_rec..

Added the situation of Mask == 0.

Thu, Nov 26, 7:55 PM · Restricted Project
psionic12 added a comment to D92155: Load plugins when creating a CompilerInvocation..

clangd (and other clang tools) get deployed in environments where all access to the filesystem goes through a llvm::vfs::Filesystem, and all filenames referred to in the compile command are within that virtual filesystem rather than the real one.
(Again, this isn't an issue if we require these paths to be specified on the *clangd* startup command line, as opposed to the clang flags that form the compile command)

Thu, Nov 26, 7:17 PM · Restricted Project
airlied updated the diff for D92004: [OpenCL] add CL 3.0 optional feature support to opencl-c.h.

I've moved a bunch of longer checks into just feature checks and defined the features at the top of the file.

Thu, Nov 26, 7:16 PM · Restricted Project
TaoPan updated the diff for D92073: [CodeGen] Add text section prefix for COFF object file.

Fix lit failures and update test case for checking text section prefix.

Thu, Nov 26, 7:12 PM · Restricted Project
kbobyrev committed rGabfcb606c2f8: [clangd] Add support for within-file rename of complicated fields (authored by kbobyrev).
[clangd] Add support for within-file rename of complicated fields
Thu, Nov 26, 7:00 PM
kbobyrev closed D91952: [clangd] Add support for within-file rename of complicated fields.
Thu, Nov 26, 6:59 PM · Restricted Project
xndcn updated the diff for D92041: [clangd] Add hover info for `this` expr.

Thanks. Update commit to fix the last nit.

Thu, Nov 26, 6:57 PM · Restricted Project, Restricted Project
kbobyrev requested review of D92202: [clangd] Add symbol origin for remote index.
Thu, Nov 26, 6:51 PM · Restricted Project
steven.zhang added a comment to D92139: [PowerPC] Add `hasSideEffects=0` for PLXVP and PSTXVP instructions definition .

I think, this patch isn't needed any more as we have already specify the match patter for these instructions and tblgen will infer the sideeffects from the patter. See what we get from tblgen now(we didn't have the sideeffect bit):

{ 1191,       3,      1,      4,      39,     0|(1ULL<<MCID::MayLoad), 0x0ULL, nullptr, nullptr, OperandInfo158 },  // Inst #1191 = LXVP
Thu, Nov 26, 6:48 PM · Restricted Project
kbobyrev requested review of D92201: [clangd] Make sure project-aware index is up-to-date for estimateMemoryUsage().
Thu, Nov 26, 6:32 PM · Restricted Project
reames added a comment to D91711: SCEV add function to see if SCEVUnknown is null.

Skimming the review and discussion, I think this patch is moving in the wrong direction. The basic issue appears to be that a pass is holding on to the result of an analysis after mutating the IR without appropriately updating the cached information. That's a bug for any analysis, not just SCEV. Say you held a pointer to a Loop object and then broke the backedge in the IR; that's a bug. I will admit that the existing SCEV code appears to support some mutation of the IR, but replace all uses with is different from true deletion.

Thu, Nov 26, 6:31 PM · Restricted Project
psionic12 added a comment to D92006: Refactoring the attrubute plugin example to fit the new API.

ping

Thu, Nov 26, 6:23 PM · Restricted Project
qiucf added a comment to D92083: Legalize the SETCC/STRICT_FSETCCS as libcall.

Thanks for the work! I thought code to 'unfold' SELECT_CC and BR_CC should exist in generic code..

Thu, Nov 26, 6:22 PM · Restricted Project
steven.zhang added a comment to D92067: [PowerPC] Promote the i1 to i64 for SINT_TO_FP/FP_TO_SINT.

After applying this patch, I enumerated signed/unsigned conversion between i1~i128 and f32/f64/f128/ppcf128, only ppcf128-i1 still crashes:

define i1 @pq_s1(ppc_fp128 %a) {
  %b = fptosi ppc_fp128 %a to i1
  ret i1 %b
}

define i1 @pq_u1(ppc_fp128 %a) {
  %b = fptoui ppc_fp128 %a to i1
  ret i1 %b
}
Assertion failed: (LC != RTLIB::UNKNOWN_LIBCALL && "Unsupported FP_TO_SINT!"), function ExpandFloatOp_FP_TO_SINT, file llvm-project/llvm/lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp

Similar promotion can also fix this?

Thu, Nov 26, 6:20 PM · Restricted Project
steven.zhang committed rG4d83aba4228e: [DAGCombine] Adding a hook to improve the precision of fsqrt if the input is… (authored by steven.zhang).
[DAGCombine] Adding a hook to improve the precision of fsqrt if the input is…
Thu, Nov 26, 6:14 PM
steven.zhang closed D80974: [DAGCombine] Adding a hook to improve the precision of fsqrt if the input is denormal.
Thu, Nov 26, 6:13 PM · Restricted Project
TOCK added a comment to D76127: [TableGen] Do not set ReadOnly attribute on intrinsics with side effects.

The diffs lack context.

This patch is some kind of follow-up of D64414, which make TableGen stop emitting Attribute::ReadNone for IntrNoMem if such intrinsic is marked as IntrHasSideEffects. This patch does the same for other cases like IntrReadMem.

Thu, Nov 26, 6:12 PM · Restricted Project
kbobyrev updated the diff for D92198: [clangd] Implement remote index handshake.

Remove unused header.

Thu, Nov 26, 6:08 PM · Restricted Project
kbobyrev updated the summary of D92198: [clangd] Implement remote index handshake.
Thu, Nov 26, 6:07 PM · Restricted Project
kbobyrev updated the diff for D92198: [clangd] Implement remote index handshake.

This is working now. However, the handshake is actually deferred for
ProjectAwareIndex until the first request. I tried to invoke it via something
like Opts.StaticIdx->estimateMemoryUsage() in ClangdMain.cpp but the
problem is getIndex() will return nullptr until the Config::current is
ready. I'm not entirely sure when this happens so I can't promote handshake to
some sensible time point yet.

Thu, Nov 26, 6:06 PM · Restricted Project
steven.zhang updated the diff for D91675: [PowerPC][FP128] Fix the incorrect signature for math library call.

Address comments.

Thu, Nov 26, 6:06 PM · Restricted Project
steven.zhang added inline comments to D91675: [PowerPC][FP128] Fix the incorrect signature for math library call.
Thu, Nov 26, 6:04 PM · Restricted Project
kazu committed rG60e749aa2348: [InlineCost] Fix indentation (NFC) (authored by kazu).
[InlineCost] Fix indentation (NFC)
Thu, Nov 26, 6:01 PM
pengfei added inline comments to D92183: [DAG] Legalize umin(x,y) -> sub(x,usubsat(x,y)) and umax(x,y) -> add(x,usubsat(y,x)) iff usubsat is legal.
Thu, Nov 26, 5:36 PM · Restricted Project
mehdi_amini added inline comments to D92166: [mlir][LLVMIR] Add support for InlineAsmOp.
Thu, Nov 26, 5:35 PM · Restricted Project
mehdi_amini added a comment to D92192: Fix appending-zero issues.

Can you please elaborate with some context in the description?

Thu, Nov 26, 5:32 PM · Restricted Project
glandium added a comment to D72420: [LoopRotate] Add support for rotating loops with switch exit.

FWIW, when applying this patch on a LLVM10-based rustc, the rustc build fails with:

PHI node has multiple entries for the same basic block with different incoming values!
  %35 = phi { i64*, i32 }* [ %83, %77 ], [ %84, %77 ], [ %33, %2 ]
label %77
  %83 = getelementptr { i64*, i32 }, { i64*, i32 }* %35, i64 -1
  %84 = getelementptr { i64*, i32 }, { i64*, i32 }* %35, i64 -1
in function _ZN80_$LT$alloc..vec..Vec$LT$T$GT$$u20$as$u20$alloc..vec..SpecExtend$LT$T$C$I$GT$$GT$9from_iter17h62b0d0798a862a64E
LLVM ERROR: Broken function found, compilation aborted!
error: could not compile `rustc_typeck`.
Thu, Nov 26, 5:32 PM · Restricted Project
aqjune committed rG2e32c49d974f: [LangRef] Add poison constant (authored by aqjune).
[LangRef] Add poison constant
Thu, Nov 26, 5:30 PM
aqjune closed D92162: [LangRef] Add poison constant.
Thu, Nov 26, 5:30 PM · Restricted Project
aqjune updated the diff for D92162: [LangRef] Add poison constant.

update

Thu, Nov 26, 5:29 PM · Restricted Project
mehdi_amini accepted D92193: Use bool in place of int for boolean things in the C API.

If this builds with MSVC nowadays, then LGTM :)

Thu, Nov 26, 5:27 PM · Restricted Project
guopeilin updated the diff for D91512: [AArch64][Isel] Avoid implicit zext for SIGN_EXTEND_INREG ( TRUNCATE ).
Thu, Nov 26, 5:20 PM · Restricted Project
mehdi_amini accepted D92188: [MLIR][SCF] Find all innermost loops for prarallel loop tiling.

You have two typos in the commit message: prarallel in the title and assumtion in the description.

Thu, Nov 26, 4:53 PM · Restricted Project
mehdi_amini added a comment to D92172: [mlir][SVE][RFC] Add an SVE dialect.

This is really nice to see this, thanks for the contribution!

Thu, Nov 26, 4:28 PM · Restricted Project
mehdi_amini added inline comments to D92172: [mlir][SVE][RFC] Add an SVE dialect.
Thu, Nov 26, 4:27 PM · Restricted Project
njames93 added inline comments to D92133: [clangd] Cache .clang-tidy files again..
Thu, Nov 26, 4:26 PM · Restricted Project
kbobyrev updated the diff for D92198: [clangd] Implement remote index handshake.

Remove some logs.

Thu, Nov 26, 4:25 PM · Restricted Project
kbobyrev planned changes to D92198: [clangd] Implement remote index handshake.

This is not working properly yet.

Thu, Nov 26, 4:21 PM · Restricted Project
kbobyrev requested review of D92198: [clangd] Implement remote index handshake.
Thu, Nov 26, 4:20 PM · Restricted Project