Page MenuHomePhabricator

AMDChirag (Chirag Khandelwal)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 24 2020, 8:34 AM (22 w, 7 h)

Recent Activity

Today

AMDChirag added inline comments to D97457: [flang][driver] Add `-fdebug-dump-parsing-log`.
Thu, Feb 25, 7:26 AM · Restricted Project, Restricted Project
AMDChirag added inline comments to D97457: [flang][driver] Add `-fdebug-dump-parsing-log`.
Thu, Feb 25, 3:45 AM · Restricted Project, Restricted Project

Mon, Feb 8

AMDChirag added a comment to D91054: [Clang][OpenMP] Frontend work for sections - D89671.

@fghanim @jdoerfert please review the code if/when possible.

Mon, Feb 8, 3:42 AM · Restricted Project

Jan 25 2021

AMDChirag updated the diff for D91054: [Clang][OpenMP] Frontend work for sections - D89671.

Added FIXME comment for cancellation construct not working with sections construct
Also updated the lit test cases to reflect this change.
The lit test case modification will be removed once this issue is resolved.

Jan 25 2021, 12:41 PM · Restricted Project
AMDChirag updated the diff for D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.

Added IsCancellable parameter to EmitOMPInlinedRegion for sections construct.
Even after which, the cancel construct is causing an assertion failure.
For now, this is marked as an expected failure and the FIXME comment is available.
The clang test case (marked XFAIL) is available in frontend patch - D91054.

Jan 25 2021, 9:38 AM · Restricted Project, Restricted Project

Jan 18 2021

AMDChirag abandoned D94373: [LLVM][OpenMP] Added OMP Scheduler Constants (Required for D89671).
Jan 18 2021, 2:36 AM · Restricted Project

Jan 11 2021

AMDChirag added a comment to D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.

Currently cancellation clause is failing to work, within sections directive. Working on it.

Jan 11 2021, 6:01 AM · Restricted Project, Restricted Project
AMDChirag updated the diff for D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.

removed the accidentally added test statement

Jan 11 2021, 2:38 AM · Restricted Project, Restricted Project

Jan 10 2021

AMDChirag updated the diff for D91054: [Clang][OpenMP] Frontend work for sections - D89671.

Added OMP delegating code for createSection (EmitOMPSectionDirective).
@fghanim working on clang lit test case.

Jan 10 2021, 11:12 PM · Restricted Project
AMDChirag updated the diff for D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.

Address a comment.

Jan 10 2021, 10:20 PM · Restricted Project, Restricted Project
AMDChirag updated the diff for D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.

Added the use of createCanonicalLoop and createStaticWorkshareLoop.
Created OMP.createSection for handling the section's code generation.
Section callbacks are no longer a part of createSections.
Modified EmitOMPInlinedRegion to be able to handle nullptr for EntryCall/ExitCall parameters.
Removed changes from OMPConstants.hpp and OMPKinds.def to, originally, move to separate differential, but now are not required since loop creation is handled with createCanonicalLoop and createStaticWorkshareLoop.
OMP.createSections no longer uses EmitOMPInlinedRegion.

Jan 10 2021, 10:16 PM · Restricted Project, Restricted Project
AMDChirag added a comment to D94373: [LLVM][OpenMP] Added OMP Scheduler Constants (Required for D89671).

Please don't merge this differential.
With new changes being done in D89671, this will probably no longer be required.

Jan 10 2021, 9:50 PM · Restricted Project
AMDChirag updated the diff for D94373: [LLVM][OpenMP] Added OMP Scheduler Constants (Required for D89671).

Addressing comment

Jan 10 2021, 9:29 PM · Restricted Project

Jan 9 2021

AMDChirag updated subscribers of D94373: [LLVM][OpenMP] Added OMP Scheduler Constants (Required for D89671).
Jan 9 2021, 10:50 PM · Restricted Project
AMDChirag requested review of D94373: [LLVM][OpenMP] Added OMP Scheduler Constants (Required for D89671).
Jan 9 2021, 10:49 PM · Restricted Project
AMDChirag added inline comments to D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.
Jan 9 2021, 9:02 PM · Restricted Project, Restricted Project

Jan 8 2021

AMDChirag added a comment to D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.
Jan 8 2021, 6:08 AM · Restricted Project, Restricted Project
AMDChirag updated subscribers of D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.
Jan 8 2021, 5:51 AM · Restricted Project, Restricted Project

Jan 7 2021

AMDChirag added a comment to D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.

@jdoerfert Ouch. Totally forgot about that, apologies, on it.
Would it be fine/better to have the change for that in a separate patch though? Or must it be a part of this patch itself?

Jan 7 2021, 10:01 AM · Restricted Project, Restricted Project
AMDChirag added a comment to D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.
Jan 7 2021, 9:12 AM · Restricted Project, Restricted Project

Dec 22 2020

AMDChirag updated the diff for D91054: [Clang][OpenMP] Frontend work for sections - D89671.

Updated BGenCallbackTy to StorableBodyGenCallbackTy.

Dec 22 2020, 5:27 AM · Restricted Project
AMDChirag updated the diff for D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.

Updated information for StoredBodyGenCallbackTy

Dec 22 2020, 5:24 AM · Restricted Project, Restricted Project
AMDChirag updated the diff for D91054: [Clang][OpenMP] Frontend work for sections - D89671.

Updated code according to the changes in LLVM side of things.

Dec 22 2020, 5:11 AM · Restricted Project
AMDChirag updated the diff for D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.

Updated code, test case, fixed some issues

Dec 22 2020, 5:05 AM · Restricted Project, Restricted Project

Dec 2 2020

AMDChirag added inline comments to D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.
Dec 2 2020, 10:30 PM · Restricted Project, Restricted Project

Nov 24 2020

AMDChirag added inline comments to D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.
Nov 24 2020, 10:41 PM · Restricted Project, Restricted Project

Nov 23 2020

AMDChirag added inline comments to D91054: [Clang][OpenMP] Frontend work for sections - D89671.
Nov 23 2020, 4:33 AM · Restricted Project
AMDChirag updated the diff for D91054: [Clang][OpenMP] Frontend work for sections - D89671.

Fixed usage of BodyGenCallbackTy
Removed ArrayRef variable

Nov 23 2020, 3:16 AM · Restricted Project

Nov 17 2020

AMDChirag updated the diff for D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.

Added FiniCB usage and Control Flow Graph

Nov 17 2020, 6:47 AM · Restricted Project, Restricted Project

Nov 9 2020

AMDChirag added inline comments to D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.
Nov 9 2020, 1:36 AM · Restricted Project, Restricted Project
AMDChirag added inline comments to D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.
Nov 9 2020, 1:33 AM · Restricted Project, Restricted Project
AMDChirag added a comment to D91054: [Clang][OpenMP] Frontend work for sections - D89671.

The test case will also be added here.

Nov 9 2020, 1:30 AM · Restricted Project
AMDChirag retitled D91054: [Clang][OpenMP] Frontend work for sections - D89671 from [LLVM][OpenMP] Frontend work for sections - D89671 to [Clang][OpenMP] Frontend work for sections - D89671.
Nov 9 2020, 1:15 AM · Restricted Project
AMDChirag requested review of D91054: [Clang][OpenMP] Frontend work for sections - D89671.
Nov 9 2020, 1:03 AM · Restricted Project

Nov 5 2020

AMDChirag updated the diff for D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.

Minor corrections in naming

Nov 5 2020, 7:47 AM · Restricted Project, Restricted Project

Nov 3 2020

AMDChirag updated the diff for D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.

squashed the commits

Nov 3 2020, 12:56 AM · Restricted Project, Restricted Project

Nov 2 2020

AMDChirag updated the diff for D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.

Applied some review changes

Nov 2 2020, 5:23 AM · Restricted Project, Restricted Project

Oct 21 2020

AMDChirag updated the diff for D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.

Amended the original commit, applying the fixes:

Oct 21 2020, 1:46 AM · Restricted Project, Restricted Project
AMDChirag updated the diff for D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.
Oct 21 2020, 1:39 AM · Restricted Project, Restricted Project
AMDChirag updated the diff for D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.
Oct 21 2020, 12:47 AM · Restricted Project, Restricted Project

Oct 19 2020

AMDChirag added a comment to D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.

@fghanim Hello and thank you!

Oct 19 2020, 9:02 PM · Restricted Project, Restricted Project
AMDChirag retitled D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder from [Flang][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder to [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.
Oct 19 2020, 8:47 PM · Restricted Project, Restricted Project
AMDChirag added a reviewer for D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder: kiranktp.
Oct 19 2020, 1:05 AM · Restricted Project, Restricted Project
AMDChirag requested review of D89671: [LLVM][OpenMP] Adding support for OpenMP sections construct in OpenMPIRBuilder.
Oct 19 2020, 12:39 AM · Restricted Project, Restricted Project