Page MenuHomePhabricator

anchu-rajendran (Anchu Rajendran S)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 9 2020, 1:36 AM (23 w, 2 d)

Recent Activity

Jul 30 2020

anchu-rajendran added a comment to D84798: [OpenMP,MLIR] Translation of parallel operation: num_threads, if clauses 3/n.

Looks good to me!

Jul 30 2020, 5:07 PM · Restricted Project

Jun 30 2020

anchu-rajendran accepted D82822: [OpenMP][FIX] Consistently use OpenMPIRBuilder if requested.

LGTM :). Thanks!

Jun 30 2020, 9:07 PM · Restricted Project

Jun 29 2020

anchu-rajendran accepted D82722: [OpenMP][IRBuilder] Support nested parallel regions.
Jun 29 2020, 12:29 AM · Restricted Project, Restricted Project

Jun 26 2020

anchu-rajendran added a comment to D82470: [OpenMP][IRBuilder] Support allocas in nested parallel regions.

The change looks good to me. Thanks!

Jun 26 2020, 2:40 AM · Restricted Project, Restricted Project

Jun 2 2020

anchu-rajendran committed rG70f1b4b41220: [flang] Implemented 2 Semantic checks for DATA statement and fixed a few bugs (authored by anchu-rajendran).
[flang] Implemented 2 Semantic checks for DATA statement and fixed a few bugs
Jun 2 2020, 10:25 PM
anchu-rajendran closed D78424: [flang] Added Semantic Checks for 2 Data constraints and fixed the semantic errors in 3 test cases.
Jun 2 2020, 10:25 PM · Restricted Project, Restricted Project
anchu-rajendran added a comment to D78424: [flang] Added Semantic Checks for 2 Data constraints and fixed the semantic errors in 3 test cases.

ping @klausler. If there are further improvements to be made, can you please suggest those. I have raised a few concerns related to questions which you have posted before.

Jun 2 2020, 7:08 AM · Restricted Project, Restricted Project

May 29 2020

anchu-rajendran committed rGdbb5979d158c: [MLIR][OpenMP] Defined master operation in OpenMP Dialect (authored by anchu-rajendran).
[MLIR][OpenMP] Defined master operation in OpenMP Dialect
May 29 2020, 10:24 AM
anchu-rajendran closed D80689: [MLIR][OpenMP] Defined master operation in OpenMP Dialect.
May 29 2020, 10:23 AM · Restricted Project, Restricted Project

May 28 2020

anchu-rajendran added a project to D80689: [MLIR][OpenMP] Defined master operation in OpenMP Dialect: Restricted Project.
May 28 2020, 9:24 PM · Restricted Project, Restricted Project
anchu-rajendran added reviewers for D80689: [MLIR][OpenMP] Defined master operation in OpenMP Dialect: kiranchandramohan, mehdi_amini, DavidTruby, ftynse.
May 28 2020, 8:51 PM · Restricted Project, Restricted Project
anchu-rajendran updated subscribers of D80689: [MLIR][OpenMP] Defined master operation in OpenMP Dialect.

It uses the custom parser and printer.

Do you mean the generic parser and printer?

May 28 2020, 8:51 PM · Restricted Project, Restricted Project
anchu-rajendran updated the diff for D80689: [MLIR][OpenMP] Defined master operation in OpenMP Dialect.

Summary of the change is modified.

May 28 2020, 8:51 PM · Restricted Project, Restricted Project

May 27 2020

anchu-rajendran added a project to D80689: [MLIR][OpenMP] Defined master operation in OpenMP Dialect: Restricted Project.
May 27 2020, 11:57 PM · Restricted Project, Restricted Project
anchu-rajendran added a reviewer for D80689: [MLIR][OpenMP] Defined master operation in OpenMP Dialect: mehdi_amini.
May 27 2020, 11:57 PM · Restricted Project, Restricted Project
anchu-rajendran updated the diff for D80689: [MLIR][OpenMP] Defined master operation in OpenMP Dialect.

Formatting changes : removed an extra newline

May 27 2020, 11:24 PM · Restricted Project, Restricted Project
anchu-rajendran added reviewers for D80689: [MLIR][OpenMP] Defined master operation in OpenMP Dialect: kiranchandramohan, DavidTruby, ftynse, kiranktp.
May 27 2020, 11:24 PM · Restricted Project, Restricted Project
anchu-rajendran created D80689: [MLIR][OpenMP] Defined master operation in OpenMP Dialect.
May 27 2020, 10:52 PM · Restricted Project, Restricted Project

May 25 2020

anchu-rajendran added a comment to D78424: [flang] Added Semantic Checks for 2 Data constraints and fixed the semantic errors in 3 test cases.

ping!

May 25 2020, 10:28 PM · Restricted Project, Restricted Project

May 17 2020

anchu-rajendran added inline comments to D78424: [flang] Added Semantic Checks for 2 Data constraints and fixed the semantic errors in 3 test cases.
May 17 2020, 11:57 PM · Restricted Project, Restricted Project
anchu-rajendran updated the diff for D78424: [flang] Added Semantic Checks for 2 Data constraints and fixed the semantic errors in 3 test cases.

Added a test with derived type for C876 checking the object should not be in blank COMMON

May 17 2020, 11:57 PM · Restricted Project, Restricted Project
anchu-rajendran updated the diff for D78424: [flang] Added Semantic Checks for 2 Data constraints and fixed the semantic errors in 3 test cases.

Updated IsAutomaticObject to return false if the symbol is an allocatable or a pointer and test cases are added to data04.f90

May 17 2020, 11:24 PM · Restricted Project, Restricted Project
anchu-rajendran added inline comments to D78424: [flang] Added Semantic Checks for 2 Data constraints and fixed the semantic errors in 3 test cases.
May 17 2020, 10:20 PM · Restricted Project, Restricted Project
anchu-rajendran updated the diff for D78424: [flang] Added Semantic Checks for 2 Data constraints and fixed the semantic errors in 3 test cases.

Removed the err variable while handling Component

May 17 2020, 10:20 PM · Restricted Project, Restricted Project

May 15 2020

anchu-rajendran updated the diff for D78424: [flang] Added Semantic Checks for 2 Data constraints and fixed the semantic errors in 3 test cases.

Reduced the use of state variables while handling component
Added code to check constraints on subscripts and restricted pointers inside subscript.

May 15 2020, 3:46 AM · Restricted Project, Restricted Project

May 14 2020

anchu-rajendran added inline comments to D78424: [flang] Added Semantic Checks for 2 Data constraints and fixed the semantic errors in 3 test cases.
May 14 2020, 10:16 AM · Restricted Project, Restricted Project

May 13 2020

anchu-rajendran added a comment to D78424: [flang] Added Semantic Checks for 2 Data constraints and fixed the semantic errors in 3 test cases.

Ping @klausler . Can you please take another look and let me know if any concerns need to be addressed. I have tried to address your comments.

May 13 2020, 11:23 PM · Restricted Project, Restricted Project

May 12 2020

anchu-rajendran updated the diff for D78424: [flang] Added Semantic Checks for 2 Data constraints and fixed the semantic errors in 3 test cases.

Made changes to update the variable symbolCheckStatus correctly.

May 12 2020, 12:30 AM · Restricted Project, Restricted Project

May 6 2020

anchu-rajendran updated the diff for D78424: [flang] Added Semantic Checks for 2 Data constraints and fixed the semantic errors in 3 test cases.
  • Addressed the review comments
  • Modified IsAutomaticArray to check all automatic objects as described in 3.11
  • Added extra checks to emit error if right most pointer reference in a component is subscripted (C877)
May 6 2020, 11:15 PM · Restricted Project, Restricted Project
anchu-rajendran added a comment to D78424: [flang] Added Semantic Checks for 2 Data constraints and fixed the semantic errors in 3 test cases.

@klausler , Thank you for the review comments! I have made the suggested changes.

May 6 2020, 11:15 PM · Restricted Project, Restricted Project

Apr 26 2020

anchu-rajendran updated the diff for D78424: [flang] Added Semantic Checks for 2 Data constraints and fixed the semantic errors in 3 test cases.
Apr 26 2020, 5:18 AM · Restricted Project, Restricted Project
anchu-rajendran added a comment to D78424: [flang] Added Semantic Checks for 2 Data constraints and fixed the semantic errors in 3 test cases.

https://reviews.llvm.org/D78834 contains the patch that reworks check-data.{h,cpp} to check typed expressions rather than the raw parse tree. Please adjust this change to do the same, if possible.

Apr 26 2020, 5:18 AM · Restricted Project, Restricted Project

Apr 25 2020

anchu-rajendran accepted D78834: Rework DATA statement semantics to use typed expressions.
Apr 25 2020, 3:09 AM · Restricted Project, Restricted Project
anchu-rajendran added a comment to D78424: [flang] Added Semantic Checks for 2 Data constraints and fixed the semantic errors in 3 test cases.

https://reviews.llvm.org/D78834 contains the patch that reworks check-data.{h,cpp} to check typed expressions rather than the raw parse tree. Please adjust this change to do the same, if possible.

Apr 25 2020, 2:37 AM · Restricted Project, Restricted Project

Apr 24 2020

anchu-rajendran added a comment to D78424: [flang] Added Semantic Checks for 2 Data constraints and fixed the semantic errors in 3 test cases.

Thanks for addressing the comments.

Also check the following.

type t1
 integer, allocatable :: arr(:)
end type
type(t1) d1
data d1/t1((/0,1/))/

The current revision does not catch this error. I dont think this case is covered under the Constraint C876 (or C877)
C876 says a variable whose designator appears as a data-stmt-object shall not be an allocatable variable . This means d1 cannot be an allocatable (and it does not say anything about the fields of d1). In this case, d1 is not.

The code is in error because the structure constructor is not a constant expression in the sense of 10.1.12. I have a fix for this in my rework of DATA statement semantics in progress.

Apr 24 2020, 1:02 AM · Restricted Project, Restricted Project

Apr 22 2020

anchu-rajendran added a comment to D78424: [flang] Added Semantic Checks for 2 Data constraints and fixed the semantic errors in 3 test cases.

Thanks for addressing the comments.

Also check the following.

type t1
 integer, allocatable :: arr(:)
end type
type(t1) d1
data d1/t1((/0,1/))/
Apr 22 2020, 10:14 PM · Restricted Project, Restricted Project
anchu-rajendran updated the diff for D78424: [flang] Added Semantic Checks for 2 Data constraints and fixed the semantic errors in 3 test cases.

Removed inline specifier from IsAutomaticArray

Apr 22 2020, 4:49 AM · Restricted Project, Restricted Project
anchu-rajendran added a comment to D78424: [flang] Added Semantic Checks for 2 Data constraints and fixed the semantic errors in 3 test cases.

Thanks for addressing the comments.

Also check the following.

type t1
 integer, allocatable :: arr(:)
end type
type(t1) d1
data d1/t1((/0,1/))/

Besides the constraints for the data statement, there are several other points mentioned in the data statement section. Like point 8 in 8.6.7 (test below) which says that the number of variables and data-statement-constants shall be the same. Are these outside the scope of your work? If so, please create a ticket somewhere so that we can come back to it later.

program mn
  character(len=3) :: n1, n2
  data n1, n2 / 'f18' /
end
Apr 22 2020, 4:49 AM · Restricted Project, Restricted Project
anchu-rajendran added inline comments to D78424: [flang] Added Semantic Checks for 2 Data constraints and fixed the semantic errors in 3 test cases.
Apr 22 2020, 4:17 AM · Restricted Project, Restricted Project
anchu-rajendran updated the diff for D78424: [flang] Added Semantic Checks for 2 Data constraints and fixed the semantic errors in 3 test cases.

Fixed a few corner cases:
Implemented a function: GetFirstName

Apr 22 2020, 4:17 AM · Restricted Project, Restricted Project

Apr 20 2020

anchu-rajendran added inline comments to D78424: [flang] Added Semantic Checks for 2 Data constraints and fixed the semantic errors in 3 test cases.
Apr 20 2020, 2:38 AM · Restricted Project, Restricted Project
anchu-rajendran updated the diff for D78424: [flang] Added Semantic Checks for 2 Data constraints and fixed the semantic errors in 3 test cases.
  • Abstracted the code to IsAutomaticArray Function.
  • Added implementation to catch semantic bugs related to fields of derived type variables.
  • Made the changes suggested.
Apr 20 2020, 2:06 AM · Restricted Project, Restricted Project

Apr 18 2020

anchu-rajendran created D78424: [flang] Added Semantic Checks for 2 Data constraints and fixed the semantic errors in 3 test cases.
Apr 18 2020, 7:00 AM · Restricted Project, Restricted Project
anchu-rajendran added a comment to D78424: [flang] Added Semantic Checks for 2 Data constraints and fixed the semantic errors in 3 test cases.

@klausler, Current implementation of C877 may change and may depend on the modifications which will be made by you. I will make changes accordingly after your changes are merged.

Apr 18 2020, 7:00 AM · Restricted Project, Restricted Project
anchu-rajendran added a comment to D78008: [flang] Added Semantic Checks for 5 Data Constraints.

I think you should just merge the code you have so I can clean it up here.

Apr 18 2020, 12:30 AM · Restricted Project, Restricted Project

Apr 17 2020

anchu-rajendran committed rGc1c01212c49a: [flang]Implemented Semantic Checkes for 5 data constraints (authored by anchu-rajendran).
[flang]Implemented Semantic Checkes for 5 data constraints
Apr 17 2020, 11:58 PM
anchu-rajendran closed D78008: [flang] Added Semantic Checks for 5 Data Constraints.
Apr 17 2020, 11:58 PM · Restricted Project, Restricted Project

Apr 16 2020

anchu-rajendran added inline comments to D78008: [flang] Added Semantic Checks for 5 Data Constraints.
Apr 16 2020, 5:03 AM · Restricted Project, Restricted Project

Apr 14 2020

anchu-rajendran updated the diff for D78008: [flang] Added Semantic Checks for 5 Data Constraints.

Changes in formatting

Apr 14 2020, 7:59 AM · Restricted Project, Restricted Project
anchu-rajendran updated the diff for D78008: [flang] Added Semantic Checks for 5 Data Constraints.

Fixed the formatting issues

Apr 14 2020, 2:05 AM · Restricted Project, Restricted Project
anchu-rajendran added inline comments to D78008: [flang] Added Semantic Checks for 5 Data Constraints.
Apr 14 2020, 1:33 AM · Restricted Project, Restricted Project
anchu-rajendran updated the diff for D78008: [flang] Added Semantic Checks for 5 Data Constraints.

Fixed the clang format problems

Apr 14 2020, 1:33 AM · Restricted Project, Restricted Project

Apr 13 2020

anchu-rajendran created D78008: [flang] Added Semantic Checks for 5 Data Constraints.
Apr 13 2020, 2:07 AM · Restricted Project, Restricted Project

Apr 9 2020

GitHub <noreply@github.com> committed rGdf1b4b144e81: [flang] Issue flang-compiler/f18#992 : Implementing Semantic checks for DATA… (authored by anchu-rajendran).
[flang] Issue flang-compiler/f18#992 : Implementing Semantic checks for DATA…
Apr 9 2020, 12:54 PM