- User Since
- Feb 20 2019, 7:26 AM (76 w, 2 d)
Mon, Aug 3
lgtm, apart from clang tests. Someone else should take a look as well, though.
cover "maybe written" by another unkown call case and add test for that.
Sun, Aug 2
Sat, Aug 1
We are now able to check if call changes an ICV through function attribute. Follow up should make it possible to get an ICV value for a call.
Fri, Jul 31
Sun, Jul 19
I see you reverted this twice. Just curious what happened?
Sat, Jul 18
Fri, Jul 17
Just in case you haven't seen already, clang/test/OpenMP/barrier_codegen.cpp needs to be updated as well.
Thu, Jul 16
I am not sure we can help you much without the actual failure output.
Wed, Jul 15
add a test
Sun, Jul 12
Sat, Jul 11
remove unnecessary flag, fix update_cc_test_checks
Fri, Jul 10
fixing the issue with dead uses.
Thanks for figuring this out!
Jul 8 2020
Jul 6 2020
Can you add a test using this option?
Jul 5 2020
Since this is not a small change, I think it would be good if @hoyFB could test if this resolves the issue.
As of yesterday, there is an AA outside of AttributorAttributes :). You should rebase.
Jul 4 2020
I think you should split this in 2 patches. One being the refactoring. (this happened to me with the ICV patch)
Jul 3 2020
Jul 2 2020
I was under the impression that the attributes will be made default in another patch. Right now we don't opt out of the default attributes, but none are set to be default yet.
If it is better to do this in this patch, no problem. I can send an email, on Monday maybe?
DisableDefaultAttributes flag instead of opt-out list
Jun 30 2020
Agreed, that could be another way to go about this. By now, I'm not really sure what is the best out of all the options. What do others think?
Jun 29 2020
For now I've only set IntrNoSync to be default and changed memset to opt-out of IntrNoSync just as an example. Maybe the part where attributes are actually made default should be done in another patch?
Introduction of IsDefault field in IntrinsicProperty as suggested by @nhaehnle.
One more thing, looks like you included only the last change, not the complete diff.
Jun 28 2020
Jun 26 2020
Personally, callsite still sounds more natural in some places, but LGTM.
Jun 25 2020
Jun 24 2020
Jun 23 2020
Sorry this took so long.
- revisit this patch with different implementation
Jun 22 2020
- clean up the patch
- basic deduplication
Jun 21 2020
leftover check lines
new test file for icv remarks
Jun 19 2020
Jun 17 2020
This was my bad. Thanks for noticing!
Jun 16 2020
left out icv part for another patch
Jun 13 2020
This is the first split of D81788