Page MenuHomePhabricator

sstefan1 (Stefan Stipanovic)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 20 2019, 7:26 AM (76 w, 2 d)

Recent Activity

Mon, Aug 3

sstefan1 added a comment to D85099: [UpdateTestChecks] Match unnamed values like "@[0-9]+" and "![0-9]+".

lgtm, apart from clang tests. Someone else should take a look as well, though.

Mon, Aug 3, 2:38 PM · Restricted Project
sstefan1 updated the diff for D85052: [OpenMPOpt] ICV Tracking Between BasicBlocks.

cover "maybe written" by another unkown call case and add test for that.

Mon, Aug 3, 12:01 PM · Restricted Project
sstefan1 added inline comments to D83283: [Attributor] AAPotentialValues Interface.
Mon, Aug 3, 12:58 AM · Restricted Project

Sun, Aug 2

sstefan1 added inline comments to D85052: [OpenMPOpt] ICV Tracking Between BasicBlocks.
Sun, Aug 2, 1:41 PM · Restricted Project
sstefan1 updated the diff for D85052: [OpenMPOpt] ICV Tracking Between BasicBlocks.

addressing comments

Sun, Aug 2, 1:31 PM · Restricted Project

Sat, Aug 1

sstefan1 added a comment to D85052: [OpenMPOpt] ICV Tracking Between BasicBlocks.

This is still "intra-procedural", correct? Or can it replace across function boundaries too?

We are now able to check if call changes an ICV through function attribute. Follow up should make it possible to get an ICV value for a call.

Sat, Aug 1, 1:36 PM · Restricted Project

Fri, Jul 31

sstefan1 requested review of D85052: [OpenMPOpt] ICV Tracking Between BasicBlocks.
Fri, Jul 31, 3:17 PM · Restricted Project

Sun, Jul 19

sstefan1 committed rGe3d646c699f1: [Attributor][NFC] applying update_test_checks with --check-attributes (authored by sstefan1).
[Attributor][NFC] applying update_test_checks with --check-attributes
Sun, Jul 19, 11:19 PM
sstefan1 closed D84130: [Attributor][NFC] applying update_test_checks with --check-attributes.
Sun, Jul 19, 11:19 PM · Restricted Project
sstefan1 resigned from D83915: [PowerPC] Remove QPX/A2Q BGQ/BGP CNK support.
Sun, Jul 19, 1:10 PM · Restricted Project, Restricted Project, Restricted Project
Herald added a project to D84130: [Attributor][NFC] applying update_test_checks with --check-attributes: Restricted Project.
Sun, Jul 19, 12:58 PM · Restricted Project
sstefan1 committed rGcf1105069648: [Utils][Fix] remove unnecessary ; at the end (authored by sstefan1).
[Utils][Fix] remove unnecessary ; at the end
Sun, Jul 19, 11:49 AM
sstefan1 committed rG937bad3594e7: [Utils] Check function attributes in update_test_checks (authored by sstefan1).
[Utils] Check function attributes in update_test_checks
Sun, Jul 19, 11:22 AM
sstefan1 closed D83629: [Utils] Check function attributes in update_test_checks.
Sun, Jul 19, 11:22 AM · Restricted Project, Restricted Project
sstefan1 added inline comments to D83629: [Utils] Check function attributes in update_test_checks.
Sun, Jul 19, 4:21 AM · Restricted Project, Restricted Project
sstefan1 updated subscribers of D83629: [Utils] Check function attributes in update_test_checks.
Sun, Jul 19, 3:48 AM · Restricted Project, Restricted Project
sstefan1 added a comment to D78861: [Attributor] Track AA dependency using dependency graph.

I see you reverted this twice. Just curious what happened?

Sun, Jul 19, 3:09 AM · Restricted Project

Sat, Jul 18

sstefan1 added inline comments to D83635: [OpenMPOpt][WIP] Merge parallel regions.
Sat, Jul 18, 12:41 PM · Restricted Project

Fri, Jul 17

sstefan1 added a comment to D81031: [OpenMP] Add Additional Function Attribute Information to OMPKinds.def.

Just in case you haven't seen already, clang/test/OpenMP/barrier_codegen.cpp needs to be updated as well.

Fri, Jul 17, 3:33 PM · Restricted Project, Restricted Project, Restricted Project

Thu, Jul 16

sstefan1 added a comment to D83744: [Attributor] Attributor call site specific AAValueConstantRange.

I inspected the output that opt generates and it makes sense.
also the script's output (included in the patch) also makes sense the.

I will double check everything but this is weird.
File check fails to match the first check line.

I am not sure we can help you much without the actual failure output.

Thu, Jul 16, 2:17 AM · Restricted Project
sstefan1 resigned from D83915: [PowerPC] Remove QPX/A2Q BGQ/BGP CNK support.
Thu, Jul 16, 12:01 AM · Restricted Project, Restricted Project, Restricted Project

Wed, Jul 15

sstefan1 added a comment to D83744: [Attributor] Attributor call site specific AAValueConstantRange.

merge with D83299
add positive and negative tests.

@jdoerfert I have a problem with this patch even though I auto generate tests, llvm-lit fails.
Is this a bug with the update_test_checks.py script ?

Wed, Jul 15, 1:42 PM · Restricted Project
sstefan1 updated the diff for D83629: [Utils] Check function attributes in update_test_checks.

add a test

Wed, Jul 15, 1:36 PM · Restricted Project, Restricted Project

Sun, Jul 12

sstefan1 added a comment to D82861: [Attributor] Add AAValueSimplifyCallSiteArgument::manifest.

Can you merge this?

Do I have a right to merge this by myself? I did arc patch and tried to git push https://github.com/llvm/llvm-project.git HEAD:master according to the document, but I failed to do that.

Sun, Jul 12, 4:06 AM · Restricted Project

Sat, Jul 11

sstefan1 updated the diff for D83629: [Utils] Check function attributes in update_test_checks.

remove unnecessary flag, fix update_cc_test_checks

Sat, Jul 11, 2:51 PM · Restricted Project, Restricted Project
Herald added a project to D83629: [Utils] Check function attributes in update_test_checks: Restricted Project.
Sat, Jul 11, 12:58 PM · Restricted Project, Restricted Project
sstefan1 committed rG850b150cff3d: [Attributor][NFC] Add more debug output for deleted functions (authored by sstefan1).
[Attributor][NFC] Add more debug output for deleted functions
Sat, Jul 11, 5:36 AM

Fri, Jul 10

sstefan1 added a reverting change for rG1d542f0ca83f: Revert "[OpenMPOpt] ICV Tracking": rGb8235d2bd871: Reland "[OpenMPOpt] ICV Tracking".
Fri, Jul 10, 5:27 PM
sstefan1 committed rGb8235d2bd871: Reland "[OpenMPOpt] ICV Tracking" (authored by sstefan1).
Reland "[OpenMPOpt] ICV Tracking"
Fri, Jul 10, 5:27 PM
sstefan1 closed D81788: [OpenMPOpt] ICV Tracking.
Fri, Jul 10, 5:27 PM · Restricted Project
sstefan1 updated the diff for D81788: [OpenMPOpt] ICV Tracking.

fixing the issue with dead uses.

Fri, Jul 10, 4:23 PM · Restricted Project
sstefan1 accepted D83583: [openmp] Remove OMPConstants.cpp and replace it by OMP.cpp generated by tablegen.

Thanks for figuring this out!

Fri, Jul 10, 3:39 PM · Restricted Project
sstefan1 accepted D83270: [OpenMP] Compute a proper module slice for the CGSCCC pass.

LGTM

Fri, Jul 10, 3:36 PM · Restricted Project

Jul 8 2020

sstefan1 added inline comments to D83297: [Attributor][WIP] Attribute scheduling visualization..
Jul 8 2020, 10:34 AM · Restricted Project
sstefan1 committed rG6aab27ba851f: [OpenMPIRBuilder][Fix] Move llvm::omp::types to OpenMPIRBuilder. (authored by sstefan1).
[OpenMPIRBuilder][Fix] Move llvm::omp::types to OpenMPIRBuilder.
Jul 8 2020, 8:26 AM
sstefan1 closed D83176: [OpenMPIRBuilder][Fix] Move llvm::omp::types to OpenMPIRBuilder..
Jul 8 2020, 8:25 AM · Restricted Project, Restricted Project

Jul 6 2020

sstefan1 abandoned D65377: [FunctionAttrs] Annotate intrinsics with nosync.
Jul 6 2020, 4:55 AM · Restricted Project
sstefan1 added a comment to D83185: [Attributor] Introduce Attribute seed allow list..

Can you add a test using this option?

Jul 6 2020, 2:30 AM · Restricted Project

Jul 5 2020

sstefan1 updated the diff for D83176: [OpenMPIRBuilder][Fix] Move llvm::omp::types to OpenMPIRBuilder..

small fix

Jul 5 2020, 7:58 AM · Restricted Project, Restricted Project
sstefan1 updated subscribers of D83176: [OpenMPIRBuilder][Fix] Move llvm::omp::types to OpenMPIRBuilder..

Since this is not a small change, I think it would be good if @hoyFB could test if this resolves the issue.

Jul 5 2020, 7:58 AM · Restricted Project, Restricted Project
sstefan1 created D83176: [OpenMPIRBuilder][Fix] Move llvm::omp::types to OpenMPIRBuilder..
Jul 5 2020, 7:26 AM · Restricted Project, Restricted Project
sstefan1 added a comment to D83172: [Attributor] Create getter function for the ID of the abstract attribute.
In D83172#2131779, @bbn wrote:

Attributes are going to be decleared outside of the Attributor soon.

Do you mean that there might be other abstract attributes defined outside the AttributorAttributes.cpp ?

As of yesterday, there is an AA outside of AttributorAttributes :). You should rebase.

Jul 5 2020, 5:19 AM · Restricted Project

Jul 4 2020

sstefan1 committed rG6c4a5e9257ba: [OpenMPOpt] ICV Tracking (authored by sstefan1).
[OpenMPOpt] ICV Tracking
Jul 4 2020, 3:02 PM
sstefan1 closed D81788: [OpenMPOpt] ICV Tracking.
Jul 4 2020, 3:02 PM · Restricted Project
sstefan1 added a comment to D82719: [OpenMPOpt][SplitMemTransfer][WIP] Getting values stored in offload arrays.

I think you should split this in 2 patches. One being the refactoring. (this happened to me with the ICV patch)

Jul 4 2020, 12:53 PM · Restricted Project, Restricted Project

Jul 3 2020

sstefan1 added inline comments to D78861: [Attributor] Track AA dependency using dependency graph.
Jul 3 2020, 12:29 AM · Restricted Project

Jul 2 2020

sstefan1 accepted D83109: [Attributor] Create getName() method for abstract attribute.

LGTM

Jul 2 2020, 11:57 PM · Restricted Project
sstefan1 added inline comments to D82193: [OpenMPOpt] ICV macro definitions.
Jul 2 2020, 2:03 PM · Restricted Project
sstefan1 updated the diff for D70365: intrinsics attribute opt-out list proposal..

small fix

Jul 2 2020, 12:57 PM · Restricted Project
sstefan1 added a comment to D70365: intrinsics attribute opt-out list proposal..

@sstefan1 could u update the patch? We then send another email out with the list of 5 attributes we will make opt-out for intrinsics. A week or so later, assuming no one objected too much, we'll land it. In the meantime we need to update the target independent ones to opt-out appropriately. I guess my nosync list will catch almost all of them already but we'll have to give it another go as the patch is updated. WDYT?

I was under the impression that the attributes will be made default in another patch. Right now we don't opt out of the default attributes, but none are set to be default yet.
If it is better to do this in this patch, no problem. I can send an email, on Monday maybe?

Jul 2 2020, 12:25 PM · Restricted Project
sstefan1 updated the diff for D70365: intrinsics attribute opt-out list proposal..

DisableDefaultAttributes flag instead of opt-out list

Jul 2 2020, 12:25 PM · Restricted Project
sstefan1 added inline comments to D82193: [OpenMPOpt] ICV macro definitions.
Jul 2 2020, 11:51 AM · Restricted Project
sstefan1 committed rG61238d2690a6: [OpenMPOpt][Fix] Remove double initialization of omp::types. (authored by sstefan1).
[OpenMPOpt][Fix] Remove double initialization of omp::types.
Jul 2 2020, 11:20 AM
sstefan1 added inline comments to D82193: [OpenMPOpt] ICV macro definitions.
Jul 2 2020, 12:29 AM · Restricted Project

Jun 30 2020

sstefan1 added a comment to D70365: intrinsics attribute opt-out list proposal..

On a related note, we might want to consider doing something for pointer/memory handling as well, since that's currently pretty awkward. Most pointer arguments should be nocapture/nofree, but we don't really mark that consistently.

Jun 30 2020, 1:35 PM · Restricted Project
sstefan1 added a comment to D70365: intrinsics attribute opt-out list proposal..

One way to avoid some of the complexity would be to opt-out of everything with a single bit. So if this is set, you don't get any default attributes. Otherwise you get all.

Agreed, that could be another way to go about this. By now, I'm not really sure what is the best out of all the options. What do others think?

Jun 30 2020, 5:23 AM · Restricted Project
sstefan1 committed rGaa93d84db934: [IR] NoFree IntrinsicProperty. (authored by sstefan1).
[IR] NoFree IntrinsicProperty.
Jun 30 2020, 2:41 AM
sstefan1 closed D82587: [IR] NoFree IntrinsicProperty..
Jun 30 2020, 2:41 AM · Restricted Project

Jun 29 2020

sstefan1 updated the diff for D81788: [OpenMPOpt] ICV Tracking.

addressing comments

Jun 29 2020, 3:18 PM · Restricted Project
sstefan1 added inline comments to D81788: [OpenMPOpt] ICV Tracking.
Jun 29 2020, 3:18 PM · Restricted Project
sstefan1 added a comment to D70365: intrinsics attribute opt-out list proposal..

For now I've only set IntrNoSync to be default and changed memset to opt-out of IntrNoSync just as an example. Maybe the part where attributes are actually made default should be done in another patch?

Jun 29 2020, 7:31 AM · Restricted Project
sstefan1 updated the diff for D70365: intrinsics attribute opt-out list proposal..

Introduction of IsDefault field in IntrinsicProperty as suggested by @nhaehnle.

Jun 29 2020, 7:31 AM · Restricted Project
sstefan1 added a comment to D82719: [OpenMPOpt][SplitMemTransfer][WIP] Getting values stored in offload arrays.

One more thing, looks like you included only the last change, not the complete diff.

Jun 29 2020, 1:02 AM · Restricted Project, Restricted Project

Jun 28 2020

sstefan1 added inline comments to D82719: [OpenMPOpt][SplitMemTransfer][WIP] Getting values stored in offload arrays.
Jun 28 2020, 9:43 AM · Restricted Project, Restricted Project

Jun 26 2020

sstefan1 added inline comments to D82193: [OpenMPOpt] ICV macro definitions.
Jun 26 2020, 9:17 AM · Restricted Project
sstefan1 committed rG951e43f357ec: [OpenMPOpt][NFC] Change ICV macros for initial value (authored by sstefan1).
[OpenMPOpt][NFC] Change ICV macros for initial value
Jun 26 2020, 8:45 AM
sstefan1 added inline comments to D82193: [OpenMPOpt] ICV macro definitions.
Jun 26 2020, 4:18 AM · Restricted Project
sstefan1 accepted D82625: [Attributor][NFC] Replace call site with call base..

Personally, callsite still sounds more natural in some places, but LGTM.

Jun 26 2020, 2:08 AM · Restricted Project

Jun 25 2020

sstefan1 created D82587: [IR] NoFree IntrinsicProperty..
Jun 25 2020, 11:20 AM · Restricted Project
sstefan1 added a reviewer for D70365: intrinsics attribute opt-out list proposal.: nhaehnle.
Jun 25 2020, 10:46 AM · Restricted Project
sstefan1 added inline comments to D81788: [OpenMPOpt] ICV Tracking.
Jun 25 2020, 3:36 AM · Restricted Project

Jun 24 2020

sstefan1 added inline comments to D70365: intrinsics attribute opt-out list proposal..
Jun 24 2020, 8:36 AM · Restricted Project
sstefan1 committed rG0f426935bb5f: [OpenMPOpt] ICV macro definitions (authored by sstefan1).
[OpenMPOpt] ICV macro definitions
Jun 24 2020, 4:50 AM
sstefan1 closed D82193: [OpenMPOpt] ICV macro definitions.
Jun 24 2020, 4:50 AM · Restricted Project

Jun 23 2020

sstefan1 added a comment to D70365: intrinsics attribute opt-out list proposal..

Sorry this took so long.

Jun 23 2020, 1:59 PM · Restricted Project
sstefan1 updated the diff for D70365: intrinsics attribute opt-out list proposal..
  • revisit this patch with different implementation
Jun 23 2020, 1:59 PM · Restricted Project

Jun 22 2020

sstefan1 retitled D81788: [OpenMPOpt] ICV Tracking from [WIP][OpenMPOPT] ICV Tracking Support to [OpenMPOpt] ICV Tracking.
Jun 22 2020, 4:07 PM · Restricted Project
sstefan1 updated the diff for D81788: [OpenMPOpt] ICV Tracking.
  • clean up the patch
  • basic deduplication
Jun 22 2020, 4:07 PM · Restricted Project

Jun 21 2020

sstefan1 added inline comments to D82193: [OpenMPOpt] ICV macro definitions.
Jun 21 2020, 2:49 PM · Restricted Project
sstefan1 updated the diff for D82193: [OpenMPOpt] ICV macro definitions.

leftover check lines

Jun 21 2020, 2:49 PM · Restricted Project
sstefan1 updated the diff for D82193: [OpenMPOpt] ICV macro definitions.

new test file for icv remarks

Jun 21 2020, 2:49 PM · Restricted Project
sstefan1 added inline comments to D82193: [OpenMPOpt] ICV macro definitions.
Jun 21 2020, 4:13 AM · Restricted Project

Jun 19 2020

sstefan1 added inline comments to D82193: [OpenMPOpt] ICV macro definitions.
Jun 19 2020, 8:37 AM · Restricted Project
sstefan1 added inline comments to D82193: [OpenMPOpt] ICV macro definitions.
Jun 19 2020, 8:05 AM · Restricted Project
sstefan1 created D82193: [OpenMPOpt] ICV macro definitions.
Jun 19 2020, 8:05 AM · Restricted Project

Jun 17 2020

sstefan1 accepted D82027: Remove "unused" member ModuleSlice from `struct OpenMPOpt`.

This was my bad. Thanks for noticing!

Jun 17 2020, 10:45 AM · Restricted Project
sstefan1 committed rG7cfd267c518a: [OpenMPOPT][NFC] Introducing OMPInformationCache. (authored by sstefan1).
[OpenMPOPT][NFC] Introducing OMPInformationCache.
Jun 17 2020, 8:04 AM
sstefan1 closed D81798: [OpenMPOPT][NFC] Introducing OMPInformationCache.
Jun 17 2020, 8:04 AM · Restricted Project

Jun 16 2020

sstefan1 updated the diff for D81798: [OpenMPOPT][NFC] Introducing OMPInformationCache.

left out icv part for another patch

Jun 16 2020, 7:42 AM · Restricted Project
sstefan1 retitled D81798: [OpenMPOPT][NFC] Introducing OMPInformationCache from [OpenMPOPT][NFC] OMPInformationCache and ICV definitions. to [OpenMPOPT][NFC] Introducing OMPInformationCache.
Jun 16 2020, 7:42 AM · Restricted Project
sstefan1 committed rG06a744afd3f4: [NFC][Attributor] Expose getOrCreateAAFor and lookupAAFor (authored by sstefan1).
[NFC][Attributor] Expose getOrCreateAAFor and lookupAAFor
Jun 16 2020, 4:25 AM
sstefan1 committed rGe099c7b64a06: [NFC][OpenMPOpt] Provide function-specific foreachUse. (authored by sstefan1).
[NFC][OpenMPOpt] Provide function-specific foreachUse.
Jun 16 2020, 3:51 AM
sstefan1 added inline comments to D78861: [Attributor] Track AA dependency using dependency graph.
Jun 16 2020, 3:50 AM · Restricted Project
sstefan1 committed rG73bfb4fd52dc: [OpenMPOpt] initial tests for ICV tracking. Only nthreads is used. (authored by sstefan1).
[OpenMPOpt] initial tests for ICV tracking. Only nthreads is used.
Jun 16 2020, 2:44 AM
sstefan1 closed D81114: [OpenMPOpt] initial tests for ICV tracking. Only nthreads is used..
Jun 16 2020, 2:43 AM · Restricted Project

Jun 13 2020

sstefan1 added a comment to D81798: [OpenMPOPT][NFC] Introducing OMPInformationCache.

This is the first split of D81788

Jun 13 2020, 3:29 PM · Restricted Project
sstefan1 created D81798: [OpenMPOPT][NFC] Introducing OMPInformationCache.
Jun 13 2020, 3:29 PM · Restricted Project
sstefan1 added a comment to D81788: [OpenMPOpt] ICV Tracking.

I left a first set of comments. I think the overall direction is good, some interesting opportunities are opening up (see below). We need tests and also to split the patch (some suggestions below).

Jun 13 2020, 1:22 PM · Restricted Project
sstefan1 created D81788: [OpenMPOpt] ICV Tracking.
Jun 13 2020, 6:26 AM · Restricted Project

Jun 11 2020

sstefan1 added inline comments to D81472: [Matrix] Update load/store intrinsics..
Jun 11 2020, 12:37 AM · Restricted Project, Restricted Project