- User Since
- Jun 28 2018, 2:24 AM (125 w, 4 d)
FYI: your email address wasn't picked up by git when landing - Author: George <>
Address (most of) the review
Forgotten git add
Sprinkle around a bit more documentation
Sure, let's use MlirStringRef everywhere, this also indicates that we don't take ownership of the string. We added it much later than APIs that could be using it and nobody had time to reconsider those yet.
Replaced with another approach - https://reviews.llvm.org/D91493.
Fri, Nov 20
Shared pointer logic looks fine: the lambda takes it by-copy and is stored internally in std::function, so the data remains live.
Thu, Nov 19
Add a check in TypeRange
LGTM, forwarding to @rriddle as I am not very familiar with this code.
Thanks for fixing and iterating!
Wed, Nov 18
Thanks, this looks better! I have a couple of further comments.
This broke some tests.
Tue, Nov 17
Thanks, looks much simpler!
LGTM for the MLIR part
Thanks for fixing!
Mon, Nov 16
Customize handling of unit attributes
Simplify cmake further
Sun, Nov 15
Fri, Nov 13
Thu, Nov 12
Please fix the test