This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Add intrinsics for vmv.v.v, vmv.v.x, and vmv.x.i
ClosedPublic

Authored by craig.topper on Dec 17 2020, 10:24 PM.

Details

Summary

We work with @rogfer01 from BSC to come out this patch.

Authored-by: Roger Ferrer Ibanez <rofirrim@gmail.com>
Co-Authored-by: Craig Topper <craig.topper@sifive.com>

Diff Detail

Event Timeline

craig.topper created this revision.Dec 17 2020, 10:24 PM
craig.topper requested review of this revision.Dec 17 2020, 10:24 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 17 2020, 10:24 PM
Herald added a subscriber: MaskRay. · View Herald Transcript
khchen accepted this revision.Dec 17 2020, 10:46 PM
khchen added inline comments.
llvm/include/llvm/IR/IntrinsicsRISCV.td
231

Nit: add comment for consistent?
like // Input: (vector_in/scalar_in, vl)

llvm/test/CodeGen/RISCV/rvv/vmv.v.v-rv32.ll
295

Could we use negative constant to test vmv.v.i?

This revision is now accepted and ready to land.Dec 17 2020, 10:46 PM
khchen requested changes to this revision.Dec 17 2020, 10:47 PM
This revision now requires changes to proceed.Dec 17 2020, 10:47 PM
khchen accepted this revision.Dec 17 2020, 11:04 PM

Sorry, I saw D93487 already has negative constant tests, it's enough.

This revision is now accepted and ready to land.Dec 17 2020, 11:04 PM
This revision was landed with ongoing or failed builds.Dec 18 2020, 9:49 AM
This revision was automatically updated to reflect the committed changes.