This patch adds new PM support for the pass (can be now used during
middle-end transforms). The old pass is remamed to
ScalarizeMaskedMemIntrinLegacyPass.
Tests-Run: code gen tests.
Paths
| Differential D92743
[ScalarizeMaskedMemIntrin] Add new PM support ClosedPublic Authored by anna on Dec 6 2020, 7:55 PM.
Details Summary This patch adds new PM support for the pass (can be now used during Tests-Run: code gen tests.
Diff Detail
Unit TestsFailed
Event Timelineanna added a parent revision: D92407: [ScalarizeMaskedMemIntrinsic] Move from CodeGen into Transforms.Dec 6 2020, 7:57 PM
Comment Actions Please consider separate renaming to Legacy to NFC patch.
Comment Actions
I thought about it and saw that the renaming was done as part of same patch for new PM support for other passes as well (and I think it was intentional, in showing the need for the name update). :) If you feel strongly about it, I can do so.
Comment Actions
I do not insist on it. This revision is now accepted and ready to land.Dec 7 2020, 7:26 PM Comment Actions can you remove this from the list in https://github.com/llvm/llvm-project/blob/6e614b0c7ed3a9a66428f342bf2a4b3700525395/llvm/tools/opt/opt.cpp#L463 and make sure that no check-llvm tests regress when -enable-new-pm is turned on by default? (I should rename that function) This revision now requires changes to proceed.Dec 7 2020, 8:39 PM Comment Actions Oh and add a -passes=scalarize-masked-mem-intrin RUN line to one of the tests just to make sure it works Comment Actions
agreed. makes sense. Comment Actions
Yes, pls rename the function since it actually represents which passes are not yet ported to NewPM. Comment Actions
https://reviews.llvm.org/D92818
I'm working on reducing it to 0 so that we can have a bot that checks if it regresses. This revision is now accepted and ready to land.Dec 8 2020, 12:43 PM Comment Actions
Great, thanks! This revision was landed with ongoing or failed builds.Dec 8 2020, 2:15 PM Closed by commit rG29356e3279b2: [ScalarizeMaskedMemIntrin] Add new PM support (authored by anna). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 310316 llvm/include/llvm/CodeGen/Passes.h
llvm/include/llvm/InitializePasses.h
llvm/include/llvm/LinkAllPasses.h
llvm/include/llvm/Transforms/Scalar/ScalarizeMaskedMemIntrin.h
llvm/lib/CodeGen/TargetPassConfig.cpp
llvm/lib/Passes/PassBuilder.cpp
llvm/lib/Passes/PassRegistry.def
llvm/lib/Transforms/Scalar/Scalar.cpp
llvm/lib/Transforms/Scalar/ScalarizeMaskedMemIntrin.cpp
llvm/test/CodeGen/X86/masked_gather_scatter.ll
llvm/tools/llc/llc.cpp
llvm/tools/opt/opt.cpp
|
space. please be uniform with the current formatting.