Page MenuHomePhabricator

skatkov (Serguei Katkov)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 25 2017, 1:38 AM (228 w, 3 d)

Recent Activity

Mon, May 17

skatkov committed rG57c660f3742f: [Statepoint Lowering] Cleanup: remove unused option statepoint-always-spill… (authored by skatkov).
[Statepoint Lowering] Cleanup: remove unused option statepoint-always-spill…
Mon, May 17, 10:16 PM
skatkov committed rG7bed58d28fd0: [Inliner] Copy attributes when deoptimize intrinsic is inlined (authored by skatkov).
[Inliner] Copy attributes when deoptimize intrinsic is inlined
Mon, May 17, 8:09 PM
skatkov closed D102602: [Inliner] Copy attributes when deoptimize intrinsic is inlined.
Mon, May 17, 8:09 PM · Restricted Project
skatkov requested review of D102602: [Inliner] Copy attributes when deoptimize intrinsic is inlined.
Mon, May 17, 2:32 AM · Restricted Project

May 13 2021

skatkov accepted D99802: [rs4gc] Strip memory related attributes consistently.

Sorry for the long delay.

May 13 2021, 1:40 AM · Restricted Project

May 5 2021

skatkov added a comment to D99802: [rs4gc] Strip memory related attributes consistently.

Once that bakes for a bit, I'd appreciate a retest cycle to see if anything else falls out. That one definitely wasn't anything I was expecting.

@skatkov Any update on this retest cycle?

May 5 2021, 7:15 PM · Restricted Project

May 4 2021

skatkov closed D101028: [GreedyRA] Do not hoist to BB if its def is after LSP.

Landed as a part of https://reviews.llvm.org/D101150.

May 4 2021, 9:31 PM · Restricted Project
skatkov closed D100945: [GreedyRA] Fix removeBackCopies to account empty copies.

Landed as a part of https://reviews.llvm.org/D101150.

May 4 2021, 9:30 PM · Restricted Project
skatkov closed D100927: [InlineSpiller] Handle the case when def is after LIP.

Landed as a part of https://reviews.llvm.org/D101150.

May 4 2021, 9:30 PM · Restricted Project
skatkov closed D100750: [Greedy RA] Take into account Last Split Point for enterIntvAtEnd.

Landed as a part of https://reviews.llvm.org/D101150.

May 4 2021, 9:30 PM · Restricted Project
skatkov closed D100748: [Greedy RA] Do not split interval on tied-def.

Landed as a part of https://reviews.llvm.org/D101150.

May 4 2021, 9:30 PM · Restricted Project
skatkov closed D100747: [Greedy RA] Last Split point for invoke statepoint should be statepoint itself.

Landed as a part of https://reviews.llvm.org/D101150.

May 4 2021, 9:29 PM · Restricted Project
skatkov committed rG9f631d14c638: [GreedyRA] Add support for invoke statepoint with tied-defs. (authored by skatkov).
[GreedyRA] Add support for invoke statepoint with tied-defs.
May 4 2021, 9:25 PM
skatkov closed D101150: [GreedyRA] Add support for invoke statepoint with tied-defs..
May 4 2021, 9:25 PM · Restricted Project
skatkov accepted D101150: [GreedyRA] Add support for invoke statepoint with tied-defs..

Accept basing on accept of all individual patches.

May 4 2021, 9:13 PM · Restricted Project

May 3 2021

skatkov updated the diff for D101150: [GreedyRA] Add support for invoke statepoint with tied-defs..
May 3 2021, 10:39 PM · Restricted Project
skatkov updated the diff for D100927: [InlineSpiller] Handle the case when def is after LIP.

Remove REQUIRED section.

May 3 2021, 9:59 PM · Restricted Project
skatkov updated the diff for D100748: [Greedy RA] Do not split interval on tied-def.

Test description is updated.

May 3 2021, 9:33 PM · Restricted Project

Apr 29 2021

skatkov updated the diff for D101150: [GreedyRA] Add support for invoke statepoint with tied-defs..

Update tests.

Apr 29 2021, 5:31 AM · Restricted Project
skatkov added a comment to D100945: [GreedyRA] Fix removeBackCopies to account empty copies.

empty copy is introduced by D100748 when we skip RegAssign.insert.
When another copy is hoisted after that we can get these two copies.

Apr 29 2021, 4:23 AM · Restricted Project
skatkov updated the diff for D100750: [Greedy RA] Take into account Last Split Point for enterIntvAtEnd.

Convert test to mir

Apr 29 2021, 4:15 AM · Restricted Project
skatkov added inline comments to D100748: [Greedy RA] Do not split interval on tied-def.
Apr 29 2021, 3:09 AM · Restricted Project
skatkov updated the diff for D100748: [Greedy RA] Do not split interval on tied-def.

Update with mir test

Apr 29 2021, 3:07 AM · Restricted Project
skatkov updated the diff for D100747: [Greedy RA] Last Split point for invoke statepoint should be statepoint itself.

ll test replaced with mir one.

Apr 29 2021, 2:53 AM · Restricted Project
skatkov committed rG2e1150d8aad6: [Greedy RA] Replace ll to mir test to make more stable to check an error. (authored by skatkov).
[Greedy RA] Replace ll to mir test to make more stable to check an error.
Apr 29 2021, 2:21 AM

Apr 23 2021

skatkov added reviewers for D100750: [Greedy RA] Take into account Last Split Point for enterIntvAtEnd: MatzeB, wmi, qcolombet.
Apr 23 2021, 3:15 AM · Restricted Project
skatkov added reviewers for D100748: [Greedy RA] Do not split interval on tied-def: MatzeB, wmi, qcolombet.
Apr 23 2021, 3:15 AM · Restricted Project
skatkov added reviewers for D100747: [Greedy RA] Last Split point for invoke statepoint should be statepoint itself: MatzeB, wmi, qcolombet.
Apr 23 2021, 3:14 AM · Restricted Project
skatkov requested review of D101150: [GreedyRA] Add support for invoke statepoint with tied-defs..
Apr 23 2021, 3:11 AM · Restricted Project

Apr 22 2021

skatkov committed rG914c83282444: [InlineSpiller] Clean-up isSpillCandBB (authored by skatkov).
[InlineSpiller] Clean-up isSpillCandBB
Apr 22 2021, 8:16 PM
skatkov closed D100922: [InlineSpiller] Clean-up isSpillCandBB.
Apr 22 2021, 8:16 PM · Restricted Project
skatkov requested review of D101028: [GreedyRA] Do not hoist to BB if its def is after LSP.
Apr 22 2021, 1:24 AM · Restricted Project
skatkov updated the summary of D100945: [GreedyRA] Fix removeBackCopies to account empty copies.
Apr 22 2021, 1:22 AM · Restricted Project

Apr 21 2021

skatkov requested review of D100945: [GreedyRA] Fix removeBackCopies to account empty copies.
Apr 21 2021, 4:46 AM · Restricted Project
skatkov requested review of D100927: [InlineSpiller] Handle the case when def is after LIP.
Apr 21 2021, 12:23 AM · Restricted Project

Apr 20 2021

skatkov requested review of D100922: [InlineSpiller] Clean-up isSpillCandBB.
Apr 20 2021, 10:38 PM · Restricted Project
skatkov added a reverting change for rG680f3d6de79f: Revert "[GreedyRA ORE] Add Cost of spill locations into remark": rG70193bdfc06f: Re-land [GreedyRA ORE] Add Cost of spill locations into remark.
Apr 20 2021, 2:22 AM
skatkov committed rG70193bdfc06f: Re-land [GreedyRA ORE] Add Cost of spill locations into remark (authored by skatkov).
Re-land [GreedyRA ORE] Add Cost of spill locations into remark
Apr 20 2021, 2:22 AM

Apr 19 2021

skatkov added a reverting change for rG328377307ad2: [GreedyRA ORE] Add Cost of spill locations into remark: rG680f3d6de79f: Revert "[GreedyRA ORE] Add Cost of spill locations into remark".
Apr 19 2021, 9:09 PM
skatkov committed rG680f3d6de79f: Revert "[GreedyRA ORE] Add Cost of spill locations into remark" (authored by skatkov).
Revert "[GreedyRA ORE] Add Cost of spill locations into remark"
Apr 19 2021, 9:09 PM
skatkov added a reverting change for D100020: [GreedyRA ORE] Add Cost of spill locations into remark: rG680f3d6de79f: Revert "[GreedyRA ORE] Add Cost of spill locations into remark".
Apr 19 2021, 9:09 PM · Restricted Project
skatkov committed rG328377307ad2: [GreedyRA ORE] Add Cost of spill locations into remark (authored by skatkov).
[GreedyRA ORE] Add Cost of spill locations into remark
Apr 19 2021, 8:57 PM
skatkov closed D100020: [GreedyRA ORE] Add Cost of spill locations into remark.
Apr 19 2021, 8:56 PM · Restricted Project
skatkov requested review of D100750: [Greedy RA] Take into account Last Split Point for enterIntvAtEnd.
Apr 19 2021, 3:44 AM · Restricted Project
skatkov requested review of D100748: [Greedy RA] Do not split interval on tied-def.
Apr 19 2021, 3:11 AM · Restricted Project
skatkov requested review of D100747: [Greedy RA] Last Split point for invoke statepoint should be statepoint itself.
Apr 19 2021, 2:49 AM · Restricted Project
skatkov updated the diff for D100020: [GreedyRA ORE] Add Cost of spill locations into remark.

rebase + test update.

Apr 19 2021, 12:14 AM · Restricted Project

Apr 18 2021

skatkov committed rG9f33943ee015: [GreedyRA ORE] Add stats for copy of virtual registers. (authored by skatkov).
[GreedyRA ORE] Add stats for copy of virtual registers.
Apr 18 2021, 11:16 PM
skatkov closed D100017: [GreedyRA ORE] Add stats for copy of virtual registers..
Apr 18 2021, 11:16 PM · Restricted Project
skatkov committed rG61d22f2e4e91: [Greedy RA] Add a check to MachineVerifier (authored by skatkov).
[Greedy RA] Add a check to MachineVerifier
Apr 18 2021, 10:42 PM
skatkov closed D100525: [Greedy RA] Add a check to MachineVerifier.
Apr 18 2021, 10:41 PM · Restricted Project

Apr 15 2021

skatkov updated the diff for D100525: [Greedy RA] Add a check to MachineVerifier.

@rnk, Reid, thank you very much for the review. Please take a look into updated version.

Apr 15 2021, 7:51 PM · Restricted Project

Apr 14 2021

skatkov requested review of D100525: [Greedy RA] Add a check to MachineVerifier.
Apr 14 2021, 10:11 PM · Restricted Project
skatkov updated the diff for D100017: [GreedyRA ORE] Add stats for copy of virtual registers..

Rebase + test update due to recent changes in RA.

Apr 14 2021, 1:39 AM · Restricted Project
skatkov committed rGcf0d3477aaf5: [GreedyRA ORE] Separate Folder Reloads and Zero Cost Folder Reloads (authored by skatkov).
[GreedyRA ORE] Separate Folder Reloads and Zero Cost Folder Reloads
Apr 14 2021, 12:26 AM
skatkov closed D100016: [GreedyRA ORE] Separate Folder Reloads and Zero Cost Folder Reloads.
Apr 14 2021, 12:25 AM · Restricted Project
skatkov updated the diff for D100016: [GreedyRA ORE] Separate Folder Reloads and Zero Cost Folder Reloads.

Assert removed.
Test is updated due to recent changes in RA.

Apr 14 2021, 12:09 AM · Restricted Project

Apr 13 2021

skatkov committed rG02265ed7ad27: [Live Intervals] Teach Greedy RA to recognize special case live-through (authored by skatkov).
[Live Intervals] Teach Greedy RA to recognize special case live-through
Apr 13 2021, 11:28 PM
skatkov closed D100296: [Live Intervals] Teach Greedy RA to recognize special case live-through.
Apr 13 2021, 11:28 PM · Restricted Project
skatkov updated the diff for D100296: [Live Intervals] Teach Greedy RA to recognize special case live-through.

Handled comments before landing,

Apr 13 2021, 9:04 PM · Restricted Project
skatkov committed rGd5ed0d4816fe: [Live Intervals] Factor-out unionBitMask. NFC. (authored by skatkov).
[Live Intervals] Factor-out unionBitMask. NFC.
Apr 13 2021, 8:55 PM
skatkov added inline comments to D100296: [Live Intervals] Teach Greedy RA to recognize special case live-through.
Apr 13 2021, 8:28 PM · Restricted Project
skatkov added inline comments to D100296: [Live Intervals] Teach Greedy RA to recognize special case live-through.
Apr 13 2021, 7:54 PM · Restricted Project
skatkov added inline comments to D100016: [GreedyRA ORE] Separate Folder Reloads and Zero Cost Folder Reloads.
Apr 13 2021, 7:49 PM · Restricted Project
skatkov added inline comments to D100016: [GreedyRA ORE] Separate Folder Reloads and Zero Cost Folder Reloads.
Apr 13 2021, 7:46 PM · Restricted Project
skatkov added inline comments to D100016: [GreedyRA ORE] Separate Folder Reloads and Zero Cost Folder Reloads.
Apr 13 2021, 7:24 PM · Restricted Project
skatkov added a comment to D99802: [rs4gc] Strip memory related attributes consistently.

Hi Philip, it seems this change causes functional failure.

Apr 13 2021, 12:58 AM · Restricted Project

Apr 12 2021

skatkov retitled D100296: [Live Intervals] Teach Greedy RA to recognize special case live-through from [WIP] Teach Greedy RA to recognize special case live-through to [Live Intervals] Teach Greedy RA to recognize special case live-through.
Apr 12 2021, 11:08 PM · Restricted Project
skatkov added a comment to D100296: [Live Intervals] Teach Greedy RA to recognize special case live-through.

Is this better?

Apr 12 2021, 11:05 PM · Restricted Project
skatkov updated the diff for D100296: [Live Intervals] Teach Greedy RA to recognize special case live-through.
Apr 12 2021, 11:05 PM · Restricted Project
skatkov updated the diff for D100296: [Live Intervals] Teach Greedy RA to recognize special case live-through.
Apr 12 2021, 9:06 PM · Restricted Project
skatkov committed rGc362179b0a12: [GreedyRA ORE] Add debug location for function level report (authored by skatkov).
[GreedyRA ORE] Add debug location for function level report
Apr 12 2021, 8:00 PM
skatkov closed D100168: [GreedyRA ORE] Add debug location for function level report.
Apr 12 2021, 8:00 PM · Restricted Project
skatkov added a comment to D100296: [Live Intervals] Teach Greedy RA to recognize special case live-through.

I really really like this idea, but the implementation, not so much. :)

This is just WIP :) Let's make it better.

Apr 12 2021, 7:39 PM · Restricted Project
skatkov updated the diff for D100296: [Live Intervals] Teach Greedy RA to recognize special case live-through.

It is probably not optimal but workable.

Apr 12 2021, 9:31 AM · Restricted Project
skatkov added inline comments to D100296: [Live Intervals] Teach Greedy RA to recognize special case live-through.
Apr 12 2021, 4:31 AM · Restricted Project
skatkov requested review of D100296: [Live Intervals] Teach Greedy RA to recognize special case live-through.
Apr 12 2021, 3:47 AM · Restricted Project

Apr 9 2021

skatkov updated the diff for D100020: [GreedyRA ORE] Add Cost of spill locations into remark.

rebase

Apr 9 2021, 3:54 AM · Restricted Project
skatkov updated the diff for D100017: [GreedyRA ORE] Add stats for copy of virtual registers..

rebase + test update.

Apr 9 2021, 3:18 AM · Restricted Project
skatkov requested review of D100168: [GreedyRA ORE] Add debug location for function level report.
Apr 9 2021, 2:22 AM · Restricted Project
skatkov updated the diff for D100016: [GreedyRA ORE] Separate Folder Reloads and Zero Cost Folder Reloads.

@reames, I moved from instruction computation to stack slot usages.
@thegameg, I landed NFC before to move from if-else to if-continue. Is it readable now or you still want me to separate added logic into utility function?

Apr 9 2021, 1:26 AM · Restricted Project

Apr 8 2021

skatkov committed rGf6e3b4fe582f: [GreedyRA ORE] Re-factor computeNumberOfSplillsReloads. (authored by skatkov).
[GreedyRA ORE] Re-factor computeNumberOfSplillsReloads.
Apr 8 2021, 10:57 PM
skatkov committed rGd2e15a83a664: [RS4GC] Cleanup meetBDVState. NFC. (authored by skatkov).
[RS4GC] Cleanup meetBDVState. NFC.
Apr 8 2021, 9:19 PM
skatkov closed D99064: [RS4GC] Cleanup meetBDVState. NFC..
Apr 8 2021, 9:18 PM · Restricted Project
skatkov updated the diff for D100016: [GreedyRA ORE] Separate Folder Reloads and Zero Cost Folder Reloads.

Handled comment. Added test.

Apr 8 2021, 5:18 AM · Restricted Project
skatkov abandoned D99876: [GreedyRA] Add some stats to remark emitter for Greedy RA..

abandon in favor of other solution.

Apr 8 2021, 5:16 AM · Restricted Project
skatkov added a comment to D100016: [GreedyRA ORE] Separate Folder Reloads and Zero Cost Folder Reloads.

I think you're computing slightly the wrong stat here. You're computing "instructions with at least one zero cost use". What I think you actually want is "number of zero cost uses folded". Key point is that a single instruction is likely to have many such uses, and, possibly, some non-zero cost uses.

Apr 8 2021, 4:07 AM · Restricted Project
skatkov committed rGa0e8738d4527: [GreedyRA ORE] Add function level spill/reloads stats (authored by skatkov).
[GreedyRA ORE] Add function level spill/reloads stats
Apr 8 2021, 2:56 AM
skatkov closed D100014: [GreedyRA ORE] Add function level spill/reloads stats.
Apr 8 2021, 2:56 AM · Restricted Project
skatkov accepted D99284: [RegAllocFast] properly handle STATEPOINT instruction..

@arsenm, any comments from your side?

Apr 8 2021, 2:42 AM · Restricted Project
skatkov updated the diff for D100014: [GreedyRA ORE] Add function level spill/reloads stats.

Test updated.

Apr 8 2021, 2:13 AM · Restricted Project
skatkov committed rG6b64c662c795: [GreedyRA ORE] Extract computeNumberOfSplillsReloads to use in different places. (authored by skatkov).
[GreedyRA ORE] Extract computeNumberOfSplillsReloads to use in different places.
Apr 8 2021, 12:53 AM
skatkov closed D100013: [GreedyRA ORE] Extract computeNumberOfSplillsReloads to use in different places. NFC..
Apr 8 2021, 12:53 AM · Restricted Project
skatkov committed rGdf2578779778: [GreedyRA ORE] Extract stats in RAGreedyStats struct. NFC. (authored by skatkov).
[GreedyRA ORE] Extract stats in RAGreedyStats struct. NFC.
Apr 8 2021, 12:37 AM
skatkov closed D100012: [GreedyRA ORE] Extract stats in RAGreedyStats struct. NFC..
Apr 8 2021, 12:37 AM · Restricted Project
skatkov committed rG0a1c6637a1e8: [GreedyRA ORE] Compute ORE stats if extra analysis is enabled (authored by skatkov).
[GreedyRA ORE] Compute ORE stats if extra analysis is enabled
Apr 8 2021, 12:24 AM
skatkov closed D100010: [GreedyRA ORE] Compute ORE stats if extra analysis is enabled.
Apr 8 2021, 12:24 AM · Restricted Project

Apr 7 2021

skatkov added inline comments to D99284: [RegAllocFast] properly handle STATEPOINT instruction..
Apr 7 2021, 8:53 PM · Restricted Project

Apr 6 2021

skatkov requested review of D100020: [GreedyRA ORE] Add Cost of spill locations into remark.
Apr 6 2021, 10:53 PM · Restricted Project
skatkov added a comment to D100017: [GreedyRA ORE] Add stats for copy of virtual registers..

Is this really useful as a user-surfacing remark? Won't it have a really high false positive rate due to coalescing?

Apr 6 2021, 10:38 PM · Restricted Project