User Details
- User Since
- Jan 25 2017, 1:38 AM (347 w, 4 d)
Mon, Aug 28
Thank you, Eli.
Sun, Aug 27
Thank you, Eli.
Aug 25 2023
Hi Eli, as no other feedbacks for a while, may I ask you to review the patch (it looks like it is a simple dead code elimination) and approve if there is no objections?
Aug 22 2023
Aug 14 2023
Aug 13 2023
Jul 20 2023
ping.
Thanks.
Jul 18 2023
Jul 17 2023
I wonder whether it will easier to review if I split this patch into three one:
- Use wouldInstructionBeTriviallyDead instead of checking side-effect and terminator only to extend the scope of collecting ephemeral values
- Use CodeMetrics utility in CodeGenPrepare
- Extend the algorithm for collecting ephemeral values by checking cycles (induction variable case)
Looks reasonable.
Jul 11 2023
ping, any feedback?
Jul 7 2023
Jul 6 2023
One comment, other looks good...
Jul 4 2023
I've taken a look at CodeMetrics::collectEphemeralValues. It does not recognize loops with phi node as well. I can extend its detector, however it collects ephemeral values basing on conditions "I->mayHaveSideEffects() || I->isTerminator()".
Jul 3 2023
In the commit message adds a couple of words about the reason - IRCE expects that true branch comes to loop.
Jul 2 2023
LGTM with nit.
Jun 30 2023
You can pre-land tests without review.
Jun 29 2023
Any words in git commit message?
Jun 28 2023
Jun 27 2023
Friendly ping...
Jun 25 2023
Comment update.
one more function renamed to start with lower symbol.
please, take a look.
Jun 21 2023
Thanks a lot for review. I'll update a patch as soon as we agreed on terminology (Closure) and description of FindClosureOfWouldBeTriviallyDeadInstructions function.
Jun 19 2023
Test are updated. Code re-factored. Anything I can do to land this?
Jun 16 2023
is it better?
Jun 15 2023
Jun 14 2023
Jun 12 2023
ping
Jun 7 2023
Fix comments.
Jun 6 2023
Jun 1 2023
May 31 2023
May 28 2023
LGTM with comment for consideration - I do not insist.
May 25 2023
May 23 2023
May 22 2023
May 18 2023
At the moment I do not see simple way to implement https://reviews.llvm.org/D148514, so I put this on hold due to temporary busy with other stuff.
At the moment, I do not see an easy way to implement this one in platform independent way. I put it on hold due to busy with other stuff.
May 16 2023
LGTM, @nikic, any remaining concerns?
May 14 2023
May 11 2023
PTAL
May 10 2023
May 9 2023
I've pre-landed the new tests, fixed the name in the test and updated this revision.
May 5 2023
Handled comments.
May 4 2023
May 3 2023
I wonder whether any problems with landing this patch?
Apr 27 2023
And actually instead of NFC tag you can just say [TEST]
Apr 26 2023
Apr 25 2023
General question: don't you want to separate sub and add handling in completely different functions.
To be honest, there will be small code duplication but in this case no need to mixup add and sub logic.
It will be easier to review and support in the future.