skatkov (Serguei Katkov)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 25 2017, 1:38 AM (81 w, 2 d)

Recent Activity

Today

skatkov added a dependent revision for D50886: [IR Verifier] Do not allow bitcast of pointer to vector of pointers and vice versa.: D50554: [ValueTracking] Accept vectors of pointer in GetUnderlyingObject utility.
Fri, Aug 17, 1:59 AM
skatkov added a dependency for D50554: [ValueTracking] Accept vectors of pointer in GetUnderlyingObject utility: D50886: [IR Verifier] Do not allow bitcast of pointer to vector of pointers and vice versa..
Fri, Aug 17, 1:59 AM
skatkov updated the diff for D50554: [ValueTracking] Accept vectors of pointer in GetUnderlyingObject utility.

Test is updated to be valid.

Fri, Aug 17, 1:59 AM
skatkov created D50886: [IR Verifier] Do not allow bitcast of pointer to vector of pointers and vice versa..
Fri, Aug 17, 1:56 AM

Yesterday

skatkov added inline comments to D50554: [ValueTracking] Accept vectors of pointer in GetUnderlyingObject utility.
Thu, Aug 16, 11:41 PM
skatkov added inline comments to D50554: [ValueTracking] Accept vectors of pointer in GetUnderlyingObject utility.
Thu, Aug 16, 11:26 PM
skatkov added a comment to D50554: [ValueTracking] Accept vectors of pointer in GetUnderlyingObject utility.

ping. Can I do anything to proceed with this change?

Thu, Aug 16, 10:25 PM

Sun, Aug 12

skatkov added inline comments to D50558: [MustExecute] Fix algorithmic bug in isGuaranteedToExecute. PR38514.
Sun, Aug 12, 8:27 PM

Fri, Aug 10

skatkov updated the diff for D50554: [ValueTracking] Accept vectors of pointer in GetUnderlyingObject utility.

Thank you! I've added two unit tests.

Fri, Aug 10, 3:22 AM
skatkov added a comment to D50554: [ValueTracking] Accept vectors of pointer in GetUnderlyingObject utility.

Thank you for your comment. Unfortunately till now I failed to create a test showing the benefit from this change in a pass (I tried). I can make one more try.
The problem I'm trying to solve is the following: in downstream pass I have a BitCast instruction which is actually originated from allocation but has a vector type gotten using gep + bitcast from allocation.
I'd like to know the fact that it is an underlying allocation but now utility function just ignore instructions with vector of pointers.

Fri, Aug 10, 1:40 AM
skatkov retitled D50554: [ValueTracking] Accept vectors of pointer in GetUnderlyingObject utility from [ValueTracking] Accept vector of pointer in GetUnderlyingObject utility to [ValueTracking] Accept vectors of pointer in GetUnderlyingObject utility.
Fri, Aug 10, 12:33 AM
skatkov created D50554: [ValueTracking] Accept vectors of pointer in GetUnderlyingObject utility.
Fri, Aug 10, 12:31 AM

Wed, Aug 8

skatkov accepted D50489: [LICM] hoist fences out of loops w/o memory operations.
Wed, Aug 8, 9:57 PM

Jul 1 2018

skatkov accepted D48627: [ImplicitNullChecks] Check for rewrite of register used in 'test' instruction.
Jul 1 2018, 7:30 PM

Jun 27 2018

skatkov added a comment to D48627: [ImplicitNullChecks] Check for rewrite of register used in 'test' instruction.

Test, actually can be simplified bit if you do not mind.

Jun 27 2018, 10:02 PM
skatkov added inline comments to D48627: [ImplicitNullChecks] Check for rewrite of register used in 'test' instruction.
Jun 27 2018, 10:00 PM

Jun 4 2018

skatkov accepted D47371: [BPI] Apply invoke heuristic before loop branch heuristic.

LGTM. If no one objects in 1-2 days, feel free to land.

Jun 4 2018, 7:31 PM

Jun 3 2018

skatkov committed rL333864: [InstCombine] Fix div handling.
[InstCombine] Fix div handling
Jun 3 2018, 7:58 PM
skatkov closed D47576: [InstCombine] Fix div handling.
Jun 3 2018, 7:58 PM

May 31 2018

skatkov added inline comments to D47576: [InstCombine] Fix div handling.
May 31 2018, 6:15 PM
skatkov updated the diff for D47576: [InstCombine] Fix div handling.

Please take a look.

May 31 2018, 6:13 PM
skatkov created D47576: [InstCombine] Fix div handling.
May 31 2018, 1:44 AM

May 22 2018

skatkov committed rL333063: SafepointIRVerifier is made unreachable block tolerant.
SafepointIRVerifier is made unreachable block tolerant
May 22 2018, 10:58 PM
skatkov closed D47011: SafepointIRVerifier is made unreachable block tolerant.
May 22 2018, 10:58 PM

May 17 2018

skatkov committed rL332695: [LICM] Extend the MustExecute scope.
[LICM] Extend the MustExecute scope
May 17 2018, 10:03 PM
skatkov closed D46996: [LICM] Extend the MustExecute scope.
May 17 2018, 10:02 PM
skatkov updated the diff for D46996: [LICM] Extend the MustExecute scope.

Before landing.

May 17 2018, 8:29 PM

May 16 2018

skatkov created D46996: [LICM] Extend the MustExecute scope.
May 16 2018, 8:15 PM

May 9 2018

skatkov committed rL331950: [SCEV] Add missed Test for rL331949..
[SCEV] Add missed Test for rL331949.
May 9 2018, 6:46 PM
skatkov committed rL331949: SCEV] Do not use induction in isKnownPredicate for simplification umax..
SCEV] Do not use induction in isKnownPredicate for simplification umax.
May 9 2018, 6:44 PM
skatkov closed D46046: [SCEV] Do not use induction in isKnownPredicate for simplification umax.
May 9 2018, 6:44 PM

May 6 2018

skatkov added a comment to D46046: [SCEV] Do not use induction in isKnownPredicate for simplification umax.

@sanjoy, are you ok with the last change?

May 6 2018, 6:33 PM

May 2 2018

skatkov updated the diff for D46046: [SCEV] Do not use induction in isKnownPredicate for simplification umax.

Agreed with Max. Restriction of recursion between isKnownPredicate and simplification of umax is too complex.

May 2 2018, 9:42 PM

Apr 27 2018

skatkov committed rL331103: [SCEV] Touch the unsused stats variables for product build..
[SCEV] Touch the unsused stats variables for product build.
Apr 27 2018, 11:45 PM
skatkov committed rL331099: [SCEV] Reduce the number of invocation to non trivial getExact function.
[SCEV] Reduce the number of invocation to non trivial getExact function
Apr 27 2018, 8:58 PM
skatkov closed D46178: [SCEV] Reduce the number of invocation to non trivial getExact function.
Apr 27 2018, 8:58 PM
skatkov added a comment to D46178: [SCEV] Reduce the number of invocation to non trivial getExact function.

Thank you for review guys. I'm ok with your version of commit message.

Apr 27 2018, 6:55 PM
skatkov updated the summary of D46178: [SCEV] Reduce the number of invocation to non trivial getExact function.
Apr 27 2018, 2:01 AM
skatkov updated the summary of D46178: [SCEV] Reduce the number of invocation to non trivial getExact function.
Apr 27 2018, 1:57 AM
skatkov added a comment to D46178: [SCEV] Reduce the number of invocation to non trivial getExact function.

assert now works.

Apr 27 2018, 1:55 AM
skatkov updated the diff for D46178: [SCEV] Reduce the number of invocation to non trivial getExact function.
Apr 27 2018, 1:54 AM
skatkov committed rL331022: [SCEV] Add trivial case handling for umin utilities. NFC..
[SCEV] Add trivial case handling for umin utilities. NFC.
Apr 27 2018, 1:08 AM
skatkov closed D46175: [SCEV] Add trivial case handling for umin utilities.
Apr 27 2018, 1:08 AM
skatkov created D46178: [SCEV] Reduce the number of invocation to non trivial getExact function.
Apr 27 2018, 1:08 AM
skatkov updated subscribers of D46175: [SCEV] Add trivial case handling for umin utilities.
Apr 27 2018, 12:37 AM
skatkov created D46175: [SCEV] Add trivial case handling for umin utilities.
Apr 27 2018, 12:11 AM

Apr 26 2018

skatkov updated the diff for D46046: [SCEV] Do not use induction in isKnownPredicate for simplification umax.

@sanjoy , please take a look.

Apr 26 2018, 9:56 PM
skatkov committed rL331015: [SCEV] Introduce bulk umin creation utilities.
[SCEV] Introduce bulk umin creation utilities
Apr 26 2018, 9:02 PM
skatkov closed D46047: [SCEV] Introduce bulk umin creation utilities.
Apr 26 2018, 9:02 PM

Apr 25 2018

skatkov updated the diff for D46047: [SCEV] Introduce bulk umin creation utilities.

Handled comments.

Apr 25 2018, 6:52 PM
skatkov added a comment to D46047: [SCEV] Introduce bulk umin creation utilities.

My bad incorrect place to update comment. Will update.
Thanks for noticing.

Apr 25 2018, 2:18 AM
skatkov added a comment to D46046: [SCEV] Do not use induction in isKnownPredicate for simplification umax.

Would removing 'isKnownViaInduction' have any impact of the number of cases 'analyzeable by scev?

Apr 25 2018, 2:10 AM
skatkov created D46047: [SCEV] Introduce bulk umin creation utilities.
Apr 25 2018, 2:04 AM
skatkov updated the diff for D46046: [SCEV] Do not use induction in isKnownPredicate for simplification umax.
Apr 25 2018, 2:00 AM
skatkov created D46046: [SCEV] Do not use induction in isKnownPredicate for simplification umax.
Apr 25 2018, 1:23 AM

Apr 3 2018

skatkov committed rL329051: [SCEV] Fix PR36974..
[SCEV] Fix PR36974.
Apr 3 2018, 12:31 AM

Mar 26 2018

skatkov added inline comments to D42759: [CGP] Split large data structres to sink more GEPs.
Mar 26 2018, 10:12 PM

Mar 22 2018

skatkov accepted D44667: [LoopPredication] Add profitability check based on BPI.

LGTM with some comments.

Mar 22 2018, 5:00 AM
skatkov added inline comments to D44667: [LoopPredication] Add profitability check based on BPI.
Mar 22 2018, 4:27 AM

Mar 21 2018

skatkov added inline comments to D44667: [LoopPredication] Add profitability check based on BPI.
Mar 21 2018, 8:54 PM
skatkov added inline comments to D44667: [LoopPredication] Add profitability check based on BPI.
Mar 21 2018, 8:40 PM
skatkov added inline comments to D44667: [LoopPredication] Add profitability check based on BPI.
Mar 21 2018, 12:29 AM
skatkov added inline comments to D44667: [LoopPredication] Add profitability check based on BPI.
Mar 21 2018, 12:25 AM
skatkov added inline comments to D44667: [LoopPredication] Add profitability check based on BPI.
Mar 21 2018, 12:24 AM

Mar 20 2018

skatkov added inline comments to D44667: [LoopPredication] Add profitability check based on BPI.
Mar 20 2018, 1:20 AM
skatkov accepted D44571: [CGP] Avoid segmentation fault when doing PHI node simplifications.
Mar 20 2018, 12:23 AM

Mar 19 2018

skatkov committed rL327824: [SCEV] Factor out isKnownViaInduction. NFC..
[SCEV] Factor out isKnownViaInduction. NFC.
Mar 19 2018, 1:37 AM
skatkov closed D44554: [SCEV] Factor out isKnownViaInduction. NFC..
Mar 19 2018, 1:37 AM

Mar 18 2018

skatkov committed rL327822: [SCEV] Re-land: Fix isKnownPredicate.
[SCEV] Re-land: Fix isKnownPredicate
Mar 18 2018, 11:39 PM
skatkov closed D44553: [SCEV] Re-land: Fix isKnownPredicate.
Mar 18 2018, 11:39 PM
skatkov added inline comments to D44571: [CGP] Avoid segmentation fault when doing PHI node simplifications.
Mar 18 2018, 11:13 PM

Mar 16 2018

skatkov added a dependency for D44554: [SCEV] Factor out isKnownViaInduction. NFC.: D44553: [SCEV] Re-land: Fix isKnownPredicate.
Mar 16 2018, 1:51 AM
skatkov added a dependent revision for D44553: [SCEV] Re-land: Fix isKnownPredicate: D44554: [SCEV] Factor out isKnownViaInduction. NFC..
Mar 16 2018, 1:51 AM
skatkov created D44554: [SCEV] Factor out isKnownViaInduction. NFC..
Mar 16 2018, 1:51 AM
skatkov created D44553: [SCEV] Re-land: Fix isKnownPredicate.
Mar 16 2018, 1:07 AM

Mar 12 2018

skatkov committed rL327363: Revert [SCEV] Fix isKnownPredicate.
Revert [SCEV] Fix isKnownPredicate
Mar 12 2018, 11:38 PM
skatkov committed rL327362: [SCEV] Fix isKnownPredicate.
[SCEV] Fix isKnownPredicate
Mar 12 2018, 11:13 PM
skatkov closed D43507: [SCEV] Fix isKnownPredicate.
Mar 12 2018, 11:13 PM
skatkov updated the diff for D43507: [SCEV] Fix isKnownPredicate.

Handled comments.

Mar 12 2018, 9:49 PM
skatkov added inline comments to D43507: [SCEV] Fix isKnownPredicate.
Mar 12 2018, 8:43 PM

Mar 11 2018

skatkov committed rL327250: [CGP] Fix the remove of matched phis in complex addressing mode.
[CGP] Fix the remove of matched phis in complex addressing mode
Mar 11 2018, 8:54 PM
skatkov closed D43758: [CGP] Fix the remove of matched phis in complex addressing mode.
Mar 11 2018, 8:54 PM
skatkov added a comment to D43507: [SCEV] Fix isKnownPredicate.

Sanjoy?

Mar 11 2018, 7:56 PM

Mar 6 2018

skatkov updated the diff for D43758: [CGP] Fix the remove of matched phis in complex addressing mode.

Please take a look.

Mar 6 2018, 11:03 PM

Mar 5 2018

skatkov added a comment to D43758: [CGP] Fix the remove of matched phis in complex addressing mode.

ping.

Mar 5 2018, 7:44 PM
skatkov updated the diff for D43507: [SCEV] Fix isKnownPredicate.

By the end of the working day I was able to create one test which shows the advantage of new approach...

Mar 5 2018, 4:02 AM
skatkov updated the diff for D43507: [SCEV] Fix isKnownPredicate.

Updated patch to handle comments. I still have a trouble to create a unit tests for this change...
I'm trying to figure out some case when the old version did not work but new one does...

Mar 5 2018, 2:47 AM

Feb 26 2018

skatkov committed rL326174: [SCEV] Cleanup SCEVInitRewriter. NFC..
[SCEV] Cleanup SCEVInitRewriter. NFC.
Feb 26 2018, 10:41 PM
skatkov created D43758: [CGP] Fix the remove of matched phis in complex addressing mode.
Feb 26 2018, 2:25 AM
skatkov committed rL326072: [SCEV] Factor out getUsedLoops.
[SCEV] Factor out getUsedLoops
Feb 26 2018, 1:30 AM
skatkov closed D43504: [SCEV] Factor out getLoopUseLists.
Feb 26 2018, 1:30 AM
skatkov committed rL326071: [SCEV] Introduce SCEVPostIncRewriter.
[SCEV] Introduce SCEVPostIncRewriter
Feb 26 2018, 12:42 AM
skatkov closed D43499: [SCEV] Introduce SCEVPostIncRewriter.
Feb 26 2018, 12:42 AM

Feb 25 2018

skatkov committed rL326067: [SCEV] Extends the SCEVInitRewriter.
[SCEV] Extends the SCEVInitRewriter
Feb 25 2018, 11:11 PM
skatkov closed D43498: [SCEV] Extends the SCEVInitRewriter.
Feb 25 2018, 11:11 PM
skatkov added inline comments to D43499: [SCEV] Introduce SCEVPostIncRewriter.
Feb 25 2018, 9:17 PM

Feb 21 2018

skatkov added a comment to D43536: [LV] Fix for PR36311, vectorizer's isUniform() abuse triggers assert in SCEV.

SGTM, the same disclaimer :) I'm not a very good at LoopVectorizer :)

Feb 21 2018, 8:27 PM

Feb 20 2018

skatkov added a comment to D43507: [SCEV] Fix isKnownPredicate.

For preliminary review, I need to add tests also...

Feb 20 2018, 3:37 AM
skatkov added dependencies for D43507: [SCEV] Fix isKnownPredicate: D43498: [SCEV] Extends the SCEVInitRewriter, D43499: [SCEV] Introduce SCEVPostIncRewriter, D43504: [SCEV] Factor out getLoopUseLists.
Feb 20 2018, 3:37 AM
skatkov added a dependent revision for D43498: [SCEV] Extends the SCEVInitRewriter: D43507: [SCEV] Fix isKnownPredicate.
Feb 20 2018, 3:37 AM