User Details
- User Since
- Jan 25 2017, 1:38 AM (208 w, 4 d)
Tue, Jan 19
Wed, Jan 13
Update before landing:
Upper bound check is added
verifier test is added
Tue, Jan 12
Mon, Jan 11
Ok, I modified the patch to re-tie operands in case of folding failure.
Sun, Jan 10
Mon, Dec 28
requested assert is added
Dec 23 2020
Test is updated.
Dec 22 2020
Handled comments,
Dec 21 2020
@dmgreen While I'm not sure this patch is a real root cause of the loop vectorizer crash https://bugs.llvm.org/show_bug.cgi?id=48564 but revert of this patch eliminates the crash.
I would appreciate if you could look into the bug.
Dec 18 2020
Dec 17 2020
lgtm
Good catch!
Dec 7 2020
lgtm.
Dec 6 2020
Please consider separate renaming to Legacy to NFC patch.
Nov 25 2020
Nov 23 2020
It is pity that we did not introduce an useful utility function.
Nov 22 2020
Nov 19 2020
lgtm
Nov 18 2020
lgtm
Nov 17 2020
I do not mind.
Nov 16 2020
Do I understand correctly that with -verify-cfg-preserved=true all new tests fail?
Nov 15 2020
Nov 12 2020
Nov 11 2020
lgtm with Anna's nit + please do a rebase.
lgtm
Nov 10 2020
Oct 26 2020
Oct 21 2020
handled nit
ok, this looks good to me. Please wait 1-2 days before landing to give a last call to others.
Oct 20 2020
Please take a look.
Oct 19 2020
Handled Max's comments.
Oct 18 2020
Oct 16 2020
Oct 9 2020
Oct 8 2020
Oct 5 2020
Oct 4 2020
Handled comments. Will wait for a day to give a chance for Roman, Philip and Max to take a look one more time.
Oct 2 2020
test is precomitted.
Oct 1 2020
Please wait for 1-2 days in case Philip wants to look at this patch.
Sep 30 2020
Sep 29 2020
Sep 28 2020
git rid of additional check for context instruction.
Sep 27 2020
Q is not SimplifyQuery here, how I could take a getWithInstruction then?