- User Since
- Apr 16 2015, 3:05 AM (114 w, 4 d)
May 25 2017
May 22 2017
May 19 2017
Apr 22 2017
Apr 21 2017
@andrew.w.kaylor - ping, do you have any comments about the latest revision?
Apr 13 2017
Add the comment about overly conservative legality check, add the test demonstrating it.
Mar 30 2017
Update, I didn't see that there was a request to add a comment. Will do and update the patch,
Mar 23 2017
Address review comments.
Mar 22 2017
It's difficult to tell. Even if FP addition is cheaper the second combine also saves us one sitofp conversion. It should be also taken into account.
Mar 21 2017
Mar 10 2017
It's worth noting for others that the motivation for the change is a bug we found in JumpThreading LVI cache invalidation. The bug is easily triggered with our downstream changes, but is difficult to trigger it upstream. We need the printer pass to write an isolated upstream test case for this problem.
Mar 1 2017
Feb 27 2017
Feb 17 2017
Feb 16 2017
Feb 9 2017
Feb 8 2017
Add an assert as suggested.
Feb 7 2017
- Land tests separately and rebase the patch against it.
- Remove addrspace(1) from the test cases.
- Change CHECK pattern matching in fp16-promote.ll test_extractelement slightly.
Feb 6 2017
Fix the type CHECK64 -> CHECK-ARMv6 in ARM load-combine.ll test case.
The test cases have been landed separately (rL294185), rebase the patch.
Feb 1 2017
Jan 31 2017
Jan 25 2017
Jan 24 2017
Address Sanjoy's comments: add new pass manager support, fix nits here and there.
Add an early exit if the module doesn't use guards.
@chandlerc since none of your comments express explicit objections or concerns and the patch has already been accepted I'm going to go ahead and land it tomorrow. Let me know if I misinterpreted your comments and you do want some changes.
Jan 23 2017
Jan 16 2017
Address review comments:
- Add recursion depth limit
- Add comments about combine before legalize
Jan 11 2017
Jan 9 2017
Address the comments, add a comment that calculateByteProvider recurses over trees, not DAGs.
Currently update_llc_test_checks.py supports arm-eabi target only. I left ARM test cases with manually written checks for now.
Address the comments.
Dec 16 2016
Dec 14 2016
Dec 13 2016
General practice in LLVM is to make small isolated changes. In this review you seem to have at least two unrelated changes:
- Fixing the segfault,
- Fixing the output issue.
Both changes are fine on their own, but when they are mixed in one commit it's more difficult to review and reason about. Given BrainF is an example it's not a big deal, but in general it's considered to be a bad practice.