Page MenuHomePhabricator
Differential D91011

[NFC, Refactor] Rename the (scoped) enum DeclaratorContext's enumerators to avoid redundancy
ClosedPublic
Actions

Authored by faisalv on Nov 7 2020, 12:33 PM.

Details

Reviewers
aaron.ballman
bruno
wchilders
BRevzin
Summary

Since these are scoped enumerators, they have to be prefixed by DeclaratorContext, so lets remove Context from the name, and return some characters to the multiverse.

Diff Detail

Unit TestsFailed
View All

TimeTest
390 mslinux > HWAddressSanitizer-x86_64.TestCases::sizes.cpp
Script: -- : 'RUN: at line 3'; /mnt/disks/ssd0/agent/llvm-project/build/./bin/clang --driver-mode=g++ -m64 -gline-tables-only -fsanitize=hwaddress -fuse-ld=lld -mcmodel=large -mllvm -hwasan-globals -mllvm -hwasan-use-short-granules -mllvm -hwasan-instrument-landing-pads=0 -mllvm -hwasan-instrument-personality-functions /mnt/disks/ssd0/agent/llvm-project/compiler-rt/test/hwasan/TestCases/sizes.cpp -nostdlib++ -lstdc++ -o /mnt/disks/ssd0/agent/llvm-project/build/projects/compiler-rt/test/hwasan/X86_64/TestCases/Output/sizes.cpp.tmp

Event Timeline

faisalv created this revision.Nov 7 2020, 12:33 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 7 2020, 12:33 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
faisalv requested review of this revision.Nov 7 2020, 12:33 PM
faisalv retitled this revision from [NFC, Refactor] Rename the (scoped) enum DeclaratorContext enumerator's to avoid redundancy to [NFC, Refactor] Rename the (scoped) enum DeclaratorContext's enumerators to avoid redundancy.Nov 7 2020, 12:51 PM
Harbormaster completed remote builds in B78001: Diff 303662.Nov 7 2020, 1:23 PM
faisalv added reviewers: wchilders, BRevzin.Nov 7 2020, 6:04 PM
aaron.ballman accepted this revision.Nov 9 2020, 6:06 AM

LGTM!

This revision is now accepted and ready to land.Nov 9 2020, 6:06 AM
wchilders accepted this revision.Nov 9 2020, 8:54 AM

+1 Nice QOL change :)

bruno accepted this revision.Nov 9 2020, 11:16 AM

LGTM

faisalv mentioned this in rGe4d27932a59f: [NFC, Refactor] Rename the (scoped) enum DeclaratorContext's enumerators to….Nov 10 2020, 9:40 PM
faisalv closed this revision.Nov 10 2020, 9:44 PM

Committed: https://github.com/llvm/llvm-project/commit/e4d27932a59fb61aaba3ff7a3ccd1b5bc9215fb9

Revision Contents
Changeset List

PathSize
clang/
include/
clang/
Parse/
2 lines
Sema/
395 lines
lib/
Parse/
100 lines
22 lines
12 lines
22 lines
30 lines
4 lines
10 lines
12 lines
16 lines
Sema/
2 lines
2 lines
10 lines
4 lines
2 lines
2 lines
282 lines

Diff 303662

View Options

clang/include/clang/Parse/Parser.h

Loading...
View Options

clang/include/clang/Sema/DeclSpec.h

Loading...
View Options

clang/lib/Parse/ParseDecl.cpp

Loading...
View Options

clang/lib/Parse/ParseDeclCXX.cpp

Loading...
View Options

clang/lib/Parse/ParseExpr.cpp

Loading...
View Options

clang/lib/Parse/ParseExprCXX.cpp

Loading...
View Options

clang/lib/Parse/ParseObjc.cpp

Loading...
View Options

clang/lib/Parse/ParseOpenMP.cpp

Loading...
View Options

clang/lib/Parse/ParseStmt.cpp

Loading...
View Options

clang/lib/Parse/ParseTemplate.cpp

Loading...
View Options

clang/lib/Parse/Parser.cpp

Loading...
View Options

clang/lib/Sema/DeclSpec.cpp

Loading...
View Options

clang/lib/Sema/SemaCodeComplete.cpp

Loading...
View Options

clang/lib/Sema/SemaDecl.cpp

Loading...
View Options

clang/lib/Sema/SemaDeclCXX.cpp

Loading...
View Options

clang/lib/Sema/SemaDeclObjC.cpp

Loading...
View Options

clang/lib/Sema/SemaExpr.cpp

Loading...
View Options

clang/lib/Sema/SemaType.cpp

Loading...