- User Since
- Mar 13 2020, 10:28 AM (44 w, 3 d)
Tue, Dec 29
Dec 15 2020
I'm still "chewing on this", I'm not sure I fully understand the problem well enough to give great "big picture" feedback. In any case, I've left a few comments where I had a potentially helpful thought :)
Nov 20 2020
Nov 13 2020
Nov 9 2020
Generally agree with this direction; Are there plans for migrating https://github.com/llvm/llvm-project/blob/master/clang/include/clang/Basic/Specifiers.h in a similar fashion, for consistency?
+1 Nice QOL change :)
Nov 6 2020
Aug 14 2020
Aug 13 2020
Jun 15 2020
Abandoned in favor of https://reviews.llvm.org/D76420
Mar 26 2020
Thanks Tyker, you're right, there is a general problem that needs handled, if this is to be handled; I had a bit of tunnel vision here. However, I'm retracting/abandoning this patch entirely as upon further review, it's not standard compliant. The current situation, is actually the correct one (for now?).
Mar 25 2020
Updated to remove duplicated (and out dated) APValue generation logic, and fixed formatting issues. (Thanks for pointing out something was awry Tyker)
Mar 24 2020
Updated the patch to correct formatting issues, and removed application of the ConstantEvaluated evaluation context to var decls as it introduces too much complexity.
Mar 20 2020
Dropped the override for constexpr evaluator, LValue evaluation base class
I should note, I don't have commit access, so I'm unable to commit this myself. Attribution would be Wyatt Childers <firstname.lastname@example.org>
Updated to assume LValue ConstantExprs have LValue APValues, with verification in debug mode. Additionally, added a missing LValue -> RValue conversion for VerifyIntegerConstantExpression.