Page MenuHomePhabricator

wchilders (Wyatt Childers)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 13 2020, 10:28 AM (44 w, 3 d)

Recent Activity

Tue, Dec 29

wchilders retitled D90976: [NFC] Fixed an issue where diagnostics printed expressions in a roundabout way from Fixed an issue where diagnostics printed expressions in a roundabout way to [NFC] Fixed an issue where diagnostics printed expressions in a roundabout way.
Tue, Dec 29, 9:08 AM · Restricted Project

Dec 15 2020

wchilders requested changes to D92733: Fix PR25627 - false positive diagnostics involving implicit-captures in dependent lambda expressions..

I'm still "chewing on this", I'm not sure I fully understand the problem well enough to give great "big picture" feedback. In any case, I've left a few comments where I had a potentially helpful thought :)

Dec 15 2020, 12:11 PM · Restricted Project

Nov 20 2020

wchilders accepted D91035: [NFC, Refactor] Convert FunctionDefinitionKind from DeclSpech.h to a scoped enum.
Nov 20 2020, 8:36 AM · Restricted Project

Nov 13 2020

wchilders added inline comments to D91035: [NFC, Refactor] Convert FunctionDefinitionKind from DeclSpech.h to a scoped enum.
Nov 13 2020, 12:36 PM · Restricted Project
wchilders added inline comments to D91035: [NFC, Refactor] Convert FunctionDefinitionKind from DeclSpech.h to a scoped enum.
Nov 13 2020, 12:30 PM · Restricted Project
wchilders added a comment to D91035: [NFC, Refactor] Convert FunctionDefinitionKind from DeclSpech.h to a scoped enum.
Nov 13 2020, 12:21 PM · Restricted Project

Nov 9 2020

wchilders updated the diff for D90976: [NFC] Fixed an issue where diagnostics printed expressions in a roundabout way.

Formatting fixes

Nov 9 2020, 12:20 PM · Restricted Project
wchilders added a comment to D91035: [NFC, Refactor] Convert FunctionDefinitionKind from DeclSpech.h to a scoped enum.

Generally agree with this direction; Are there plans for migrating https://github.com/llvm/llvm-project/blob/master/clang/include/clang/Basic/Specifiers.h in a similar fashion, for consistency?

Nov 9 2020, 9:13 AM · Restricted Project
wchilders accepted D91011: [NFC, Refactor] Rename the (scoped) enum DeclaratorContext's enumerators to avoid redundancy.

+1 Nice QOL change :)

Nov 9 2020, 8:54 AM · Restricted Project

Nov 6 2020

wchilders requested review of D90976: [NFC] Fixed an issue where diagnostics printed expressions in a roundabout way.
Nov 6 2020, 2:53 PM · Restricted Project

Aug 14 2020

wchilders added inline comments to D85933: Don't track consteval references for dependent members.
Aug 14 2020, 1:24 PM · Restricted Project

Aug 13 2020

wchilders requested review of D85933: Don't track consteval references for dependent members.
Aug 13 2020, 1:55 PM · Restricted Project

Jun 15 2020

wchilders abandoned D76443: Use ConstantExpr cached APValues if present for code generation.

Abandoned in favor of https://reviews.llvm.org/D76420

Jun 15 2020, 12:04 PM · Restricted Project

Mar 26 2020

wchilders abandoned D76724: Prevent immediate evaluations inside of decltype.

Thanks Tyker, you're right, there is a general problem that needs handled, if this is to be handled; I had a bit of tunnel vision here. However, I'm retracting/abandoning this patch entirely as upon further review, it's not standard compliant. The current situation, is actually the correct one (for now?).

Mar 26 2020, 8:06 AM · Restricted Project

Mar 25 2020

wchilders updated the diff for D76443: Use ConstantExpr cached APValues if present for code generation.

Updated to remove duplicated (and out dated) APValue generation logic, and fixed formatting issues. (Thanks for pointing out something was awry Tyker)

Mar 25 2020, 10:16 AM · Restricted Project

Mar 24 2020

wchilders created D76724: Prevent immediate evaluations inside of decltype.
Mar 24 2020, 12:53 PM · Restricted Project
wchilders updated the diff for D76447: Apply ConstantEvaluated evaluation contexts to more manifestly constant evaluated scopes.

Updated the patch to correct formatting issues, and removed application of the ConstantEvaluated evaluation context to var decls as it introduces too much complexity.

Mar 24 2020, 10:12 AM · Restricted Project

Mar 20 2020

wchilders updated the diff for D76438: ConstantExpr cached APValues if present for constant evaluation.

Dropped the override for constexpr evaluator, LValue evaluation base class

Mar 20 2020, 2:40 PM · Restricted Project
wchilders added a comment to D76438: ConstantExpr cached APValues if present for constant evaluation.

I should note, I don't have commit access, so I'm unable to commit this myself. Attribution would be Wyatt Childers <wchilders@lock3software.com>

Mar 20 2020, 2:39 PM · Restricted Project
wchilders added inline comments to D76438: ConstantExpr cached APValues if present for constant evaluation.
Mar 20 2020, 2:39 PM · Restricted Project
wchilders updated the diff for D76438: ConstantExpr cached APValues if present for constant evaluation.

Updated to assume LValue ConstantExprs have LValue APValues, with verification in debug mode. Additionally, added a missing LValue -> RValue conversion for VerifyIntegerConstantExpression.

Mar 20 2020, 1:01 PM · Restricted Project
wchilders added inline comments to D76438: ConstantExpr cached APValues if present for constant evaluation.
Mar 20 2020, 1:01 PM · Restricted Project

Mar 19 2020

wchilders added inline comments to D76447: Apply ConstantEvaluated evaluation contexts to more manifestly constant evaluated scopes.
Mar 19 2020, 5:00 PM · Restricted Project
wchilders added inline comments to D76438: ConstantExpr cached APValues if present for constant evaluation.
Mar 19 2020, 3:22 PM · Restricted Project
wchilders added inline comments to D76447: Apply ConstantEvaluated evaluation contexts to more manifestly constant evaluated scopes.
Mar 19 2020, 1:09 PM · Restricted Project
wchilders created D76447: Apply ConstantEvaluated evaluation contexts to more manifestly constant evaluated scopes.
Mar 19 2020, 1:09 PM · Restricted Project
wchilders added inline comments to D76443: Use ConstantExpr cached APValues if present for code generation.
Mar 19 2020, 12:32 PM · Restricted Project
wchilders created D76443: Use ConstantExpr cached APValues if present for code generation.
Mar 19 2020, 12:32 PM · Restricted Project
wchilders added inline comments to D76438: ConstantExpr cached APValues if present for constant evaluation.
Mar 19 2020, 11:27 AM · Restricted Project
wchilders created D76438: ConstantExpr cached APValues if present for constant evaluation.
Mar 19 2020, 10:52 AM · Restricted Project
wchilders abandoned D76396: Allow immediate invocation of constructors.

I have already a patch aiming to do the same thing. D74007

Mar 19 2020, 10:17 AM · Restricted Project

Mar 18 2020

wchilders added inline comments to D76396: Allow immediate invocation of constructors.
Mar 18 2020, 7:32 PM · Restricted Project
wchilders added inline comments to D76396: Allow immediate invocation of constructors.
Mar 18 2020, 7:32 PM · Restricted Project
wchilders created D76396: Allow immediate invocation of constructors.
Mar 18 2020, 4:51 PM · Restricted Project
wchilders retitled D76396: Allow immediate invocation of constructors from Allow immediate invocations of constructors to Allow immediate invocation of constructors.
Mar 18 2020, 4:51 PM · Restricted Project