Page MenuHomePhabricator

BRevzin (Barry Revzin)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 4 2018, 1:22 PM (151 w, 9 h)

Recent Activity

Sep 29 2020

BRevzin added inline comments to D78938: Make LLVM build in C++20 mode.
Sep 29 2020, 7:19 AM · Restricted Project, Restricted Project
BRevzin added inline comments to D78938: Make LLVM build in C++20 mode.
Sep 29 2020, 7:08 AM · Restricted Project, Restricted Project

Sep 27 2020

BRevzin added inline comments to D78938: Make LLVM build in C++20 mode.
Sep 27 2020, 7:56 PM · Restricted Project, Restricted Project

Sep 9 2020

BRevzin added a comment to D78938: Make LLVM build in C++20 mode.

@BRevzin, you should a) mention the u8/const char* issue in the description too, and also what compiler you used to build this with. I fully expect at this stage that there are some C++20 compilers that might have slightly different interpretations of things which this won't resolve, so knowing which one this is intended to work with could help with historical research.

Sep 9 2020, 5:37 AM · Restricted Project, Restricted Project

Sep 8 2020

BRevzin retitled D78938: Make LLVM build in C++20 mode from Fixing all comparisons for C++20 compilation. to Make LLVM build in C++20 mode.
Sep 8 2020, 11:17 AM · Restricted Project, Restricted Project

Sep 7 2020

BRevzin added inline comments to D78938: Make LLVM build in C++20 mode.
Sep 7 2020, 8:17 AM · Restricted Project, Restricted Project
BRevzin added a comment to D78938: Make LLVM build in C++20 mode.

Not that I have anything particularly against this, but won't this likely rot fairly rapidly? It's not like LLVM is even on C++17 let alone C++20 yet, so trying to make it work like the latter when it's just going to break again seems a bit like wasted effort to me.

Sep 7 2020, 8:16 AM · Restricted Project, Restricted Project

Sep 4 2020

BRevzin updated the diff for D78938: Make LLVM build in C++20 mode.

Updating this review with some additional changes that need to be made since I last touched it, and some of the previous changes had inadvertently broken the C++14 build so fixing those as well.

Sep 4 2020, 2:01 PM · Restricted Project, Restricted Project

May 25 2020

BRevzin added inline comments to D78938: Make LLVM build in C++20 mode.
May 25 2020, 1:56 PM · Restricted Project, Restricted Project
BRevzin updated the diff for D78938: Make LLVM build in C++20 mode.
  • Explaining the cryptic parentheses.
May 25 2020, 1:56 PM · Restricted Project, Restricted Project

May 23 2020

BRevzin updated the diff for D78938: Make LLVM build in C++20 mode.
  • Backing out changes that aren't strictly comparison-related.
May 23 2020, 5:30 PM · Restricted Project, Restricted Project
BRevzin added a comment to D78938: Make LLVM build in C++20 mode.

I hadn't build the tests before, updated with a few more changes. Some of the tests require u8 literals, whose type changes in C++20. I had no idea what to do with that, so I just #ifdef-ed out those tests with the appropriate feature test macro.

May 23 2020, 10:35 AM · Restricted Project, Restricted Project
BRevzin updated the diff for D78938: Make LLVM build in C++20 mode.
  • Adding missing return.
May 23 2020, 10:35 AM · Restricted Project, Restricted Project
BRevzin updated the diff for D78938: Make LLVM build in C++20 mode.
  • A few more changes from tests.
May 23 2020, 10:35 AM · Restricted Project, Restricted Project

Apr 28 2020

BRevzin added a comment to D78938: Make LLVM build in C++20 mode.

(peanut gallery: I'd consider, while you're touching these all anyway, changing them all to non-member (friended where required) as I believe that's best practice - allows equal implicit conversions on either side, for instance (even if some types have no implicit conversions - it at least provides a nice consistency/examples that people are likely to copy from))

Apr 28 2020, 6:24 AM · Restricted Project, Restricted Project
BRevzin added inline comments to D78919: Changing DenseMapIterator's comparisons to be hidden friends..
Apr 28 2020, 6:24 AM · Restricted Project

Apr 27 2020

BRevzin updated the diff for D78938: Make LLVM build in C++20 mode.

Trying this again.

Apr 27 2020, 6:20 PM · Restricted Project, Restricted Project
BRevzin added a comment to D78938: Make LLVM build in C++20 mode.

Wtf, where'd my other changes go?

I've hit this before, use arc diff --update D78938 <base_branch>.

Apr 27 2020, 6:20 PM · Restricted Project, Restricted Project
BRevzin added a comment to D78938: Make LLVM build in C++20 mode.

Wtf, where'd my other changes go?

Apr 27 2020, 5:16 PM · Restricted Project, Restricted Project
BRevzin updated the diff for D78938: Make LLVM build in C++20 mode.

More idiomatic comparison implementation.

Apr 27 2020, 3:39 PM · Restricted Project, Restricted Project
BRevzin added inline comments to D78938: Make LLVM build in C++20 mode.
Apr 27 2020, 3:39 PM · Restricted Project, Restricted Project
BRevzin updated the summary of D78938: Make LLVM build in C++20 mode.
Apr 27 2020, 3:39 PM · Restricted Project, Restricted Project
BRevzin abandoned D78919: Changing DenseMapIterator's comparisons to be hidden friends..

This review changed just the one type, I went ahead and fixed the rest of the clang build in a bigger review.

Apr 27 2020, 9:39 AM · Restricted Project
BRevzin created D78938: Make LLVM build in C++20 mode.
Apr 27 2020, 9:39 AM · Restricted Project, Restricted Project
BRevzin updated the summary of D78919: Changing DenseMapIterator's comparisons to be hidden friends..
Apr 27 2020, 5:52 AM · Restricted Project
BRevzin created D78919: Changing DenseMapIterator's comparisons to be hidden friends..
Apr 27 2020, 5:52 AM · Restricted Project

Mar 15 2020

BRevzin added a comment to D74186: Removing *_equality..

I would rather see a patch that only removes the removed interfaces, and doesn't do all the additional cleanup you've done.

Mar 15 2020, 3:00 PM · Restricted Project
BRevzin updated the diff for D74186: Removing *_equality..

Splitting the diff to JUST remove weak/strong_equality.

Mar 15 2020, 3:00 PM · Restricted Project

Mar 4 2020

BRevzin added inline comments to D74186: Removing *_equality..
Mar 4 2020, 9:32 AM · Restricted Project

Feb 6 2020

BRevzin updated the summary of D74186: Removing *_equality..
Feb 6 2020, 5:35 PM · Restricted Project
BRevzin updated the summary of D74186: Removing *_equality..
Feb 6 2020, 5:35 PM · Restricted Project
BRevzin created D74186: Removing *_equality..
Feb 6 2020, 5:27 PM · Restricted Project

Jan 5 2018

BRevzin added a comment to D41740: [clang-tidy] Adding a new bugprone check for streaming objects of type int8_t or uint8_t.

Could you please add a test case with a template that reduces the type to int8 or uint8?

Jan 5 2018, 10:10 AM · Restricted Project
BRevzin updated the diff for D41740: [clang-tidy] Adding a new bugprone check for streaming objects of type int8_t or uint8_t.

Updates based on review comments - and rebased off of latest so as to get the ReleaseNotes right. Added options so that the user can provide the list of stream types and int typedef types, as desired, defaulting to just basic_ostream and int8_t/uint8_t.

Jan 5 2018, 10:01 AM · Restricted Project

Jan 4 2018

BRevzin added a comment to D41740: [clang-tidy] Adding a new bugprone check for streaming objects of type int8_t or uint8_t.

So admittedly, I don't have any experience in clang-tidy. This check is intended to catch what is to us a really annoying source of error (and I'm probably not the only one?). I suspect there are far better ways of writing this check than the one that I pretty much guess-and-checked my way into.

Jan 4 2018, 2:49 PM · Restricted Project
BRevzin set the repository for D41740: [clang-tidy] Adding a new bugprone check for streaming objects of type int8_t or uint8_t to rCTE Clang Tools Extra.
Jan 4 2018, 2:41 PM · Restricted Project
BRevzin created D41740: [clang-tidy] Adding a new bugprone check for streaming objects of type int8_t or uint8_t.
Jan 4 2018, 1:33 PM · Restricted Project