Page MenuHomePhabricator

BRevzin (Barry Revzin)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 4 2018, 1:22 PM (84 w, 1 d)

Recent Activity

Jan 5 2018

BRevzin added a comment to D41740: [clang-tidy] Adding a new bugprone check for streaming objects of type int8_t or uint8_t.

Could you please add a test case with a template that reduces the type to int8 or uint8?

Jan 5 2018, 10:10 AM · Restricted Project
BRevzin updated the diff for D41740: [clang-tidy] Adding a new bugprone check for streaming objects of type int8_t or uint8_t.

Updates based on review comments - and rebased off of latest so as to get the ReleaseNotes right. Added options so that the user can provide the list of stream types and int typedef types, as desired, defaulting to just basic_ostream and int8_t/uint8_t.

Jan 5 2018, 10:01 AM · Restricted Project

Jan 4 2018

BRevzin added a comment to D41740: [clang-tidy] Adding a new bugprone check for streaming objects of type int8_t or uint8_t.

So admittedly, I don't have any experience in clang-tidy. This check is intended to catch what is to us a really annoying source of error (and I'm probably not the only one?). I suspect there are far better ways of writing this check than the one that I pretty much guess-and-checked my way into.

Jan 4 2018, 2:49 PM · Restricted Project
BRevzin set the repository for D41740: [clang-tidy] Adding a new bugprone check for streaming objects of type int8_t or uint8_t to rCTE Clang Tools Extra.
Jan 4 2018, 2:41 PM · Restricted Project
BRevzin created D41740: [clang-tidy] Adding a new bugprone check for streaming objects of type int8_t or uint8_t.
Jan 4 2018, 1:33 PM · Restricted Project