Page MenuHomePhabricator

[RISCV] Don't use DCI.CombineTo to replace a single result
ClosedPublic

Authored by craig.topper on Oct 29 2020, 9:34 PM.

Details

Summary

Just return the new node which is the standard practice.

I also noticed what appeared to be an unnecessary attempt at creating an ANY_EXTEND where the type should already be correct. I replace it with assert to verify the type.

Diff Detail

Event Timeline

craig.topper created this revision.Oct 29 2020, 9:34 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 29 2020, 9:34 PM
craig.topper requested review of this revision.Oct 29 2020, 9:34 PM
frasercrmck accepted this revision.Oct 30 2020, 2:11 AM

LGTM. That operand to FMV_W_X_RV64 does indeed look like it should always be i64.

This revision is now accepted and ready to land.Oct 30 2020, 2:11 AM

Should this be marked [NFC]?