[MLIR] Move TestDialect to ::test namespace

[stephenneuendorffer]

Summary

While the changes are extensive, they basically fall into a few
categories:

1. Moving the TestDialect itself.
2. Updating C++ code in tablegen to explicitly use ::mlir, since it

will be put in a headers that shouldn't expect a 'using'.

3. Updating some generic MLIR Interface definitions to do the same thing.
4. Updating the Tablegen generator in a few places to be explicit about

namespaces

5. Doing the same thing for llvm references, since we no longer pick

up the definitions from mlir/Support/LLVM.h

[mehdi_amini]

LGTM on the principle, whenever you get it to work :)

[mehdi_amini]

mlir/test/lib/Dialect/Test/TestDialect.cpp

22

River mentioned to me that a good tradeoff would be to keep the using namespace mlir; but move it after the point where we include all the TableGen generated stuff.

That way all the manually written code in this file does not need to be clobbered with mlir:: everywhere.

[stephenneuendorffer]

mlir/test/lib/Dialect/Test/TestDialect.cpp

22

Agreed, I'm more concerned about the tablegen'd stuff being broken right now.

[stephenneuendorffer]

Yeah, still broken.

mlir/test/lib/Dialect/Test/TestDialect.h

 
 
 #include "TestOpStructs.h.inc"
 #include "TestOpsDialect.h.inc"
 
 #define GET_OP_CLASSES
 #include "TestOps.h.inc"
 
-namespace mlir {
+namespace test {
 void registerTestDialect(DialectRegistry &registry);
-} // end namespace mlir
+} // end namespace test
 
 #endif // MLIR_TESTDIALECT_H

mlir/test/lib/Dialect/Test/TestDialect.cpp

 #include "mlir/IR/Module.h"
 #include "mlir/IR/PatternMatch.h"
 #include "mlir/IR/TypeUtilities.h"
 #include "mlir/Transforms/FoldUtils.h"
 #include "mlir/Transforms/InliningUtils.h"
 #include "llvm/ADT/SetVector.h"
 #include "llvm/ADT/StringSwitch.h"
 
-using namespace mlir;
+//using namespace mlir;
 
-void mlir::registerTestDialect(DialectRegistry &registry) {
+void test::registerTestDialect(DialectRegistry &registry) {
   registry.insert<TestDialect>();
 }
 
 //===----------------------------------------------------------------------===//
 // TestDialect Interfaces
 //===----------------------------------------------------------------------===//
 
 namespace {

mlir/test/lib/Dialect/Test/TestOps.td

 include "mlir/Interfaces/SideEffectInterfaces.td"
 include "mlir/Interfaces/CallInterfaces.td"
 include "mlir/Interfaces/ControlFlowInterfaces.td"
 include "mlir/Interfaces/InferTypeOpInterface.td"
 include "mlir/Interfaces/SideEffectInterfaces.td"
 
 def Test_Dialect : Dialect {
   let name = "test";
-  let cppNamespace = "::mlir";
+  let cppNamespace = "::test";
   let hasOperationAttrVerify = 1;
   let hasRegionArgAttrVerify = 1;
   let hasRegionResultAttrVerify = 1;
 }
 
 class TEST_Op<string mnemonic, list<OpTrait> traits = []> :
     Op<Test_Dialect, mnemonic, traits>;
 

 
 def MultiTensorRankOf : TEST_Op<"multi_tensor_rank_of"> {
   let arguments = (ins
     TensorRankOf<[I8, I32, F32], [0, 1]>:$arg0
   );
 }
 
 def TEST_TestType : DialectType<Test_Dialect,
-    CPred<"$_self.isa<::mlir::TestType>()">, "test">,
-    BuildableType<"$_builder.getType<::mlir::TestType>()">;
+    CPred<"$_self.isa<::test::TestType>()">, "test">,
+    BuildableType<"$_builder.getType<::test::TestType>()">;
 
 //===----------------------------------------------------------------------===//
 // Test Symbols
 //===----------------------------------------------------------------------===//
 
 def SymbolOp : TEST_Op<"symbol", [Symbol]> {
   let summary =  "operation which defines a new symbol";
   let arguments = (ins StrAttr:$sym_name,

mlir/test/lib/Dialect/Test/TestTypes.h

 //===----------------------------------------------------------------------===//
 
 #ifndef MLIR_TESTTYPES_H
 #define MLIR_TESTTYPES_H
 
 #include "mlir/IR/Diagnostics.h"
 #include "mlir/IR/Types.h"
 
-namespace mlir {
+namespace test {
 
 #include "TestTypeInterfaces.h.inc"
 
 /// This class is a simple test type that uses a generated interface.
 struct TestType : public Type::TypeBase<TestType, Type, TypeStorage,
                                         TestTypeInterface::Trait> {
   using Base::Base;
 
public:
   /// Body getter and setter.
   LogicalResult setBody(Type body) { return Base::mutate(body); }
   Type getBody() { return getImpl()->body; }
 
   /// Name/key getter.
   StringRef getName() { return getImpl()->name; }
 };
 
-} // end namespace mlir
+} // end namespace test
 
 #endif // MLIR_TESTTYPES_H