Page MenuHomePhabricator

msifontes (Mauricio Sifontes)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 3 2020, 7:09 PM (25 w, 1 d)

Recent Activity

Aug 20 2020

msifontes committed rG21f8d4146893: Refactor Reduction Tree Pass (authored by msifontes).
Refactor Reduction Tree Pass
Aug 20 2020, 10:00 PM
msifontes closed D85591: Refactor Reduction Tree Pass.
Aug 20 2020, 10:00 PM · Restricted Project
msifontes updated the diff for D85591: Refactor Reduction Tree Pass.

Apply requested changes

Aug 20 2020, 9:34 PM · Restricted Project

Aug 18 2020

msifontes updated the diff for D85591: Refactor Reduction Tree Pass.

Fix clang-format error

Aug 18 2020, 2:15 PM · Restricted Project
msifontes updated the diff for D85591: Refactor Reduction Tree Pass.

Modify the reduction node transform space to use a bool vector with the transformed indices marked as true.

Aug 18 2020, 12:08 PM · Restricted Project
msifontes updated the diff for D85591: Refactor Reduction Tree Pass.

Remove unused headers in OpReducer.h

Aug 18 2020, 10:48 AM · Restricted Project
msifontes updated the diff for D85591: Refactor Reduction Tree Pass.

Change mlir-reduce.cpp to use new OpReducer

Aug 18 2020, 10:43 AM · Restricted Project
msifontes updated the diff for D85591: Refactor Reduction Tree Pass.

Merge confilcts in working tree.

Aug 18 2020, 10:18 AM · Restricted Project
msifontes committed rG8f4859d35120: Create Optimization Pass Wrapper for MLIR Reduce (authored by msifontes).
Create Optimization Pass Wrapper for MLIR Reduce
Aug 18 2020, 9:48 AM
msifontes closed D84783: Create Opt Reduction Pass.
Aug 18 2020, 9:47 AM · Restricted Project
msifontes updated the diff for D84783: Create Opt Reduction Pass.

NFC: Amend commit message

Aug 18 2020, 9:44 AM · Restricted Project
msifontes updated the diff for D84783: Create Opt Reduction Pass.

Apply requested changes

Aug 18 2020, 9:11 AM · Restricted Project

Aug 17 2020

msifontes updated the diff for D84783: Create Opt Reduction Pass.

Add missing new line in simple-test.mlir

Aug 17 2020, 10:25 AM · Restricted Project
msifontes updated the diff for D84783: Create Opt Reduction Pass.

NFC: Fix Typo

Aug 17 2020, 10:22 AM · Restricted Project
msifontes updated the diff for D84783: Create Opt Reduction Pass.

Refactor Optimization Pass

Aug 17 2020, 10:15 AM · Restricted Project

Aug 14 2020

msifontes committed rGc26ed5c9657a: Fix warning caused by ReductionTreePass class (authored by msifontes).
Fix warning caused by ReductionTreePass class
Aug 14 2020, 12:13 PM
msifontes closed D85983: Fix warning caused by ReductionTreePass class.
Aug 14 2020, 12:12 PM · Restricted Project
msifontes updated the diff for D85591: Refactor Reduction Tree Pass.

NFC: Formatting changes

Aug 14 2020, 11:33 AM · Restricted Project
msifontes retitled D85983: Fix warning caused by ReductionTreePass class from Fix "base class initialization in copy constructor" warning for ReductionTreePass class. to Fix warning caused by ReductionTreePass class.
Aug 14 2020, 11:26 AM · Restricted Project
msifontes requested review of D85983: Fix warning caused by ReductionTreePass class.
Aug 14 2020, 11:22 AM · Restricted Project

Aug 11 2020

msifontes updated the diff for D85591: Refactor Reduction Tree Pass.

Apply Requested changes

Aug 11 2020, 11:25 PM · Restricted Project
msifontes updated the diff for D85591: Refactor Reduction Tree Pass.

NFC: clang-format

Aug 11 2020, 8:30 AM · Restricted Project

Aug 10 2020

msifontes updated the diff for D85591: Refactor Reduction Tree Pass.

Merge createTransformedVariants and createErasedVariants utilities into single createVariants utility.

Aug 10 2020, 5:11 PM · Restricted Project

Aug 8 2020

msifontes updated the diff for D85591: Refactor Reduction Tree Pass.

Fix indexing bug in createTransformedVariants().

Aug 8 2020, 6:14 PM · Restricted Project
msifontes updated the summary of D85591: Refactor Reduction Tree Pass.
Aug 8 2020, 4:21 PM · Restricted Project
msifontes added reviewers for D85591: Refactor Reduction Tree Pass: jpienaar, tpopp, rriddle.
Aug 8 2020, 4:13 PM · Restricted Project
msifontes requested review of D85591: Refactor Reduction Tree Pass.
Aug 8 2020, 4:11 PM · Restricted Project

Aug 7 2020

msifontes committed rG27d0e14da9b4: Create Reduction Tree Pass (authored by msifontes).
Create Reduction Tree Pass
Aug 7 2020, 4:18 PM
msifontes closed D83969: Create the Reduction Tree Pass.
Aug 7 2020, 4:18 PM · Restricted Project
msifontes updated the diff for D83969: Create the Reduction Tree Pass.

NFC: clang format

Aug 7 2020, 3:01 PM · Restricted Project
msifontes updated the diff for D83969: Create the Reduction Tree Pass.

Fix header formatting warning

Aug 7 2020, 2:42 PM · Restricted Project
msifontes updated the diff for D83969: Create the Reduction Tree Pass.

Apply requested changes

Aug 7 2020, 1:41 PM · Restricted Project
msifontes added inline comments to D83969: Create the Reduction Tree Pass.
Aug 7 2020, 1:30 PM · Restricted Project

Aug 5 2020

msifontes updated the diff for D83969: Create the Reduction Tree Pass.

Apply requested changes

Aug 5 2020, 9:29 AM · Restricted Project

Jul 31 2020

msifontes added inline comments to D83969: Create the Reduction Tree Pass.
Jul 31 2020, 9:02 AM · Restricted Project
msifontes updated the diff for D83969: Create the Reduction Tree Pass.

Apply requested changes

Jul 31 2020, 9:02 AM · Restricted Project

Jul 28 2020

msifontes added reviewers for D84783: Create Opt Reduction Pass: jpienaar, tpopp.
Jul 28 2020, 11:56 AM · Restricted Project
msifontes updated the diff for D84783: Create Opt Reduction Pass.

Include only the new changes in this commit.

Jul 28 2020, 11:56 AM · Restricted Project
msifontes requested review of D84783: Create Opt Reduction Pass.
Jul 28 2020, 11:43 AM · Restricted Project

Jul 24 2020

msifontes updated the diff for D83969: Create the Reduction Tree Pass.

Move ReductionTreePass non-templated members to ReductionTreeUtils class in order to move some of the implementation to the .cpp file.

Jul 24 2020, 9:19 AM · Restricted Project

Jul 23 2020

msifontes updated the diff for D83969: Create the Reduction Tree Pass.

NFC: Add ending namespace comment

Jul 23 2020, 9:08 PM · Restricted Project
msifontes updated the diff for D83969: Create the Reduction Tree Pass.

Resolve clang-tidy error

Jul 23 2020, 9:04 PM · Restricted Project
msifontes updated the diff for D83969: Create the Reduction Tree Pass.

Fix Passes.h.inc dependency

Jul 23 2020, 6:49 PM · Restricted Project
msifontes updated the diff for D83969: Create the Reduction Tree Pass.
Jul 23 2020, 6:07 PM · Restricted Project
msifontes updated the diff for D83969: Create the Reduction Tree Pass.

Apply changes

Jul 23 2020, 12:13 PM · Restricted Project

Jul 22 2020

msifontes updated the diff for D83969: Create the Reduction Tree Pass.

NFC

Jul 22 2020, 8:14 PM · Restricted Project
msifontes updated the diff for D83969: Create the Reduction Tree Pass.

Apply requested changes

  • Add missing c++ designators
  • Remove uninteresting nodes when sorting
  • Create testing script to test new functionality
  • Comment formatting changes
  • Add class member descriptions
  • Reformatted OpReducer class to FuncReducer class with the objective of reducing the number of functions.
  • Remove ClonePass()
  • Use of llvm::enumerate where possible
  • Modify ReductioNode constructor to split the functionality of linking a child node to a parent
  • Change module measurement to character measurement using ifstream and the temporary file
Jul 22 2020, 8:07 PM · Restricted Project
msifontes added inline comments to D83969: Create the Reduction Tree Pass.
Jul 22 2020, 3:53 PM · Restricted Project
msifontes added inline comments to D83969: Create the Reduction Tree Pass.
Jul 22 2020, 3:48 PM · Restricted Project
msifontes added inline comments to D83969: Create the Reduction Tree Pass.
Jul 22 2020, 3:47 PM · Restricted Project
msifontes updated the diff for D83969: Create the Reduction Tree Pass.
Jul 22 2020, 12:49 PM · Restricted Project
msifontes updated the diff for D83969: Create the Reduction Tree Pass.
Jul 22 2020, 12:29 PM · Restricted Project
msifontes updated the diff for D83969: Create the Reduction Tree Pass.

Fix PassDetail.h header guard format

Jul 22 2020, 10:40 AM · Restricted Project
msifontes updated the diff for D83969: Create the Reduction Tree Pass.

Remove duplicate Tester.cpp

Jul 22 2020, 10:18 AM · Restricted Project
msifontes updated the diff for D83969: Create the Reduction Tree Pass.

NFC Changes

Jul 22 2020, 10:14 AM · Restricted Project
msifontes updated the diff for D83969: Create the Reduction Tree Pass.

Apply Requested changes

Jul 22 2020, 10:11 AM · Restricted Project

Jul 20 2020

msifontes updated the diff for D83969: Create the Reduction Tree Pass.

Apply requested changes

Jul 20 2020, 9:16 PM · Restricted Project

Jul 16 2020

msifontes updated the diff for D83969: Create the Reduction Tree Pass.
Jul 16 2020, 11:25 AM · Restricted Project
msifontes updated the diff for D83969: Create the Reduction Tree Pass.

Add empty line to CMakeList file.

Jul 16 2020, 11:23 AM · Restricted Project
msifontes added reviewers for D83969: Create the Reduction Tree Pass: jpienaar, tpopp.
Jul 16 2020, 11:18 AM · Restricted Project
msifontes updated the diff for D83969: Create the Reduction Tree Pass.
  1. Updating D83969: Create the Reduction Tree Pass #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment. #
  4. If you intended to create a new revision, use:
  5. $ arc diff --create

Fix working directory HEAD

Jul 16 2020, 11:15 AM · Restricted Project
Herald added a project to D83969: Create the Reduction Tree Pass: Restricted Project.
Jul 16 2020, 10:53 AM · Restricted Project
msifontes abandoned D83653: Create ReductionTree and ReductionNode classes.
Jul 16 2020, 10:14 AM · Restricted Project

Jul 13 2020

msifontes added inline comments to D83653: Create ReductionTree and ReductionNode classes.
Jul 13 2020, 11:50 AM · Restricted Project
msifontes updated the diff for D83653: Create ReductionTree and ReductionNode classes.

Apply requested changes

Jul 13 2020, 11:49 AM · Restricted Project

Jul 12 2020

msifontes updated the diff for D83653: Create ReductionTree and ReductionNode classes.

Formatting changes

Jul 12 2020, 8:03 PM · Restricted Project
msifontes updated the diff for D83653: Create ReductionTree and ReductionNode classes.

Delete commented out function call in mlir-reduce.cpp

Jul 12 2020, 8:00 PM · Restricted Project
msifontes added reviewers for D83653: Create ReductionTree and ReductionNode classes: jpienaar, tpopp.
Jul 12 2020, 7:57 PM · Restricted Project
Herald added a project to D83653: Create ReductionTree and ReductionNode classes: Restricted Project.
Jul 12 2020, 7:56 PM · Restricted Project

Jul 10 2020

msifontes committed rG16e9ccb2be7a: Create TestReducer pass (authored by msifontes).
Create TestReducer pass
Jul 10 2020, 5:47 PM
msifontes closed D83422: Create TestReducer pass.
Jul 10 2020, 5:47 PM · Restricted Project

Jul 8 2020

msifontes updated the diff for D83422: Create TestReducer pass.
  • Modify error to exit with code 1
  • Modify testcase to use the 'not' keyword
  • Change 'bug' wording to 'failure'
Jul 8 2020, 9:38 PM · Restricted Project
msifontes updated the diff for D83422: Create TestReducer pass.

Modify TestReducer.cpp to MLIRTestReducer.cpp

Jul 8 2020, 3:52 PM · Restricted Project
msifontes updated the diff for D83422: Create TestReducer pass.
  • Modify naming from test reduce to test reducer
  • Add mlir-opt test case without test-mlir-reducer pass
Jul 8 2020, 3:16 PM · Restricted Project
msifontes added inline comments to D83422: Create TestReducer pass.
Jul 8 2020, 3:12 PM · Restricted Project
msifontes added reviewers for D83422: Create TestReducer pass: jpienaar, tpopp.
Jul 8 2020, 1:17 PM · Restricted Project
Herald added a project to D83422: Create TestReducer pass: Restricted Project.
Jul 8 2020, 1:16 PM · Restricted Project
msifontes added inline comments to D82803: Create the MLIR Reduce framework.
Jul 8 2020, 7:37 AM · Restricted Project

Jul 7 2020

msifontes committed rGec04ce462352: Create the MLIR Reduce framework (authored by msifontes).
Create the MLIR Reduce framework
Jul 7 2020, 4:43 PM
msifontes closed D82803: Create the MLIR Reduce framework.
Jul 7 2020, 4:43 PM · Restricted Project
msifontes updated the diff for D82803: Create the MLIR Reduce framework.

Remove unsupported windows tests

Jul 7 2020, 12:15 PM · Restricted Project
msifontes updated the diff for D82803: Create the MLIR Reduce framework.

Add windows specific testcase

Jul 7 2020, 10:10 AM · Restricted Project
msifontes updated the diff for D82803: Create the MLIR Reduce framework.

Remove windows specific test case

Jul 7 2020, 9:39 AM · Restricted Project
msifontes updated the diff for D82803: Create the MLIR Reduce framework.

Remove the windows test case

Jul 7 2020, 9:14 AM · Restricted Project
msifontes added inline comments to D82803: Create the MLIR Reduce framework.
Jul 7 2020, 8:36 AM · Restricted Project
msifontes added a project to rG28a45d54a7fe: Create the framework and testing environment for MLIR Reduce - a tool with the…: Restricted Project.
Jul 7 2020, 8:29 AM · Restricted Project

Jul 6 2020

msifontes committed rG28a45d54a7fe: Create the framework and testing environment for MLIR Reduce - a tool with the… (authored by msifontes).
Create the framework and testing environment for MLIR Reduce - a tool with the…
Jul 6 2020, 7:00 PM · Restricted Project
msifontes committed rGa5a8c1ed5660: Create the MLIR Reduce framework (authored by msifontes).
Create the MLIR Reduce framework
Jul 6 2020, 6:15 PM
msifontes updated the summary of D82803: Create the MLIR Reduce framework.
Jul 6 2020, 3:09 PM · Restricted Project
msifontes updated the summary of D82803: Create the MLIR Reduce framework.
Jul 6 2020, 3:09 PM · Restricted Project
msifontes updated the diff for D82803: Create the MLIR Reduce framework.

Modify Tester class documentation

Jul 6 2020, 11:44 AM · Restricted Project
msifontes updated the diff for D82803: Create the MLIR Reduce framework.

Fix Tester.cpp dependency issue

Jul 6 2020, 11:11 AM · Restricted Project
msifontes updated the diff for D82803: Create the MLIR Reduce framework.
Jul 6 2020, 9:33 AM · Restricted Project

Jul 4 2020

msifontes updated the diff for D82803: Create the MLIR Reduce framework.

Apply requested changes

Jul 4 2020, 5:19 PM · Restricted Project

Jul 3 2020

msifontes added inline comments to D82803: Create the MLIR Reduce framework.
Jul 3 2020, 1:04 PM · Restricted Project
msifontes updated the diff for D82803: Create the MLIR Reduce framework.

Add Tester class documentation

Jul 3 2020, 1:04 PM · Restricted Project

Jul 2 2020

msifontes added inline comments to D82803: Create the MLIR Reduce framework.
Jul 2 2020, 11:10 PM · Restricted Project
msifontes added inline comments to D82803: Create the MLIR Reduce framework.
Jul 2 2020, 12:29 AM · Restricted Project

Jul 1 2020

msifontes added inline comments to D82803: Create the MLIR Reduce framework.
Jul 1 2020, 11:15 PM · Restricted Project
msifontes updated the diff for D82803: Create the MLIR Reduce framework.

Remove STATIC library declaration

Jul 1 2020, 10:43 PM · Restricted Project