Page MenuHomePhabricator

msifontes (Mauricio Sifontes)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 3 2020, 7:09 PM (5 w, 1 d)

Recent Activity

Wed, Jul 8

msifontes updated the diff for D83422: Create TestReducer pass.
  • Modify error to exit with code 1
  • Modify testcase to use the 'not' keyword
  • Change 'bug' wording to 'failure'
Wed, Jul 8, 9:38 PM · Restricted Project
msifontes updated the diff for D83422: Create TestReducer pass.

Modify TestReducer.cpp to MLIRTestReducer.cpp

Wed, Jul 8, 3:52 PM · Restricted Project
msifontes updated the diff for D83422: Create TestReducer pass.
  • Modify naming from test reduce to test reducer
  • Add mlir-opt test case without test-mlir-reducer pass
Wed, Jul 8, 3:16 PM · Restricted Project
msifontes added inline comments to D83422: Create TestReducer pass.
Wed, Jul 8, 3:12 PM · Restricted Project
msifontes added reviewers for D83422: Create TestReducer pass: jpienaar, tpopp.
Wed, Jul 8, 1:17 PM · Restricted Project
Herald added a project to D83422: Create TestReducer pass: Restricted Project.
Wed, Jul 8, 1:16 PM · Restricted Project
msifontes added inline comments to D82803: Create the MLIR Reduce framework.
Wed, Jul 8, 7:37 AM · Restricted Project

Tue, Jul 7

msifontes committed rGec04ce462352: Create the MLIR Reduce framework (authored by msifontes).
Create the MLIR Reduce framework
Tue, Jul 7, 4:43 PM
msifontes closed D82803: Create the MLIR Reduce framework.
Tue, Jul 7, 4:43 PM · Restricted Project
msifontes updated the diff for D82803: Create the MLIR Reduce framework.

Remove unsupported windows tests

Tue, Jul 7, 12:15 PM · Restricted Project
msifontes updated the diff for D82803: Create the MLIR Reduce framework.

Add windows specific testcase

Tue, Jul 7, 10:10 AM · Restricted Project
msifontes updated the diff for D82803: Create the MLIR Reduce framework.

Remove windows specific test case

Tue, Jul 7, 9:39 AM · Restricted Project
msifontes updated the diff for D82803: Create the MLIR Reduce framework.

Remove the windows test case

Tue, Jul 7, 9:14 AM · Restricted Project
msifontes added inline comments to D82803: Create the MLIR Reduce framework.
Tue, Jul 7, 8:36 AM · Restricted Project
msifontes removed an edge from rGa5a8c1ed5660: Create the MLIR Reduce framework: D82803: Create the MLIR Reduce framework.
Tue, Jul 7, 8:31 AM
msifontes added an edge to rG28a45d54a7fe: Create the framework and testing environment for MLIR Reduce - a tool with the…: D82803: Create the MLIR Reduce framework.
Tue, Jul 7, 8:31 AM · Restricted Project
msifontes edited commit(s) for D82803: Create the MLIR Reduce framework, added 1: rG28a45d54a7fe: Create the framework and testing environment for MLIR Reduce - a tool with the…; removed 1: rGa5a8c1ed5660: Create the MLIR Reduce framework.
Tue, Jul 7, 8:31 AM · Restricted Project
msifontes added a project to rG28a45d54a7fe: Create the framework and testing environment for MLIR Reduce - a tool with the…: Restricted Project.
Tue, Jul 7, 8:29 AM · Restricted Project

Mon, Jul 6

msifontes committed rG28a45d54a7fe: Create the framework and testing environment for MLIR Reduce - a tool with the… (authored by msifontes).
Create the framework and testing environment for MLIR Reduce - a tool with the…
Mon, Jul 6, 7:00 PM · Restricted Project
msifontes committed rGa5a8c1ed5660: Create the MLIR Reduce framework (authored by msifontes).
Create the MLIR Reduce framework
Mon, Jul 6, 6:15 PM
msifontes updated the summary of D82803: Create the MLIR Reduce framework.
Mon, Jul 6, 3:09 PM · Restricted Project
msifontes updated the summary of D82803: Create the MLIR Reduce framework.
Mon, Jul 6, 3:09 PM · Restricted Project
msifontes updated the diff for D82803: Create the MLIR Reduce framework.

Modify Tester class documentation

Mon, Jul 6, 11:44 AM · Restricted Project
msifontes updated the diff for D82803: Create the MLIR Reduce framework.

Fix Tester.cpp dependency issue

Mon, Jul 6, 11:11 AM · Restricted Project
msifontes updated the diff for D82803: Create the MLIR Reduce framework.
Mon, Jul 6, 9:33 AM · Restricted Project

Sat, Jul 4

msifontes updated the diff for D82803: Create the MLIR Reduce framework.

Apply requested changes

Sat, Jul 4, 5:19 PM · Restricted Project

Fri, Jul 3

msifontes added inline comments to D82803: Create the MLIR Reduce framework.
Fri, Jul 3, 1:04 PM · Restricted Project
msifontes updated the diff for D82803: Create the MLIR Reduce framework.

Add Tester class documentation

Fri, Jul 3, 1:04 PM · Restricted Project

Thu, Jul 2

msifontes added inline comments to D82803: Create the MLIR Reduce framework.
Thu, Jul 2, 11:10 PM · Restricted Project
msifontes added inline comments to D82803: Create the MLIR Reduce framework.
Thu, Jul 2, 12:29 AM · Restricted Project

Wed, Jul 1

msifontes added inline comments to D82803: Create the MLIR Reduce framework.
Wed, Jul 1, 11:15 PM · Restricted Project
msifontes updated the diff for D82803: Create the MLIR Reduce framework.

Remove STATIC library declaration

Wed, Jul 1, 10:43 PM · Restricted Project
msifontes updated the diff for D82803: Create the MLIR Reduce framework.

Move Tester.cpp to lib/Reducer

Wed, Jul 1, 6:54 PM · Restricted Project
msifontes added a comment to D82803: Create the MLIR Reduce framework.

The implementation mlir/tools/mlir-reduce/Tester.cpp does not seems in the right place: it should be somewhere under lib/

Wed, Jul 1, 5:18 PM · Restricted Project
msifontes updated the diff for D82803: Create the MLIR Reduce framework.

Apply requested changes

Wed, Jul 1, 4:14 PM · Restricted Project
msifontes updated the diff for D82803: Create the MLIR Reduce framework.

Add windows specific testing script and test

Wed, Jul 1, 4:13 PM · Restricted Project
msifontes updated the diff for D82803: Create the MLIR Reduce framework.

Remove mlir-opt from testing script

Wed, Jul 1, 11:20 AM · Restricted Project

Tue, Jun 30

msifontes updated the diff for D82803: Create the MLIR Reduce framework.

Normalize path separators

Tue, Jun 30, 5:55 PM · Restricted Project
msifontes updated the diff for D82803: Create the MLIR Reduce framework.

Modify testing script so that it is not OS specific

Tue, Jun 30, 2:09 PM · Restricted Project
msifontes updated the diff for D82803: Create the MLIR Reduce framework.

Updating D82803: Create the MLIR Reduce framework

Tue, Jun 30, 1:03 PM · Restricted Project
msifontes updated the diff for D82803: Create the MLIR Reduce framework.

Updating D82803: Create the MLIR Reduce framework

Tue, Jun 30, 11:56 AM · Restricted Project
msifontes updated the diff for D82803: Create the MLIR Reduce framework.
  1. Updating D82803: Create the MLIR Reduce framework
Tue, Jun 30, 9:12 AM · Restricted Project
msifontes added a comment to D82803: Create the MLIR Reduce framework.

If the tools is intended to be extended, I suspect that classes like class Tester should be in a library (and so the header be under the include folder).
The tools folder is only for the generated binary, I'd follow what we do with mlir-opt as a pattern here.

Ping here, in case you missed it?

Tue, Jun 30, 9:11 AM · Restricted Project
msifontes updated the diff for D82803: Create the MLIR Reduce framework.

Applied Review changes

Tue, Jun 30, 8:39 AM · Restricted Project

Mon, Jun 29

msifontes updated the diff for D82803: Create the MLIR Reduce framework.
  1. Updating D82803: Create the MLIR Reduce framework
Mon, Jun 29, 8:24 PM · Restricted Project
msifontes updated the diff for D82803: Create the MLIR Reduce framework.
  1. Updating D82803: Create the MLIR Reduce framework
Mon, Jun 29, 4:39 PM · Restricted Project
msifontes updated the diff for D82803: Create the MLIR Reduce framework.
  1. Updating D82803: Create the MLIR Reduce framework
Mon, Jun 29, 2:25 PM · Restricted Project
msifontes added reviewers for D82803: Create the MLIR Reduce framework: jpienaar, tpopp.
Mon, Jun 29, 2:25 PM · Restricted Project
msifontes created D82803: Create the MLIR Reduce framework.
Mon, Jun 29, 1:36 PM · Restricted Project
msifontes updated the diff for D82803: Create the MLIR Reduce framework.

#Updating D82803: Create the MLIR Reduce framework

Mon, Jun 29, 1:36 PM · Restricted Project

Jun 8 2020

msifontes updated the diff for D81431: Added number of operands verification for shape.assuming_all operation..
  1. Updating D81431: modified: ../mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td modified: ../mlir/lib/Dialect/Shape/IR/Shape.cpp modified: ../mlir/test/Dialect/Shape/invalid.mlir #
  2. Enter a brief description of the changes included in this update.
  3. The first line is used as subject, next lines as comment.
Jun 8 2020, 4:06 PM · Restricted Project
msifontes abandoned D81434: Made AssumingAllOp error message more explicit..
Jun 8 2020, 4:06 PM · Restricted Project
msifontes created D81434: Made AssumingAllOp error message more explicit..
Jun 8 2020, 3:33 PM · Restricted Project
msifontes created D81431: Added number of operands verification for shape.assuming_all operation..
Jun 8 2020, 2:24 PM · Restricted Project