Page MenuHomePhabricator

jurahul (Rahul Joshi)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 17 2020, 11:03 AM (22 w, 4 d)

Recent Activity

Yesterday

jurahul updated subscribers of D87926: [MLIR] Fix default builders generated by TableGen to use TypeRange for result types.
Mon, Sep 21, 5:04 PM · Restricted Project
jurahul added inline comments to D88040: [mlir] NFC: fix trivial typos under include directory.
Mon, Sep 21, 12:16 PM · Restricted Project
jurahul added inline comments to D87926: [MLIR] Fix default builders generated by TableGen to use TypeRange for result types.
Mon, Sep 21, 10:38 AM · Restricted Project
jurahul added a comment to D88012: WIP: DSL-style builder generator.

Overall, should we discuss whether we want a per-dialect builder or put that on per-op (i.e, Op::create) to not have another object involved in this (the dialect builder). I know you had pointed me to an earlier discussion, I didn't get an opportunity to carry it forward.

Mon, Sep 21, 9:11 AM · Restricted Project

Fri, Sep 18

jurahul requested review of D87955: [MLIR][NFC] Adopt use of BlockRange in place of ArrayRef<Block *>.
Fri, Sep 18, 4:40 PM · Restricted Project
jurahul added a reviewer for D87944: [MLIR][NFC] Adopt use of TypeRange in build() methods.: jpienaar.
Fri, Sep 18, 2:22 PM · Restricted Project
jurahul requested review of D87944: [MLIR][NFC] Adopt use of TypeRange in build() methods..
Fri, Sep 18, 2:22 PM · Restricted Project
jurahul added a reviewer for D87926: [MLIR] Fix default builders generated by TableGen to use TypeRange for result types: jpienaar.
Fri, Sep 18, 11:48 AM · Restricted Project
jurahul requested review of D87926: [MLIR] Fix default builders generated by TableGen to use TypeRange for result types.
Fri, Sep 18, 11:47 AM · Restricted Project

Thu, Sep 17

jurahul added inline comments to D87870: [GISel] Add new combines for G_FMUL.
Thu, Sep 17, 5:41 PM · Restricted Project
jurahul committed rGea237e2c8e5d: [MLIR] Fix build failure due to https://reviews.llvm.org/D87059. (authored by jurahul).
[MLIR] Fix build failure due to https://reviews.llvm.org/D87059.
Thu, Sep 17, 4:58 PM
jurahul closed D87872: [MLIR] Fix build failure due to https://reviews.llvm.org/D87059..
Thu, Sep 17, 4:58 PM · Restricted Project
jurahul requested review of D87872: [MLIR] Fix build failure due to https://reviews.llvm.org/D87059..
Thu, Sep 17, 4:51 PM · Restricted Project
jurahul committed rG8069844577d4: [MLIR][TableGen] Automatic detection and elimination of redundant methods (authored by jurahul).
[MLIR][TableGen] Automatic detection and elimination of redundant methods
Thu, Sep 17, 4:05 PM
jurahul closed D87059: [MLIR][TableGen] Automatic detection and elimination of redundant methods.
Thu, Sep 17, 4:05 PM · Restricted Project
jurahul added inline comments to D87059: [MLIR][TableGen] Automatic detection and elimination of redundant methods.
Thu, Sep 17, 1:19 PM · Restricted Project
jurahul updated the diff for D87059: [MLIR][TableGen] Automatic detection and elimination of redundant methods.

Rebase

Thu, Sep 17, 1:18 PM · Restricted Project

Tue, Sep 15

jurahul added inline comments to D87059: [MLIR][TableGen] Automatic detection and elimination of redundant methods.
Tue, Sep 15, 2:07 PM · Restricted Project
jurahul updated the diff for D87059: [MLIR][TableGen] Automatic detection and elimination of redundant methods.

Review feedback

Tue, Sep 15, 2:06 PM · Restricted Project

Tue, Sep 8

jurahul accepted D87334: Wordsmith RegionBranchOpInterface verification errors.

Looks ok. In general if there is a control flow edge from parent->region, the values flowing along may not necessarily be the parent operands, and if there is control flow edge from a region->parent, the values flowing may not necessarily flow into parent results. But the current RegionBranchOpInterface is designed to model this, so this looks ok.

Tue, Sep 8, 4:10 PM · Restricted Project
jurahul committed rG8893d0816ccd: [MLIR] Change Operation::create() methods to use Value/Type/Block ranges. (authored by jurahul).
[MLIR] Change Operation::create() methods to use Value/Type/Block ranges.
Tue, Sep 8, 2:19 PM
jurahul closed D86985: [MLIR] Change Operation::create() methods to use Value/Type/Block ranges..
Tue, Sep 8, 2:19 PM · Restricted Project

Wed, Sep 2

jurahul retitled D86985: [MLIR] Change Operation::create() methods to use Value/Type/Block ranges. from [MLIR] Change Operation::create() methods to use Value/Type/Successor ranges. to [MLIR] Change Operation::create() methods to use Value/Type/Block ranges..
Wed, Sep 2, 3:34 PM · Restricted Project
jurahul updated the diff for D86985: [MLIR] Change Operation::create() methods to use Value/Type/Block ranges..

Add comment for BlockRange

Wed, Sep 2, 3:33 PM · Restricted Project
jurahul requested review of D87059: [MLIR][TableGen] Automatic detection and elimination of redundant methods.
Wed, Sep 2, 3:21 PM · Restricted Project
jurahul updated the diff for D86985: [MLIR] Change Operation::create() methods to use Value/Type/Block ranges..

Review feedback

Wed, Sep 2, 1:24 PM · Restricted Project

Tue, Sep 1

jurahul added inline comments to D86985: [MLIR] Change Operation::create() methods to use Value/Type/Block ranges..
Tue, Sep 1, 4:14 PM · Restricted Project
jurahul requested review of D86985: [MLIR] Change Operation::create() methods to use Value/Type/Block ranges..
Tue, Sep 1, 3:41 PM · Restricted Project

Aug 19 2020

jurahul abandoned D84075: [MLIR] Add convenience specializations of OpBuilder create() and friends.
Aug 19 2020, 6:32 PM · Restricted Project
jurahul committed rG9c7b0c4aa5eb: [MLIR] Add PatternRewriter::mergeBlockBefore() to merge a block in the middle… (authored by jurahul).
[MLIR] Add PatternRewriter::mergeBlockBefore() to merge a block in the middle…
Aug 19 2020, 4:25 PM
jurahul closed D86251: [MLIR] Add PatternRewriter::mergeBlockBefore() to merge a block in the middle of another block..
Aug 19 2020, 4:25 PM · Restricted Project
jurahul requested review of D86251: [MLIR] Add PatternRewriter::mergeBlockBefore() to merge a block in the middle of another block..
Aug 19 2020, 3:47 PM · Restricted Project

Aug 17 2020

jurahul committed rG9a4b30cf8429: [MLIR] Add support for defining and using Op specific analysis (authored by jurahul).
[MLIR] Add support for defining and using Op specific analysis
Aug 17 2020, 9:01 AM
jurahul closed D84897: [MLIR] Add support for defining and using Op specific analysis.
Aug 17 2020, 9:01 AM · Restricted Project

Aug 13 2020

jurahul updated the diff for D84897: [MLIR] Add support for defining and using Op specific analysis.

Remove double private

Aug 13 2020, 8:44 PM · Restricted Project
jurahul added inline comments to D84897: [MLIR] Add support for defining and using Op specific analysis.
Aug 13 2020, 8:42 PM · Restricted Project

Aug 12 2020

jurahul committed rG12d16de538ce: [MLIR][NFC] Remove tblgen:: prefix in TableGen/*.cpp files (authored by jurahul).
[MLIR][NFC] Remove tblgen:: prefix in TableGen/*.cpp files
Aug 12 2020, 2:42 PM
jurahul closed D85800: [MLIR][NFC] Remove tblgen:: prefix in TableGen/*.cpp files.
Aug 12 2020, 2:42 PM · Restricted Project

Aug 11 2020

jurahul added reviewers for D85800: [MLIR][NFC] Remove tblgen:: prefix in TableGen/*.cpp files: jpienaar, rriddle.
Aug 11 2020, 5:48 PM · Restricted Project
jurahul requested review of D85800: [MLIR][NFC] Remove tblgen:: prefix in TableGen/*.cpp files.
Aug 11 2020, 5:47 PM · Restricted Project
jurahul added a comment to D85704: [drr] Add $_loc special directive for NativeCodeCall.

2 documentation typos, otherwise looks good to me.

Aug 11 2020, 11:57 AM · Restricted Project

Aug 10 2020

jurahul added inline comments to D84897: [MLIR] Add support for defining and using Op specific analysis.
Aug 10 2020, 5:54 PM · Restricted Project
jurahul updated the diff for D84897: [MLIR] Add support for defining and using Op specific analysis.

Address review comments

Aug 10 2020, 5:53 PM · Restricted Project
jurahul committed rG13d05787d0d2: [MLIR][TableGen] Fix ambiguous build methods when inferring result types. (authored by jurahul).
[MLIR][TableGen] Fix ambiguous build methods when inferring result types.
Aug 10 2020, 10:05 AM
jurahul closed D85060: [MLIR][TableGen] Fix ambiguous build methods when inferring result types..
Aug 10 2020, 10:05 AM · Restricted Project
jurahul added a comment to D85060: [MLIR][TableGen] Fix ambiguous build methods when inferring result types..

Thanks. Filed https://bugs.llvm.org/show_bug.cgi?id=47095 to tract the more general mechanism for doing this.

Aug 10 2020, 10:02 AM · Restricted Project

Aug 7 2020

jurahul updated the diff for D85060: [MLIR][TableGen] Fix ambiguous build methods when inferring result types..

Fix comment

Aug 7 2020, 2:02 PM · Restricted Project
jurahul added a comment to D85060: [MLIR][TableGen] Fix ambiguous build methods when inferring result types..

I agree. A more general solution might be to generate all "collective" variants first, and then have a way for the build methods that will be ambiguous with any of them automatically filtered out, so that we don't have to guard their generation, just their emission. That might need the OpMethodSignature to have more structure than the current string members. I will file a bug for this assuming folks agree.

Why not have opClass.newMethod flag this? If adding a new method to the class with the same signature, flag it (return nullptr or some such, depending on where the collision occurs it is either fine or an error). Start with the build methods users requested first and then add autogenerated ones as long as they don't conflict. Then we don't have to do gymnastics here. I'd say even the non-collective ones are the more user friendly ones. Although in cases of conflict it provides the same signature so perhaps it doesn't matter which one gets generated.

Aug 7 2020, 9:35 AM · Restricted Project

Aug 6 2020

jurahul added inline comments to D85382: [MLIR] Add getSizeInBits() for tensor of complex.
Aug 6 2020, 2:27 PM · Restricted Project
jurahul added inline comments to D85449: [mlir][SCF] Add utility to outline the then and else branches of an scf.IfOp.
Aug 6 2020, 10:48 AM · Restricted Project
jurahul added inline comments to D85073: [MLIR] Make gpu.launch_func rewrite pattern part of the LLVM lowering pass..
Aug 6 2020, 8:26 AM · Restricted Project

Aug 4 2020

jurahul updated the diff for D84897: [MLIR] Add support for defining and using Op specific analysis.

Address clang-tidy warnings

Aug 4 2020, 2:14 PM · Restricted Project
jurahul updated the diff for D84897: [MLIR] Add support for defining and using Op specific analysis.

Rebase

Aug 4 2020, 1:21 PM · Restricted Project
jurahul added a comment to D85060: [MLIR][TableGen] Fix ambiguous build methods when inferring result types..

Thanks. @jpienaar, waiting to give you an opportunity to look as well.

Aug 4 2020, 1:19 PM · Restricted Project
jurahul committed rG1d6a724aa1c1: [MLIR] Change FunctionType::get() and TupleType::get() to use TypeRange (authored by jurahul).
[MLIR] Change FunctionType::get() and TupleType::get() to use TypeRange
Aug 4 2020, 12:44 PM
jurahul closed D85075: [MLIR] Change FunctionType::get() and TupleType::get() to use TypeRange.
Aug 4 2020, 12:44 PM · Restricted Project
jurahul updated the diff for D85075: [MLIR] Change FunctionType::get() and TupleType::get() to use TypeRange.

Fix a clang-format warning

Aug 4 2020, 11:46 AM · Restricted Project
jurahul updated the diff for D85075: [MLIR] Change FunctionType::get() and TupleType::get() to use TypeRange.

Address nits

Aug 4 2020, 11:09 AM · Restricted Project

Aug 3 2020

jurahul updated the diff for D85075: [MLIR] Change FunctionType::get() and TupleType::get() to use TypeRange.

Remove OperationSupport.h include

Aug 3 2020, 6:30 PM · Restricted Project
jurahul added a comment to D85075: [MLIR] Change FunctionType::get() and TupleType::get() to use TypeRange.

I did run clang-format, giving it another go.

Aug 3 2020, 6:02 PM · Restricted Project
jurahul updated the diff for D85075: [MLIR] Change FunctionType::get() and TupleType::get() to use TypeRange.

Review feedback

Aug 3 2020, 6:02 PM · Restricted Project
jurahul added a comment to D85060: [MLIR][TableGen] Fix ambiguous build methods when inferring result types..

I agree. A more general solution might be to generate all "collective" variants first, and then have a way for the build methods that will be ambiguous with any of them automatically filtered out, so that we don't have to guard their generation, just their emission. That might need the OpMethodSignature to have more structure than the current string members. I will file a bug for this assuming folks agree.

Aug 3 2020, 11:31 AM · Restricted Project
jurahul updated the diff for D85075: [MLIR] Change FunctionType::get() and TupleType::get() to use TypeRange.

Remove commented out code.

Aug 3 2020, 8:51 AM · Restricted Project

Aug 2 2020

jurahul updated the diff for D85075: [MLIR] Change FunctionType::get() and TupleType::get() to use TypeRange.

Fix flang build failure, address some clang-tidy issues

Aug 2 2020, 5:58 PM · Restricted Project

Aug 1 2020

jurahul requested review of D85075: [MLIR] Change FunctionType::get() and TupleType::get() to use TypeRange.
Aug 1 2020, 9:47 AM · Restricted Project

Jul 31 2020

jurahul edited reviewers for D85060: [MLIR][TableGen] Fix ambiguous build methods when inferring result types., added: jpienaar, stephenneuendorffer; removed: antiagainst.
Jul 31 2020, 5:04 PM · Restricted Project
jurahul requested review of D85060: [MLIR][TableGen] Fix ambiguous build methods when inferring result types..
Jul 31 2020, 5:02 PM · Restricted Project
jurahul committed rGeb8c72cb0d89: [MLIR][NFC] Add FuncOp::getArgumentTypes() (authored by jurahul).
[MLIR][NFC] Add FuncOp::getArgumentTypes()
Jul 31 2020, 1:18 PM
jurahul closed D85038: [MLIR][NFC] Add FuncOp::addArgument() and FuncOp::getArgumentTypes().
Jul 31 2020, 1:18 PM · Restricted Project
jurahul updated the diff for D85038: [MLIR][NFC] Add FuncOp::addArgument() and FuncOp::getArgumentTypes().

Remove FuncOp::getArgument()

Jul 31 2020, 11:40 AM · Restricted Project
jurahul added inline comments to D85038: [MLIR][NFC] Add FuncOp::addArgument() and FuncOp::getArgumentTypes().
Jul 31 2020, 11:38 AM · Restricted Project
jurahul requested review of D85038: [MLIR][NFC] Add FuncOp::addArgument() and FuncOp::getArgumentTypes().
Jul 31 2020, 10:53 AM · Restricted Project

Jul 30 2020

jurahul committed rGa34a8d52605a: [MLIR][NFC] Add SymbolUse::UseRange::empty() (authored by jurahul).
[MLIR][NFC] Add SymbolUse::UseRange::empty()
Jul 30 2020, 3:19 PM
jurahul closed D84984: [MLIR][NFC] Add SymbolUse::UseRange::empty().
Jul 30 2020, 3:19 PM · Restricted Project
jurahul requested review of D84984: [MLIR][NFC] Add SymbolUse::UseRange::empty().
Jul 30 2020, 2:18 PM · Restricted Project

Jul 29 2020

jurahul added a reviewer for D84897: [MLIR] Add support for defining and using Op specific analysis: mehdi_amini.
Jul 29 2020, 5:23 PM · Restricted Project
jurahul requested review of D84897: [MLIR] Add support for defining and using Op specific analysis.
Jul 29 2020, 5:22 PM · Restricted Project

Jul 28 2020

jurahul committed rG706d992cedaf: [NFC] Add getArgumentTypes() to Region (authored by jurahul).
[NFC] Add getArgumentTypes() to Region
Jul 28 2020, 6:28 PM
jurahul closed D84807: [NFC] Add getArgumentTypes() to Region.
Jul 28 2020, 6:28 PM · Restricted Project
jurahul committed rG0b161def6cac: [MLIR] Add unit test for tblgen Op build methods (authored by jurahul).
[MLIR] Add unit test for tblgen Op build methods
Jul 28 2020, 3:44 PM
jurahul closed D84074: [MLIR] Add unit test for tblgen Op build methods.
Jul 28 2020, 3:44 PM · Restricted Project
jurahul requested review of D84807: [NFC] Add getArgumentTypes() to Region.
Jul 28 2020, 3:26 PM · Restricted Project
jurahul added a comment to D84074: [MLIR] Add unit test for tblgen Op build methods.

I have added a comment explaining why I am testing these 3 combinations in particulat:

I think you have a reason for this configuration, but it isn't clear just looking at the code why (for example) multiple variadic args need not be tested.

Jul 28 2020, 10:32 AM · Restricted Project
jurahul updated the diff for D84074: [MLIR] Add unit test for tblgen Op build methods.

Address review comment

Jul 28 2020, 10:30 AM · Restricted Project

Jul 22 2020

jurahul committed rGed88cd77d4a0: [NFC] Simplify `splitLiteralAndReplacement` function (authored by jurahul).
[NFC] Simplify `splitLiteralAndReplacement` function
Jul 22 2020, 3:33 PM
jurahul closed D84178: [NFC] Simplify `splitLiteralAndReplacement` function.
Jul 22 2020, 3:33 PM · Restricted Project
jurahul committed rGe6ea5b388b0d: [LLVM] Update formatv() documentation to clarify no escape for `}` (authored by jurahul).
[LLVM] Update formatv() documentation to clarify no escape for `}`
Jul 22 2020, 3:31 PM
jurahul closed D83888: [LLVM] Update formatv() documentation to clarify no escape for `}`.
Jul 22 2020, 3:31 PM · Restricted Project

Jul 21 2020

jurahul added a comment to D84075: [MLIR] Add convenience specializations of OpBuilder create() and friends.

@ftynse, I read your document a bit, but another idea came to my mind which seems like an incremental change. Instead of the per-dialect builder you had suggested:

Jul 21 2020, 7:43 AM · Restricted Project

Jul 20 2020

jurahul added a comment to D84075: [MLIR] Add convenience specializations of OpBuilder create() and friends.

Agreed, in certain instances if clarity is desired, an explicit TypeRange{} can be still be added. But in many cases, things may be clear enough that the extra 'TypeRange{}' or ValueRange{} may be just noise, which is what I am attempting to address here. We have some instances within MLIR, but I suspect several out-of-tree instances that would read easier without these casts.

Jul 20 2020, 9:39 AM · Restricted Project
jurahul added a reviewer for D84178: [NFC] Simplify `splitLiteralAndReplacement` function: sammccall.
Jul 20 2020, 8:29 AM · Restricted Project
Herald added a project to D84178: [NFC] Simplify `splitLiteralAndReplacement` function: Restricted Project.
Jul 20 2020, 8:29 AM · Restricted Project
jurahul updated the diff for D84075: [MLIR] Add convenience specializations of OpBuilder create() and friends.

Cleanup leftover macro code

Jul 20 2020, 8:23 AM · Restricted Project
jurahul added a comment to D84075: [MLIR] Add convenience specializations of OpBuilder create() and friends.

This is my attempt to remove the use of Macros. With this, we essentially need one specialization class for each function we want to specialize. I tried to go down a different route as well, creating an instance of an (empty) specialization object with a templated () operator. The hope was that we can define this class just once, and say the builder has an instance of this class called 'create' and we could do something like

Jul 20 2020, 8:21 AM · Restricted Project
jurahul updated the diff for D84075: [MLIR] Add convenience specializations of OpBuilder create() and friends.

Eliminate macros

Jul 20 2020, 8:08 AM · Restricted Project
jurahul added inline comments to D83888: [LLVM] Update formatv() documentation to clarify no escape for `}`.
Jul 20 2020, 8:06 AM · Restricted Project
jurahul updated the summary of D83888: [LLVM] Update formatv() documentation to clarify no escape for `}`.
Jul 20 2020, 8:05 AM · Restricted Project
jurahul updated the diff for D83888: [LLVM] Update formatv() documentation to clarify no escape for `}`.

Review feedback

Jul 20 2020, 8:04 AM · Restricted Project

Jul 17 2020

jurahul added inline comments to D84075: [MLIR] Add convenience specializations of OpBuilder create() and friends.
Jul 17 2020, 5:38 PM · Restricted Project
jurahul added inline comments to D84075: [MLIR] Add convenience specializations of OpBuilder create() and friends.
Jul 17 2020, 4:45 PM · Restricted Project