Page MenuHomePhabricator

jurahul (Rahul Joshi)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 17 2020, 11:03 AM (115 w, 3 d)

Recent Activity

Jan 24 2022

jurahul committed rGadb6494660eb: [MLIR] Add generic walk support to OpState (authored by jurahul).
[MLIR] Add generic walk support to OpState
Jan 24 2022, 1:36 PM
jurahul closed D117949: [MLIR] Add generic walk support to OpDefinition.h.
Jan 24 2022, 1:36 PM · Restricted Project

Jan 22 2022

jurahul updated the summary of D117949: [MLIR] Add generic walk support to OpDefinition.h.
Jan 22 2022, 6:01 AM · Restricted Project
jurahul requested review of D117949: [MLIR] Add generic walk support to OpDefinition.h.
Jan 22 2022, 6:01 AM · Restricted Project

Jan 14 2022

jurahul committed rG8067ced144a2: [MLIR] Introduce generic visitors. (authored by jurahul).
[MLIR] Introduce generic visitors.
Jan 14 2022, 9:16 AM
jurahul closed D116230: [MLIR] Introduce generic visitors..
Jan 14 2022, 9:16 AM · Restricted Project

Jan 13 2022

jurahul updated the diff for D116230: [MLIR] Introduce generic visitors..

Address River's comments.

Jan 13 2022, 1:32 PM · Restricted Project
jurahul updated the diff for D116230: [MLIR] Introduce generic visitors..

Address review comments

Jan 13 2022, 11:08 AM · Restricted Project
jurahul added inline comments to D116230: [MLIR] Introduce generic visitors..
Jan 13 2022, 10:00 AM · Restricted Project

Jan 12 2022

jurahul added inline comments to D116230: [MLIR] Introduce generic visitors..
Jan 12 2022, 4:38 PM · Restricted Project
jurahul updated the diff for D116230: [MLIR] Introduce generic visitors..

Address review comments

Jan 12 2022, 4:36 PM · Restricted Project

Jan 4 2022

jurahul added a comment to D116230: [MLIR] Introduce generic visitors..

@rriddle PTAL again.

Jan 4 2022, 7:50 AM · Restricted Project

Dec 24 2021

jurahul updated the diff for D116230: [MLIR] Introduce generic visitors..

Address review comments.

Dec 24 2021, 10:30 AM · Restricted Project

Dec 23 2021

jurahul added reviewers for D116230: [MLIR] Introduce generic visitors.: dcaballe, mehdi_amini.
Dec 23 2021, 1:31 PM · Restricted Project
jurahul requested review of D116230: [MLIR] Introduce generic visitors..
Dec 23 2021, 11:48 AM · Restricted Project

Nov 23 2021

jurahul committed rG4961fcfbcf68: Move dependency llvm:AllTargetsAsmParsers from Translation to ExecutionEngine. (authored by jurahul).
Move dependency llvm:AllTargetsAsmParsers from Translation to ExecutionEngine.
Nov 23 2021, 2:11 PM
jurahul closed D114471: Move dependency llvm:AllTargetsAsmParsers from Translation to ExecutionEngine..
Nov 23 2021, 2:10 PM · Restricted Project
jurahul added reviewers for D114471: Move dependency llvm:AllTargetsAsmParsers from Translation to ExecutionEngine.: nicolasvasilache, mehdi_amini, GMNGeoffrey.
Nov 23 2021, 1:29 PM · Restricted Project
jurahul requested review of D114471: Move dependency llvm:AllTargetsAsmParsers from Translation to ExecutionEngine..
Nov 23 2021, 1:25 PM · Restricted Project

Sep 15 2021

jurahul accepted D109822: [MLIR] Tighten type constraint on memref.global op def.
Sep 15 2021, 10:04 AM · Restricted Project

Aug 31 2021

jurahul added inline comments to D108536: [mlir][RISCVV][RFC] Initial RISCVV Dialect.
Aug 31 2021, 9:19 AM · Restricted Project, Restricted Project

Jul 26 2021

jurahul committed rG86778e8b3036: [MLIR][NFC] Rework some comments. (authored by jurahul).
[MLIR][NFC] Rework some comments.
Jul 26 2021, 5:09 PM
jurahul closed D106834: [MLIR][NFC] Rework some comments..
Jul 26 2021, 5:09 PM · Restricted Project
jurahul added reviewers for D106834: [MLIR][NFC] Rework some comments.: rriddle, mehdi_amini.
Jul 26 2021, 3:47 PM · Restricted Project
jurahul requested review of D106834: [MLIR][NFC] Rework some comments..
Jul 26 2021, 3:47 PM · Restricted Project
jurahul committed rG58aa3881bac6: [MLIR][SCF][NFC] Fix typo in documentation of scf.while (authored by jurahul).
[MLIR][SCF][NFC] Fix typo in documentation of scf.while
Jul 26 2021, 3:32 PM
jurahul closed D106806: [MLIR][SCF][NFC] Fix typo in documentation of scf.while.
Jul 26 2021, 3:32 PM · Restricted Project
jurahul added reviewers for D106806: [MLIR][SCF][NFC] Fix typo in documentation of scf.while: ftynse, jpienaar.
Jul 26 2021, 9:42 AM · Restricted Project
jurahul requested review of D106806: [MLIR][SCF][NFC] Fix typo in documentation of scf.while.
Jul 26 2021, 9:39 AM · Restricted Project

Jul 23 2021

jurahul committed rG17de7ed556ad: [MLIR][NFC] Minor cleanup in liveness. (authored by jurahul).
[MLIR][NFC] Minor cleanup in liveness.
Jul 23 2021, 1:30 PM
jurahul closed D106702: [MLIR][NFC] Minor cleanup in liveness..
Jul 23 2021, 1:30 PM · Restricted Project
jurahul updated the diff for D106702: [MLIR][NFC] Minor cleanup in liveness..

Update usage in comment

Jul 23 2021, 1:12 PM · Restricted Project
jurahul added a reviewer for D106702: [MLIR][NFC] Minor cleanup in liveness.: rriddle.
Jul 23 2021, 1:11 PM · Restricted Project
jurahul added inline comments to D106702: [MLIR][NFC] Minor cleanup in liveness..
Jul 23 2021, 1:10 PM · Restricted Project
jurahul added reviewers for D106702: [MLIR][NFC] Minor cleanup in liveness.: pifon2a, herhut, mehdi_amini.
Jul 23 2021, 12:52 PM · Restricted Project
jurahul requested review of D106702: [MLIR][NFC] Minor cleanup in liveness..
Jul 23 2021, 12:51 PM · Restricted Project

Jul 22 2021

jurahul committed rGf8d3755f00b8: [MLIR][memref] Fix findDealloc() to handle > 1 dealloc for the given alloc. (authored by jurahul).
[MLIR][memref] Fix findDealloc() to handle > 1 dealloc for the given alloc.
Jul 22 2021, 9:35 AM
jurahul closed D106456: [MLIR][memref] Fix findDealloc() to handle > 1 dealloc for the given alloc..
Jul 22 2021, 9:35 AM · Restricted Project

Jul 21 2021

jurahul updated the diff for D106456: [MLIR][memref] Fix findDealloc() to handle > 1 dealloc for the given alloc..

Remove findDeallocs()

Jul 21 2021, 5:14 PM · Restricted Project
jurahul added inline comments to D106456: [MLIR][memref] Fix findDealloc() to handle > 1 dealloc for the given alloc..
Jul 21 2021, 3:01 PM · Restricted Project
jurahul added reviewers for D106456: [MLIR][memref] Fix findDealloc() to handle > 1 dealloc for the given alloc.: herhut, pifon2a, dfki-jugr, mehdi_amini.
Jul 21 2021, 9:13 AM · Restricted Project
jurahul requested review of D106456: [MLIR][memref] Fix findDealloc() to handle > 1 dealloc for the given alloc..
Jul 21 2021, 9:11 AM · Restricted Project

Jul 20 2021

jurahul committed rG0cc2346cbfaa: [MLIR][NFC] Minor cleanup for BufferDeallocation pass. (authored by jurahul).
[MLIR][NFC] Minor cleanup for BufferDeallocation pass.
Jul 20 2021, 9:43 AM
jurahul closed D106373: [MLIR][NFC] Minor cleanup for BufferDeallocation pass..
Jul 20 2021, 9:43 AM · Restricted Project
jurahul added reviewers for D106373: [MLIR][NFC] Minor cleanup for BufferDeallocation pass.: dfki-jugr, herhut, pifon2a.
Jul 20 2021, 9:02 AM · Restricted Project
jurahul requested review of D106373: [MLIR][NFC] Minor cleanup for BufferDeallocation pass..
Jul 20 2021, 8:58 AM · Restricted Project
jurahul committed rG53e5a60fd53d: [NFC] Fix some comments and only look at terminators when looking for… (authored by jurahul).
[NFC] Fix some comments and only look at terminators when looking for…
Jul 20 2021, 8:07 AM
jurahul closed D106326: [NFC] Fix some comments and only look at terminators when looking for ReturnLike ops.
Jul 20 2021, 8:06 AM · Restricted Project

Jul 19 2021

jurahul added reviewers for D106326: [NFC] Fix some comments and only look at terminators when looking for ReturnLike ops: tpopp, herhut, mehdi_amini.
Jul 19 2021, 5:25 PM · Restricted Project
jurahul requested review of D106326: [NFC] Fix some comments and only look at terminators when looking for ReturnLike ops.
Jul 19 2021, 5:20 PM · Restricted Project

May 13 2021

jurahul committed rG23a84e1c602c: [MLIR] Fix build failures due to unused variables in non-debug builds. (authored by jurahul).
[MLIR] Fix build failures due to unused variables in non-debug builds.
May 13 2021, 6:43 PM
jurahul closed D102458: [MLIR] Fix build failures due to unused variables in non-debug builds..
May 13 2021, 6:43 PM · Restricted Project
jurahul added a reviewer for D102458: [MLIR] Fix build failures due to unused variables in non-debug builds.: aartbik.
May 13 2021, 6:39 PM · Restricted Project
jurahul added reviewers for D102458: [MLIR] Fix build failures due to unused variables in non-debug builds.: silvas, GMNGeoffrey.
May 13 2021, 6:36 PM · Restricted Project
jurahul requested review of D102458: [MLIR] Fix build failures due to unused variables in non-debug builds..
May 13 2021, 6:34 PM · Restricted Project

Feb 22 2021

jurahul added a comment to D97217: [mlir] Extend Operation visitor with pre-order traversal.

Please also see: https://github.com/tensorflow/tensorflow/blob/master/tensorflow/compiler/mlir/tensorflow/utils/visitor_util.h

Feb 22 2021, 2:03 PM · Restricted Project

Jan 12 2021

jurahul committed rG67a339e96839: [MLIR] Disallow `sym_visibility`, `sym_name` and `type` attributes in the… (authored by jurahul).
[MLIR] Disallow `sym_visibility`, `sym_name` and `type` attributes in the…
Jan 12 2021, 9:12 AM
jurahul closed D94200: [MLIR] Disallow `sym_visibility`, `sym_name` and `type` attributes in the parsed attribute dictionary..
Jan 12 2021, 9:12 AM · Restricted Project

Jan 6 2021

jurahul updated the diff for D94200: [MLIR] Disallow `sym_visibility`, `sym_name` and `type` attributes in the parsed attribute dictionary..

Make error message concise.

Jan 6 2021, 4:33 PM · Restricted Project
jurahul updated the diff for D94200: [MLIR] Disallow `sym_visibility`, `sym_name` and `type` attributes in the parsed attribute dictionary..

Better error messages

Jan 6 2021, 4:26 PM · Restricted Project
jurahul added inline comments to D94200: [MLIR] Disallow `sym_visibility`, `sym_name` and `type` attributes in the parsed attribute dictionary..
Jan 6 2021, 3:56 PM · Restricted Project
jurahul added inline comments to D94200: [MLIR] Disallow `sym_visibility`, `sym_name` and `type` attributes in the parsed attribute dictionary..
Jan 6 2021, 3:54 PM · Restricted Project
jurahul updated the diff for D94200: [MLIR] Disallow `sym_visibility`, `sym_name` and `type` attributes in the parsed attribute dictionary..

Simplify by moving check in parseFunctionLikeOp

Jan 6 2021, 3:43 PM · Restricted Project
jurahul added a comment to D94200: [MLIR] Disallow `sym_visibility`, `sym_name` and `type` attributes in the parsed attribute dictionary..

This is in preparation of the visibility related changes discussed in https://llvm.discourse.group/t/external-function-declaration-has-changed-help-needed/2357. This change disallows attributes that sym_visibility/sym_name/type etc which are parsed/inferred from other places to be present in the attribute dictionary. This way, for the follow on changes, the function parser has just one parsed visibility value (parsed as keyword private/public/nested) to consider instead of trying to also look into the parsed attribute dictionary.

Jan 6 2021, 3:20 PM · Restricted Project
jurahul requested review of D94200: [MLIR] Disallow `sym_visibility`, `sym_name` and `type` attributes in the parsed attribute dictionary..
Jan 6 2021, 3:17 PM · Restricted Project

Dec 29 2020

jurahul added inline comments to D93908: [AsmPrinter] Make OpAsmPrinter::printFunctionalType be resilient to null values..
Dec 29 2020, 11:23 AM · Restricted Project

Dec 28 2020

jurahul committed rG25007b4d7e09: [MLIR][NFC] Change FunctionLike::setAllArgAttrs/setAllResultAttrs to do a one… (authored by jurahul).
[MLIR][NFC] Change FunctionLike::setAllArgAttrs/setAllResultAttrs to do a one…
Dec 28 2020, 2:16 PM
jurahul closed D93870: [MLIR][NFC] Change FunctionLike::setAllArgAttrs/setAllResultAttrs to do a one-shot attribute update..
Dec 28 2020, 2:16 PM · Restricted Project
jurahul retitled D93870: [MLIR][NFC] Change FunctionLike::setAllArgAttrs/setAllResultAttrs to do a one-shot attribute update. from [MLIR] Change FunctionLike::setAllArgAttrs/setAllResultAttrs to do a one-shot attribute update. to [MLIR][NFC] Change FunctionLike::setAllArgAttrs/setAllResultAttrs to do a one-shot attribute update..
Dec 28 2020, 1:35 PM · Restricted Project
jurahul updated the diff for D93870: [MLIR][NFC] Change FunctionLike::setAllArgAttrs/setAllResultAttrs to do a one-shot attribute update..

Use if-else

Dec 28 2020, 1:34 PM · Restricted Project
jurahul added a reviewer for D93870: [MLIR][NFC] Change FunctionLike::setAllArgAttrs/setAllResultAttrs to do a one-shot attribute update.: jpienaar.
Dec 28 2020, 12:21 PM · Restricted Project
jurahul requested review of D93870: [MLIR][NFC] Change FunctionLike::setAllArgAttrs/setAllResultAttrs to do a one-shot attribute update..
Dec 28 2020, 12:06 PM · Restricted Project

Dec 10 2020

jurahul committed rG563879b6f946: [NFC] Use ConvertOpToLLVMPattern instead of ConvertToLLVMPattern. (authored by jurahul).
[NFC] Use ConvertOpToLLVMPattern instead of ConvertToLLVMPattern.
Dec 10 2020, 9:34 AM
jurahul closed D92989: [NFC] Use ConvertOpToLLVMPattern instead of ConvertToLLVMPattern..
Dec 10 2020, 9:34 AM · Restricted Project

Dec 9 2020

jurahul requested review of D92989: [NFC] Use ConvertOpToLLVMPattern instead of ConvertToLLVMPattern..
Dec 9 2020, 6:18 PM · Restricted Project
jurahul committed rGb0d02b698b94: [MLIR] Minor cleanup for Shape dialect. (authored by jurahul).
[MLIR] Minor cleanup for Shape dialect.
Dec 9 2020, 2:22 PM
jurahul closed D92901: [MLIR] Minor cleanup for Shape dialect..
Dec 9 2020, 2:22 PM · Restricted Project
jurahul added inline comments to D92927: [mlir][Shape] Make sure tensor_cast(constant_shape) folding uses the correct type.
Dec 9 2020, 11:22 AM · Restricted Project
jurahul added inline comments to D92901: [MLIR] Minor cleanup for Shape dialect..
Dec 9 2020, 9:24 AM · Restricted Project
jurahul updated the diff for D92901: [MLIR] Minor cleanup for Shape dialect..

Address feedback

Dec 9 2020, 9:23 AM · Restricted Project

Dec 8 2020

jurahul updated the diff for D92901: [MLIR] Minor cleanup for Shape dialect..

Remove test case

Dec 8 2020, 8:33 PM · Restricted Project
jurahul added inline comments to D92901: [MLIR] Minor cleanup for Shape dialect..
Dec 8 2020, 8:31 PM · Restricted Project
jurahul retitled D92901: [MLIR] Minor cleanup for Shape dialect. from [MLIR] Minor cleanup for Shape dialect. - Remove some unused types from the Shape dialect - Fix from_extent_tensor to only allow 1D index tensors - Fix assuming_yield to only allow shape.assuming as the parent op. - Fix some documentation typos... to [MLIR] Minor cleanup for Shape dialect. .
Dec 8 2020, 5:51 PM · Restricted Project
jurahul requested review of D92901: [MLIR] Minor cleanup for Shape dialect..
Dec 8 2020, 5:50 PM · Restricted Project

Dec 4 2020

jurahul committed rGfe7fdcac87be: [MLIR] Fix parseFunctionLikeOp() to fail parsing empty regions (authored by jurahul).
[MLIR] Fix parseFunctionLikeOp() to fail parsing empty regions
Dec 4 2020, 9:10 AM
jurahul closed D91886: [MLIR] Fix parseFunctionLikeOp() to fail parsing empty regions.
Dec 4 2020, 9:10 AM · Restricted Project
jurahul committed rG245233423e46: [MLIR] Generate inferReturnTypes declaration using InferTypeOpInterface trait. (authored by jurahul).
[MLIR] Generate inferReturnTypes declaration using InferTypeOpInterface trait.
Dec 4 2020, 9:09 AM
jurahul closed D92585: [MLIR] Generate inferReturnTypes declaration using InferTypeOpInterface trait..
Dec 4 2020, 9:09 AM · Restricted Project

Dec 3 2020

jurahul added inline comments to D92585: [MLIR] Generate inferReturnTypes declaration using InferTypeOpInterface trait..
Dec 3 2020, 4:19 PM · Restricted Project
jurahul updated the diff for D92585: [MLIR] Generate inferReturnTypes declaration using InferTypeOpInterface trait..

Address feedback

Dec 3 2020, 4:18 PM · Restricted Project
jurahul updated the diff for D92585: [MLIR] Generate inferReturnTypes declaration using InferTypeOpInterface trait..

Fix clang-tidy warning

Dec 3 2020, 3:38 PM · Restricted Project
jurahul requested review of D92585: [MLIR] Generate inferReturnTypes declaration using InferTypeOpInterface trait..
Dec 3 2020, 10:16 AM · Restricted Project

Dec 2 2020

jurahul updated the diff for D91886: [MLIR] Fix parseFunctionLikeOp() to fail parsing empty regions.

River's feedback

Dec 2 2020, 4:50 PM · Restricted Project
jurahul added a comment to D91886: [MLIR] Fix parseFunctionLikeOp() to fail parsing empty regions.

Not really. Note that both

Dec 2 2020, 10:48 AM · Restricted Project

Dec 1 2020

jurahul committed rG6b043ecdb71b: [MLIR] Fix genTypeInterfaceMethods() to work correctly with InferTypeOpInterface (authored by jurahul).
[MLIR] Fix genTypeInterfaceMethods() to work correctly with InferTypeOpInterface
Dec 1 2020, 1:37 PM
jurahul closed D92414: [MLIR] Fix genTypeInterfaceMethods() to work correctly with InferTypeOpInterface.
Dec 1 2020, 1:37 PM · Restricted Project
jurahul added a comment to D92414: [MLIR] Fix genTypeInterfaceMethods() to work correctly with InferTypeOpInterface.

Could we also remove the hard coding in genTypeInterfaceMethods ? (not for this one)

Dec 1 2020, 1:34 PM · Restricted Project
jurahul added a comment to D92414: [MLIR] Fix genTypeInterfaceMethods() to work correctly with InferTypeOpInterface.

The fix here is such that TableGen generated inferReturnTypes takes precedence over the one generated by the InferTypeOpInterface. Just tagging the Op with the trait is not sufficient since I assume we also want the generated inferReturnTypes. The other possible fix is to avoid generating the TableGen generated inferReturnTypes method when the Op is tagged with DeclareOpInterfaceMethods<InferTypeOpInterface> and delegate the definition of the method to the user. I've erred on the side of using the TableGen one.

Dec 1 2020, 11:27 AM · Restricted Project
jurahul requested review of D92414: [MLIR] Fix genTypeInterfaceMethods() to work correctly with InferTypeOpInterface.
Dec 1 2020, 11:21 AM · Restricted Project

Nov 24 2020

jurahul added a comment to D91886: [MLIR] Fix parseFunctionLikeOp() to fail parsing empty regions.

Ping.

Nov 24 2020, 10:11 AM · Restricted Project