Page MenuHomePhabricator

[Clang/Test]: Update tests where `noundef` attribute is necessary
Needs ReviewPublic

Authored by guiand on Jun 22 2020, 10:29 AM.

Details

Summary

The noundef attribute generally applies to all scalar function
arguments and return values. In the interest of having Clang's
test suite reflect its codegen, it has been updated to include
the new attribute.

Most tests were updated programatically, although some
required more manual intervention, usually due to regexps or
other complications in parsing. Some tests were too burdensome
to update immediately, and to these were applied a cc1 flag to
mask emitting noundef attributes in argument position.

Diff Detail

Event Timeline

guiand created this revision.Jun 22 2020, 10:29 AM

This very large diff affects more than 1,000 files. Use the Changeset List to browse changes.

This we will "look" at once the rest is settled ;)

guiand updated this revision to Diff 273570.Jun 25 2020, 5:56 PM
guiand retitled this revision from [Clang/Test]: Update tests where `frozen` attribute is necessary to [Clang/Test]: Update tests where `noundef` attribute is necessary.
guiand edited the summary of this revision. (Show Details)

Updated almost all tests to rename frozen->noundef. Still needs rebase to master

guiand updated this revision to Diff 275771.Mon, Jul 6, 11:12 AM

Another wave of test updates

lenary removed a subscriber: lenary.Mon, Jul 6, 11:13 AM
guiand updated this revision to Diff 277992.Tue, Jul 14, 3:00 PM

Update tests again

guiand updated this revision to Diff 280588.Fri, Jul 24, 2:36 PM

Update tests to reflect more strict noundef rules

guiand updated this revision to Diff 281452.Tue, Jul 28, 6:53 PM

All tests up to date. Of particular note are the ppc-*mmintrin.c tests, which seemed to drastically change upon rerunning the test autogen script.

@jdoerfert what would the procedure be for reviewing these test changes / getting this landed with the noundef patch?

guiand updated this revision to Diff 282328.Fri, Jul 31, 3:11 PM

Rebased; all tests passing again. Removed the change to the ppc-*mmintrin.c tests, instead I just use the -disable-noundef-args flag`. Cleaned up typos.

jdoerfert resigned from this revision.Mon, Aug 3, 12:06 AM
jdoerfert edited reviewers, added: rsmith, rjmccall; removed: jdoerfert, sscalpone.
jdoerfert added subscribers: rjmccall, rsmith.

@jdoerfert what would the procedure be for reviewing these test changes / getting this landed with the noundef patch?

Hmmm. I guess @rsmith @rjmccall and others need to decide how this proceeds.