Page MenuHomePhabricator

hyeongyukim (Hyeongyu Kim)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 28 2021, 7:00 PM (60 w, 19 h)

Recent Activity

Feb 18 2022

hyeongyukim committed rG35baa26747b0: [NFC][Clang/test] add target triple to CodeGen/analyze_noundef.cpp (authored by hyeongyukim).
[NFC][Clang/test] add target triple to CodeGen/analyze_noundef.cpp
Feb 18 2022, 12:55 AM
hyeongyukim committed rG5333447a00ff: [NFC] Fix a buildbot failure after b529744 (authored by hyeongyukim).
[NFC] Fix a buildbot failure after b529744
Feb 18 2022, 12:39 AM
hyeongyukim committed rGb529744c29a8: [Clang] Rename `disable-noundef-analysis` flag to `-[no-]enable-noundef… (authored by hyeongyukim).
[Clang] Rename `disable-noundef-analysis` flag to `-[no-]enable-noundef…
Feb 18 2022, 12:03 AM
hyeongyukim closed D119998: [Clang] Rename `disable-noundef-analysis` flag to `-[no-]enable-noundef-analysis`.
Feb 18 2022, 12:02 AM · Restricted Project

Feb 16 2022

hyeongyukim added reviewers for D119998: [Clang] Rename `disable-noundef-analysis` flag to `-[no-]enable-noundef-analysis`: dblaikie, MaskRay, rjmccall.
Feb 16 2022, 6:36 PM · Restricted Project
hyeongyukim requested review of D119998: [Clang] Rename `disable-noundef-analysis` flag to `-[no-]enable-noundef-analysis`.
Feb 16 2022, 6:33 PM · Restricted Project

Feb 14 2022

hyeongyukim added a comment to D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default.

Thank you for your clarification. I'll change it.

Feb 14 2022, 5:21 PM · Restricted Project
hyeongyukim added a comment to D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default.

It may not be worth changing now, but I want to mention: it's more conventional to have a BoolOption which adds -[no-]noundef-analysis. Since both positive and negative forms exist. When we make the default switch, existing users don't need to change the option. After the option becomes quite stable and the workaround is deemed not useful, we can remove the CC1 option.

+1 to this (changing the name and the default at the same time makes migrations a bit more difficult - if the default is changed without renaming (by having both positive and negative flag names) then users can adopt their current default explicitly with no change ahead of picking up the patch that changes the default) & also this flag seems to have no tests? Could you (@hyeongyukim ) add some frontend test coverage for the flag - and yeah, maybe consider giving it a name that has both explicit on/off names, as @MaskRay suggested? (I think that's useful even after the default switch - since a user might want to override a previous argument on the command line, etc)

Feb 14 2022, 3:38 PM · Restricted Project

Jan 16 2022

hyeongyukim committed rG4608b1d726da: Resolve lit failures in clang-aarch64* (authored by hyeongyukim).
Resolve lit failures in clang-aarch64*
Jan 16 2022, 6:06 AM
hyeongyukim committed rGbe9eafc71004: [msan] reflect the changed flag to the tests. (authored by hyeongyukim).
[msan] reflect the changed flag to the tests.
Jan 16 2022, 3:56 AM
hyeongyukim committed rG1b1c8d83d356: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and… (authored by hyeongyukim).
[Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and…
Jan 16 2022, 2:13 AM

Jan 14 2022

hyeongyukim added a comment to D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default.

@nathanchance Hi, I analyzed all four warnings.

Jan 14 2022, 12:36 AM · Restricted Project

Jan 13 2022

hyeongyukim added a comment to D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default.

@nathanchance
You were right. I succeeded in reproducing the warning with -fsanitize-coverage=trace-pc
However, this problem seems to be fixed in the latest version. (I used 57a551a)

Jan 13 2022, 8:23 AM · Restricted Project

Jan 11 2022

hyeongyukim added a comment to D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default.

I tried to reproduce the last warning (intelfbhw_validate_mode), but I failed to produce it.
I think my reproducer is correct, but it does not make any warning.
Can you tell me which part was wrong?

Jan 11 2022, 10:01 PM · Restricted Project

Dec 29 2021

hyeongyukim added a comment to D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default.

Great. I'll check it out.

Dec 29 2021, 5:02 PM · Restricted Project

Dec 28 2021

hyeongyukim added a comment to D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default.

@hyeongyukim I am currently offline for the evening but it seems like my reduction might have been too aggressive. It looks like this code comes from ravb_set_gti() (https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/ethernet/renesas/ravb_main.c?h=v5.16-rc7#n2480), which checks that rate is not zero before using it as a divisor. I will see if I can get a reproducer without any undefined behavior such as this.

Dec 28 2021, 7:10 PM · Restricted Project
hyeongyukim added a comment to D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default.

Prior to the latest revert (fd9b099906c61e46574d1ea2d99b973321fe1d21), the Linux kernel's binary verifier (objtool) points out an issue when building with ThinLTO and -fsanitize=integer-divide-by-zero. I have no idea if this is an issue with the tool or this series. A simplified reproducer:

$ cat ravb_main.i
int ravb_set_gti_ndev_rate;
unsigned int ravb_set_gti_ndev_inc;
void ravb_set_gti_ndev() {
  ravb_set_gti_ndev_inc = 1000000000;
  ravb_set_gti_ndev_inc = ravb_set_gti_ndev_inc / ravb_set_gti_ndev_rate;
  if (ravb_set_gti_ndev_inc)
    _dev_err(ravb_set_gti_ndev_inc);
}

$ clang -std=gnu89 -O2 -flto=thin -fsanitize=integer-divide-by-zero -c -o ravb_main.o ravb_main.i

$ llvm-ar cDPrsT ravb.o ravb_main.o

$ ld.lld -m elf_x86_64 -r -o ravb.lto.o --whole-archive ravb.o

$ ./objtool orc generate --no-fp --no-unreachable --retpoline --uaccess --mcount --module ravb.lto.o
ravb.lto.o: warning: objtool: .text.ravb_set_gti_ndev: unexpected end of section

With LLVM 13.0.0, there is no warning with those commands. The original and reduced .i file, interestingness test, and static objtool binary are available here.

Dec 28 2021, 5:50 PM · Restricted Project

Nov 14 2021

hyeongyukim added a comment to D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default.

Either this or D108453 (which were committed together!) caused this assert according to my git-bisect: https://godbolt.org/z/4rqYKfW7K

NOTE that this fails in a lit-test for me, clang CodeGen/ifunc.c (though my downstream seems to run the verifier even with -emit-llvm, so you might need to just swap it to an -emit-obj to get this to repro).

Nov 14 2021, 5:29 PM · Restricted Project

Nov 13 2021

hyeongyukim committed rG7f7cab6bb1d4: [sanitizer][aarch64] fix clone system call's inline assembly (authored by hyeongyukim).
[sanitizer][aarch64] fix clone system call's inline assembly
Nov 13 2021, 4:53 PM

Nov 8 2021

hyeongyukim committed rG8d3b28e7547a: [NFC] Fix lit test failures for clang/CodegenCoroutines (authored by hyeongyukim).
[NFC] Fix lit test failures for clang/CodegenCoroutines
Nov 8 2021, 9:47 AM
hyeongyukim added a reverting change for rGaacfbb953eb7: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and…: rGfd9b099906c6: Revert "[Clang/Test]: Rename enable_noundef_analysis to disable-noundef….
Nov 8 2021, 9:18 AM
hyeongyukim committed rGfd9b099906c6: Revert "[Clang/Test]: Rename enable_noundef_analysis to disable-noundef… (authored by hyeongyukim).
Revert "[Clang/Test]: Rename enable_noundef_analysis to disable-noundef…
Nov 8 2021, 9:18 AM
hyeongyukim added a reverting change for rG63fff0f5bffe: Fix lit test failures in CodeGenCoroutines: rGfd9b099906c6: Revert "[Clang/Test]: Rename enable_noundef_analysis to disable-noundef….
Nov 8 2021, 9:18 AM
hyeongyukim added a reverting change for D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default: rGfd9b099906c6: Revert "[Clang/Test]: Rename enable_noundef_analysis to disable-noundef….
Nov 8 2021, 9:18 AM · Restricted Project
hyeongyukim added a comment to D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default.

Either this or D108453 (which were committed together!) caused this assert according to my git-bisect: https://godbolt.org/z/4rqYKfW7K

NOTE that this fails in a lit-test for me, clang CodeGen/ifunc.c (though my downstream seems to run the verifier even with -emit-llvm, so you might need to just swap it to an -emit-obj to get this to repro).

If you cannot fix this quickly, let me know and I can revert it.

IR for this looks like:

[ekeane1@scsel-clx-24 llvm]$ /localdisk2/ekeane1/workspaces/xmain-web/builds/xmainefi2linux_debug/llvm/bin/clang -cc1 -internal-isystem /localdisk2/ekeane1/workspaces/xmain-web/builds/xmainefi2linux_debug/llvm/lib/clang/14.0.0/include -nostdsysteminc -triple i386-unknown-linux-gnu -emit-llvm -o - /localdisk2/ekeane1/workspaces/xmain-web/llvm/clang/test/CodeGen/ifunc.c -disable-llvm-passes
; ModuleID = '/localdisk2/ekeane1/workspaces/xmain-web/llvm/clang/test/CodeGen/ifunc.c'
source_filename = "/localdisk2/ekeane1/workspaces/xmain-web/llvm/clang/test/CodeGen/ifunc.c"
target datalayout = "e-m:e-p:32:32-p270:32:32-p271:32:32-p272:64:64-f64:32:64-f80:32-n8:16:32-S128"
target triple = "i386-unknown-linux-gnu"

@global = global i32 0, align 4

@foo = ifunc i32 (i32), i32 (i32)* ()* @foo_ifunc
@goo = ifunc void (), bitcast (i8* ()* @goo_ifunc to void ()* ()*)

; Function Attrs: noinline nounwind optnone
define internal i32 (i32)* @foo_ifunc() #0 {
entry:
  %0 = load i32, i32* @global, align 4
  %tobool = icmp ne i32 %0, 0
  %1 = zext i1 %tobool to i64
  %cond = select i1 %tobool, i32 (i32)* @f1, i32 (i32)* @f2
  ret i32 (i32)* %cond
}

; Function Attrs: noinline nounwind optnone
define dso_local i32 @bar() #0 {
entry:
  %call = call i32 @foo(i32 noundef 1)
  ret i32 %call
}

; Function Attrs: noinline nounwind optnone
define dso_local void @bar2() #0 {
entry:
  call void @goo()
  ret void
}

; Function Attrs: noinline nounwind optnone
define dso_local i8* @goo_ifunc() #0 {
entry:
  ret i8* null
}

; Function Attrs: noinline nounwind optnone
define internal i32 @f1(i32 noundef %i) #0 {
entry:
  %i.addr = alloca i32, align 4
  store i32 %i, i32* %i.addr, align 4
  %0 = load i32, i32* %i.addr, align 4
  %add = add nsw i32 %0, 1
  ret i32 %add
}

; Function Attrs: noinline nounwind optnone
define internal i32 @f2(i32 noundef %i) #0 {
entry:
  %i.addr = alloca i32, align 4
  store i32 %i, i32* %i.addr, align 4
  %0 = load i32, i32* %i.addr, align 4
  %add = add nsw i32 %0, 2
  ret i32 %add
}

attributes #0 = { noinline nounwind optnone "frame-pointer"="none" "min-legal-vector-width"="0" "no-trapping-math"="true" "stack-protector-buffer-size"="8" "target-features"="+cx8,+x87" }

!llvm.module.flags = !{!0, !1}
!llvm.ident = !{!2}

!0 = !{i32 1, !"NumRegisterParameters", i32 0}
!1 = !{i32 1, !"wchar_size", i32 4}
!2 = !{!"Intel(R) oneAPI DPC++/C++ Compiler 2022.1.0 (2022.x.0.YYYYMMDD)"}
Nov 8 2021, 9:03 AM · Restricted Project

Nov 6 2021

hyeongyukim committed rG63fff0f5bffe: Fix lit test failures in CodeGenCoroutines (authored by hyeongyukim).
Fix lit test failures in CodeGenCoroutines
Nov 6 2021, 3:59 AM
hyeongyukim committed rGaacfbb953eb7: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and… (authored by hyeongyukim).
[Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and…
Nov 6 2021, 3:20 AM

Nov 5 2021

hyeongyukim added a comment to D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default.
diff --git a/compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp b/compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp
index ea3e5bdbc754..826c6d36e1b1 100644
--- a/compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp
+++ b/compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp
@@ -1360,7 +1360,7 @@ uptr internal_clone(int (*fn)(void *), void *child_stack, int flags, void *arg,
 #elif defined(__aarch64__)
 uptr internal_clone(int (*fn)(void *), void *child_stack, int flags, void *arg,
                     int *parent_tidptr, void *newtls, int *child_tidptr) {
-  long long res;
+  register long long res __asm__("x0");
   if (!fn || !child_stack)
     return -EINVAL;
   CHECK_EQ(0, (uptr)child_stack % 16);

After modifying internal_clone like this, the problem disappeared.
Is it okay to commit this change by myself?

Nov 5 2021, 8:32 AM · Restricted Project

Nov 1 2021

hyeongyukim added a comment to D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default.

I checked the reason for failure in address sanitizer tests on the 2-stage aarch64 buildbots.
The buildbot failure was occured because the internal_clone function of the compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp file is being compiled incorrectly.
The internal_clone function is a simple function that calls the clone system call of Linux. Its original return value should be the PID of the newly created process, but the actual returned value is 220 (which is the __NR_clone value.)

Nov 1 2021, 6:50 AM · Restricted Project

Oct 15 2021

hyeongyukim closed D108453: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default (2).
Oct 15 2021, 8:02 PM · Restricted Project, Restricted Project
hyeongyukim committed rG8ca4b3ef19fe: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and… (authored by aqjune).
[Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and…
Oct 15 2021, 8:02 PM
hyeongyukim committed rG80dba72a669b: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and… (authored by aqjune).
[Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and…
Oct 15 2021, 8:02 PM
hyeongyukim closed D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default.
Oct 15 2021, 8:02 PM · Restricted Project
hyeongyukim updated the diff for D108453: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default (2).

Rebase

Oct 15 2021, 9:31 AM · Restricted Project, Restricted Project

Oct 11 2021

hyeongyukim added a comment to D106041: [SimpleLoopUnswitch] Re-fix introduction of UB when hoisted condition may be undef or poison.

Thank you for the review.
I will also prepare for improvement!

Oct 11 2021, 9:06 AM · Restricted Project
hyeongyukim committed rG0aeb37324dbb: [SimpleLoopUnswitch] Re-fix introduction of UB when hoisted condition may be… (authored by hyeongyukim).
[SimpleLoopUnswitch] Re-fix introduction of UB when hoisted condition may be…
Oct 11 2021, 9:02 AM
hyeongyukim closed D106041: [SimpleLoopUnswitch] Re-fix introduction of UB when hoisted condition may be undef or poison.
Oct 11 2021, 9:02 AM · Restricted Project

Oct 7 2021

hyeongyukim added a comment to D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default.

Thank you!
In the meantime, I will rebase this patch and resolve conflicts.

Oct 7 2021, 6:32 PM · Restricted Project

Oct 6 2021

hyeongyukim updated the diff for D106041: [SimpleLoopUnswitch] Re-fix introduction of UB when hoisted condition may be undef or poison.

Changed to the original patch.

Oct 6 2021, 10:21 PM · Restricted Project
hyeongyukim added a comment to D106041: [SimpleLoopUnswitch] Re-fix introduction of UB when hoisted condition may be undef or poison.

Right, many codes were not directly related to solving the loop unswitch problem.
Those codes were created to reduce performance regression, and I agree to separate them into different patches.

Oct 6 2021, 8:37 PM · Restricted Project
hyeongyukim retitled D106041: [SimpleLoopUnswitch] Re-fix introduction of UB when hoisted condition may be undef or poison from [WIP][SimpleLoopUnswitch] Re-fix introduction of UB when hoisted condition may be undef or poison to [SimpleLoopUnswitch] Re-fix introduction of UB when hoisted condition may be undef or poison.
Oct 6 2021, 4:40 AM · Restricted Project
hyeongyukim updated the diff for D106041: [SimpleLoopUnswitch] Re-fix introduction of UB when hoisted condition may be undef or poison.

remove unused sink functions.

Oct 6 2021, 1:51 AM · Restricted Project
hyeongyukim updated the diff for D106041: [SimpleLoopUnswitch] Re-fix introduction of UB when hoisted condition may be undef or poison.

Add nontrivial-unswitch-freeze.ll to show changes.

Oct 6 2021, 1:48 AM · Restricted Project
hyeongyukim added a comment to D106041: [SimpleLoopUnswitch] Re-fix introduction of UB when hoisted condition may be undef or poison.

Since the flag that adds the freeze is off, there is no change in the existing test code.
How about adding -freeze-loop-unswitch-cond to some of the tests so that we can see where the freeze is added?

Oct 6 2021, 12:35 AM · Restricted Project
hyeongyukim updated the diff for D106041: [SimpleLoopUnswitch] Re-fix introduction of UB when hoisted condition may be undef or poison.

refix test code

Oct 6 2021, 12:32 AM · Restricted Project
hyeongyukim updated the diff for D106041: [SimpleLoopUnswitch] Re-fix introduction of UB when hoisted condition may be undef or poison.

update test codes

Oct 6 2021, 12:31 AM · Restricted Project
hyeongyukim updated the diff for D106041: [SimpleLoopUnswitch] Re-fix introduction of UB when hoisted condition may be undef or poison.

Add Freeze-loop-unswitch-cond flag.
This flag determines whether to add a freeze to the condition of the loop switch.
When this flag is turned on, the miscompilation is solved, but It will degrade the performance.
The default value of the flag is set to false until the performance problem is completely solved.

Oct 6 2021, 12:27 AM · Restricted Project

Oct 3 2021

hyeongyukim committed rGcf284f6c5ef3: [LSV] Change the default value of InstertElement to poison (authored by hyeongyukim).
[LSV] Change the default value of InstertElement to poison
Oct 3 2021, 1:58 AM
hyeongyukim closed D111005: [LSV] Change the default value of InstertElement to poison.
Oct 3 2021, 1:58 AM · Restricted Project
hyeongyukim added a comment to D111005: [LSV] Change the default value of InstertElement to poison.

Thanks!

Oct 3 2021, 1:57 AM · Restricted Project
hyeongyukim added inline comments to D111005: [LSV] Change the default value of InstertElement to poison.
Oct 3 2021, 12:38 AM · Restricted Project
hyeongyukim added reviewers for D111005: [LSV] Change the default value of InstertElement to poison: aqjune, nikic, RKSimon, fhahn, spatel, efriedma.
Oct 3 2021, 12:38 AM · Restricted Project
hyeongyukim requested review of D111005: [LSV] Change the default value of InstertElement to poison.
Oct 3 2021, 12:32 AM · Restricted Project

Sep 28 2021

hyeongyukim committed rG86bf234d0b70: [IR] Change the default value of InstertElement to poison (1/4) (authored by hyeongyukim).
[IR] Change the default value of InstertElement to poison (1/4)
Sep 28 2021, 6:29 AM
hyeongyukim closed D110311: [IR] Change the default value of InstertElement to poison (1/4).
Sep 28 2021, 6:29 AM · Restricted Project

Sep 27 2021

hyeongyukim updated the diff for D110311: [IR] Change the default value of InstertElement to poison (1/4).

reformat code

Sep 27 2021, 10:27 PM · Restricted Project
hyeongyukim updated the diff for D110311: [IR] Change the default value of InstertElement to poison (1/4).

Add the new CreateInsertElement

Sep 27 2021, 9:55 PM · Restricted Project
hyeongyukim added a comment to D110311: [IR] Change the default value of InstertElement to poison (1/4).

@spatel Thanks!
@hyeongyukim Do you mind if we add the new CreateInsertElements and use them in this patch?

Sep 27 2021, 5:34 PM · Restricted Project

Sep 26 2021

hyeongyukim updated the diff for D110311: [IR] Change the default value of InstertElement to poison (1/4).

Revert PPCTargetTransformInfo.cpp

Sep 26 2021, 1:33 PM · Restricted Project
hyeongyukim added a comment to D110311: [IR] Change the default value of InstertElement to poison (1/4).

Q: Is there any test that is affected by this?

Sep 26 2021, 11:11 AM · Restricted Project

Sep 23 2021

hyeongyukim updated subscribers of D110311: [IR] Change the default value of InstertElement to poison (1/4).
Sep 23 2021, 12:41 AM · Restricted Project
hyeongyukim added a comment to D110311: [IR] Change the default value of InstertElement to poison (1/4).

Like D110226, D110227, and D110230, It would be better to change undef to poison in one place.

Sep 23 2021, 12:40 AM · Restricted Project
hyeongyukim added reviewers for D110311: [IR] Change the default value of InstertElement to poison (1/4): spatel, efriedma, jdoerfert, nikic, lebedev.ri.
Sep 23 2021, 12:40 AM · Restricted Project

Sep 22 2021

hyeongyukim updated the summary of D110311: [IR] Change the default value of InstertElement to poison (1/4).
Sep 22 2021, 11:56 PM · Restricted Project
hyeongyukim requested review of D110311: [IR] Change the default value of InstertElement to poison (1/4).
Sep 22 2021, 11:55 PM · Restricted Project
hyeongyukim committed rG10a5632550ab: [NFC][InstCombine] Fix inconsistent comments (authored by hyeongyukim).
[NFC][InstCombine] Fix inconsistent comments
Sep 22 2021, 5:36 PM
hyeongyukim committed rG98e96663f6a7: [InstCombine] Update InstCombine to use poison instead of undef for… (authored by hyeongyukim).
[InstCombine] Update InstCombine to use poison instead of undef for…
Sep 22 2021, 8:48 AM
hyeongyukim closed D110230: [InstCombine] Update InstCombine to use poison instead of undef for shufflevector's placeholder (3/3).
Sep 22 2021, 8:48 AM · Restricted Project, Restricted Project
hyeongyukim committed rGec8311444abe: [InstCombine] Update InstCombine to use poison instead of undef for… (authored by hyeongyukim).
[InstCombine] Update InstCombine to use poison instead of undef for…
Sep 22 2021, 8:15 AM
hyeongyukim closed D110227: [InstCombine] Update InstCombine to use poison instead of undef for shufflevector's placeholder (2/3).
Sep 22 2021, 8:15 AM · Restricted Project
hyeongyukim committed rGe5aaf0332670: [InstCombine] Update InstCombine to use poison instead of undef for… (authored by hyeongyukim).
[InstCombine] Update InstCombine to use poison instead of undef for…
Sep 22 2021, 7:19 AM
hyeongyukim closed D110226: [InstCombine] Update InstCombine to use poison instead of undef for shufflevector's placeholder (1/3).
Sep 22 2021, 7:19 AM · Restricted Project, Restricted Project
hyeongyukim updated the diff for D110226: [InstCombine] Update InstCombine to use poison instead of undef for shufflevector's placeholder (1/3).

Correct the wrong rebase.

Sep 22 2021, 6:53 AM · Restricted Project, Restricted Project
hyeongyukim updated the diff for D110226: [InstCombine] Update InstCombine to use poison instead of undef for shufflevector's placeholder (1/3).

Rebase

Sep 22 2021, 6:50 AM · Restricted Project, Restricted Project
hyeongyukim updated the diff for D110226: [InstCombine] Update InstCombine to use poison instead of undef for shufflevector's placeholder (1/3).

Fix comment, update test file(wasm.c)

Sep 22 2021, 6:42 AM · Restricted Project, Restricted Project
hyeongyukim added reviewers for D110230: [InstCombine] Update InstCombine to use poison instead of undef for shufflevector's placeholder (3/3): spatel, efriedma, jdoerfert, nikic, lebedev.ri, regehr.
Sep 22 2021, 5:36 AM · Restricted Project, Restricted Project
hyeongyukim added reviewers for D110227: [InstCombine] Update InstCombine to use poison instead of undef for shufflevector's placeholder (2/3): spatel, efriedma, jdoerfert, nikic, lebedev.ri, regehr.
Sep 22 2021, 5:35 AM · Restricted Project
hyeongyukim updated the diff for D110230: [InstCombine] Update InstCombine to use poison instead of undef for shufflevector's placeholder (3/3).

reformat code

Sep 22 2021, 5:33 AM · Restricted Project, Restricted Project
hyeongyukim added reviewers for D110226: [InstCombine] Update InstCombine to use poison instead of undef for shufflevector's placeholder (1/3): spatel, efriedma, jdoerfert, nikic, lebedev.ri, regehr.
Sep 22 2021, 4:08 AM · Restricted Project, Restricted Project
hyeongyukim retitled D110230: [InstCombine] Update InstCombine to use poison instead of undef for shufflevector's placeholder (3/3) from [InstCombine] Update InstCombine to use poison instead of undef for shufflevector's placeholder (2/3) to [InstCombine] Update InstCombine to use poison instead of undef for shufflevector's placeholder (3/3).
Sep 22 2021, 4:07 AM · Restricted Project, Restricted Project
hyeongyukim requested review of D110230: [InstCombine] Update InstCombine to use poison instead of undef for shufflevector's placeholder (3/3).
Sep 22 2021, 4:05 AM · Restricted Project, Restricted Project
hyeongyukim requested review of D110227: [InstCombine] Update InstCombine to use poison instead of undef for shufflevector's placeholder (2/3).
Sep 22 2021, 2:04 AM · Restricted Project
hyeongyukim retitled D110226: [InstCombine] Update InstCombine to use poison instead of undef for shufflevector's placeholder (1/3) from [InstCombine] Update InstcombineCast to use poison instead of undef for shufflevector's placeholder (1/3) to [InstCombine] Update InstCombine to use poison instead of undef for shufflevector's placeholder (1/3).
Sep 22 2021, 2:03 AM · Restricted Project, Restricted Project
hyeongyukim retitled D110226: [InstCombine] Update InstCombine to use poison instead of undef for shufflevector's placeholder (1/3) from [InstCombine] Update InstcombineCast to use poison instead of undef for shufflevector's placeholder (1/4) to [InstCombine] Update InstcombineCast to use poison instead of undef for shufflevector's placeholder (1/3).
Sep 22 2021, 1:50 AM · Restricted Project, Restricted Project
hyeongyukim requested review of D110226: [InstCombine] Update InstCombine to use poison instead of undef for shufflevector's placeholder (1/3).
Sep 22 2021, 1:19 AM · Restricted Project, Restricted Project

Sep 21 2021

hyeongyukim committed rG043733d67731: [IR] Add the constructor of ShuffleVector for one-input-vector. (authored by hyeongyukim).
[IR] Add the constructor of ShuffleVector for one-input-vector.
Sep 21 2021, 6:06 AM
hyeongyukim closed D110146: [IR] Add the constructor of ShuffleVector for one-input-vector..
Sep 21 2021, 6:06 AM · Restricted Project
hyeongyukim updated the diff for D110146: [IR] Add the constructor of ShuffleVector for one-input-vector..

rebase and change function name.

Sep 21 2021, 6:05 AM · Restricted Project
hyeongyukim added reviewers for D110146: [IR] Add the constructor of ShuffleVector for one-input-vector.: spatel, efriedma, jdoerfert, nikic, lebedev.ri, nlopes, aqjune, regehr.
Sep 21 2021, 3:46 AM · Restricted Project
hyeongyukim abandoned D110034: [InstCombine] Update vector transforms to use poison instead of undef for insertelement and shufflevector's placeholder.
Sep 21 2021, 3:45 AM · Restricted Project
hyeongyukim added a comment to D110034: [InstCombine] Update vector transforms to use poison instead of undef for insertelement and shufflevector's placeholder.

I just created a patch D110146 that adds a constructor, so I'll close this patch.

Sep 21 2021, 3:45 AM · Restricted Project
hyeongyukim requested review of D110146: [IR] Add the constructor of ShuffleVector for one-input-vector..
Sep 21 2021, 3:41 AM · Restricted Project
hyeongyukim added a comment to D110034: [InstCombine] Update vector transforms to use poison instead of undef for insertelement and shufflevector's placeholder.

Oh, I misunderstood. I'll just add a constructor for one-vector-input.

Sep 21 2021, 3:30 AM · Restricted Project

Sep 20 2021

hyeongyukim added a comment to D110034: [InstCombine] Update vector transforms to use poison instead of undef for insertelement and shufflevector's placeholder.

We have a one-vector-input create function in IRBuilder, so it was easy to update that in one place with D93793. Could we do the same for the raw ShuffleVectorInst constructor?

Sep 20 2021, 8:29 PM · Restricted Project

Sep 19 2021

hyeongyukim added reviewers for D110034: [InstCombine] Update vector transforms to use poison instead of undef for insertelement and shufflevector's placeholder: spatel, efriedma, jdoerfert, nikic, lebedev.ri, nlopes, aqjune, regehr.
Sep 19 2021, 6:27 AM · Restricted Project
hyeongyukim requested review of D110034: [InstCombine] Update vector transforms to use poison instead of undef for insertelement and shufflevector's placeholder.
Sep 19 2021, 6:25 AM · Restricted Project

Sep 12 2021

hyeongyukim added a comment to D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default.

I did some experiments to confirm the benefits of adding a noundef attribute to the function parameter. (test result link)

Sep 12 2021, 11:27 PM · Restricted Project

Aug 20 2021

hyeongyukim added a comment to D108453: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default (2).

This and D105169 are renewed version of the old patch (D82317).
When pushing to the main branch, I'll commit this and D105169 as a single commit to avoid CI failure.

Aug 20 2021, 3:03 AM · Restricted Project, Restricted Project
hyeongyukim retitled D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default from [Clang/Test]: Enable enable_noundef_analysis as default to [Clang/Test]: Enable enable_noundef_analysis by default.
Aug 20 2021, 3:01 AM · Restricted Project
hyeongyukim updated the summary of D108453: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default (2).
Aug 20 2021, 2:58 AM · Restricted Project, Restricted Project