This is an archive of the discontinued LLVM Phabricator instance.

Differential D81333

Fix a typo in RISCVISelLowering.cpp
ClosedPublic

Authored by benshi001 on Jun 6 2020, 6:23 AM.

Details

Reviewers
MaskRay
Commits
rG4b6f0ea66cb1: [RISCV] Fix a typo in RISCVISelLowering.cpp
Summary

The 9th parameter of "static bool CC_RISCV(...)" is isFixed, not isRet.

Diff Detail

Event Timeline

benshi001 created this revision.Jun 6 2020, 6:23 AM
Herald added subscribers: llvm-commits, evandro, luismarques and 26 others. · View Herald TranscriptJun 6 2020, 6:23 AM
Harbormaster failed remote builds in B59373: Diff 269019!Jun 6 2020, 7:26 AM
MaskRay accepted this revision.Jun 6 2020, 8:57 AM

Looks great!

This revision is now accepted and ready to land.Jun 6 2020, 8:57 AM
Closed by commit rG4b6f0ea66cb1: [RISCV] Fix a typo in RISCVISelLowering.cpp (authored by benshi001, committed by MaskRay). · Explain WhyJun 6 2020, 7:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
lib/
Target/
RISCV/
2 lines

Diff 269036

llvm/lib/Target/RISCV/RISCVISelLowering.cpp

Show First 20 Lines • Show All 1,667 Lines • ▼ Show 20 Lines for (unsigned i = 0; i != NumArgs; ++i) {
Type *ArgTy = nullptr; Type *ArgTy = nullptr;
if (IsRet) if (IsRet)
ArgTy = FType->getReturnType(); ArgTy = FType->getReturnType();
else if (Ins[i].isOrigArg()) else if (Ins[i].isOrigArg())
ArgTy = FType->getParamType(Ins[i].getOrigArgIndex()); ArgTy = FType->getParamType(Ins[i].getOrigArgIndex());
RISCVABI::ABI ABI = MF.getSubtarget<RISCVSubtarget>().getTargetABI(); RISCVABI::ABI ABI = MF.getSubtarget<RISCVSubtarget>().getTargetABI();
if (CC_RISCV(MF.getDataLayout(), ABI, i, ArgVT, ArgVT, CCValAssign::Full, if (CC_RISCV(MF.getDataLayout(), ABI, i, ArgVT, ArgVT, CCValAssign::Full,
ArgFlags, CCInfo, /*IsRet=*/true, IsRet, ArgTy)) { ArgFlags, CCInfo, /*IsFixed=*/true, IsRet, ArgTy)) {
LLVM_DEBUG(dbgs() << "InputArg #" << i << " has unhandled type " LLVM_DEBUG(dbgs() << "InputArg #" << i << " has unhandled type "
<< EVT(ArgVT).getEVTString() << '\n'); << EVT(ArgVT).getEVTString() << '\n');
llvm_unreachable(nullptr); llvm_unreachable(nullptr);
} }
} }
} }
void RISCVTargetLowering::analyzeOutputArgs( void RISCVTargetLowering::analyzeOutputArgs(
▲ Show 20 Lines • Show All 1,272 Lines • Show Last 20 Lines