This is an archive of the discontinued LLVM Phabricator instance.

Differential D81213

[RISCV] Support experimental v extension v0.9.
ClosedPublic

Authored by HsiangKai on Jun 4 2020, 7:45 PM.

Details

Reviewers
evandro
rogfer01
rkruppe
Commits
rG721d93fc5aa8: Support experimental v extension v0.9.
Summary

Change Clang options to support experimental v extension v0.9.

Diff Detail

Event Timeline

HsiangKai created this revision.Jun 4 2020, 7:45 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 4 2020, 7:45 PM
Herald added subscribers: cfe-commits, luismarques, apazos and 24 others. · View Herald Transcript
HsiangKai added a parent revision: D80802: [RISCV] Upgrade RVV MC to v0.9..Jun 4 2020, 7:45 PM
Harbormaster failed remote builds in B59178: Diff 268645!Jun 4 2020, 7:52 PM
evandro accepted this revision.Jun 29 2020, 3:29 PM

It LGTM after D80802.

This revision is now accepted and ready to land.Jun 29 2020, 3:29 PM
HsiangKai mentioned this in D80802: [RISCV] Upgrade RVV MC to v0.9..Jul 16 2020, 9:52 AM
StephenFan removed a parent revision: D80802: [RISCV] Upgrade RVV MC to v0.9..Jul 23 2020, 8:01 AM
This revision was landed with ongoing or failed builds.Jul 31 2020, 4:42 PM
Closed by commit rG721d93fc5aa8: Support experimental v extension v0.9. (authored by HsiangKai). · Explain Why
This revision was automatically updated to reflect the committed changes.
HsiangKai added a commit: rG721d93fc5aa8: Support experimental v extension v0.9..

Revision Contents

PathSize
clang/
lib/
Driver/
ToolChains/
Arch/
2 lines
test/
Driver/
2 lines

Diff 268645

clang/lib/Driver/ToolChains/Arch/RISCV.cpp

Show First 20 Lines • Show All 57 Lines • ▼ Show 20 Lines
// extension that the compiler currently supports. // extension that the compiler currently supports.
static Optional<RISCVExtensionVersion> static Optional<RISCVExtensionVersion>
isExperimentalExtension(StringRef Ext) { isExperimentalExtension(StringRef Ext) {
if (Ext == "b" || Ext == "zbb" || Ext == "zbc" || Ext == "zbe" || if (Ext == "b" || Ext == "zbb" || Ext == "zbc" || Ext == "zbe" ||
Ext == "zbf" || Ext == "zbm" || Ext == "zbp" || Ext == "zbr" || Ext == "zbf" || Ext == "zbm" || Ext == "zbp" || Ext == "zbr" ||
Ext == "zbs" || Ext == "zbt" || Ext == "zbproposedc") Ext == "zbs" || Ext == "zbt" || Ext == "zbproposedc")
return RISCVExtensionVersion{"0", "92"}; return RISCVExtensionVersion{"0", "92"};
if (Ext == "v") if (Ext == "v")
return RISCVExtensionVersion{"0", "8"}; return RISCVExtensionVersion{"0", "9"};
return None; return None;
} }
static bool isSupportedExtension(StringRef Ext) { static bool isSupportedExtension(StringRef Ext) {
// LLVM supports "z" extensions which are marked as experimental. // LLVM supports "z" extensions which are marked as experimental.
if (isExperimentalExtension(Ext)) if (isExperimentalExtension(Ext))
return true; return true;
▲ Show 20 Lines • Show All 588 Lines • Show Last 20 Lines

clang/test/Driver/riscv-arch.c

Show First 20 Lines • Show All 370 Lines • ▼ Show 20 Lines
// RV32-EXPERIMENTAL-V-NOVERS: error: invalid arch name 'rv32iv' // RV32-EXPERIMENTAL-V-NOVERS: error: invalid arch name 'rv32iv'
// RV32-EXPERIMENTAL-V-NOVERS: experimental extension requires explicit version number // RV32-EXPERIMENTAL-V-NOVERS: experimental extension requires explicit version number
// RUN: %clang -target riscv32-unknown-elf -march=rv32iv0p1 -menable-experimental-extensions -### %s -c 2>&1 | \ // RUN: %clang -target riscv32-unknown-elf -march=rv32iv0p1 -menable-experimental-extensions -### %s -c 2>&1 | \
// RUN: FileCheck -check-prefix=RV32-EXPERIMENTAL-V-BADVERS %s // RUN: FileCheck -check-prefix=RV32-EXPERIMENTAL-V-BADVERS %s
// RV32-EXPERIMENTAL-V-BADVERS: error: invalid arch name 'rv32iv0p1' // RV32-EXPERIMENTAL-V-BADVERS: error: invalid arch name 'rv32iv0p1'
// RV32-EXPERIMENTAL-V-BADVERS: unsupported version number 0.1 for experimental extension // RV32-EXPERIMENTAL-V-BADVERS: unsupported version number 0.1 for experimental extension
// RUN: %clang -target riscv32-unknown-elf -march=rv32iv0p8 -menable-experimental-extensions -### %s -c 2>&1 | \ // RUN: %clang -target riscv32-unknown-elf -march=rv32iv0p9 -menable-experimental-extensions -### %s -c 2>&1 | \
// RUN: FileCheck -check-prefix=RV32-EXPERIMENTAL-V-GOODVERS %s // RUN: FileCheck -check-prefix=RV32-EXPERIMENTAL-V-GOODVERS %s
// RV32-EXPERIMENTAL-V-GOODVERS: "-target-feature" "+experimental-v" // RV32-EXPERIMENTAL-V-GOODVERS: "-target-feature" "+experimental-v"