This is an archive of the discontinued LLVM Phabricator instance.

[Alignement][NFC] Deprecate untyped CreateAlignedLoad
ClosedPublic

Authored by gchatelet on Jan 23 2020, 2:34 AM.

Details

Summary

This is patch is part of a series to introduce an Alignment type.
See this thread for context: http://lists.llvm.org/pipermail/llvm-dev/2019-July/133851.html
See this patch for the introduction of the type: https://reviews.llvm.org/D64790

Event Timeline

gchatelet created this revision.Jan 23 2020, 2:34 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 23 2020, 2:34 AM
courbet accepted this revision.Jan 23 2020, 2:46 AM
courbet added inline comments.
llvm/lib/CodeGen/AtomicExpandPass.cpp
1723

You don't need the .value() here, there is a MaybeAlign overload.

1739

ditto

llvm/lib/Transforms/InstCombine/InstCombineLoadStoreAlloca.cpp
468–469

remove llvm , use auto ?

This revision is now accepted and ready to land.Jan 23 2020, 2:46 AM
gchatelet updated this revision to Diff 239853.Jan 23 2020, 4:33 AM
gchatelet marked 3 inline comments as done.
  • Address comments
gchatelet marked an inline comment as done.Jan 23 2020, 4:34 AM
gchatelet added inline comments.
llvm/lib/CodeGen/AtomicExpandPass.cpp
1723

Good catch. I'll do the same kind of patch for CreateAlignedStore afterwards to catch them all.

This revision was automatically updated to reflect the committed changes.
RKSimon added inline comments.
llvm/lib/Target/X86/X86InterleavedAccess.cpp
219

@gchatelet This is causing misaligned load accesses: https://bugs.llvm.org/show_bug.cgi?id=45957

efriedma added inline comments.
llvm/lib/Target/X86/X86InterleavedAccess.cpp
219

This change is NFC. Semantically, this code hasn't changed since D24681.

jdoerfert added inline comments.
llvm/lib/Target/X86/X86InterleavedAccess.cpp
219