In preparation of D65531 as well as the reuse of these tests for the
Attributor, we modernize them and use the update_test_checks. Note that
there were some strugglers we will update the same way later on.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
I just run update on all of them and did not fix them yet. Please provide feedback if you have any, I'll update this revision asap.
llvm/test/Transforms/ArgumentPromotion/2008-02-01-ReturnAttrs.ll | ||
---|---|---|
2–3 | Do you want: ; RUN: opt < %s -argpromotion -S | FileCheck %s --check-prefixes=ALL,ARGPROMOTION ; RUN: opt < %s -aa-pipeline='basic-aa' -passes=attributor -attributor-disable=false -attributor-max-iterations-verify -attributor-max-iterations=1 -S | FileCheck %s --check-prefixes=ALL,ATTRIBUTOR ? | |
llvm/test/Transforms/ArgumentPromotion/musttail.ll | ||
48 | does the script produce these verbose check-lines for define? |
Thx for the initial feedback, I'll update this soon.
llvm/test/Transforms/ArgumentPromotion/2008-02-01-ReturnAttrs.ll | ||
---|---|---|
2–3 | Will do | |
llvm/test/Transforms/ArgumentPromotion/musttail.ll | ||
48 | I took the original check lines where it made sense but I can also drop these in favor of the auto-generated ones, or I can allow the script to emit the arguments (which I think I preferred). I'll update the tests once I've done that. |
If you want to add attributor runlines, i really insist on following the example i showed, it will result in cleaner diff overall.
That being said i like that the attributor runlines are in a separate diff.
D68852 adds the "privatizable pointer" attribute to the Attributor and runs it on all these test. I can split it so we first run it without the privatizable pointer attribute but it's unclear if that is helpful.
I made the check prefixes ALL,ARGPROMOTION now and added the parent diffs (update_..._.py changes)
Uh, why, that's backwards? It will defeat the point of placing ALL first - then you won't have duplicate check lines for attributor.
I think, determined by browsing the diff, that this way the next diff (with the Attributor) is smaller. If you think I should reverse it again, I can do that as well.
llvm/test/Transforms/ArgumentPromotion/musttail.ll | ||
---|---|---|
48 | The "new" script (see parent revisions) does generate verbose check lines for defines and arguments. The former always the latter on request. |
Do you want:
?