In preparation of D65531 as well as the reuse of these tests for the
Attributor, we modernize them and use the update_test_checks. Note that
there were some strugglers we will update the same way later on.
Do you want:
; RUN: opt < %s -argpromotion -S | FileCheck %s --check-prefixes=ALL,ARGPROMOTION ; RUN: opt < %s -aa-pipeline='basic-aa' -passes=attributor -attributor-disable=false -attributor-max-iterations-verify -attributor-max-iterations=1 -S | FileCheck %s --check-prefixes=ALL,ATTRIBUTOR
does the script produce these verbose check-lines for define?
Thx for the initial feedback, I'll update this soon.
I took the original check lines where it made sense but I can also drop these in favor of the auto-generated ones, or I can allow the script to emit the arguments (which I think I preferred). I'll update the tests once I've done that.
If you want to add attributor runlines, i really insist on following the example i showed, it will result in cleaner diff overall.
That being said i like that the attributor runlines are in a separate diff.
I think, determined by browsing the diff, that this way the next diff (with the Attributor) is smaller. If you think I should reverse it again, I can do that as well.
The "new" script (see parent revisions) does generate verbose check lines for defines and arguments. The former always the latter on request.