Page MenuHomePhabricator

[UpdateTestChecks] Capture function signature variable definitions
AbandonedPublic

Authored by arichardson on Dec 13 2019, 2:56 AM.

Details

Reviewers
jdoerfert
Summary

Currently, even when using --function-signature, the first use of an
argument will create a new FileCheck capture (e.g. [[X:%.*]]) even though
the value has already been captured in the CHECK-SAME line for the
function signature.
To fix this problem return the vars_seen set from genericize_check_lines()
and pass it to the second call so that it sees the variables captured
as part of the function signature.

Diff Detail

Event Timeline

arichardson created this revision.Dec 13 2019, 2:56 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 13 2019, 2:56 AM

Isn't this a copy of D69722 ? We need to get the testing stuff in so my pending patches can go in as well.

Isn't this a copy of D69722 ? We need to get the testing stuff in so my pending patches can go in as well.

Ah yes indeed, sorry about that. I should set up a rule to get notified about update script changes.

I'll commit the test change shortly (probably tomorrow UK time), just giving @MaskRay and @xbolva00 a chance to comment before.

arichardson abandoned this revision.Dec 13 2019, 11:38 AM

Duplicate of D69722 with a worse python implementation.

Isn't this a copy of D69722 ? We need to get the testing stuff in so my pending patches can go in as well.

Ah yes indeed, sorry about that. I should set up a rule to get notified about update script changes.

I'll commit the test change shortly (probably tomorrow UK time), just giving @MaskRay and @xbolva00 a chance to comment before.

Perfect, thanks again for the testing infrastructure. Really appreciated!