Page MenuHomePhabricator

[CodeGen] Define an interface for the new pass manager. (new)
AcceptedPublic

Authored by ychen on Sep 17 2019, 7:15 PM.

Details

Summary

This is mostly to address comments in D64179. Since the updated code is
quite different, I created this new patch for review.

Diff Detail

Event Timeline

ychen created this revision.Sep 17 2019, 7:15 PM
ychen updated this revision to Diff 220708.Sep 18 2019, 11:06 AM

Pass in instead of manage IR unit analysis managers in MachineFunctionIRAnalysisManager

Harbormaster completed remote builds in B38264: Diff 220709.
ychen updated this revision to Diff 233001.Dec 9 2019, 9:56 PM

fix a bug

arsenm accepted this revision.Jan 31 2020, 8:44 AM
arsenm added a subscriber: arsenm.

LGTM with nits

llvm/include/llvm/CodeGen/PassManager.h
59

Extra space before (

64

Ditto

llvm/unittests/CodeGen/PassManagerTest.cpp
140

Typo unknonwn

145

Typo unknonwn

This revision is now accepted and ready to land.Jan 31 2020, 8:44 AM

LGTM with nits

@arsenm Thanks for the review! It seems some more folks want to chime in.

ychen updated this revision to Diff 242108.Feb 3 2020, 9:30 AM
  • Address Matt's comments
ychen marked 4 inline comments as done.Feb 3 2020, 9:31 AM

Unit tests: pass. 62418 tests passed, 0 failed and 845 were skipped.

clang-tidy: fail. clang-tidy found 0 errors and 2 warnings. 0 of them are added as review comments below (why?).

clang-format: fail. Please format your changes with clang-format by running git-clang-format HEAD^ or applying this patch.

Build artifacts: diff.json, clang-tidy.txt, clang-format.patch, CMakeCache.txt, console-log.txt, test-results.xml

Pre-merge checks is in beta. Report issue. Please join beta or enable it for your project.