Not for a concrete bug, but for consistency only. Basically, it makes the module data layout match target data layout before opt&codegen starts under all circumstances (LTO/clang).

Dec 16 2020, 6:24 PM · Restricted Project

Dec 14 2020

ychen added a comment to D67687: [NewPM][CodeGen] Introduce machine pass and machine pass manager.

In D67687#2453588, @dblaikie wrote:

In D67687#2452438, @ychen wrote:

@dblaikie The laying issue in 31ecf8d29d81d196374a562c6d2bd2c25a62861e is addressed here. Do you mind taking another look? Thanks!

The last delta on the patch is fairly large - not sure I can absorb it all. If the problematic dependency is no longer present, that's the key thing - I'm happy to take your word for it, if you've checked the included headers/grep'd for references of whichever libraries were incorrectly connected.

Dec 14 2020, 6:20 PM · Restricted Project

ychen requested review of D67687: [NewPM][CodeGen] Introduce machine pass and machine pass manager.

@dblaikie The laying issue in 31ecf8d29d81d196374a562c6d2bd2c25a62861e is addressed here. Do you mind taking another look? Thanks!

Dec 14 2020, 9:24 AM · Restricted Project

Dec 9 2020

ychen committed rGfc3942526f5c: [NFCI] Add a missing triple in clang/test/CodeGen/ppc64le-varargs-f128.c (authored by ychen).

[NFCI] Add a missing triple in clang/test/CodeGen/ppc64le-varargs-f128.c

Dec 9 2020, 6:18 PM

ychen committed rG8b23b3ab3aea: [NFCI] Add missing triple to several LTO tests (authored by ychen).

[NFCI] Add missing triple to several LTO tests

Dec 9 2020, 1:14 PM

ychen added a comment to D83607: [NewPM][CodeGen] Port MIRPrinter to NewPM.

In D83607#2438923, @aeubanks wrote:

Should we get the llc testing infra working with the NPM before porting passes?

Dec 9 2020, 12:40 PM · Restricted Project

ychen added a reviewer for D67687: [NewPM][CodeGen] Introduce machine pass and machine pass manager: dblaikie.

Dec 9 2020, 12:17 PM · Restricted Project

ychen updated the diff for D67687: [NewPM][CodeGen] Introduce machine pass and machine pass manager.

fix the laying issue.

change buildCodeGenPipeline signature to take pass manager references as inputs.

Dec 9 2020, 12:11 PM · Restricted Project

ychen reopened D67687: [NewPM][CodeGen] Introduce machine pass and machine pass manager.

Dec 9 2020, 12:11 PM · Restricted Project

Dec 8 2020

ychen committed rG1821265db681: [Time-report] Add a flag -ftime-report={per-pass,per-pass-run} to control the… (authored by ychen).

[Time-report] Add a flag -ftime-report={per-pass,per-pass-run} to control the…

Dec 8 2020, 10:14 AM

ychen closed D92436: [Time-report] Add a flag -ftime-report={per-pass,per-pass-run} to control the pass timing aggregation.

Dec 8 2020, 10:14 AM · Restricted Project, Restricted Project

Dec 7 2020

ychen added inline comments to D92436: [Time-report] Add a flag -ftime-report={per-pass,per-pass-run} to control the pass timing aggregation.

Dec 7 2020, 8:15 PM · Restricted Project, Restricted Project

ychen updated the diff for D92436: [Time-report] Add a flag -ftime-report={per-pass,per-pass-run} to control the pass timing aggregation.

clang/test/Misc/time-passes.c: add -fno-experimental-new-pass-manager
llvm/test/Other/time-passes.ll: makes sure each pass has one entry.

Dec 7 2020, 8:13 PM · Restricted Project, Restricted Project

ychen requested review of D92781: [NewPM][CodeGen] Port FreeMachineFunction to NPM.

Dec 7 2020, 11:54 AM · Restricted Project

ychen added a reviewer for D83607: [NewPM][CodeGen] Port MIRPrinter to NewPM: aeubanks.

Dec 7 2020, 11:51 AM · Restricted Project

ychen added reviewers for D92436: [Time-report] Add a flag -ftime-report={per-pass,per-pass-run} to control the pass timing aggregation: aeubanks, asbirlea.

Dec 7 2020, 11:42 AM · Restricted Project, Restricted Project

ychen added a reviewer for D92436: [Time-report] Add a flag -ftime-report={per-pass,per-pass-run} to control the pass timing aggregation: lattner.

Dec 7 2020, 9:25 AM · Restricted Project, Restricted Project

Dec 4 2020

ychen updated the diff for D92436: [Time-report] Add a flag -ftime-report={per-pass,per-pass-run} to control the pass timing aggregation.

fix rebase error

Dec 4 2020, 12:34 PM · Restricted Project, Restricted Project

Dec 3 2020

ychen added a comment to D87216: [NewPM] Support --print-before/after in NPM.

In D87216#2431626, @aeubanks wrote:

In D87216#2431508, @ychen wrote:

It is very unfortunate that we have to manage and translate between two sets of names (one pass name and one type name). This makes me wonder if we just keep the pass name as the return value of PassInfoMixin::name and get rid of class name everywhere. Right now I couldn't think of anything is blocking us from doing that. WDYT? @asbirlea ?

We'd have to move the names from PassRegistry.def to every pass class definition which would be a lot of work but definitely feasible.

Dec 3 2020, 11:54 AM · Restricted Project, Restricted Project

ychen added a reviewer for D92436: [Time-report] Add a flag -ftime-report={per-pass,per-pass-run} to control the pass timing aggregation: fedor.sergeev.

Dec 3 2020, 10:17 AM · Restricted Project, Restricted Project

ychen accepted D87216: [NewPM] Support --print-before/after in NPM.

It is very unfortunate that we have to manage and translate between two sets of names (one pass name and one type name). This makes me wonder if we just keep the pass name as the return value of PassInfoMixin::name and get rid of class name everywhere. Right now I couldn't think of anything is blocking us from doing that. WDYT? @asbirlea ?

Dec 3 2020, 10:04 AM · Restricted Project, Restricted Project

Dec 2 2020

ychen updated the diff for D92436: [Time-report] Add a flag -ftime-report={per-pass,per-pass-run} to control the pass timing aggregation.

rebase

Dec 2 2020, 11:25 AM · Restricted Project, Restricted Project

Dec 1 2020

ychen added inline comments to D81958: [clangd] Add library to semantically strip flags by name..

Dec 1 2020, 8:40 PM · Restricted Project

ychen requested review of D92436: [Time-report] Add a flag -ftime-report={per-pass,per-pass-run} to control the pass timing aggregation.

Dec 1 2020, 4:23 PM · Restricted Project, Restricted Project

ychen accepted D92138: [LTO][NewPM] Run verifier when doing LTO.

LGTM.

Dec 1 2020, 9:51 AM · Restricted Project

Nov 30 2020

ychen added inline comments to D70655: [AutoFDO] Top-down Inlining for specialization with context-sensitive profile.

Nov 30 2020, 7:57 PM · Restricted Project

ychen added inline comments to D82919: [SampleFDO] Enable sample-profile-top-down-load by default..

Nov 30 2020, 7:54 PM · Restricted Project

ychen added inline comments to D82919: [SampleFDO] Enable sample-profile-top-down-load by default..

Nov 30 2020, 3:35 PM · Restricted Project

Nov 24 2020

ychen accepted D91804: [NewPM] Add pipeline EP callback after initial frontend cleanup.

LGTM. Thanks!

Nov 24 2020, 7:09 PM · Restricted Project

ychen added a comment to D91804: [NewPM] Add pipeline EP callback after initial frontend cleanup.

In D91804#2415163, @asbirlea wrote:

EarlySimplificationEPCallback?

Nov 24 2020, 6:17 PM · Restricted Project

Nov 23 2020

ychen added a comment to D91804: [NewPM] Add pipeline EP callback after initial frontend cleanup.

In D91804#2412277, @asbirlea wrote:

I don't think "ModuleOptimizer" in the name makes sense, the association can come from the "Early" part. Either keep the naming as is, or "EarlyAfterStart" if you want to define order against the other callbacks.
ychen@ so you have a better naming suggestion?

Nov 23 2020, 4:34 PM · Restricted Project

ychen added a comment to D51276: [New PM][PassTiming] implement -time-passes for the new pass manager.

In D51276#1676924, @tejohnson wrote:

In D51276#1254958, @chandlerc wrote:

In D51276#1254913, @fedor.sergeev wrote:

as for the per-pass-name aggregation - I was going to supply a follow-up patch that changes -time-passes from boolean option to -time-passes=<aggregation-type>.
Perhaps aggregation-type should be 'aggregate' by default, and 'invocations' providing per-invocation info.
Yet I dont want to just remove the possibility of getting a more fine-grained data that we have in this patch.

Yeah, i definitely like having the per-invocation information. I'm just suggesting that (eventually, happy for this to come in follow-ups) we'll probably want the default to be aggregated a bit.

Ping on getting this aggregation. I just tried running -ftime-report on a large file, and got >2 million lines of output, with 41K lines for just the InlinerPass alone. This isn't particularly helpful when trying to understand overall impacts of changes on various passes.

Nov 23 2020, 3:27 PM · Restricted Project

ychen accepted D91683: Port -print-memderefs to NPM.

LGTM

Nov 23 2020, 11:37 AM · Restricted Project

Nov 19 2020

ychen added a comment to D91804: [NewPM] Add pipeline EP callback after initial frontend cleanup.

FWIW, could we keep naming it ModuleOptimizerEarlyEPCallback? That sounds pretty intuitive to me and reminds users of the old name. Is the renaming for using the prefix Pipeline?

Nov 19 2020, 11:02 PM · Restricted Project

Nov 14 2020

ychen accepted D91477: [DCE] Port -redundant-dbg-inst-elim to NPM.

LGTM

Nov 14 2020, 9:40 AM · Restricted Project

Nov 13 2020

ychen committed rGa22335416110: [CGProfile] allows bitcast in metadata node storing function pointers (authored by ychen).

[CGProfile] allows bitcast in metadata node storing function pointers

Nov 13 2020, 9:29 AM

ychen closed D88433: [CGProfile] allows bitcast in metadata node storing function pointers.

Nov 13 2020, 9:29 AM · Restricted Project

ychen retitled D88433: [CGProfile] allows bitcast in metadata node storing function pointers from [IRMover] Fix up "CG Profile" MDNode after RAUW to [CGProfile] allows bitcast in metadata node storing function pointers.

Nov 13 2020, 9:24 AM · Restricted Project