User Details
User Details
- User Since
- Nov 19 2013, 9:02 PM (487 w, 1 d)
Wed, Mar 15
Wed, Mar 15
ychen committed rGe7a2da5298dc: [Inliner] Assign dummy debug location to the memcpy for byval argument (authored by ychen).
[Inliner] Assign dummy debug location to the memcpy for byval argument
Mon, Mar 13
Mon, Mar 13
ychen added a comment to D145607: [Inliner] Assign dummy debug location to the memcpy for byval argument.
ping
Fri, Mar 10
Fri, Mar 10
[NFC] fix typo `funciton` -> `function`
Fri, Mar 10, 6:06 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
ychen abandoned D126341: Order implicitly instantiated global variable's initializer by the reverse instantiation order.
Superseded by D127233, D127259, rG7f8d844df5e9
Wed, Mar 8
Wed, Mar 8
ychen requested review of D145607: [Inliner] Assign dummy debug location to the memcpy for byval argument.
Mon, Mar 6
Mon, Mar 6
ychen committed rG3e00f24f6356: [NFC][Clang] add test comments for GitHub issue 58896 (authored by ychen).
[NFC][Clang] add test comments for GitHub issue 58896
Sun, Mar 5
Sun, Mar 5
ychen committed rG7f8d844df5e9: [CodeGen] guarantee variable templates are initialized in the reverse… (authored by ychen).
[CodeGen] guarantee variable templates are initialized in the reverse…
Fri, Mar 3
Fri, Mar 3
ychen committed rGe423885e272c: [CodeGen] guarantee templated static variables are initialized in the reverse… (authored by ychen).
[CodeGen] guarantee templated static variables are initialized in the reverse…
ychen updated the diff for D127259: [CodeGen] guarantee templated static variables are initialized in the reverse instantiation order.
- rebase
ychen added a comment to D127259: [CodeGen] guarantee templated static variables are initialized in the reverse instantiation order.
Jan 23 2023
Jan 23 2023
ychen added a comment to D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1.
Jan 7 2023
Jan 7 2023
ychen added a reviewer for D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1: cor3ntin.
Dec 17 2022
Dec 17 2022
ychen updated the diff for D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1.
- update cxx_status.html
Dec 12 2022
Dec 12 2022
ychen added a comment to D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1.
ychen updated the diff for D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1.
- Address Corentin's comments
ychen updated the diff for D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1.
format
ychen added a reviewer for D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1: Restricted Project.
ychen requested review of D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1.
Nov 2 2022
Nov 2 2022
ychen committed rG40e99473170f: [Clang] follow-up D128745, remove ClangABICompat checks (authored by ychen).
[Clang] follow-up D128745, remove ClangABICompat checks
ychen updated the diff for D136120: [Clang] follow-up D128745, remove ClangABICompat checks.
- rebase
Nov 1 2022
Nov 1 2022
LGTM
ychen added a comment to D136975: [Concepts] Correctly handle failure when checking concepts recursively.
ychen added a comment to D136975: [Concepts] Correctly handle failure when checking concepts recursively.
Thanks for the patch. It looks good to me.
Oct 30 2022
Oct 30 2022
ychen committed rG500876226c60: [lit][NFC] not check stdout in googletest-timeout.py (authored by ychen).
[lit][NFC] not check stdout in googletest-timeout.py
ychen committed rGe18c2c5548f6: [Clang] use non-instantiated function declaration for constraints partial… (authored by ychen).
[Clang] use non-instantiated function declaration for constraints partial…
ychen committed rG5d086cce8b92: [Clang] perform "maximum TLS alignment" check for template instantiation (authored by ychen).
[Clang] perform "maximum TLS alignment" check for template instantiation
Oct 28 2022
Oct 28 2022
ychen added inline comments to rGd3efa577f549: [lit] Keep stdout/stderr when using GoogleTest format.
Oct 26 2022
Oct 26 2022
ychen added inline comments to D136744: [Clang] perform "maximum TLS alignment" check for template instantiation.
ychen updated the diff for D136744: [Clang] perform "maximum TLS alignment" check for template instantiation.
- remove unnecessary check
ychen updated the summary of D136744: [Clang] perform "maximum TLS alignment" check for template instantiation.
ychen requested review of D136744: [Clang] perform "maximum TLS alignment" check for template instantiation.
Oct 25 2022
Oct 25 2022
ychen updated the diff for D136545: [Clang] use non-instantiated function declaration for constraints partial ordering.
- rebase
Oct 24 2022
Oct 24 2022
ychen added inline comments to D136545: [Clang] use non-instantiated function declaration for constraints partial ordering.
ychen retitled D136545: [Clang] use non-instantiated function declaration for constraints partial ordering from [Clang] use non-template function declaration for constraints partial ordering to [Clang] use non-instantiated function declaration for constraints partial ordering.
ychen added a comment to D136545: [Clang] use non-instantiated function declaration for constraints partial ordering.
ychen updated the diff for D136545: [Clang] use non-instantiated function declaration for constraints partial ordering.
- do the same when 1. taking the address of a non-template function (with a test) 2. computing SMF eligibility (unfortunately it's hard to compose a test, suggestions are appreciated).
- restore the removed test case
ychen added a comment to D136120: [Clang] follow-up D128745, remove ClangABICompat checks.
ping?
Oct 23 2022
Oct 23 2022
ychen added a comment to D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access.
Looks straightforward to me with one suggestion.
Oct 22 2022
Oct 22 2022
ychen updated the diff for D136545: [Clang] use non-instantiated function declaration for constraints partial ordering.
- add a release note.
ychen added inline comments to D136545: [Clang] use non-instantiated function declaration for constraints partial ordering.
ychen committed rGc9447c62966e: [Clang] fold expression is considered atomic during constraints normalization (authored by ychen).
[Clang] fold expression is considered atomic during constraints normalization
Oct 19 2022
Oct 19 2022
ychen committed rG63512592e97d: [lit] fix a error when using --show-used-features (authored by ychen).
[lit] fix a error when using --show-used-features
ychen committed rG24c6ea917cfd: [JMCInstrument] rename ELF section name from ".just.my.code" to ".data.just.my. (authored by ychen).
[JMCInstrument] rename ELF section name from ".just.my.code" to ".data.just.my.
Oct 18 2022
Oct 18 2022
ychen committed rG13d6a57cbe27: [Clang] constraints partial ordering should work with deduction guide (authored by ychen).
[Clang] constraints partial ordering should work with deduction guide
ychen added inline comments to D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions.
ychen committed rG340eac01f7da: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained… (authored by ychen).
[C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained…
ychen added a comment to D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions.
@mizvekov Thanks for the review and provided valuable feedback.
ychen committed rG6bca52be0349: [Clang] update cxx_dr_status.html by running make_cxx_dr_status (authored by ychen).
[Clang] update cxx_dr_status.html by running make_cxx_dr_status
ychen updated the diff for D136133: [Clang] update cxx_dr_status.html by running make_cxx_dr_status.
- DR2565 is fully implemented.
ychen updated the diff for D136120: [Clang] follow-up D128745, remove ClangABICompat checks.
- update Release notes
- remove obsolete CodeGen tests which was used to test ClangABICompat checks, similar Sema tests are already in place.
ychen added inline comments to D136133: [Clang] update cxx_dr_status.html by running make_cxx_dr_status.
ychen added a comment to D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions.
ychen updated the diff for D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions.
- rebase
Oct 17 2022
Oct 17 2022
ychen updated the diff for D136133: [Clang] update cxx_dr_status.html by running make_cxx_dr_status.
- rebase
ychen requested review of D136133: [Clang] update cxx_dr_status.html by running make_cxx_dr_status.
[Clang] add DR tests for D128745
ychen retitled D136120: [Clang] follow-up D128745, remove ClangABICompat checks from [Clang] follow-up D128745, remove all ClangABICompat checks to [Clang] follow-up D128745, remove ClangABICompat checks.
ychen added a reviewer for D136120: [Clang] follow-up D128745, remove ClangABICompat checks: Restricted Project.
ychen requested review of D136120: [Clang] follow-up D128745, remove ClangABICompat checks.
ychen added a comment to D134507: [Clang] add missing ClangABICompat check.
ychen added inline comments to D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions.
ychen updated the diff for D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions.
- use getTemplateArgs
Oct 14 2022
Oct 14 2022
ychen added inline comments to D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions.
ychen updated the diff for D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions.
- skip non-dependent NTTP comparison because they're equivalent (match GCC)
Oct 13 2022
Oct 13 2022
ychen added a comment to D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions.
ychen updated the summary of D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions.
Per further discussions in D128745, this is not needed.
Oct 12 2022
Oct 12 2022
ychen added a comment to D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template.
Oct 11 2022
Oct 11 2022
ychen added a comment to D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions.
@mizvekov it turns out I don't need that code anymore. Thanks.
ychen updated the diff for D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions.
- remove dead code.
LGTM.
ychen added a comment to D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template.
ychen added inline comments to D135045: [Frontend] Recognize environment variable SOURCE_DATE_EPOCH.
ychen added a comment to D135045: [Frontend] Recognize environment variable SOURCE_DATE_EPOCH.
Looks good to me except for one nit. And the test still fails on Windows for some reason.
[clang-format] update --files help description
Oct 6 2022
Oct 6 2022
ychen added a comment to D135115: [clang-format] update --files help description.
Oct 5 2022
Oct 5 2022
ychen added inline comments to D135045: [Frontend] Recognize environment variable SOURCE_DATE_EPOCH.
ychen added inline comments to D135045: [Frontend] Recognize environment variable SOURCE_DATE_EPOCH.
ychen updated the diff for D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions.
- rebased on D135088
ychen updated the diff for D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions.
- rebase
ychen updated the diff for D128750: [C++20] Implement P2113R0: Changes to the Partial Ordering of Constrained Functions.
- rebase
ychen added inline comments to D135045: [Frontend] Recognize environment variable SOURCE_DATE_EPOCH.
D135088 was landed instead.
Oct 4 2022
Oct 4 2022
ychen updated the diff for D135115: [clang-format] update --files help description.
- make corresponding change in the commandline
ychen updated the diff for D135115: [clang-format] update --files help description.
- address comments
ychen committed rG5d69937b9f9c: [Clang] make canonical AutoType constraints-free (authored by ychen).
[Clang] make canonical AutoType constraints-free
ychen added a comment to D128745: [c++] implements DR692, DR1395 and tentatively DR1432, about partial ordering of variadic template partial specialization or function template.