Page MenuHomePhabricator

ychen (Yuanfang Chen)
Engineering

Projects

User Details

User Since
Nov 19 2013, 9:02 PM (303 w, 5 d)

Recent Activity

Tue, Sep 10

ychen added a comment to D64183: [NewPM] Port MachineModuleInfo to the new pass manager..

Thank you for review. Could I another LGTM after rebase?

Tue, Sep 10, 11:43 AM · Restricted Project
ychen removed a parent revision for D64183: [NewPM] Port MachineModuleInfo to the new pass manager.: D64179: [CodeGen] Define an interface for the new pass manager..
Tue, Sep 10, 11:40 AM · Restricted Project
ychen removed a child revision for D64179: [CodeGen] Define an interface for the new pass manager.: D64183: [NewPM] Port MachineModuleInfo to the new pass manager..
Tue, Sep 10, 11:40 AM · Restricted Project
ychen updated the diff for D64183: [NewPM] Port MachineModuleInfo to the new pass manager..

rebase & address comments.

Tue, Sep 10, 11:36 AM · Restricted Project

Mon, Sep 9

ychen updated the summary of D64183: [NewPM] Port MachineModuleInfo to the new pass manager..
Mon, Sep 9, 10:42 PM · Restricted Project
ychen added a comment to D64183: [NewPM] Port MachineModuleInfo to the new pass manager..

Hello, Charlie went back to school after his internship, I'll commit this on his behalf. Please let me know if there are any concerns.

Mon, Sep 9, 10:32 PM · Restricted Project
ychen updated the summary of D64183: [NewPM] Port MachineModuleInfo to the new pass manager..
Mon, Sep 9, 10:32 PM · Restricted Project
ychen added inline comments to D67053: [LLD] [COFF] Resolve source locations for undefined references using dwarf.
Mon, Sep 9, 2:51 PM · Restricted Project
ychen added inline comments to D67053: [LLD] [COFF] Resolve source locations for undefined references using dwarf.
Mon, Sep 9, 1:08 PM · Restricted Project
ychen added inline comments to D67357: [llvm-objdump] Fix llvm-objdump --all-headers output order.
Mon, Sep 9, 11:48 AM · Restricted Project
ychen added inline comments to D67053: [LLD] [COFF] Resolve source locations for undefined references using dwarf.
Mon, Sep 9, 11:30 AM · Restricted Project

Wed, Sep 4

ychen added a comment to D67141: [DebugInfo] Emit DW_TAG_enumeration_type for referenced global enumerator..
In D67141#1658238, @rnk wrote:

lgtm, thanks!

Wed, Sep 4, 1:59 PM · Restricted Project, Restricted Project
ychen committed rG48c6fadc0dac: [DebugInfo] Emit DW_TAG_enumeration_type for referenced global enumerator. (authored by ychen).
[DebugInfo] Emit DW_TAG_enumeration_type for referenced global enumerator.
Wed, Sep 4, 1:58 PM
ychen updated the diff for D67141: [DebugInfo] Emit DW_TAG_enumeration_type for referenced global enumerator..
  • address comment
Wed, Sep 4, 12:40 PM · Restricted Project, Restricted Project
ychen committed rGe6b26f2f91a3: Avoid assemble step in verbose-output-quoting.c (authored by ychen).
Avoid assemble step in verbose-output-quoting.c
Wed, Sep 4, 10:10 AM

Tue, Sep 3

ychen added a comment to D65527: Avoid assemble step in verbose-output-quoting.c.

Would that work for this test also?

Yes, that sounds good.

Tue, Sep 3, 9:50 PM · Restricted Project, Restricted Project
ychen updated the diff for D65527: Avoid assemble step in verbose-output-quoting.c.

Address comment.

Tue, Sep 3, 9:50 PM · Restricted Project, Restricted Project
ychen created D67141: [DebugInfo] Emit DW_TAG_enumeration_type for referenced global enumerator..
Tue, Sep 3, 9:30 PM · Restricted Project, Restricted Project

Wed, Aug 21

ychen committed rG08ff5df49c61: Fix documentation build after rL369568 (authored by ychen).
Fix documentation build after rL369568
Wed, Aug 21, 2:00 PM
ychen committed rGf24c1e6b515e: [clang-tidy] Check for dynamically initialized statics in headers. (authored by ychen).
[clang-tidy] Check for dynamically initialized statics in headers.
Wed, Aug 21, 1:00 PM
ychen added a comment to D62829: [clang-tidy] Check for dynamically initialized statics in headers..

Since Charlie has completed his internship before LGTM, I'll commit this on his behalf.

Wed, Aug 21, 11:05 AM · Restricted Project, Restricted Project, Restricted Project

Aug 1 2019

ychen committed rGf6d42dccb534: Test linux only for absolute paths in the -fuse-ld option (authored by ychen).
Test linux only for absolute paths in the -fuse-ld option
Aug 1 2019, 11:53 AM

Jul 31 2019

ychen created D65527: Avoid assemble step in verbose-output-quoting.c.
Jul 31 2019, 11:33 AM · Restricted Project, Restricted Project

Jul 26 2019

ychen committed rGf184ce53a7cb: [CMake] Allow LLVM_EXTERNAL_<proj>_SOURCE_DIR to be overridden if it is empty. (authored by ychen).
[CMake] Allow LLVM_EXTERNAL_<proj>_SOURCE_DIR to be overridden if it is empty.
Jul 26 2019, 12:27 PM

Jul 25 2019

ychen added a comment to D65045: [CMake] Allow LLVM_EXTERNAL_<proj>_SOURCE_DIR to be overridden if it is empty..

ping:)

Jul 25 2019, 4:14 PM · Restricted Project

Jul 24 2019

ychen committed rGfac3900c5120: [llvm-objdump] Emit warning if --start-address/--stop-address specify range… (authored by ychen).
[llvm-objdump] Emit warning if --start-address/--stop-address specify range…
Jul 24 2019, 9:57 AM

Jul 23 2019

ychen added a comment to D64779: [llvm-objdump] Emit warning if --start-address/--stop-address specify range outside file's address range..

ping?

Jul 23 2019, 7:41 PM · Restricted Project

Jul 22 2019

ychen added a reviewer for D65045: [CMake] Allow LLVM_EXTERNAL_<proj>_SOURCE_DIR to be overridden if it is empty.: hans.
Jul 22 2019, 6:35 PM · Restricted Project
ychen updated the diff for D64779: [llvm-objdump] Emit warning if --start-address/--stop-address specify range outside file's address range..
  • update
Jul 22 2019, 9:32 AM · Restricted Project
ychen updated the diff for D64779: [llvm-objdump] Emit warning if --start-address/--stop-address specify range outside file's address range..
  • Use !=ET_REL
  • Add a test case for ET_CORE
Jul 22 2019, 9:24 AM · Restricted Project
ychen retitled D65045: [CMake] Allow LLVM_EXTERNAL_<proj>_SOURCE_DIR to be overridden if it is empty. from [CMake] LLVM_EXTERNAL_<proj>_SOURCE_DIR should be adjustable. to [CMake] Allow LLVM_EXTERNAL_<proj>_SOURCE_DIR to be overridden if it is empty..
Jul 22 2019, 8:53 AM · Restricted Project
ychen updated the diff for D65045: [CMake] Allow LLVM_EXTERNAL_<proj>_SOURCE_DIR to be overridden if it is empty..
  • update
Jul 22 2019, 8:53 AM · Restricted Project

Jul 20 2019

ychen added a comment to D65045: [CMake] Allow LLVM_EXTERNAL_<proj>_SOURCE_DIR to be overridden if it is empty..

Adding ‘FORCE’ makes this not user overridable, which is the whole point of this being a cache variable.

Jul 20 2019, 10:02 PM · Restricted Project
ychen updated the diff for D65045: [CMake] Allow LLVM_EXTERNAL_<proj>_SOURCE_DIR to be overridden if it is empty..
  • Override LLVM_EXTERNAL_<proj>_SOURCE_DIR when it is empty.
Jul 20 2019, 10:01 PM · Restricted Project
ychen added a comment to D65045: [CMake] Allow LLVM_EXTERNAL_<proj>_SOURCE_DIR to be overridden if it is empty..

https://github.com/llvm/llvm-project/blob/master/llvm/docs/CMake.rst and some other places in the codebase refer to the type as PATH.

Jul 20 2019, 7:08 PM · Restricted Project
ychen created D65045: [CMake] Allow LLVM_EXTERNAL_<proj>_SOURCE_DIR to be overridden if it is empty..
Jul 20 2019, 7:07 PM · Restricted Project
ychen committed rGb4e06328fc26: [lldb] Fix buildbot build fail caused by r366645 (authored by ychen).
[lldb] Fix buildbot build fail caused by r366645
Jul 20 2019, 5:08 PM
ychen abandoned D55915: [Driver] Make -fno-omit-frame-pointer imply -mno-omit-leaf-frame-pointer.
Jul 20 2019, 4:09 PM · Restricted Project
ychen committed rGff22ec3d7004: [Clang] Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer'… (authored by ychen).
[Clang] Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer'…
Jul 20 2019, 3:53 PM

Jul 18 2019

ychen added a comment to D56353: Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with '-mframe-pointer'.

@chandlerc ping?

Jul 18 2019, 8:39 PM · Restricted Project, Restricted Project
ychen added inline comments to D64948: IR: Teach Constant::needsRelocation() that relative pointers don't need to be relocated..
Jul 18 2019, 1:59 PM · Restricted Project
ychen committed rGabbc3ff4ad9e: [NFC][llvm-readobj] Refactor dynamic string table indexing into a function. (authored by ychen).
[NFC][llvm-readobj] Refactor dynamic string table indexing into a function.
Jul 18 2019, 10:08 AM

Jul 15 2019

ychen updated the diff for D56353: Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with '-mframe-pointer'.
  • update
Jul 15 2019, 7:30 PM · Restricted Project, Restricted Project
ychen added inline comments to D64779: [llvm-objdump] Emit warning if --start-address/--stop-address specify range outside file's address range..
Jul 15 2019, 7:22 PM · Restricted Project
ychen updated the diff for D64779: [llvm-objdump] Emit warning if --start-address/--stop-address specify range outside file's address range..
  • update
Jul 15 2019, 7:20 PM · Restricted Project
ychen updated the summary of D64779: [llvm-objdump] Emit warning if --start-address/--stop-address specify range outside file's address range..
Jul 15 2019, 7:04 PM · Restricted Project
ychen created D64779: [llvm-objdump] Emit warning if --start-address/--stop-address specify range outside file's address range..
Jul 15 2019, 3:57 PM · Restricted Project
ychen committed rGa28dcf693d15: [llvm-readelf] Print "File: lib.a(file.o)" info when dumping archive files. (authored by ychen).
[llvm-readelf] Print "File: lib.a(file.o)" info when dumping archive files.
Jul 15 2019, 3:54 PM
ychen updated the diff for D56353: Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with '-mframe-pointer'.
  • Make FramePointerKind enum class.
  • Replace two if-else-if blocks to switch statements.
Jul 15 2019, 3:27 PM · Restricted Project, Restricted Project
ychen added inline comments to D56353: Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with '-mframe-pointer'.
Jul 15 2019, 3:24 PM · Restricted Project, Restricted Project
ychen added inline comments to D64674: [llvm-readobj] Refactor dynamic string table indexing into a function..
Jul 15 2019, 9:32 AM · Restricted Project
ychen updated the diff for D64674: [llvm-readobj] Refactor dynamic string table indexing into a function..
  • Address reviewer's comments.
Jul 15 2019, 9:32 AM · Restricted Project
ychen retitled D64674: [llvm-readobj] Refactor dynamic string table indexing into a function. from [NFC][llvm-readobj] Refactor dynamic string table indexing into a function. to [llvm-readobj] Refactor dynamic string table indexing into a function..
Jul 15 2019, 9:30 AM · Restricted Project

Jul 14 2019

ychen added a comment to D64674: [llvm-readobj] Refactor dynamic string table indexing into a function..

Do you find another use case of printDynamicString? If yes, can you name it?

Jul 14 2019, 6:36 PM · Restricted Project
ychen updated the diff for D64674: [llvm-readobj] Refactor dynamic string table indexing into a function..
  • Replace printDynamicString with getDynamicString.
  • Change tests accordingly.
Jul 14 2019, 6:34 PM · Restricted Project

Jul 12 2019

ychen created D64674: [llvm-readobj] Refactor dynamic string table indexing into a function..
Jul 12 2019, 3:41 PM · Restricted Project
ychen retitled D56353: Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with '-mframe-pointer' from Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with'-mframe-pointer=' to Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with '-mframe-pointer'.
Jul 12 2019, 11:47 AM · Restricted Project, Restricted Project
ychen updated the diff for D56353: Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with '-mframe-pointer'.
Jul 12 2019, 11:37 AM · Restricted Project, Restricted Project

Jul 11 2019

ychen accepted D64294: [Driver] Refactor interaction between -f(no-)?omit-frame-pointer and -m(no-)?omit-leaf-frame-pointer.

LGTM

Jul 11 2019, 9:30 AM · Restricted Project, Restricted Project

Jul 10 2019

ychen added inline comments to D64294: [Driver] Refactor interaction between -f(no-)?omit-frame-pointer and -m(no-)?omit-leaf-frame-pointer.
Jul 10 2019, 10:21 AM · Restricted Project, Restricted Project

Jul 9 2019

ychen added inline comments to D64294: [Driver] Refactor interaction between -f(no-)?omit-frame-pointer and -m(no-)?omit-leaf-frame-pointer.
Jul 9 2019, 8:36 PM · Restricted Project, Restricted Project
ychen committed rGc5f8aa8bea66: [llvm-objdump] Keep warning for --disassemble-functions in correct order. (authored by ychen).
[llvm-objdump] Keep warning for --disassemble-functions in correct order.
Jul 9 2019, 2:54 PM
ychen updated the diff for D64361: [llvm-readelf] Print "File: lib.a(file.o)" info when dumping archive files..
  • update
Jul 9 2019, 2:50 PM · Restricted Project

Jul 8 2019

ychen updated the diff for D64361: [llvm-readelf] Print "File: lib.a(file.o)" info when dumping archive files..
  • update
Jul 8 2019, 9:21 PM · Restricted Project
ychen added a comment to D64361: [llvm-readelf] Print "File: lib.a(file.o)" info when dumping archive files..

Thank you for capturing that. The added new line in the previous revision is for GNU output. I should have done what LLVM output did: add a prefixing new line.

Jul 8 2019, 7:16 PM · Restricted Project
ychen updated the diff for D64361: [llvm-readelf] Print "File: lib.a(file.o)" info when dumping archive files..
  • update
Jul 8 2019, 7:15 PM · Restricted Project
ychen added inline comments to D64165: [llvm-objdump] Keep warning for --disassemble-functions in correct order..
Jul 8 2019, 12:40 PM · Restricted Project
ychen created D64361: [llvm-readelf] Print "File: lib.a(file.o)" info when dumping archive files..
Jul 8 2019, 12:40 PM · Restricted Project
ychen updated the summary of D64165: [llvm-objdump] Keep warning for --disassemble-functions in correct order..
Jul 8 2019, 12:40 PM · Restricted Project
ychen committed rG5de4692cc746: Teach the symbolizer lib symbolize objects directly. (authored by ychen).
Teach the symbolizer lib symbolize objects directly.
Jul 8 2019, 12:30 PM
ychen added a comment to D64294: [Driver] Refactor interaction between -f(no-)?omit-frame-pointer and -m(no-)?omit-leaf-frame-pointer.

In D56353, I remember @chandlerc thought -f(no-)omit-frame-pointer should win over -m(no-)omit-leaf-frame-pointer. I'm not sure what his thoughts on this now. @chandlerc ?

Jul 8 2019, 9:46 AM · Restricted Project, Restricted Project
ychen added inline comments to D64165: [llvm-objdump] Keep warning for --disassemble-functions in correct order..
Jul 8 2019, 8:44 AM · Restricted Project
ychen updated the diff for D64165: [llvm-objdump] Keep warning for --disassemble-functions in correct order..
  • update
Jul 8 2019, 8:41 AM · Restricted Project

Jul 3 2019

ychen created D64165: [llvm-objdump] Keep warning for --disassemble-functions in correct order..
Jul 3 2019, 4:10 PM · Restricted Project
ychen updated the diff for D63521: Teach the symbolizer lib symbolize objects directly..
  • update
Jul 3 2019, 11:56 AM · Restricted Project

Jul 2 2019

ychen updated the diff for D63521: Teach the symbolizer lib symbolize objects directly..
  • update
Jul 2 2019, 12:19 PM · Restricted Project
ychen committed rGd16c162c9453: [llvm-objdump] Warn if no user specified sections (-j) are not found. (authored by ychen).
[llvm-objdump] Warn if no user specified sections (-j) are not found.
Jul 2 2019, 11:40 AM

Jul 1 2019

ychen added a comment to D63521: Teach the symbolizer lib symbolize objects directly..

Hi @MaskRay, from @rnk 's inputs, seems this is not a common case worth pursuing at least for the moment, is it ok to move forward with the first choice I described?

My comment on your first version of this patch is about the potential code duplication. Now the codeview concern of the code duplication has been addressed.

The current version doesn't look bad to me. Do you think the initial version is better?

The expected client for this new symbolizeCode interface is for archive members and COFF is unlikely to symbolize plain object files for the moment.
I think the concern here the code movement for removing the potential duplication puts some untested code in the path for DWARF. I assume if there is a need for the COFF archive member symbolization we could easily deduplicate the code in the patch for COFF?

Jul 1 2019, 10:04 AM · Restricted Project
ychen updated the diff for D63779: [llvm-objdump] Warn if no user specified sections (-j) are found..
  • update
Jul 1 2019, 9:20 AM · Restricted Project

Jun 28 2019

Herald added a project to D38446: update comments in clang-format.py for python3 compatibility: Restricted Project.
Jun 28 2019, 2:25 PM · Restricted Project, Restricted Project
ychen added inline comments to D63779: [llvm-objdump] Warn if no user specified sections (-j) are found..
Jun 28 2019, 10:07 AM · Restricted Project
ychen updated the diff for D63779: [llvm-objdump] Warn if no user specified sections (-j) are found..
  • update
Jun 28 2019, 10:04 AM · Restricted Project
ychen added a comment to D63521: Teach the symbolizer lib symbolize objects directly..

Hi @MaskRay, from @rnk 's inputs, seems this is not a common case worth pursuing at least for the moment, is it ok to move forward with the first choice I described?

Jun 28 2019, 9:52 AM · Restricted Project
ychen updated the diff for D63779: [llvm-objdump] Warn if no user specified sections (-j) are found..
  • update
Jun 28 2019, 12:03 AM · Restricted Project

Jun 27 2019

ychen updated the diff for D63779: [llvm-objdump] Warn if no user specified sections (-j) are found..
  • update
Jun 27 2019, 12:15 PM · Restricted Project
ychen committed rG2dcd2c2493b1: [llvm-objdump] Update the doc for --disassemble-functions. (authored by ychen).
[llvm-objdump] Update the doc for --disassemble-functions.
Jun 27 2019, 11:42 AM

Jun 26 2019

ychen added a comment to D63521: Teach the symbolizer lib symbolize objects directly..

I don't think it's a loss of functionality versus the previous version which creates DWARFContext even for COFF object (not work obviously). This version still does not work for COFF archive but looks a little bit more reasonable. IMHO, we should have no or all support for COFF archive, not partial support. I could either

Jun 26 2019, 11:40 PM · Restricted Project
ychen updated the diff for D63779: [llvm-objdump] Warn if no user specified sections (-j) are found..
  • update
Jun 26 2019, 10:24 AM · Restricted Project
ychen updated the diff for D63779: [llvm-objdump] Warn if no user specified sections (-j) are found..
  • update
Jun 26 2019, 10:20 AM · Restricted Project
ychen updated the diff for D63787: [llvm-objdump] Update the doc for --disassemble-functions..
  • update
Jun 26 2019, 9:28 AM · Restricted Project
ychen retitled D63779: [llvm-objdump] Warn if no user specified sections (-j) are found. from [llvm-objdump] Warn if no user specified sections (-j) are not found. to [llvm-objdump] Warn if no user specified sections (-j) are found..
Jun 26 2019, 9:05 AM · Restricted Project

Jun 25 2019

ychen created D63787: [llvm-objdump] Update the doc for --disassemble-functions..
Jun 25 2019, 1:35 PM · Restricted Project
ychen created D63779: [llvm-objdump] Warn if no user specified sections (-j) are found..
Jun 25 2019, 10:31 AM · Restricted Project
ychen added inline comments to D63521: Teach the symbolizer lib symbolize objects directly..
Jun 25 2019, 9:26 AM · Restricted Project

Jun 24 2019

ychen added a comment to D63524: [llvm-objdump] Allow --disassemble-functions to take demangled names.

Hi @ychen, would you mind posting a patch to update the docs for this behaviour change? I didn't mention it previously, because rL364019, which added --disassemble-functions to the listed options, was still under review, but it landed before this change did.

Jun 24 2019, 11:18 AM · Restricted Project
ychen committed rG6e04b92c896c: [llvm-objdump] Match GNU objdump on symbol types shown in disassembly output. (authored by ychen).
[llvm-objdump] Match GNU objdump on symbol types shown in disassembly output.
Jun 24 2019, 10:51 AM
ychen closed D62964: [llvm-objdump] Match GNU objdump on symbol types shown in disassembly output..
Jun 24 2019, 10:51 AM · Restricted Project
ychen updated the diff for D63521: Teach the symbolizer lib symbolize objects directly..
  • address reviewer's comments.
Jun 24 2019, 10:21 AM · Restricted Project

Jun 23 2019

ychen added a comment to D62964: [llvm-objdump] Match GNU objdump on symbol types shown in disassembly output..

Hi @MaskRay, does this version look good to you?

Jun 23 2019, 9:13 PM · Restricted Project

Jun 21 2019

ychen added inline comments to D63631: [llvm-objdump] Move --start-address >= --stop-address check out of the -d code..
Jun 21 2019, 6:24 PM · Restricted Project