- User Since
- Nov 19 2013, 9:02 PM (322 w, 5 d)
Sat, Jan 25
- fix two linux test failure
Fri, Jan 24
Somehow this caused three failures on Linux. I'll take a look.
Thu, Jan 23
- enable profile test-suite discovery
Mon, Jan 20
1 feels very special for multithreading code. I've seen code with separate paths for 1 and > 1, although I'm not aware of any similar code for ThinLTO.
Sun, Jan 19
@MaskRay @mehdi_amini I have no clue either on how this does not happen before. Adding std::__throw_system_error in ThreadPool ctor and reverting this change, I still see the crash in my machine (Ubuntu 18.04). I'm inclined to think the exception did not trigger before rather than it was triggered but somehow muted in some way.
@MaskRay Yeah, that would be ideal. I'm also in favor of supporting python3 only. The change for open to add encoding parameter is still needed though since the default value is platform-dependent.
Wed, Jan 15
There are some interesting failures that need to be investigated.
This is going deeper...
I saw a null pointer dereference for the p3-2a.cpp file added here. It is not always reproducible for me, I was able to reproduce it once offline. Any idea?
- fix tests
Apologies that it takes so long. I'll fix the test and land it today.
Tue, Jan 14
- fix test when clang is the host compiler
- rebase & clang-format
- fix a typo
- when optnone is not present, add optsize for Os and minsize for Oz
- add Os Oz function attribute test.
- add Os Oz pipeline test
Thu, Jan 9
Since this is -fapple-ext specific, would it be better to keep everything as is and move the always_inline setting for -fapple-ext from code emission to after the regular inline attribute decision is made on non--fapple-ext cases in SetLLVMFunctionAttributesForDefinition? It would be less diff and keep the assertion which IMHO is still useful.
Wed, Jan 8
- fix test
Mon, Jan 6
Sat, Jan 4
--cmake-define works just fine.
Fri, Jan 3
Defining __BOOL_DEFINED for C would cause build error.
address the comment
Dec 26 2019
Dec 24 2019
Probably need to translate old attributes to new attribute in AutoUpgrade.cpp? Otherwise, this may cause problems for existing LTO libraries.
Dec 20 2019
Thanks for the feedback. Obviously, my CMake skills needs to catch up. My
intention was to add the macro definition only for CXX compilation, but
add_definitions, add_compile_options change both C and CXX flags AFAIK at
the time. After some digging, it seems add_compile_options and
add_compile_definitions support cmake-generator-expressions that could be
used to implement this perfectly. However, add_compile_definitions was not
available until CMake v3.12, so I use add_compile_options here.
Dec 18 2019
Dec 17 2019
Dec 10 2019
Dec 9 2019
fix a bug
Oct 24 2019
Address reviewer's comments.
Sorry for the confusion @steven_wu. By stable I mean the probability that the -fthin-link-bitcode option is replaced with some other thinlink mechanism under the distributed build environment. Since at least for ccache, the compilation output caching depends on the semantics of options ("-o" is assumed to be compilation output). For the case of -fthin-link-bitcode, both -Xclang -fthin-link-bitcode and -o are the output. I'm not familiar with compiler cache tools, but having the caching depends on a cc1 option feels not right since it is not an option of any other compilers, so most caching tools don't recognize it.
Oct 23 2019
Thanks for the inputs @steven_wu @tejohnson. Totally agree with the points you brought up. One last thing I'm not quite sure is the caching of -fthin-link-bitcode. It is a -cc1 option since it is a kind of implementation of ThinLTO, right? I'm a little hesitant to begin writing up patches to teach build system/caching tool (I could think of at least three for our workload) to recognize this option because of that. If there are any changes to the option, the same thing needs to be done again. Do you have any thoughts on that? Is the option in use for your workload and do you think it is stable enough to have build systems caching for it? (Another option is to produce -fthin-link-bitcode output post compile time which I assume having total build time impact to some degree).
Oct 4 2019
Oct 2 2019
Oct 1 2019
Sep 30 2019
By undefined I don't know what kind of consistent behavior could be checked.
Removed in r373297. Thanks.
Fixed in r373244. Thanks!
Sep 27 2019
Sep 20 2019
Here is another case showing the issue http://lists.llvm.org/pipermail/llvm-dev/2019-September/135283.html
Sep 19 2019
Sep 18 2019
Pass in instead of manage IR unit analysis managers in MachineFunctionIRAnalysisManager
Sep 17 2019
Hello, Charlie went back to school after the internship. I'm trying the address the comments in a new patch. https://reviews.llvm.org/D67687
- Missing assignment of TheModule in move constructor.
Sep 16 2019