This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Add MC layer support for Zicfilp.
ClosedPublic

Authored by fakepaper56 on Aug 7 2023, 10:26 PM.

Details

Summary

This adds extension Zicfilp and support pseudo instruction lpad.

Diff Detail

Event Timeline

fakepaper56 created this revision.Aug 7 2023, 10:26 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 7 2023, 10:26 PM
fakepaper56 requested review of this revision.Aug 7 2023, 10:26 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptAug 7 2023, 10:26 PM
fakepaper56 planned changes to this revision.Aug 7 2023, 11:01 PM

Also support pseudo instruction lpad.

fakepaper56 retitled this revision from [RISCV] Add Zicfilp extension. to [RISCV] Add MC layer support for Zicfilp..Aug 8 2023, 12:38 AM
fakepaper56 edited the summary of this revision. (Show Details)

Update docs/RISCVUsage.rst.

reames added inline comments.Aug 14 2023, 9:49 AM
llvm/docs/RISCVUsage.rst
120

This in the wrong place; this is not a ratified extension.

You need to link to the right spec version as well. This is particularly important here as this spec has gone through a ton of churn, and may still do so.

llvm/test/MC/RISCV/zicfilp-valid.s
18

If the proper extension is provided to llvm-objdump, we really shouldn't be disassembling this as the auipc name, it should be the landing pad mnemonic.

I think this is just the use of -m no-aliases above.

craig.topper added inline comments.Aug 14 2023, 11:04 AM
llvm/lib/Target/RISCV/RISCVInstrInfo.td
665

There is a designated spot in this file for InstAliases.

Address comments.

fakepaper56 marked 3 inline comments as done.Aug 14 2023, 2:24 PM
This revision is now accepted and ready to land.Aug 15 2023, 4:41 PM
This revision was automatically updated to reflect the committed changes.