This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Remove some instructions from Zvfbfwma by implying Zfbfmin according to the latest spec
ClosedPublic

Authored by joshua-arch1 on Jul 20 2023, 10:47 PM.

Details

Summary

According to the latest spec, Zvfbfwma requires Zvfbfmin and Zvfbfmin requires Zfbfmin, with FLH/FSH/FMV.H.X/HMV.X.H removed from Zvfbfwma.

Diff Detail

Event Timeline

joshua-arch1 created this revision.Jul 20 2023, 10:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 20 2023, 10:47 PM
joshua-arch1 requested review of this revision.Jul 20 2023, 10:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 20 2023, 10:47 PM
joshua-arch1 edited the summary of this revision. (Show Details)Jul 20 2023, 10:48 PM
asb added a comment.Jul 21 2023, 8:41 AM

Thanks! From a first quick pass through this seems correct, but could you please adjust the spec version as well? As the PDF including this change is marked as spec v0.8.

Adjust the spec version from 0.6 to 0.8

asb accepted this revision.Jul 24 2023, 8:21 AM

LGTM and I can't see other relevant changes to the spec in the 0.6 -> 0.8 change (though it's not impossible I'm missing them, the history is a bit messy).

Prior to committing, please update the version of the spec linked to in RISCVUsage.rst and mention the spec bump in the commit message. Thanks!

This revision is now accepted and ready to land.Jul 24 2023, 8:21 AM
craig.topper added inline comments.Jul 26 2023, 9:49 PM
llvm/lib/Support/RISCVISAInfo.cpp
982

You can drop zve32f here now since its in Zvfbfmin

llvm/lib/Target/RISCV/RISCVFeatures.td
467

Need to add Zfbfmin here?

475

I think we need to add Zvfbfmin here

Herald added a project: Restricted Project. · View Herald TranscriptJul 28 2023, 12:51 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript