Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
clang/test/Preprocessor/predefined-arch-macros.c | ||
---|---|---|
1922 | Maybe create a common CHECK_GNR_BASE prefix that you can check graniterapids/graniterapids-d against - currently graniterapids-d is barely testing anything |
clang/test/Preprocessor/predefined-arch-macros.c | ||
---|---|---|
1922 | Oh, it should be -check-prefixes=CHECK_GNR_M64,CHECK_GNRD_M64 |
clang/test/Preprocessor/predefined-arch-macros.c | ||
---|---|---|
1925–1926 | Won't this fail on the graniterapids-d run? |
clang/test/Preprocessor/predefined-arch-macros.c | ||
---|---|---|
1925–1926 | Whops, I didn't realize this problem before! But it indeed doesn't fail. Need to figure out why... |
clang/test/Preprocessor/predefined-arch-macros.c | ||
---|---|---|
1925–1926 | I'm guessing when using multi prefixes, it will try to match with the second one if the first failed. It's common and easy to understand for positive check but a bit confusing for negative one. |
clang/test/Preprocessor/predefined-arch-macros.c | ||
---|---|---|
1925–1926 | I did some experiments and arrived at same guessing. It indeed worked here for graniterapids-d and checked each #define for it. |
llvm/lib/Target/X86/X86.td | ||
---|---|---|
1081–1082 |
llvm/lib/Target/X86/X86.td | ||
---|---|---|
1081 | Sorry for mess here. Addressed. |
LGTM, but please wait one or two days for other reviewers.
llvm/lib/TargetParser/X86TargetParser.cpp | ||
---|---|---|
430–433 | Remove the space. |
Maybe create a common CHECK_GNR_BASE prefix that you can check graniterapids/graniterapids-d against - currently graniterapids-d is barely testing anything