Details

Reviewers

asb
VincentWu
wangpc
kito-cheng

Commits

rG1a3b14d26152: [RISCV] Add C intrinsics for scalar bitmanip and crypto

Summary

This adds riscv_bitmanip and riscv_crypto.h

This is based on the proposed spec here https://github.com/riscv-non-isa/riscv-c-api-doc/pull/44

Tests that previously used builtins directly now use the intrinsics.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

craig.topper created this revision.Jul 18 2023, 2:57 PM

Herald added a project: Restricted Project. · View Herald TranscriptJul 18 2023, 2:57 PM

Herald added subscribers: jobnoorman, luke, vkmr and 24 others. · View Herald Transcript

craig.topper requested review of this revision.Jul 18 2023, 2:57 PM

Herald added a project: Restricted Project. · View Herald TranscriptJul 18 2023, 2:57 PM

Herald added subscribers: eopXD, MaskRay. · View Herald Transcript

git add the header

Fix file description

Fix name of zip/unzip builtin

Can we run mem2reg pass in RUNs just like RVV tests (maybe another cleanup patch)? I think there are a lot of noises in CHECKS.

Harbormaster completed remote builds in B246373: Diff 541759.Jul 18 2023, 11:52 PM

craig.topper mentioned this in rG7fb0f4a6eba2: [RISCV] Run mem2reg on the scalar C builtin tests to remove allocas and….Jul 19 2023, 10:31 AM

Rebase after using mem2reg.
Fix a couple copy/paste mistakes that were much easier to spot with mem2reg.

Harbormaster completed remote builds in B246620: Diff 542121.Jul 19 2023, 1:45 PM

Add riscv_bitmanip.h to cover all of Zbb and Zbkb

Harbormaster completed remote builds in B249669: Diff 546315.Aug 1 2023, 9:56 PM

craig.topper retitled this revision from [RISCV] Add C intrinsics for scalar crypto to [RISCV] Add C intrinsics for scalar bitmanip and crypto.Aug 1 2023, 9:58 PM

craig.topper edited the summary of this revision. (Show Details)

LGTM, But waiting for other reviewers.

LGTM if the proposal is merged.

This revision is now accepted and ready to land.Aug 21 2023, 1:23 AM

Herald added a subscriber: sunshaoce. · View Herald TranscriptAug 21 2023, 1:23 AM

Kakadu added a subscriber: Kakadu.Aug 30 2023, 11:30 AM

Rebase

Harbormaster completed remote builds in B258123: Diff 558166.Fri, Nov 24, 12:36 PM

Closed by commit rG1a3b14d26152: [RISCV] Add C intrinsics for scalar bitmanip and crypto (authored by craig.topper). · Explain WhyFri, Nov 24, 4:17 PM

This revision was automatically updated to reflect the committed changes.

craig.topper added a commit: rG1a3b14d26152: [RISCV] Add C intrinsics for scalar bitmanip and crypto.

Herald added a project: Restricted Project. · View Herald TranscriptFri, Nov 24, 4:17 PM

Herald added a subscriber: llvm-commits. · View Herald Transcript

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

[RISCV] Add C intrinsics for scalar bitmanip and crypto
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 558170

clang/lib/Headers/CMakeLists.txt

clang/lib/Headers/riscv_bitmanip.h

clang/lib/Headers/riscv_crypto.h

clang/test/CodeGen/RISCV/rvb-intrinsics/zbkb.c

clang/test/CodeGen/RISCV/rvb-intrinsics/zbkc.c

clang/test/CodeGen/RISCV/rvb-intrinsics/zbkx.c

clang/test/CodeGen/RISCV/rvk-intrinsics/riscv32-zknd.c

clang/test/CodeGen/RISCV/rvk-intrinsics/riscv32-zkne.c

clang/test/CodeGen/RISCV/rvk-intrinsics/riscv32-zknh.c

clang/test/CodeGen/RISCV/rvk-intrinsics/riscv64-zknd-zkne.c

clang/test/CodeGen/RISCV/rvk-intrinsics/riscv64-zknd.c

clang/test/CodeGen/RISCV/rvk-intrinsics/riscv64-zkne.c

clang/test/CodeGen/RISCV/rvk-intrinsics/riscv64-zknh.c

clang/test/CodeGen/RISCV/rvk-intrinsics/zksed.c

clang/test/CodeGen/RISCV/rvk-intrinsics/zksh.c

llvm/docs/ReleaseNotes.rst

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

[RISCV] Add C intrinsics for scalar bitmanip and cryptoClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 558170

clang/lib/Headers/CMakeLists.txt

clang/lib/Headers/riscv_bitmanip.h

clang/lib/Headers/riscv_crypto.h

clang/test/CodeGen/RISCV/rvb-intrinsics/zbkb.c

clang/test/CodeGen/RISCV/rvb-intrinsics/zbkc.c

clang/test/CodeGen/RISCV/rvb-intrinsics/zbkx.c

clang/test/CodeGen/RISCV/rvk-intrinsics/riscv32-zknd.c

clang/test/CodeGen/RISCV/rvk-intrinsics/riscv32-zkne.c

clang/test/CodeGen/RISCV/rvk-intrinsics/riscv32-zknh.c

clang/test/CodeGen/RISCV/rvk-intrinsics/riscv64-zknd-zkne.c

clang/test/CodeGen/RISCV/rvk-intrinsics/riscv64-zknd.c

clang/test/CodeGen/RISCV/rvk-intrinsics/riscv64-zkne.c

clang/test/CodeGen/RISCV/rvk-intrinsics/riscv64-zknh.c

clang/test/CodeGen/RISCV/rvk-intrinsics/zksed.c

clang/test/CodeGen/RISCV/rvk-intrinsics/zksh.c

llvm/docs/ReleaseNotes.rst

[RISCV] Add C intrinsics for scalar bitmanip and crypto
ClosedPublic
Actions

Revision Contents
Changeset List