[clang] Fix assertion while parsing an invalid for loop

[cor3ntin]

Summary

with multiple declarations followed by a colon.

Fixes #63010

[cor3ntin]

revert ws changes

[shafik]

clang/lib/Parse/ParseStmt.cpp

2205

Can you explain why you removed this?

clang/test/Parser/cxx0x-for-range.cpp

67

Did you try dropping the ; at the end of this line to make sure it still does what we expect?

[cor3ntin]

clang/lib/Parse/ParseStmt.cpp

2205

The current diagnostics are pretty bad https://godbolt.org/z/z9odv3zjb - this fixes that

clang/test/Parser/cxx0x-for-range.cpp

67

yup, you think it's worth adding a test?

[shafik]

LGTM

clang/test/Parser/cxx0x-for-range.cpp

67

Yes, I feel like so many bugs could have been fixed by having better coverage that would have caught them when they were committed in the first place.

[cor3ntin]

Add tests for missing semi colons