Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D151771

[RISCV] Merge emitDirectiveOptionArchPlus and emitDirectiveOptionArchMinus into a single interface. NFC
ClosedPublic
Actions

Authored by craig.topper on May 30 2023, 8:25 PM.

Details

Reviewers
StephenFan
jrtc27
luismarques
Commits
rGac1df22315a5: [RISCV] Merge emitDirectiveOptionArchPlus and emitDirectiveOptionArchMinus into…
Summary

Probably going to do some other refactors after this, but this one
was easy and clearly reduces duplicate code.

Diff Detail

Event Timeline

craig.topper created this revision.May 30 2023, 8:25 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 30 2023, 8:25 PM
Herald added subscribers: jobnoorman, luke, VincentWu and 26 others. · View Herald Transcript
craig.topper requested review of this revision.May 30 2023, 8:25 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 30 2023, 8:25 PM
Herald added subscribers: • pcwang-thead, eopXD, MaskRay. · View Herald Transcript
Harbormaster completed remote builds in B235464: Diff 526878.May 30 2023, 9:45 PM
StephenFan accepted this revision.May 30 2023, 10:41 PM

LGTM

This revision is now accepted and ready to land.May 30 2023, 10:41 PM
Closed by commit rGac1df22315a5: [RISCV] Merge emitDirectiveOptionArchPlus and emitDirectiveOptionArchMinus into… (authored by craig.topper). · Explain WhyMay 30 2023, 10:53 PM
This revision was automatically updated to reflect the committed changes.
craig.topper added a commit: rGac1df22315a5: [RISCV] Merge emitDirectiveOptionArchPlus and emitDirectiveOptionArchMinus into….

Revision Contents
Changeset List

PathSize
llvm/
lib/
Target/
RISCV/
AsmParser/
8 lines
MCTargetDesc/
15 lines
26 lines

Diff 526911

View Options

llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp

Loading...
View Options

llvm/lib/Target/RISCV/MCTargetDesc/RISCVTargetStreamer.h

Loading...
View Options

llvm/lib/Target/RISCV/MCTargetDesc/RISCVTargetStreamer.cpp

Loading...