Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/test/Analysis/CostModel/RISCV/gep-zero-indices.ll | ||
---|---|---|
7–23 ↗ | (On Diff #519599) | Could you add some more tests with other types/vector lengths? |
Comment Actions
Add a comment to describe what the gep-zero-indices tests are for, and add
a few more test cases
Comment Actions
LGTM to the test additions in test/Analysis/CostModel/RISCV/gep-zero-indices.ll only. The other piece needs a bit of cleanup, and is tied more to the sequence.
llvm/test/Analysis/CostModel/RISCV/gep-zero-indices.ll | ||
---|---|---|
7 ↗ | (On Diff #533298) | indices |
llvm/test/Transforms/SLPVectorizer/RISCV/gep.ll | ||
6 | This needs more explanation as to *why* this shouldn't be vectorized. |
Comment Actions
LGTM to the CostModel tests only. Please split and land. Please do *not* update this patch again without doing so, and likely rearranging the dependencies on other reviews.
This needs more explanation as to *why* this shouldn't be vectorized.