This is an archive of the discontinued LLVM Phabricator instance.

[RISCV][SLP] Add tests for unprofitable SLP vectorization due to GEP. NFC
ClosedPublic

Authored by luke on May 4 2023, 12:17 PM.

Diff Detail

Event Timeline

luke created this revision.May 4 2023, 12:17 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 4 2023, 12:17 PM
luke requested review of this revision.May 4 2023, 12:17 PM
ABataev added inline comments.May 4 2023, 12:33 PM
llvm/test/Analysis/CostModel/RISCV/gep-zero-indices.ll
8–24

Could you add some more tests with other types/vector lengths?

luke updated this revision to Diff 519842.May 5 2023, 7:03 AM

Add more zero indices tests

luke updated this revision to Diff 533298.Jun 21 2023, 9:32 AM

Add a comment to describe what the gep-zero-indices tests are for, and add
a few more test cases

evandro removed a subscriber: evandro.Jun 21 2023, 9:40 AM

LGTM to the test additions in test/Analysis/CostModel/RISCV/gep-zero-indices.ll only. The other piece needs a bit of cleanup, and is tied more to the sequence.

llvm/test/Analysis/CostModel/RISCV/gep-zero-indices.ll
7

indices

llvm/test/Transforms/SLPVectorizer/RISCV/gep.ll
5

This needs more explanation as to *why* this shouldn't be vectorized.

luke updated this revision to Diff 533632.Jun 22 2023, 8:40 AM

Include new cost model tests for GEPs in this patch

LGTM to the CostModel tests only. Please split and land. Please do *not* update this patch again without doing so, and likely rearranging the dependencies on other reviews.

luke updated this revision to Diff 535753.Jun 29 2023, 5:51 AM

Split out the cost model tests

luke retitled this revision from [RISCV][SLP] Add tests for GEP costs in SLP to [RISCV] Add tests for unprofitable SLP vectorization due to GEP.Jun 29 2023, 5:51 AM
luke updated this revision to Diff 535841.Jun 29 2023, 9:11 AM

Split out non-SLP changes

luke updated this revision to Diff 535842.Jun 29 2023, 9:13 AM

Undo accidental diff update: apologies for the noise.

Retitle to add SLP again and add NFC

luke retitled this revision from [RISCV] Add tests for unprofitable SLP vectorization due to GEP to [RISCV][SLP] Add tests for unprofitable SLP vectorization due to GEP. NFC.Jun 29 2023, 9:22 AM
This revision is now accepted and ready to land.Jun 29 2023, 9:22 AM
This revision was landed with ongoing or failed builds.Jun 29 2023, 11:10 AM
This revision was automatically updated to reflect the committed changes.