Page MenuHomePhabricator

vporpo (Vasileios Porpodas)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 12 2016, 8:44 PM (362 w, 4 d)

Recent Activity

Mon, Feb 27

vporpo committed rGa700fb3d9b31: [SLP] Fixes crash in BoUpSLP::isGatherShuffledEntry() (authored by vporpo).
[SLP] Fixes crash in BoUpSLP::isGatherShuffledEntry()
Mon, Feb 27, 12:32 PM · Restricted Project, Restricted Project
vporpo closed D144895: [SLP] Fixes crash in BoUpSLP::isGatherShuffledEntry().
Mon, Feb 27, 12:31 PM · Restricted Project, Restricted Project
vporpo updated the diff for D144895: [SLP] Fixes crash in BoUpSLP::isGatherShuffledEntry().

Replace TE->Scalars with VL, as suggested.

Mon, Feb 27, 10:56 AM · Restricted Project, Restricted Project
vporpo updated the summary of D144895: [SLP] Fixes crash in BoUpSLP::isGatherShuffledEntry().
Mon, Feb 27, 10:41 AM · Restricted Project, Restricted Project
vporpo added a comment to D141940: [SLP]Add shuffling of extractelements to avoid extra costs/data movement..

I think this is the cause of the crash: https://reviews.llvm.org/D144895
@ABataev could you take a look ?

Mon, Feb 27, 10:40 AM · Restricted Project, Restricted Project
vporpo requested review of D144895: [SLP] Fixes crash in BoUpSLP::isGatherShuffledEntry().
Mon, Feb 27, 10:39 AM · Restricted Project, Restricted Project

Feb 15 2023

vporpo committed rGe6fbfb1ff1d3: [NFC] Make Module::getIFuncList() private (authored by vporpo).
[NFC] Make Module::getIFuncList() private
Feb 15 2023, 12:17 PM · Restricted Project, Restricted Project
vporpo closed D144127: [NFC] Make Module::getIFuncList() private.
Feb 15 2023, 12:16 PM · Restricted Project, Restricted Project
vporpo requested review of D144127: [NFC] Make Module::getIFuncList() private.
Feb 15 2023, 10:59 AM · Restricted Project, Restricted Project
vporpo added a comment to D143968: [NFC][IR] Make Module::getIFuncList() private..

Hi - I noticed it doesn't appear that getIFuncList was actually made private by this one.

Thanks, let me fix it.

Feb 15 2023, 10:51 AM · Restricted Project, Restricted Project

Feb 14 2023

vporpo added a comment to D144027: [NFC][IR] Make Module::getGlobalList() private.

Yeah sorry about that, I reverted it here: b5f239363a3 Revert "[NFC][IR] Make Module::getGlobalList() private"

Feb 14 2023, 3:32 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
vporpo added a reverting change for rGcb5f239363a3: Revert "[NFC][IR] Make Module::getGlobalList() private": rG823186b14dc9: Recommit: [NFC][IR] Make Module::getGlobalList() private.
Feb 14 2023, 3:13 PM · Restricted Project, Restricted Project, Restricted Project
vporpo committed rG823186b14dc9: Recommit: [NFC][IR] Make Module::getGlobalList() private (authored by vporpo).
Recommit: [NFC][IR] Make Module::getGlobalList() private
Feb 14 2023, 3:13 PM · Restricted Project, Restricted Project, Restricted Project
vporpo added a reverting change for D144027: [NFC][IR] Make Module::getGlobalList() private: rGcb5f239363a3: Revert "[NFC][IR] Make Module::getGlobalList() private".
Feb 14 2023, 2:30 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
vporpo added a reverting change for rGed3e3ee9e30d: [NFC][IR] Make Module::getGlobalList() private: rGcb5f239363a3: Revert "[NFC][IR] Make Module::getGlobalList() private".
Feb 14 2023, 2:30 PM · Restricted Project, Restricted Project, Restricted Project
vporpo committed rGcb5f239363a3: Revert "[NFC][IR] Make Module::getGlobalList() private" (authored by vporpo).
Revert "[NFC][IR] Make Module::getGlobalList() private"
Feb 14 2023, 2:30 PM · Restricted Project, Restricted Project, Restricted Project
vporpo committed rGed3e3ee9e30d: [NFC][IR] Make Module::getGlobalList() private (authored by vporpo).
[NFC][IR] Make Module::getGlobalList() private
Feb 14 2023, 2:26 PM · Restricted Project, Restricted Project, Restricted Project
vporpo closed D144027: [NFC][IR] Make Module::getGlobalList() private.
Feb 14 2023, 2:25 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
vporpo added a comment to D144040: [NFC][IR] Force accesses to Function attributes go through getters/setters.

And what is this needed for / what will this be used for?

This is to make it easier to track changes to the attributes for Checkpointing, but regardless I think this is generally useful e.g., for debugging, as you can watch all changes from a single point.

Feb 14 2023, 1:48 PM · Restricted Project, Restricted Project
vporpo added a comment to D144040: [NFC][IR] Force accesses to Function attributes go through getters/setters.

It funnels all changes to attributes through a single function, which makes it really easy to track all attribute changes from a single point.

Feb 14 2023, 1:29 PM · Restricted Project, Restricted Project
vporpo requested review of D144040: [NFC][IR] Force accesses to Function attributes go through getters/setters.
Feb 14 2023, 1:19 PM · Restricted Project, Restricted Project
vporpo updated the diff for D144027: [NFC][IR] Make Module::getGlobalList() private.

Rebase

Feb 14 2023, 11:43 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
vporpo committed rGfb717fe06dd0: [NFC][IR] Make Module::getNamedMDList() private (authored by vporpo).
[NFC][IR] Make Module::getNamedMDList() private
Feb 14 2023, 11:42 AM · Restricted Project, Restricted Project
vporpo closed D143969: [NFC][IR] Make Module::getNamedMDList() private.
Feb 14 2023, 11:42 AM · Restricted Project, Restricted Project
vporpo added inline comments to D144027: [NFC][IR] Make Module::getGlobalList() private.
Feb 14 2023, 9:45 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
vporpo updated the diff for D144027: [NFC][IR] Make Module::getGlobalList() private.

Removed commented out lines from ModuleTest.cpp

Feb 14 2023, 9:44 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
vporpo requested review of D144027: [NFC][IR] Make Module::getGlobalList() private.
Feb 14 2023, 9:35 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project
vporpo updated the diff for D143969: [NFC][IR] Make Module::getNamedMDList() private.

Rebase

Feb 14 2023, 9:30 AM · Restricted Project, Restricted Project
vporpo committed rGd180443570d7: [NFC][IR] Make Module::getIFuncList() private. (authored by vporpo).
[NFC][IR] Make Module::getIFuncList() private.
Feb 14 2023, 9:28 AM · Restricted Project, Restricted Project
vporpo closed D143968: [NFC][IR] Make Module::getIFuncList() private..
Feb 14 2023, 9:28 AM · Restricted Project, Restricted Project

Feb 13 2023

vporpo updated the diff for D143968: [NFC][IR] Make Module::getIFuncList() private..

Rebase

Feb 13 2023, 9:19 PM · Restricted Project, Restricted Project
vporpo added a reverting change for rG6d4a674acbc5: Revert "[NFC][IR] Make Module::getAliasList() private": rGafad153a0890: Recommit: [NFC][IR] Make Module::getAliasList() private.
Feb 13 2023, 8:09 PM · Restricted Project, Restricted Project
vporpo committed rGafad153a0890: Recommit: [NFC][IR] Make Module::getAliasList() private (authored by vporpo).
Recommit: [NFC][IR] Make Module::getAliasList() private
Feb 13 2023, 8:09 PM · Restricted Project, Restricted Project
vporpo added a reverting change for rGb64f7d028bdc: [NFC][IR] Make Module::getAliasList() private: rG6d4a674acbc5: Revert "[NFC][IR] Make Module::getAliasList() private".
Feb 13 2023, 7:14 PM · Restricted Project, Restricted Project
vporpo committed rG6d4a674acbc5: Revert "[NFC][IR] Make Module::getAliasList() private" (authored by vporpo).
Revert "[NFC][IR] Make Module::getAliasList() private"
Feb 13 2023, 7:14 PM · Restricted Project, Restricted Project
vporpo added a reverting change for D143958: [NFC][IR] Make Module::getAliasList() private: rG6d4a674acbc5: Revert "[NFC][IR] Make Module::getAliasList() private".
Feb 13 2023, 7:14 PM · Restricted Project, Restricted Project, Restricted Project
vporpo updated the diff for D143968: [NFC][IR] Make Module::getIFuncList() private..

Rebase

Feb 13 2023, 7:06 PM · Restricted Project, Restricted Project
vporpo committed rGb64f7d028bdc: [NFC][IR] Make Module::getAliasList() private (authored by vporpo).
[NFC][IR] Make Module::getAliasList() private
Feb 13 2023, 7:06 PM · Restricted Project, Restricted Project
vporpo closed D143958: [NFC][IR] Make Module::getAliasList() private.
Feb 13 2023, 7:05 PM · Restricted Project, Restricted Project, Restricted Project
vporpo requested review of D143969: [NFC][IR] Make Module::getNamedMDList() private.
Feb 13 2023, 5:50 PM · Restricted Project, Restricted Project
vporpo requested review of D143968: [NFC][IR] Make Module::getIFuncList() private..
Feb 13 2023, 5:23 PM · Restricted Project, Restricted Project
vporpo updated the diff for D143958: [NFC][IR] Make Module::getAliasList() private.

Addressed comments

Feb 13 2023, 4:46 PM · Restricted Project, Restricted Project, Restricted Project
vporpo abandoned D141731: [NFC] Makes mutable Function::getBasicBlockList() private.
Feb 13 2023, 4:26 PM · Restricted Project, Restricted Project
vporpo added a reviewer for D141731: [NFC] Makes mutable Function::getBasicBlockList() private: aeubanks.
Feb 13 2023, 4:17 PM · Restricted Project, Restricted Project
vporpo added inline comments to D143958: [NFC][IR] Make Module::getAliasList() private.
Feb 13 2023, 4:12 PM · Restricted Project, Restricted Project, Restricted Project
vporpo requested review of D143958: [NFC][IR] Make Module::getAliasList() private.
Feb 13 2023, 3:34 PM · Restricted Project, Restricted Project, Restricted Project
vporpo updated the diff for D141731: [NFC] Makes mutable Function::getBasicBlockList() private.

Rebase

Feb 13 2023, 2:41 PM · Restricted Project, Restricted Project

Jan 30 2023

vporpo committed rG279f262d497e: [Doc] Removes extra argument of ReplaceInstWithValue() (authored by vporpo).
[Doc] Removes extra argument of ReplaceInstWithValue()
Jan 30 2023, 7:04 PM · Restricted Project, Restricted Project
vporpo closed D142944: [Doc] Removes extra argument of ReplaceInstWithValue().
Jan 30 2023, 7:04 PM · Restricted Project, Restricted Project
vporpo updated the diff for D142944: [Doc] Removes extra argument of ReplaceInstWithValue().

Removed newline

Jan 30 2023, 5:37 PM · Restricted Project, Restricted Project
vporpo added inline comments to D142944: [Doc] Removes extra argument of ReplaceInstWithValue().
Jan 30 2023, 5:35 PM · Restricted Project, Restricted Project
vporpo requested review of D142944: [Doc] Removes extra argument of ReplaceInstWithValue().
Jan 30 2023, 5:14 PM · Restricted Project, Restricted Project
vporpo added inline comments to D140054: [docs] Updates ProgrammersManual to reflect the change that BasicBlock::getInstList() is private..
Jan 30 2023, 5:09 PM · Restricted Project, Restricted Project

Jan 13 2023

vporpo requested review of D141731: [NFC] Makes mutable Function::getBasicBlockList() private.
Jan 13 2023, 2:47 PM · Restricted Project, Restricted Project

Jan 10 2023

vporpo committed rG9b970eb5daa3: [AsmWriter] Don't crash when printing a null operand bundle. (authored by vporpo).
[AsmWriter] Don't crash when printing a null operand bundle.
Jan 10 2023, 4:38 PM · Restricted Project, Restricted Project
vporpo closed D141415: [AsmWriter] Don't crash when printing a null operand bundle..
Jan 10 2023, 4:38 PM · Restricted Project, Restricted Project
vporpo committed rG3531c41168e0: [AsmWriter] Don't crash when printing addrspace and the operand is null (authored by vporpo).
[AsmWriter] Don't crash when printing addrspace and the operand is null
Jan 10 2023, 3:15 PM · Restricted Project, Restricted Project
vporpo closed D141343: [AsmWriter] Don't crash when printing addrspace and the operand is null.
Jan 10 2023, 3:15 PM · Restricted Project, Restricted Project
vporpo requested review of D141415: [AsmWriter] Don't crash when printing a null operand bundle..
Jan 10 2023, 11:13 AM · Restricted Project, Restricted Project
vporpo updated the diff for D141343: [AsmWriter] Don't crash when printing addrspace and the operand is null.

Rebase

Jan 10 2023, 11:11 AM · Restricted Project, Restricted Project

Jan 9 2023

vporpo requested review of D141343: [AsmWriter] Don't crash when printing addrspace and the operand is null.
Jan 9 2023, 7:06 PM · Restricted Project, Restricted Project

Dec 16 2022

vporpo abandoned D140235: [IR][NFC] Add Function::erase(BasicBlock *) for erasing a single BasicBlock..

BB->eraseFromParent() is a better option.

Dec 16 2022, 12:41 PM · Restricted Project, Restricted Project
vporpo abandoned D140237: [IR][NFC] Add BasicBlock::erase(Instruction *I) for erasing a single Instruction..
Dec 16 2022, 12:40 PM · Restricted Project, Restricted Project
vporpo added a comment to D140237: [IR][NFC] Add BasicBlock::erase(Instruction *I) for erasing a single Instruction..

If the intention is to make it behave like a container, then the erase method should take an iterator.
But who would possibly use it if it requires a BB reference to call the method? It is kind of easier and safer to just I->eraseFromParent().
I don't mind adding this, just don't see how it can be useful.

Dec 16 2022, 12:40 PM · Restricted Project, Restricted Project
vporpo updated the diff for D140237: [IR][NFC] Add BasicBlock::erase(Instruction *I) for erasing a single Instruction..

I->eraseFromParent() now calls BasicBlock::erase(BB). Also BasicBlock::erase(BB) now calls InstList.erase() directly instead of calling BasicBlock::erase(FromIt, ToIt).

Dec 16 2022, 12:21 PM · Restricted Project, Restricted Project
vporpo added a comment to D140237: [IR][NFC] Add BasicBlock::erase(Instruction *I) for erasing a single Instruction..

It is exactly the same. There is no super strong reason for having both functions.
The main reason is that the BB behaves like a list as it implements begin(), end(), size(), splice() etc. so not having an erase(I) function looks strange.
Up until now one could simply do BB->getInstList().erase(I), instead of I->eraseFromParent(), so this function is covering this case.

Dec 16 2022, 12:07 PM · Restricted Project, Restricted Project
vporpo requested review of D140237: [IR][NFC] Add BasicBlock::erase(Instruction *I) for erasing a single Instruction..
Dec 16 2022, 11:18 AM · Restricted Project, Restricted Project
vporpo requested review of D140235: [IR][NFC] Add Function::erase(BasicBlock *) for erasing a single BasicBlock..
Dec 16 2022, 11:00 AM · Restricted Project, Restricted Project
vporpo committed rG470bc76b1350: [IR][NFC] Cleanup: Remove non-const block iterators to force all updates go… (authored by vporpo).
[IR][NFC] Cleanup: Remove non-const block iterators to force all updates go…
Dec 16 2022, 10:03 AM · Restricted Project, Restricted Project
vporpo closed D140154: [IR][NFC] Cleanup: Removed non-const block iterators to force all updates go through an interface function.
Dec 16 2022, 10:03 AM · Restricted Project, Restricted Project

Dec 15 2022

vporpo committed rG12c55eb66de0: [docs] Update docs since getBasicBlockList() is now private (authored by vporpo).
[docs] Update docs since getBasicBlockList() is now private
Dec 15 2022, 9:46 PM · Restricted Project, Restricted Project
vporpo closed D140163: [docs] Update docs since getBasicBlockList() is now private.
Dec 15 2022, 9:45 PM · Restricted Project, Restricted Project
vporpo committed rGad36f767a4d1: [NFC] Cleanup: Function::getBasicBlockList() and Function::getSublistAccess()… (authored by vporpo).
[NFC] Cleanup: Function::getBasicBlockList() and Function::getSublistAccess()…
Dec 15 2022, 9:42 PM · Restricted Project, Restricted Project
vporpo closed D140162: [NFC] Cleanup: Function::getBasicBlockList() and Function::getSublistAccess() are now private.
Dec 15 2022, 9:42 PM · Restricted Project, Restricted Project
vporpo updated the diff for D140162: [NFC] Cleanup: Function::getBasicBlockList() and Function::getSublistAccess() are now private.

Rebase

Dec 15 2022, 4:30 PM · Restricted Project, Restricted Project
vporpo requested review of D140163: [docs] Update docs since getBasicBlockList() is now private.
Dec 15 2022, 1:25 PM · Restricted Project, Restricted Project
vporpo requested review of D140162: [NFC] Cleanup: Function::getBasicBlockList() and Function::getSublistAccess() are now private.
Dec 15 2022, 1:21 PM · Restricted Project, Restricted Project
vporpo committed rGcb5ebfa2824b: [NFC] Cleanup: Remove instances of Function::getBasicBlockList() (authored by vporpo).
[NFC] Cleanup: Remove instances of Function::getBasicBlockList()
Dec 15 2022, 1:14 PM · Restricted Project, Restricted Project
vporpo closed D140121: [NFC] Cleanup: Remove instances of Function::getBasicBlockList()..
Dec 15 2022, 1:14 PM · Restricted Project, Restricted Project
vporpo requested review of D140154: [IR][NFC] Cleanup: Removed non-const block iterators to force all updates go through an interface function.
Dec 15 2022, 12:39 PM · Restricted Project, Restricted Project
vporpo committed rG32b38d248fd3: [NFC] Rename Instruction::insertAt() to Instruction::insertInto(), to be… (authored by vporpo).
[NFC] Rename Instruction::insertAt() to Instruction::insertInto(), to be…
Dec 15 2022, 12:28 PM · Restricted Project, Restricted Project, Restricted Project
vporpo closed D140085: [NFC] Rename Instruction::insertAt() to Instruction::insertInto(), to be consistent with BasicBlock::insertInto().
Dec 15 2022, 12:28 PM · Restricted Project, Restricted Project, Restricted Project
vporpo requested review of D140121: [NFC] Cleanup: Remove instances of Function::getBasicBlockList()..
Dec 15 2022, 10:42 AM · Restricted Project, Restricted Project
vporpo updated the diff for D140085: [NFC] Rename Instruction::insertAt() to Instruction::insertInto(), to be consistent with BasicBlock::insertInto().

Rebase

Dec 15 2022, 10:05 AM · Restricted Project, Restricted Project, Restricted Project
vporpo committed rG80f2f1eabc49: [NFC] Rename Function::insertBasicBlockAt() to Function::insert(). (authored by vporpo).
[NFC] Rename Function::insertBasicBlockAt() to Function::insert().
Dec 15 2022, 10:04 AM · Restricted Project, Restricted Project, Restricted Project
vporpo closed D140068: [NFC] Rename Function::insertBasicBlockAt() to Function::insert()..
Dec 15 2022, 10:04 AM · Restricted Project, Restricted Project, Restricted Project

Dec 14 2022

vporpo requested review of D140085: [NFC] Rename Instruction::insertAt() to Instruction::insertInto(), to be consistent with BasicBlock::insertInto().
Dec 14 2022, 6:51 PM · Restricted Project, Restricted Project, Restricted Project
vporpo committed rG5b5b3d7e3232: [NFC] Cleanup: Remove unnecessary use of Function::getBasicBlockList() (authored by vporpo).
[NFC] Cleanup: Remove unnecessary use of Function::getBasicBlockList()
Dec 14 2022, 5:26 PM · Restricted Project, Restricted Project
vporpo updated the diff for D140068: [NFC] Rename Function::insertBasicBlockAt() to Function::insert()..

Fixed a couple more files that were missing from the original patch.

Dec 14 2022, 4:43 PM · Restricted Project, Restricted Project, Restricted Project
vporpo requested review of D140068: [NFC] Rename Function::insertBasicBlockAt() to Function::insert()..
Dec 14 2022, 4:26 PM · Restricted Project, Restricted Project, Restricted Project
vporpo committed rGc2355b361a0e: [IR] Adds Function::erase() for erasing a range of basic blocks (authored by vporpo).
[IR] Adds Function::erase() for erasing a range of basic blocks
Dec 14 2022, 4:24 PM · Restricted Project, Restricted Project
vporpo closed D140064: [IR] Adds Function::erase() for erasing a range of basic blocks.
Dec 14 2022, 4:24 PM · Restricted Project, Restricted Project
vporpo committed rGdc891846b811: [NFC] Cleanup: Replace Function::getBasicBlockList().splice() with Function… (authored by vporpo).
[NFC] Cleanup: Replace Function::getBasicBlockList().splice() with Function…
Dec 14 2022, 3:35 PM · Restricted Project, Restricted Project
vporpo closed D139984: [NFC] Cleanup: Replace Function::getBasicBlockList().splice() with Function::splice().
Dec 14 2022, 3:35 PM · Restricted Project, Restricted Project
vporpo requested review of D140064: [IR] Adds Function::erase() for erasing a range of basic blocks.
Dec 14 2022, 3:30 PM · Restricted Project, Restricted Project
vporpo added a comment to D139905: [NFC] Cleanup: BasicBlock::getInstList() is now private..

Both examples should now be fixed. Updated the doc too. Thanks for your help @aeubanks .

Dec 14 2022, 2:54 PM · Restricted Project, Restricted Project
vporpo committed rG8580de156f2b: [NFC] Fixes ModuleMaker example build failure caused by… (authored by vporpo).
[NFC] Fixes ModuleMaker example build failure caused by…
Dec 14 2022, 2:52 PM · Restricted Project, Restricted Project
vporpo closed D140052: [NFC] Fixes example build failure caused by c143b77b30fc23f70aac94be66e412651771c0fc.
Dec 14 2022, 2:52 PM · Restricted Project, Restricted Project
vporpo committed rGdd3d679179f7: [NFC] Fixes BrainF example build failure caused by… (authored by vporpo).
[NFC] Fixes BrainF example build failure caused by…
Dec 14 2022, 2:26 PM · Restricted Project, Restricted Project
vporpo committed rGbc63a393262d: [docs] Updates ProgrammersManual to reflect the change that BasicBlock… (authored by vporpo).
[docs] Updates ProgrammersManual to reflect the change that BasicBlock…
Dec 14 2022, 2:08 PM · Restricted Project, Restricted Project