This is an archive of the discontinued LLVM Phabricator instance.

[RISCV][llvm-mca] Add mca tests for riscv lmul instruments
ClosedPublic

Authored by michaelmaitland on Apr 28 2023, 4:11 PM.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptApr 28 2023, 4:11 PM
michaelmaitland requested review of this revision.Apr 28 2023, 4:11 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 28 2023, 4:11 PM
andreadb accepted this revision.May 1 2023, 9:51 PM

LGTM

This revision is now accepted and ready to land.May 1 2023, 9:51 PM

Regenerate test checks.

llvm/test/tools/llvm-mca/RISCV/different-instruments.s
64

I don't think this is expected behavior for the vadds to take the same amount of time, so I'm going to need to take another look at whats going on.

vitalybuka reopened this revision.May 12 2023, 11:31 PM
This revision is now accepted and ready to land.May 12 2023, 11:31 PM

Add lit config

It looks like this patch failed on "sanitizer-x86_64-linux-fast" even though lit config only supposed to run on riscv.

thakis added a subscriber: thakis.May 22 2023, 11:56 AM

These tests don't seem to pass: http://45.33.8.238/linux/107615/step_12.txt

Please take a look and revert for now if it takes a while to fix.

michaelmaitland added a comment.EditedMay 22 2023, 12:03 PM

These tests don't seem to pass: http://45.33.8.238/linux/107615/step_12.txt

Please take a look and revert for now if it takes a while to fix.

Can you please share what cmake options you used? I'm unable to reproduce on my end and not getting any messages from buildbot failures.

myhsu added a comment.May 22 2023, 1:09 PM

These tests don't seem to pass: http://45.33.8.238/linux/107615/step_12.txt

Please take a look and revert for now if it takes a while to fix.

Can you please share what cmake options you used? I'm unable to reproduce on my end and not getting any messages from buildbot failures.

I think it's GN not cmake, the instruction is here: https://github.com/llvm/llvm-project/tree/main/llvm/utils/gn

These tests don't seem to pass: http://45.33.8.238/linux/107615/step_12.txt

Please take a look and revert for now if it takes a while to fix.

Can you please share what cmake options you used? I'm unable to reproduce on my end and not getting any messages from buildbot failures.

I think it's GN not cmake, the instruction is here: https://github.com/llvm/llvm-project/tree/main/llvm/utils/gn

@thakis are you able to share gn arguments? I have not been able to reproduce the issue. Please let me know if you'd like me to revert while we sort this out.

These tests don't seem to pass: http://45.33.8.238/linux/107615/step_12.txt

Please take a look and revert for now if it takes a while to fix.

Can you please share what cmake options you used? I'm unable to reproduce on my end and not getting any messages from buildbot failures.

I think it's GN not cmake, the instruction is here: https://github.com/llvm/llvm-project/tree/main/llvm/utils/gn

I can't repro this in a cmake build, so it's a gn-specific thing which is unsupported (I'll take a look myself)

evandro removed a subscriber: evandro.May 22 2023, 5:24 PM

Apologies, this ended up being a configuration issue over here.