This is an archive of the discontinued LLVM Phabricator instance.

Differential D148878

Adopt Properties to store operations inherent Attributes in the Affine dialect
ClosedPublic

Authored by mehdi_amini on Apr 21 2023, 12:03 AM.

Details

Reviewers
rriddle
jpienaar
bondhugula
nicolasvasilache
dcaballe
Commits
rG9f2eea26a909: Adopt Properties to store operations inherent Attributes in the Affine dialect
Summary

This is part of an on-going migration to adopt Properties inside MLIR.

Diff Detail

Event Timeline

mehdi_amini created this revision.Apr 21 2023, 12:03 AM
Herald added a reviewer: bondhugula. · View Herald TranscriptApr 21 2023, 12:03 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: bviyer, Moerafaat, zero9178 and 20 others. · View Herald Transcript
mehdi_amini requested review of this revision.Apr 21 2023, 12:03 AM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptApr 21 2023, 12:03 AM
Herald added a reviewer: dcaballe. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B227081: Diff 515606.Apr 21 2023, 12:25 AM
mehdi_amini added a child revision: D148879: Adopt Properties to store operations inherent Attributes in the AMDGPU dialect.Apr 21 2023, 9:06 AM
mehdi_amini added a parent revision: D148300: Adopt Properties to store operations inherent Attributes in the LLVM dialect.
mehdi_amini updated this revision to Diff 515769.Apr 21 2023, 9:28 AM

Rebase

Harbormaster completed remote builds in B227206: Diff 515769.Apr 21 2023, 10:38 AM
mehdi_amini updated this revision to Diff 515989.Apr 21 2023, 8:21 PM

Rebase

Harbormaster completed remote builds in B227384: Diff 515989.Apr 21 2023, 9:35 PM
mehdi_amini updated this revision to Diff 516243.Apr 23 2023, 10:31 PM

Rebase after improving diagnostic on invalid IR

rriddle accepted this revision.Apr 23 2023, 10:57 PM
This revision is now accepted and ready to land.Apr 23 2023, 10:57 PM
jpienaar accepted this revision.Apr 24 2023, 5:47 AM
mehdi_amini updated this revision to Diff 516653.Apr 25 2023, 12:19 AM

Rebase

Harbormaster completed remote builds in B227906: Diff 516653.Apr 25 2023, 1:35 AM
This revision was landed with ongoing or failed builds.May 8 2023, 8:34 AM
Closed by commit rG9f2eea26a909: Adopt Properties to store operations inherent Attributes in the Affine dialect (authored by mehdi_amini). · Explain Why
This revision was automatically updated to reflect the committed changes.
mehdi_amini added a commit: rG9f2eea26a909: Adopt Properties to store operations inherent Attributes in the Affine dialect.

Revision Contents

PathSize
mlir/
include/
mlir/
Dialect/
Affine/
IR/
1 line

Diff 516653

mlir/include/mlir/Dialect/Affine/IR/AffineOps.td

Show All 17 Lines
include "mlir/Interfaces/ControlFlowInterfaces.td" include "mlir/Interfaces/ControlFlowInterfaces.td"
include "mlir/Interfaces/LoopLikeInterface.td" include "mlir/Interfaces/LoopLikeInterface.td"
include "mlir/Interfaces/SideEffectInterfaces.td" include "mlir/Interfaces/SideEffectInterfaces.td"
def Affine_Dialect : Dialect { def Affine_Dialect : Dialect {
let name = "affine"; let name = "affine";
let cppNamespace = "::mlir::affine"; let cppNamespace = "::mlir::affine";
let hasConstantMaterializer = 1; let hasConstantMaterializer = 1;
let usePropertiesForAttributes = 1;
let dependentDialects = ["arith::ArithDialect"]; let dependentDialects = ["arith::ArithDialect"];
} }
// Base class for Affine dialect ops. // Base class for Affine dialect ops.
class Affine_Op<string mnemonic, list<Trait> traits = []> : class Affine_Op<string mnemonic, list<Trait> traits = []> :
Op<Affine_Dialect, mnemonic, traits>; Op<Affine_Dialect, mnemonic, traits>;
// Require regions to have affine.yield. // Require regions to have affine.yield.
▲ Show 20 Lines • Show All 1,099 Lines • Show Last 20 Lines