- User Since
- Jun 9 2020, 7:49 AM (44 w, 2 d)
Oct 12 2020
Looks good, thanks!
Oct 8 2020
Next wave of comments addressed
Comments of Nicolas incorporated
OK->success, error messages changed a bit
Oct 7 2020
Comments of nicolas addressed
Oct 6 2020
Sep 30 2020
Sep 23 2020
Sep 17 2020
Sep 15 2020
NoTile -> noTile, TileSize -> tileSize
Refactored "Magic numbers" away by introducing NoTile and TileSize constants in ConvOpVectorization
Comments of Alex addressed
Sep 10 2020
Sep 9 2020
Sep 8 2020
integration tests split into different commit
Moved conversion to core (kept only pass).
Removed getZero helper function.
Simplified code with vector and std intrinsics op creation.
All comments except for the migration to Linalg/Vectorization.cpp resolved.
Sep 7 2020
Moved pass to test/lib.
Replaced start and end offset with Mask.
Introduced preconditions for input and kernel sizes.
Reflected changes in tests.
Sep 2 2020
Comments of nicolas resolved
Implementation changed as discussed here:
Sep 1 2020
I haven't sync with him regarding implementation details but I think he has an overview of what my goal is and how do I want to achieve it as he is my co-host.
Aug 31 2020
Landed as 8dace28f92056a04e02d913684d3f448ee1f295a
Aug 30 2020
@rriddle I think I've resolved all of your comments.. Do you have some more? Thanks.
Conversion tests added
Aug 27 2020
Aug 26 2020
added missing add_subdirectory in CMakeLists
more comments of rriddle addressed
comments of rriddle addressed
Aug 25 2020
Aart's comments addressed
Aug 24 2020
Aug 19 2020
CHECK-NEXT -> CHECK
added test for transfer_write
Aug 18 2020
Aug 17 2020
Aug 12 2020
Aug 4 2020