This is an archive of the discontinued LLVM Phabricator instance.

Adopt Properties to store operations inherent Attributes in TOSA
ClosedPublic

Authored by mehdi_amini on Apr 13 2023, 9:58 PM.

Details

Summary

This is part of an on-going migration to adopt Properties inside MLIR.

Diff Detail

Event Timeline

mehdi_amini created this revision.Apr 13 2023, 9:58 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 13 2023, 9:58 PM
mehdi_amini requested review of this revision.Apr 13 2023, 9:58 PM

Thanks for adding this Mehdi.

It looks good, although I did notice some tests where an opening < was placed without a matching >, seemingly always when the > would be the last character on the checked line. Was that intentional?

mlir/test/Dialect/Tosa/constant-op-fold.mlir
159

Is this missing a trailing >?

Yes this was somehow intentional: in the spirit of matching the minimum amount of information.
Best would be to use something like CHECK: tosa.cont followed by CHECK-SAME: value = 1

Actually I am not sure why there aren’t better pretty printers in this dialect?

Yes this was somehow intentional: in the spirit of matching the minimum amount of information.
Best would be to use something like CHECK: tosa.cont followed by CHECK-SAME: value = 1

Thanks for the explanation, that makes sense.

Actually I am not sure why there aren’t better pretty printers in this dialect?

No special reason other than what exists is functional. I'll get someone here to take a look at updating the printers.

Rebase after improving diagnostic on invalid IR

rriddle accepted this revision.Apr 23 2023, 10:55 PM
This revision is now accepted and ready to land.Apr 23 2023, 10:55 PM
This revision was landed with ongoing or failed builds.May 2 2023, 8:57 PM
This revision was automatically updated to reflect the committed changes.