This is part of an on-going migration to adopt Properties inside MLIR.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Thanks for adding this Mehdi.
It looks good, although I did notice some tests where an opening < was placed without a matching >, seemingly always when the > would be the last character on the checked line. Was that intentional?
mlir/test/Dialect/Tosa/constant-op-fold.mlir | ||
---|---|---|
159 | Is this missing a trailing >? |
Yes this was somehow intentional: in the spirit of matching the minimum amount of information.
Best would be to use something like CHECK: tosa.cont followed by CHECK-SAME: value = 1
Actually I am not sure why there aren’t better pretty printers in this dialect?
Thanks for the explanation, that makes sense.
Actually I am not sure why there aren’t better pretty printers in this dialect?
No special reason other than what exists is functional. I'll get someone here to take a look at updating the printers.
Is this missing a trailing >?