This is an archive of the discontinued LLVM Phabricator instance.

[AArch64][SME2] Add the IR intrinsics for SME2 fclamp, sclamp and uclamp instructions
ClosedPublic

Authored by david-arm on Jan 23 2023, 6:05 AM.

Details

Summary

Adds intrinsics for the following SME2 instructions:

  • fclamp (2 and 4 vectors)
  • sclamp (2 and 4 vectors)
  • uclamp (2 and 4 vectors)

I've added these new instructions to the existing sve2p1-* tests
because although they are included as part of SME2 they are still
SVE-like, in that they only operate on SVE vectors.

NOTE: These intrinsics are still in development and are subject to future changes.

Diff Detail

Event Timeline

david-arm created this revision.Jan 23 2023, 6:05 AM
david-arm requested review of this revision.Jan 23 2023, 6:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 23 2023, 6:05 AM
Matt added a subscriber: Matt.Jan 23 2023, 9:23 AM
CarolineConcatto accepted this revision.Jan 24 2023, 8:19 AM

Thank you David,
IMHO it is LGTM patch.
I liked the changes you did in the tests to use attributes #1.
I am thinking in refactor the add tests to do the same, because some are for sme-f64f64 and some for sme-i16i64.

This revision is now accepted and ready to land.Jan 24 2023, 8:19 AM
This revision was landed with ongoing or failed builds.Jan 25 2023, 1:27 AM
This revision was automatically updated to reflect the committed changes.