This is an archive of the discontinued LLVM Phabricator instance.

[AArch64][SME2] Add Multi-vector add/sub, storing into ZA intrinsic
ClosedPublic

Authored by CarolineConcatto on Jan 19 2023, 6:58 AM.

Details

Summary

Add the following intrinsic:

ADD single & multi
SUB single & multi

NOTE: These intrinsics are still in development and are subject to future changes.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptJan 19 2023, 6:58 AM
CarolineConcatto requested review of this revision.Jan 19 2023, 6:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 19 2023, 6:58 AM

-Add the missing test for sub intrinsic

david-arm accepted this revision.Jan 23 2023, 4:47 AM

LGTM! Before merging could you address the nits on the tests please? Thanks in advance. :)

llvm/test/CodeGen/AArch64/sme2-intrinsics-add.ll
3

nit: I don't think we need the -mattr=+sve here.

llvm/test/CodeGen/AArch64/sme2-intrinsics-sub.ll
3

nit: I don't think we need the -mattr=+sve here.

9

nit: 'za' appears twice in the test name - perhaps all the single tests in this file can just be named @multi_vector_sub_write_single_za_vg1x2_i32, etc?

This revision is now accepted and ready to land.Jan 23 2023, 4:47 AM
Matt added a subscriber: Matt.Jan 23 2023, 9:23 AM
CarolineConcatto marked 2 inline comments as done.
  • Address comments in the test files