This is an archive of the discontinued LLVM Phabricator instance.

[AArch64][SME2] Add Multi-vector add/sub and accumulate into ZA intrinsic
ClosedPublic

Authored by CarolineConcatto on Jan 20 2023, 6:47 AM.

Details

Summary

Add the following intrinsic:

ADD
SUB
FADD
FSUB
NOTE: These intrinsics are still in development and are subject to future changes.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptJan 20 2023, 6:47 AM
CarolineConcatto requested review of this revision.Jan 20 2023, 6:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 20 2023, 6:47 AM
kmclaughlin added inline comments.Jan 24 2023, 3:24 AM
llvm/include/llvm/IR/IntrinsicsAArch64.td
2957

Can this be added to the foreach loop above? I think the values for intr and za are the same in both.

llvm/lib/Target/AArch64/SMEInstrFormats.td
143

nit: please can you add a space between these classes :)

CarolineConcatto marked 2 inline comments as done.

-Use only one set of foreach couple in IntrinsicsAArch64.td to build
VG4 and VG2 add/sub instructions

kmclaughlin accepted this revision.Jan 24 2023, 9:23 AM

Thank you for the changes, @CarolineConcatto!

This revision is now accepted and ready to land.Jan 24 2023, 9:23 AM